Re: [PATCH xserver 2/5] xfree86/modes: Check for CRTC transforms in xf86_use_hw_cursor(_argb)

2015-12-24 Thread Michel Dänzer
On 24.12.2015 16:57, Michel Dänzer wrote: > From: Michel Dänzer > > We currently don't handle transforms for the HW cursor image, so return > FALSE to signal a software cursor must be used if a transform is in use > on any CRTC. > > Signed-off-by: Michel Dänzer

Re: [PATCH xserver 3/5] xfree86: Re-set current cursor after RandR 1.2 CRTC configuration change

2015-12-24 Thread Keith Packard
Michel Dänzer writes: > From: Michel Dänzer > > Add xf86CursorResetCursor, which allows switching between HW and SW > cursor depending on the current state. > > Call it from xf86DisableUnusedFunctions, which is called after any CRTC > configuration

Re: [PATCH xserver 4/5] modesetting: Remove xf86_reload_cursors call

2015-12-24 Thread Keith Packard
Michel Dänzer writes: > From: Michel Dänzer > > It was already disabled, but it's definitely no longer needed now that > xf86CursorResetCursor is getting called for each CRTC configuration > change. I think we can remove xf86_reload_cursors from the

Re: [PATCH xserver 5/5] modesetting: Allow CRTC transforms to actually take effect

2015-12-24 Thread Keith Packard
Michel Dänzer writes: > From: Michel Dänzer > > Setting crtc->transformPresent to FALSE was preventing the transform > from actually taking effect and putting RandR into a confused state. > > Now that the RandR 1.2 cursor code handles transforms

Re: [PATCH xserver 2/5] xfree86/modes: Check for CRTC transforms in xf86_use_hw_cursor(_argb)

2015-12-24 Thread Keith Packard
Michel Dänzer writes: > From: Michel Dänzer > > We currently don't handle transforms for the HW cursor image, so return > FALSE to signal a software cursor must be used if a transform is in use > on any CRTC. Reviewed-by: Keith Packard

Re: [PATCH xserver 1/5] xfree86/modes: Refactor xf86_use_hw_cursor_argb to use xf86_use_hw_cursor

2015-12-24 Thread Keith Packard
Michel Dänzer writes: > From: Michel Dänzer > > This reduces code duplication. > > One side effect of this change is that xf86_config->cursor will no longer > be updated for cursors which cannot use the HW cursor. That means we'll be holding on to