Re: [PATCH RESEND] xfree86: prune duplicate monitor modes.

2016-01-27 Thread Eric Anholt
Michel Dänzer writes: > From: Leo Liu > > same monitor modes added causing memory leak > when looping `xrandr --prop'. > > Signed-off-by: Leo Liu > Signed-off-by: Michel Dänzer > --- > > More than two years later...

Re: [PATCH 3/5] xephyr: Remove DRI1

2016-01-27 Thread Eric Anholt
Adam Jackson writes: > This only worked if the backend server supported DRI1, which is > stunningly unlikely these days. Patches 1-3 are: Reviewed-by: Eric Anholt I have an old branch around for doing DRI3 under Xephyr, but I'm happy to resurrect what I need

[PATCH xserver 08/19] glamor: Set up XV sampler uniforms once at program build time.

2016-01-27 Thread Eric Anholt
No sense doing it on every draw. Signed-off-by: Eric Anholt --- glamor/glamor_xv.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/glamor/glamor_xv.c b/glamor/glamor_xv.c index 6e1a588..5d31fee 100644 --- a/glamor/glamor_xv.c +++

[PATCH xserver 15/19] glamor: Clarify some logic in RepeatFix handling.

2016-01-27 Thread Eric Anholt
wh ratios are != 1.0 only when large, so with that we can simplify down how we end up with RepeatFix being used. Signed-off-by: Eric Anholt --- glamor/glamor_render.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git

[PATCH xserver 03/19] glamor: Clarify when Render fallbacks happen due to an unsupported op.

2016-01-27 Thread Eric Anholt
Signed-off-by: Eric Anholt --- glamor/glamor_render.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/glamor/glamor_render.c b/glamor/glamor_render.c index 5712cf8..51718d1 100644 --- a/glamor/glamor_render.c +++ b/glamor/glamor_render.c @@ -1577,8

[PATCH xserver 09/19] glamor: Simplify XV vertex setup.

2016-01-27 Thread Eric Anholt
We were clipping the drawn rectangle to each clip box, then expanding the box to a big triangle to avoid tearing, then drawing each triangle to the destination through a scissor. If we're using a scissor for clipping, though, then we don't need to clip the drawn primitive on the CPU in the first

[PATCH xserver 02/19] glamor: Label programs before linking them.

2016-01-27 Thread Eric Anholt
i965 does most of its compiling at link time, so our debug output for its shaders didn't have the name on. Signed-off-by: Eric Anholt --- glamor/glamor_core.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/glamor/glamor_core.c

[PATCH xserver 18/19] glamor: Cut down a bunch of conditional handling for RepeatFix.

2016-01-27 Thread Eric Anholt
For hardware that doesn't do actual jumps for conditionals (i915, current vc4 driver), this reduces the number of texture fetches performed (assuming the driver isn't really smart about noticing that the same sampler is used on each side of an if). No performance difference on i965 with x11perf

[PATCH xserver 14/19] glamor: Drop extra conditionals for large pixmap handling.

2016-01-27 Thread Eric Anholt
For a small pixmap, it's got a box from 0,0 to width/height, so we can always use that. Signed-off-by: Eric Anholt --- glamor/glamor_utils.h | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/glamor/glamor_utils.h b/glamor/glamor_utils.h

[PATCH xserver 01/19] ephyr: Make sure we have GLX_ARB_create_context before calling it.

2016-01-27 Thread Eric Anholt
This should fix aborts()s from epoxy on old software stacks. Signed-off-by: Eric Anholt --- hw/kdrive/ephyr/ephyr_glamor_glx.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/hw/kdrive/ephyr/ephyr_glamor_glx.c

[PATCH xserver 19/19] glamor: Flip around conditionals in RepeatNone fixups.

2016-01-27 Thread Eric Anholt
Signed-off-by: Eric Anholt --- glamor/glamor_render.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/glamor/glamor_render.c b/glamor/glamor_render.c index da45920..73ac831 100644 --- a/glamor/glamor_render.c +++ b/glamor/glamor_render.c @@ -110,8 +110,8

[PATCH xserver 12/19] glamor: Reuse the glamor_program_alpha_* enums for Render.

2016-01-27 Thread Eric Anholt
This is a step toward using glamor_program.c for Render acceleration. Signed-off-by: Eric Anholt --- glamor/glamor_priv.h | 12 ++-- glamor/glamor_render.c | 28 ++-- 2 files changed, 16 insertions(+), 24 deletions(-) diff --git

[PATCH xserver 10/19] glamor: Convert XV to using glamor_program.c.

2016-01-27 Thread Eric Anholt
One less custom path! By following the common glamor_program.c use pattern, we get the ability to handle large pixmaps as the destination. It's also one less place where glamor_utils.h coordinate transformation happens. Signed-off-by: Eric Anholt --- glamor/glamor_priv.h |

[PATCH xserver 11/19] glamor: Drop extra SHADER_IN type for no mask present.

2016-01-27 Thread Eric Anholt
We can just hand in a constant mask and the driver will optimize away the multiplication for us. Signed-off-by: Eric Anholt --- glamor/glamor_priv.h | 1 - glamor/glamor_render.c | 17 ++--- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git

[PATCH xserver 00/19] glamor: Cleanups all over

2016-01-27 Thread Eric Anholt
I've been working on vc4 X performance again, particularly looking at dragging windows with xcompmgr -c running. I'll be sending a separate patch to accelerate a8 rendering on GLES2-class renderers, but even with that things are crazy slow. I think at this point the major problem is the crazy

[PATCH xserver 04/19] glamor: Drop dead *_from_x_coord_y() functions.

2016-01-27 Thread Eric Anholt
They've been dead since the yInverted removal (e310387f443b6333edf02c8980daa303505382b4). Signed-off-by: Eric Anholt --- glamor/glamor_utils.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/glamor/glamor_utils.h b/glamor/glamor_utils.h index d4366c1..875c935 100644 ---

[PATCH xserver 16/19] glamor: Clean up formatting of RepeatFix shader code.

2016-01-27 Thread Eric Anholt
All sorts of weird indentation, and some cuddled conditional statements deep in the if tree. Signed-off-by: Eric Anholt --- glamor/glamor_render.c | 57 ++ 1 file changed, 30 insertions(+), 27 deletions(-) diff --git

[PATCH xserver 13/19] glamor: Simplify the pixmap box looping.

2016-01-27 Thread Eric Anholt
We had a double loop across h and w, and passed the current x and y out to callers who then used w to multiply/add to an index. Instead, just single loop across w * h. Signed-off-by: Eric Anholt --- glamor/glamor_composite_glyphs.c | 10 ++ glamor/glamor_copy.c

[PATCH xserver 07/19] glamor: Drop dead glamor_pict_format_is_compatible().

2016-01-27 Thread Eric Anholt
This hasn't been used since 2f80c7791bb0b11f261cb1e3e0d89163dcdd0342 (GLAMOR_SEPARATE_TEXTURE removal). Signed-off-by: Eric Anholt --- glamor/glamor_utils.h | 20 1 file changed, 20 deletions(-) diff --git a/glamor/glamor_utils.h b/glamor/glamor_utils.h

[PATCH xserver 17/19] glamor: Clarify how the repeat values being passed around work.

2016-01-27 Thread Eric Anholt
Signed-off-by: Eric Anholt --- glamor/glamor_render.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/glamor/glamor_render.c b/glamor/glamor_render.c index a2a7f4a..ed425f5 100644 --- a/glamor/glamor_render.c +++ b/glamor/glamor_render.c @@

[PATCH xserver 06/19] glamor: Drop comment about dead yInverted flag.

2016-01-27 Thread Eric Anholt
Wait long enough, and you don't need to think about it at all. Signed-off-by: Eric Anholt --- glamor/glamor_transform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/glamor/glamor_transform.c b/glamor/glamor_transform.c index ad06943..564a52d 100644 ---

[PATCH xserver 05/19] glamor: Rename the *y_inverted helpers to not say "inverted".

2016-01-27 Thread Eric Anholt
Signed-off-by: Eric Anholt --- glamor/glamor_utils.h | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/glamor/glamor_utils.h b/glamor/glamor_utils.h index 875c935..3adc687 100644 --- a/glamor/glamor_utils.h +++

Re: [PATCH 1/1] Initialize pci_dev

2016-01-27 Thread Adam Jackson
On Fri, 2016-01-22 at 00:26 +, Pascal Terjan wrote: > Else it is read before initialization if XSERVER_LIBPCIACCESS is not defined > or location.type is not BUS_PCI. > > Noticed when I got a segfault where it was 0x1 while doing some tests on arm. > > Signed-off-by: Pascal Terjan

[PATCH xserver] modesetting: Require sufficiently new libdrm

2016-01-27 Thread Adam Jackson
Bugzilla: https://bugs.freedesktop.org/93883 Signed-off-by: Adam Jackson --- configure.ac | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index ac3bb64..312fc69 100644 --- a/configure.ac +++ b/configure.ac @@ -2035,8 +2035,7 @@

Re: [PATCH xserver] modesetting: Require sufficiently new libdrm

2016-01-27 Thread Alex Deucher
On Wed, Jan 27, 2016 at 11:50 AM, Adam Jackson wrote: > Bugzilla: https://bugs.freedesktop.org/93883 > Signed-off-by: Adam Jackson Reviewed-by: Alex Deucher > --- > configure.ac | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH xserver] dri2: Sync i915_pci_ids.h and i965_pci_ids.h from mesa

2016-01-27 Thread Adam Jackson
On Wed, 2016-01-27 at 13:47 +0100, Andreas Boll wrote: > I've verified that i915_pci_ids.h and i965_pci_ids.h match with > current mesa master 19ae5de981e014 > > Reviewed-by: Andreas Boll remote: I: patch #71718 updated using rev

[PATCH xserver] dri2: Sync i915_pci_ids.h and i965_pci_ids.h from mesa

2016-01-27 Thread Timo Aaltonen
Adds Skylake, Kabylake and Broxton allowing them to use modesetting + glamor with dri2. Signed-off-by: Timo Aaltonen --- hw/xfree86/dri2/pci_ids/i915_pci_ids.h | 4 +-- hw/xfree86/dri2/pci_ids/i965_pci_ids.h | 56 +++--- 2 files changed,

Re: [PATCH xf86-input-libinput] Add property/option for enabling/disabling tap-n-drag

2016-01-27 Thread Hans de Goede
Hi, On 27-01-16 02:20, Peter Hutterer wrote: Signed-off-by: Peter Hutterer Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- include/libinput-properties.h | 6 +++ man/libinput.man | 8

Re: [PATCH xserver] dri2: Sync i915_pci_ids.h and i965_pci_ids.h from mesa

2016-01-27 Thread Andreas Boll
I've verified that i915_pci_ids.h and i965_pci_ids.h match with current mesa master 19ae5de981e014 Reviewed-by: Andreas Boll Thanks, Andreas 2016-01-27 13:18 GMT+01:00 Timo Aaltonen : > Adds Skylake, Kabylake and Broxton allowing them to use >