Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

Michel Dänzer writes: > This does mean though that if one has only up to patch 3 applied (e.g. > during a bisection), one is exposed to the issues fixed by patch 4. So > maybe patch 4 should be squashed into patch 3. That's a very important point -- developing code in small

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

Hi Emil, Each point of the patch set is not broken. Patches are arranged like this to show how I do it: 1. create a pageflip.c to host common page flip code 2. copy amdgpu DDX DRI2 page flip code to modesetting dri2.c 3. merge common DRI2 and present page flip code to pageflip.c Patch 4 is not

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

On 19/08/16 11:02 AM, Yu, Qiang wrote: > > Each point of the patch set is not broken. Patches are arranged like > this to show how I do it: > 1. create a pageflip.c to host common page flip code > 2. copy amdgpu DDX DRI2 page flip code to modesetting dri2.c > 3. merge common DRI2 and present page

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

On 19/08/16 01:56 AM, ⚛ wrote: > > There is some confusion at > https://www.phoronix.com/forums/forum/phoronix/latest-phoronix-articles/891632-dri2-page-flipping-patches-for-the-generic-modesetting-ddx > about this patch. Confusion in the Phoronix forums? No way! ;) > There was no previous

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

Thanks Michel. I'll update patches in V2 according to your comments. Regards, Qiang From: Michel Dänzer Sent: Thursday, August 18, 2016 4:18:11 PM To: Yu, Qiang Cc: xorg-devel@lists.x.org; amd-...@lists.freedesktop.org Subject: Re:

Re: [PATCH xserver] wayland: Emulate crossing for native window

On Wed, Aug 17, 2016 at 03:53:14AM -0400, Olivier Fourdan wrote: > Hi all, > > Gentle reminder about this patch... sorry about the delay. 48c5c23..6e5bec2 master -> master Cheers, Peter > > Cheers, > Olivier > > - Original Message - > > Emitting a LeaveNotify event every

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

Hello There is some confusion at https://www.phoronix.com/forums/forum/phoronix/latest-phoronix-articles/891632-dri2-page-flipping-patches-for-the-generic-modesetting-ddx about this patch. There was no previous DRI2 page flipping support in modesetting? What is improved by the patch? Thanks.

Re: Michel Dänzer is invited to help maintain master X server branch

Keith Packard writes: > Michel Dänzer writes: > >> Many glamor changes have been pushed by Adam or Keith lately. Is that >> intentional, i.e. is it okay for others to push glamor changes which are >> ready, or should we always get in touch with Eric first?

Re: [PATCH] xace: Fix XaceCensorImage to actually censor the right part of the image

Aaron Plattner writes: > Aargh, stupid borders. I always forget about them. I guess this is why > we have regression tests. You just don't recall the whole original fight about borders. Left in X11 solely for X10 compatibility. Aren't you glad we have them? -- -keith

Re: [PATCH xserver] Fix Xorg -configure not working anymore

On Thu, 2016-08-18 at 11:17 +0200, Hans de Goede wrote: > Hi, > > On 17-08-16 16:58, Adam Jackson wrote: > > > > On Wed, 2016-08-17 at 10:01 +0900, Michel Dänzer wrote: > > > > > > > > At least longer term, maybe we should just remove Xorg -configure? Does > > > it serve any useful purpose

Re: [PATCH] xace: Fix XaceCensorImage to actually censor the right part of the image

Aargh, stupid borders. I always forget about them. I guess this is why we have regression tests. On 08/18/2016 09:11 AM, Adam Jackson wrote: > On Thu, 2016-08-18 at 11:09 +0900, Michel Dänzer wrote: > >> Unfortunately, this broke two XTS tests: >> >> xts5@xlib9@xgetimage@7 >>

Re: [PATCH xf86-input-libinput] Always delay hotplugging subdevices

Peter Hutterer writes: > Avoid creating new devices from within the input thread which was the case for > tablet tools. It requires a lot more care about locking and has a potential to > mess up things. > > Instead, schedule a WorkProc and buffer all events until we

Re: [PATCH xserver] modesetting: Fix msSharePixmapBacking returning a non-linear bo

Hans de Goede writes: > An alternative solution would be to add a flag argument to > glamor_fd_from_pixmap, so that callers like this one which > know for sure they want a linear bo can specify that through > a flag, and other callers can just pass in: fd_from_pixmap is the

Re: [PATCH] xace: Fix XaceCensorImage to actually censor the right part of the image

On Thu, 2016-08-18 at 11:09 +0900, Michel Dänzer wrote: > Unfortunately, this broke two XTS tests: > > xts5@xlib9@xgetimage@7 > xts5@xlib9@xgetsubimage@7 Low impact, fortunately, but still unpleasant. The test in question is: 520|0 7 00020031 1 2|Assertion XGetImage-7.(A) 520|0 7 00020031 1

Re: Michel Dänzer is invited to help maintain master X server branch

Michel Dänzer writes: > Many glamor changes have been pushed by Adam or Keith lately. Is that > intentional, i.e. is it okay for others to push glamor changes which are > ready, or should we always get in touch with Eric first? Would saying "it depends" help at all? When

Re: [PATCH xserver v3] glamor: Handle bitplane in glamor_copy_fbo_cpu

On Thu, Aug 18, 2016 at 5:42 AM, Michel Dänzer wrote: > From: Michel Dänzer > > This can significantly speed up at least some CopyPlane cases, e.g. > indirectly for stippled fills. > > v2: > * Make temporary pixmap the same size as the destination

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

Hi Qiang, On 17 August 2016 at 11:29, Qiang Yu wrote: > Hi guys, > > This patch set is for adding DRI2 page flip support to modesetting > driver. I mainly take reference of amdgpu DDX and reuse present > page flip code in the modesetting driver. > > Regards, > Qiang > > Qiang

Re: [PATCH xserver v2] glamor: Handle bitplane in glamor_copy_fbo_cpu

On 15/08/16 11:18 PM, walter harms wrote: > Am 15.08.2016 11:43, schrieb Michel Dänzer: >> >> diff --git a/glamor/glamor_copy.c b/glamor/glamor_copy.c >> index 3501a0d..82e040a 100644 >> --- a/glamor/glamor_copy.c >> +++ b/glamor/glamor_copy.c >> @@ -222,9 +222,40 @@

[PATCH xserver v3] glamor: Handle bitplane in glamor_copy_fbo_cpu

From: Michel Dänzer This can significantly speed up at least some CopyPlane cases, e.g. indirectly for stippled fills. v2: * Make temporary pixmap the same size as the destination pixmap (instead of the destination drawable size), and fix coordinate parameters passed

Re: [PATCH xserver] Fix Xorg -configure not working anymore

Hi, On 17-08-16 16:58, Adam Jackson wrote: On Wed, 2016-08-17 at 10:01 +0900, Michel Dänzer wrote: At least longer term, maybe we should just remove Xorg -configure? Does it serve any useful purpose anymore? I know it causes quite a lot of trouble for users and those trying to help them...

Re: [PATCH xserver] modesetting: Fix msSharePixmapBacking returning a non-linear bo

Hi, On 17-08-16 16:44, Keith Packard wrote: Hans de Goede writes: Some code paths end up in msSharePixmapBacking with a pixmap which does not have its usage_hint set to sharable. This causes glamor_fd_from_pixmap() to create a non-linear bo, which is wrong for a shared

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

On 17/08/16 07:29 PM, Qiang Yu wrote: > Hi guys, > > This patch set is for adding DRI2 page flip support to modesetting > driver. I mainly take reference of amdgpu DDX and reuse present > page flip code in the modesetting driver. > > Regards, > Qiang > > Qiang Yu (6): > modesetting: make

Re: [PATCH xserver 3/6] modesetting: add DRI2 page flip support

On 17/08/16 07:29 PM, Qiang Yu wrote: > > +static void > +ms_dri2_flip_free(struct ms_crtc_pageflip *flip) > +{ > +struct ms_flipdata *flipdata = flip->flipdata; > + > +free(flip); > +if (--flipdata->flip_count > 0) > +return; > +free(flipdata); > +} > + > +static void >

Re: [PATCH xserver 1/6] modesetting: make ms_do_pageflip generic for share with DRI2

On 17/08/16 07:29 PM, Qiang Yu wrote: > > -DebugPresent(("\t\tms:fq %lld c %d -> %d seq %llu\n", > - (long long) flipdata->event->event_id, > - flipdata->flip_count, flipdata->flip_count + 1, > - (long long) seq)); Might be nice to move this

Re: Michel Dänzer is invited to help maintain master X server branch

On 16/08/16 01:51 AM, Keith Packard wrote: > > When Adam left for a week's vacation, Michel noted that the master X > server branch was not keeping up -- a couple of important patches were > not getting committed in a reasonable amount of time. I haven't had > enough bandwidth myself for several