Re: [PATCH v2 libXi 2/2] XListInputDevices: don't touch ndevices in case of error

On Fri, Oct 14, 2016 at 02:28:55PM +0100, Emil Velikov wrote: > On 13 October 2016 at 04:58, Peter Hutterer wrote: > > We used to always set *ndevices to the number of devices returned by the > > server. This magically worked because we pretty much never returned an

Re: [PATCH libXi] XListInputDevices: Do not modify ndevices in case of an error

On Sat, Oct 15, 2016 at 02:06:42PM +0200, Niels Ole Salscheider wrote: > Output parameters must only be modified if there is no error. > > Signed-off-by: Niels Ole Salscheider see this patch here please https://patchwork.freedesktop.org/patch/115414/ Cheers,

Re: [PATCH libXi v2] SizeClassInfo can return 0 even without an error

On Sat, Oct 15, 2016 at 01:48:19PM +0200, Niels Ole Salscheider wrote: > With this patch we catch the error case separately. Previously, it > was not possible to distinguish between a size of 0 and an error. > XListInputDevices assumed that a return value of 0 indicates an > error and returned an