Re: [PATCH 3/3 all repositories] autogen: Set a default subject prefix for patches

On Tue, Jan 24, 2017 at 02:35:34AM +, Emil Velikov wrote: > On 24 January 2017 at 00:40, Peter Hutterer wrote: > > From: Adam Jackson > > > > Per discussion at XDC2015, we want this so we can easily distinguish > > which module a patch is for.

Re: [PATCH util-modular 4/4] release.sh: implement around git worktree

On 24 January 2017 at 01:14, Peter Hutterer wrote: > On Mon, Jan 23, 2017 at 12:51:31PM +, Emil Velikov wrote: >> On 23 January 2017 at 04:03, Peter Hutterer wrote: >> > On Fri, Jan 20, 2017 at 02:19:06PM +, Emil Velikov wrote: >> >> On

Re: [PATCH v2 xserver 3/4] dri2: refine dri2_probe_driver_name (v2)

On 23 January 2017 at 06:30, Yu, Qiang wrote: > > Hi, > > If no further comments, can this patch be merged? > It's up-to our maintainers to pull the series. They might be a bit busy with other atm. -Emil ___ xorg-devel@lists.x.org:

Re: [PATCH 3/3 all repositories] autogen: Set a default subject prefix for patches

On 24 January 2017 at 00:40, Peter Hutterer wrote: > From: Adam Jackson > > Per discussion at XDC2015, we want this so we can easily distinguish > which module a patch is for. There's no way to set this in the > server-side config, so setting a default

[PATCH util-modular v3] release.sh: remove $MESA_VERSION from the destination location

From: Emil Velikov Requested by a number of distribution maintainers. Used starting with the 17.0 series. v2: Keep things conditional based on the version. v3: Also update srv_path, to create the correct path Signed-off-by: Emil Velikov

Re: [PATCH util-modular 4/4] release.sh: implement around git worktree

On Mon, Jan 23, 2017 at 12:51:31PM +, Emil Velikov wrote: > On 23 January 2017 at 04:03, Peter Hutterer wrote: > > On Fri, Jan 20, 2017 at 02:19:06PM +, Emil Velikov wrote: > >> On 20 January 2017 at 02:49, Peter Hutterer > >> wrote: >

libx11: Issues with Data32/_XData32

Hi, I've been debugging an issue in gtk2-perl causing it to SIGBUS on sparc64, and traced it back to what seems to be dodgy code inside libx11. One of the tests calls gdk_window_set_opacity, which calls XChangeProperty with a pointer to a guint32, cast to char*, with the length set to 32 bits as

Re: [PATCH] libXinerama: Set number to 0 on error.

On Mon, Jan 23, 2017 at 11:52:13AM -0500, Adam Jackson wrote: > Not that any caller has likely made this mistake, but you want an if > (number) before this, otherwise you turn a protocol error into a > segfault. If a caller supplies NULL, a segfault would always occur because the pointer is never

Re: [Mesa-dev] Time to update GSoC/EVoC ideas page

On Fri, Jan 20, 2017 at 08:44:19AM -0800, Jason Ekstrand wrote: > On Fri, Jan 20, 2017 at 2:15 AM, Nicolai Hähnle wrote: > > > Hi Rob, > > > > On 19.01.2017 23:32, Rob Clark wrote: > > > >> Just a friendly reminder that now would be a good time to update the > >> wiki page

[PATCH 2/3 all repositories] autogen.sh: use quoted string variables

From: Emil Velikov Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov Reviewed-by: Peter Hutterer Signed-off-by: Peter Hutterer

[PATCH 3/3 all repositories] autogen: Set a default subject prefix for patches

From: Adam Jackson Per discussion at XDC2015, we want this so we can easily distinguish which module a patch is for. There's no way to set this in the server-side config, so setting a default at autogen time is about the best we can do. Reviewed-by: Eric Anholt

[PATCH 0/3 all repositories] autogen.sh: sync with server

Heads up: I'll be pushing the following three patches into all xorg repositories that need it in the next few days. Speak up now or be forever silent, etc. etc. Cheers, Peter ___ xorg-devel@lists.x.org: X.Org development Archives:

[PATCH 1/3 all repositories] autogen.sh: use exec instead of waiting for configure to finish

Syncs the invocation of configure with the one from the server. Signed-off-by: Peter Hutterer --- autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index fc34bd5..fd9c59a 100755 --- a/autogen.sh +++ b/autogen.sh @@

Re: [PATCH xserver 00/19] Module loader cleanup

On Mon, Jan 23, 2017 at 14:32:14 -0500, Adam Jackson wrote: > I'd like to move the module loader up to dix. In preparation for that, here's > a bunch of cleanup patches. The first three aren't mine, I just think they're > neat. > A few nits in separate mails, but for the series: Reviewed-by:

Re: [PATCH xserver 19/19] loader: Fix an obviously backwards comparison

On Mon, Jan 23, 2017 at 14:32:33 -0500, Adam Jackson wrote: > Hmm, this code looks wrong to me. I know! Instead of fix it, I'll put a > comment here that nobody will look at for decades on end. > > Yaaay xfree86. > > Signed-off-by: Adam Jackson > --- >

Re: [PATCH xserver 06/19] loader: Remove *GetOS

On Mon, Jan 23, 2017 at 14:32:20 -0500, Adam Jackson wrote: > This API is dumb. uname(3) exists, feel free to use it, but ideally > write to the interface not to the OS. There are a couple of drivers > using this API, they could all reasonably just not. > It's uname(2) AFAICT :) Cheers,

Re: [PATCH xserver 02/19] xfree86: remove unused path from the LoadModule API

On 01/23/2017 01:27 PM, Eric Anholt wrote: > Adam Jackson writes: > >> From: Emil Velikov >> >> Similar to its little brothre - LoadSubModule. Currently all call sites >> provide NULL anyway ;-) > > "brother". Other than that, > > Reviewed-by: Eric

Re: [PATCH xserver 04/19] xfree86: flatten pathlist management in the loader

On Mon, Jan 23, 2017 at 14:32:18 -0500, Adam Jackson wrote: > From: Emil Velikov > > Now that used can set the path only via LoaderSetPath(), we can simplify > things. > used -> users, maybe? Cheers, Julien ___

Re: [PATCH xserver 04/19] xfree86: flatten pathlist management in the loader

Adam Jackson writes: > From: Emil Velikov > > Now that used can set the path only via LoaderSetPath(), we can simplify "users"? Other than that, 4-14 are: Reviewed-by: Eric Anholt There is so much "wow, remember when that was a

Re: [PATCH xserver 01/19] xfree86: remove references from LoadSubModule's path from the doc

On Mon, Jan 23, 2017 at 14:32:15 -0500, Adam Jackson wrote: > From: Emil Velikov > > Afaics the argument hasn't been part of the API since the documentation > has been converted to xml with commit fc6ebe1e1d3 "Convert LinuxDoc > documents to DocBook/XML" > The commit

Re: [PATCH:xdm] Install xdm man pages under admin section (8), not user programs (1)

On Mon, Jan 16, 2017 at 16:26:08 -0800, Alan Coopersmith wrote: > As best I can tell, it was historically under section 1 mainly because > the old X Consortium Imake configs only supporting installing program > man pages there, and didn't have an option for using other sections. > >

Re: [PATCH xserver 02/19] xfree86: remove unused path from the LoadModule API

Adam Jackson writes: > From: Emil Velikov > > Similar to its little brothre - LoadSubModule. Currently all call sites > provide NULL anyway ;-) "brother". Other than that, Reviewed-by: Eric Anholt signature.asc Description: PGP

Re: [PATCH xserver 01/19] xfree86: remove references from LoadSubModule's path from the doc

Adam Jackson writes: > From: Emil Velikov > > Afaics the argument hasn't been part of the API since the documentation > has been converted to xml with commit fc6ebe1e1d3 "Convert LinuxDoc > documents to DocBook/XML" In the subject, "remove references

[PATCH xserver 00/19] Module loader cleanup

I'd like to move the module loader up to dix. In preparation for that, here's a bunch of cleanup patches. The first three aren't mine, I just think they're neat. b/hw/xfree86/common/xf86.h |2 b/hw/xfree86/common/xf86Config.c| 78 - b/hw/xfree86/common/xf86Config.h|

[PATCH xserver 02/19] xfree86: remove unused path from the LoadModule API

From: Emil Velikov Similar to its little brothre - LoadSubModule. Currently all call sites provide NULL anyway ;-) Cc: Aaron Plattner Signed-off-by: Emil Velikov --- hw/xfree86/common/xf86Helper.c | 2 +-

[PATCH xserver 18/19] loader: Learn about the joy of snprintf

Signed-off-by: Adam Jackson --- hw/xfree86/loader/loadmod.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/loadmod.c index cb86925..ca77c7a 100644 --- a/hw/xfree86/loader/loadmod.c +++

[PATCH xserver 17/19] loader: Remove unused path and name from ModuleDescPtr

Just a waste of memory. Path was never referenced at all, and name was only used when unloading the module; we can just as well get the module's internal idea of its name from VersionInfo. Signed-off-by: Adam Jackson --- hw/xfree86/loader/loaderProcs.h | 2 --

[PATCH xserver 13/19] xfree86: Remove a stray reference to font modules

Signed-off-by: Adam Jackson --- hw/xfree86/common/xf86Configure.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/xfree86/common/xf86Configure.c b/hw/xfree86/common/xf86Configure.c index 8c8e49e..0d7a127 100644 --- a/hw/xfree86/common/xf86Configure.c

[PATCH xserver 19/19] loader: Fix an obviously backwards comparison

Hmm, this code looks wrong to me. I know! Instead of fix it, I'll put a comment here that nobody will look at for decades on end. Yaaay xfree86. Signed-off-by: Adam Jackson --- hw/xfree86/loader/loadmod.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH xserver 15/19] loader: Turn LoaderListDirs into LoaderListDir

Callers only ever use this for a single directory anyway. While we're at it, also move xf86DriverListFromCompile near its only user in the X -configure code (and inline it out of existence), and remove LoaderFreeDirList as it's unused (since X -configure is just going to exit anyway, none of that

[PATCH xserver 11/19] xfree86: Remove DriverRec1 compat struct

The idea here is that the driver might have once been old enough to not have the driverFunc slot in DriverRec, with the module ABI not having changed when it was added. That was ages ago, and drivers always declare themselves with DriverRec not DriverRec1, so uninitialized slots will simply be

[PATCH xserver 12/19] xfree86: Fix up some bad indentation

indent(1) gets confused by function-like macros with no trailing semicolon, which is fair enough really. Signed-off-by: Adam Jackson --- hw/xfree86/common/xf86Configure.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git

[PATCH xserver 05/19] loader: Port from xfree86 to dix API

Signed-off-by: Adam Jackson --- hw/xfree86/loader/loader.c | 43 +- hw/xfree86/loader/loadmod.c | 141 2 files changed, 81 insertions(+), 103 deletions(-) diff --git a/hw/xfree86/loader/loader.c

[PATCH xserver 09/19] loader: Remove unused loader error codes and dead enum

The enum has been unused since at least the removal of elfloader. Signed-off-by: Adam Jackson --- hw/xfree86/common/xf86Module.h | 15 +-- hw/xfree86/loader/loadmod.c| 18 -- 2 files changed, 1 insertion(+), 32 deletions(-) diff --git

[PATCH xserver 06/19] loader: Remove *GetOS

This API is dumb. uname(3) exists, feel free to use it, but ideally write to the interface not to the OS. There are a couple of drivers using this API, they could all reasonably just not. This also removes the OS name from the loader subdirectory path search. Having /usr/lib/xorg shared across

[PATCH xserver 10/19] loader: Remove silly "unspecified" version handling

Nobody who is using this functionality is ever not specifying a major version, which makes sense. If you don't care about a minor version, that's equivalent to saying you require minor >= 0, so just say so; likewise patch level. Likewise nobody using this functionality is ever not specifying an

[PATCH xserver 07/19] loader: Don't add internal/ to the search path

Signed-off-by: Adam Jackson --- hw/xfree86/loader/loadmod.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/loadmod.c index 95a37fc..d326d9d 100644 --- a/hw/xfree86/loader/loadmod.c +++ b/hw/xfree86/loader/loadmod.c @@ -177,7

[PATCH xserver 08/19] loader: Include fewer headers from xf86Module.h

This looks like more, but only if you don't compare it to the number pulled in by misc.h. Signed-off-by: Adam Jackson --- hw/xfree86/common/xf86Module.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/common/xf86Module.h

[PATCH xserver 01/19] xfree86: remove references from LoadSubModule's path from the doc

From: Emil Velikov Afaics the argument hasn't been part of the API since the documentation has been converted to xml with commit fc6ebe1e1d3 "Convert LinuxDoc documents to DocBook/XML" Signed-off-by: Emil Velikov ---

[PATCH xserver 03/19] xfree86: remove dummy/dead function prototype for LoadDriver

From: Emil Velikov Signed-off-by: Emil Velikov --- hw/xfree86/loader/loaderProcs.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/xfree86/loader/loaderProcs.h b/hw/xfree86/loader/loaderProcs.h index 8d7872f..ee8a557 100644 ---

[PATCH xserver] tests: shuffle around the linking order to please GNU ld

Classic GNU ld resolves symbol dependencies only forward, while GOLD seems to work regardless of the specified library order. I assume that the original author of the changes (just like me), has been using GNU ld with GOLD enabled (default on ArchLinux), and did not check on older distros like

Re: [PATCH] libXinerama: Set number to 0 on error.

On Sun, 2017-01-22 at 15:18 +0100, Tobias Stoeckmann wrote: > @@ -286,6 +286,7 @@ XineramaQueryScreens( >  if (!_XReply (dpy, (xReply *) , 0, xFalse)) { >   UnlockDisplay (dpy); >   SyncHandle (); > + *number = 0; Not that any caller has likely made this mistake, but you want an

[PATCH xserver] parser: Fix crash when xf86nameCompare(s1 = x, s2 = NULL)

Signed-off-by: Adam Jackson --- hw/xfree86/parser/scan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/xfree86/parser/scan.c b/hw/xfree86/parser/scan.c index 81a454b..3356224 100644 --- a/hw/xfree86/parser/scan.c +++ b/hw/xfree86/parser/scan.c @@ -1046,6 +1046,8 @@

[PATCH xserver] glamor: keep gl_fbo and fbo consistent

If the pixmap type is neither GLAMOR_TEXTURE_ONLY nor GLAMOR_TEXTURE_DRM we might have the fbo field set but the gl_fbo still set to the default GLAMOR_FBO_UNATTACHED, which later may fail an assert in glamor_upload_picture_to_texture(). Bugzilla:

[PATCH util-modular] WIP: HACK: invoke configure from a subdir

--- Educated guess since I cannot reproduce it. If you're seing any of the install/changelog issues mentioned in my email, just drop the relevant lines from Makefile.am release.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/release.sh b/release.sh index

Re: [PATCH util-modular 4/4] release.sh: implement around git worktree

On 23 January 2017 at 04:03, Peter Hutterer wrote: > On Fri, Jan 20, 2017 at 02:19:06PM +, Emil Velikov wrote: >> On 20 January 2017 at 02:49, Peter Hutterer wrote: >> > On Thu, Jan 19, 2017 at 07:30:10PM +, Emil Velikov wrote: >> >>