Re: [PATCH xserver 0/3] meson build for xserver

2017-04-26 Thread Adam Jackson
On Tue, 2017-04-25 at 19:49 -0700, Keith Packard wrote: > Eric Anholt writes: > > > Eric Anholt (3): > >   dix: Remove a redundant #define > >   Use #ifdef instead of #if for features to make Meson easier. > > Reviewed-by: Keith Packard > > >   Add a Meson

Re: [PATCH xserver v2] os: Handle SIGABRT

2017-04-26 Thread Adam Jackson
On Wed, 2017-04-26 at 18:31 +0900, Michel Dänzer wrote: > From: Michel Dänzer > > Without this, assertion failures can make life hard for users and > those > trying to help them. > > v2: > * Change commit log wording slightly to "can make life hard", since >   apparently

Re: [PATCH xserver 2/3] Use #ifdef instead of #if for features to make Meson easier.

2017-04-26 Thread Keith Packard
Aaron Plattner writes: > Waiting until autotools is nuked sounds fine to me. I just wanted to > throw the idea of using -Wundef out there. me too. -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org:

Re: [PATCH xserver 2/3] Use #ifdef instead of #if for features to make Meson easier.

2017-04-26 Thread Aaron Plattner
On 04/26/2017 11:21 AM, Eric Anholt wrote: > Aaron Plattner writes: > >> We try to do exactly the opposite in our internal driver build, because >> it's too easy to accidentally do something like >> >> #ifdef GLAMOUR_HAS_GBM >> >> And mistakes like that don't always cause

Re: [PATCH xserver 2/3] Use #ifdef instead of #if for features to make Meson easier.

2017-04-26 Thread Eric Anholt
Aaron Plattner writes: > We try to do exactly the opposite in our internal driver build, because > it's too easy to accidentally do something like > > #ifdef GLAMOUR_HAS_GBM > > And mistakes like that don't always cause obvious build failures like > this would. So we build

Re: [PATCH xserver 2/3] Use #ifdef instead of #if for features to make Meson easier.

2017-04-26 Thread Aaron Plattner
We try to do exactly the opposite in our internal driver build, because it's too easy to accidentally do something like #ifdef GLAMOUR_HAS_GBM And mistakes like that don't always cause obvious build failures like this would. So we build everything with -Wundef -Werror=undef and try to use #if

Re: [PATCH xserver 3/3] Add a Meson build system alongside autotools.

2017-04-26 Thread Jon Turney
On 26/04/2017 00:03, Eric Anholt wrote: This is a work in progress that builds Xvfb, Xephyr, Xwayland, Xnest, and Xdmx so far. The outline of Xquartz/Xwin support is in tree, but hasn't been built yet. The unit tests are also not done. man pages and documentation are also not done. I've

[PATCH xserver v2] os: Handle SIGABRT

2017-04-26 Thread Michel Dänzer
From: Michel Dänzer Without this, assertion failures can make life hard for users and those trying to help them. v2: * Change commit log wording slightly to "can make life hard", since apparently e.g. logind can alleviate that somewhat. * Set default handler for

Re: [PATCH xserver v2 2/7] xwayland: Allow pointer warp on the root window

2017-04-26 Thread Olivier Fourdan
Hey Carlos, > Of sorts, as we can't honor pointer warping across the whole root window > coordinates, peek the pointer focus in this case. > > Signed-off-by: Carlos Garnacho > --- > v2: Check that requester and focus window clients are the same > > hw/xwayland/xwayland.c