Re: [PATCH xserver 3/3] render: Fix default picture format initialization

Adam Jackson writes: > What would this mean? If I point this picture at a depth-30 pixmap, is > the intent really "draw into this as though it was x8r8g8b8"? Is there > a world where that's useful? I agree that it probably isn't useful, but we need to be careful with the

Re: [PATCH xserver 3/3] render: Fix default picture format initialization

Michel Dänzer writes: > On 2018-02-22 10:53 PM, Adam Jackson wrote: >> "depth" for a picture format is the sum of bits of a/r/g/b, and not x. >> The default format list was creating an x8r8g8b8 format at depth 32, >> which is wrong. Likewise, servers supporting depth 30 would

Re: [PATCH xserver 3/3] render: Fix default picture format initialization

Adam Jackson writes: > This is at the bottom of fbPictureInit. This is code that every driver > already runs. The loop will find that a pixmap of depth 16 has 16 bits > per pixel, and since that's larger than 12, it will add x4r4g4b4. But, a pixmap of depth 15 or 16 cannot

Re: [PATCH xserver 1/2] render: Store all 16bpc of precision for solid pictures

Adam Jackson writes: > Signed-off-by: Adam Jackson Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH xserver 2/2] render: Simplify miCompositeRects

Adam Jackson writes: > Make a solid-fill picture for this instead of a 1x1 pixmap. In principle > the backend can accelerate this directly, and we also get to preserve > all the bits of the fill color. > > Signed-off-by: Adam Jackson Reviewed-by: Keith Packard

[PATCH xserver 2/2] render: Simplify miCompositeRects

Make a solid-fill picture for this instead of a 1x1 pixmap. In principle the backend can accelerate this directly, and we also get to preserve all the bits of the fill color. Signed-off-by: Adam Jackson --- render/mirect.c | 63

[PATCH xserver 0/2] Minor Render cleanups

Some more little things found while testing the depth 30 series. Sadly neither one fixes the rendercheck issues, but neither do they break anything, and the result is definitely simpler. exa/exa_render.c| 4 +++- fb/fbpict.c | 16 +++-- glamor/glamor_program.c | 7

[PATCH xserver 1/2] render: Store all 16bpc of precision for solid pictures

Signed-off-by: Adam Jackson --- exa/exa_render.c| 4 +++- fb/fbpict.c | 16 +++- glamor/glamor_program.c | 7 --- glamor/glamor_render.c | 14 -- glamor/glamor_utils.h | 9 + render/picture.c| 10 +-

Re: [PATCH xserver 7/7] modesetting: Allow a DRM fd to be passed through XF86_VIDEO_MODESETTING_FD

Eric Anholt writes: > Any security concerns with a suid xserver here? Not that I know of, but it's probably only a matter of someone smarter than me looking? I think what I want is a command line option that is disabled when the server is setuid (or, frankly, run as root at

Re: [PATCH xserver] composite: Fix use-after-free in compReparentWindow

On Thu, 2018-02-22 at 22:25 -0800, Keith Packard wrote: > Peter Harris writes: > > > If an implicitly redirected window is unredirected by the reparent > > operation, cw will be a stale pointer. > > > > Signed-off-by: Peter Harris > > Reviewed-by:

Re: [PATCH xserver 3/3] render: Fix default picture format initialization

On Thu, 2018-02-22 at 16:52 -0800, Keith Packard wrote: > > switch (bpp) { > > case 16: > > /* depth 12 formats */ > > -if (pDepth->depth >= 12) { > > -addFormat(formats, , PICT_x4r4g4b4, > > pDepth->depth); > > -

Re: [PATCH xserver 3/3] render: Fix default picture format initialization

On Fri, 2018-02-23 at 10:51 +0100, Michel Dänzer wrote: > On 2018-02-22 10:53 PM, Adam Jackson wrote: > > "depth" for a picture format is the sum of bits of a/r/g/b, and not x. > > The default format list was creating an x8r8g8b8 format at depth 32, > > which is wrong. Likewise, servers supporting

Re: [PATCH xserver 7/7] modesetting: Allow a DRM fd to be passed through XF86_VIDEO_MODESETTING_FD

Keith Packard writes: > This lets an application open a suitable DRM device and pass the file > descriptor to the mode setting driver through an environment variable. > > There's a companion application, xlease, which creates a DRM master by > leasing an output from another X

Re: [PATCH util/modular] release.sh: Add support for mesa-demos

2018-02-23 13:02 GMT+01:00 Emil Velikov : > On 23 February 2018 at 09:40, Andreas Boll wrote: >> Signed-off-by: Andreas Boll >> --- >> release.sh | 34 ++ >> 1 file changed, 22

Re: [PATCH util-modular] release.sh: remove workaround for early Mesa versions

Reviewed-by: Andreas Boll 2018-02-23 13:56 GMT+01:00 Emil Velikov : > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > release.sh | 14 -- > 1 file changed, 14

[PATCH util/modular v2] release.sh: Add support for mesa-demos

v2: Rebase on Mesa cleanup. Move demos into its own elif statement. Signed-off-by: Andreas Boll --- Rebased on https://patchwork.freedesktop.org/patch/206466/ release.sh | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/release.sh

[PATCH util-modular] release.sh: remove workaround for early Mesa versions

From: Emil Velikov Signed-off-by: Emil Velikov --- release.sh | 14 -- 1 file changed, 14 deletions(-) diff --git a/release.sh b/release.sh index ff89d2e..99bd0c3 100755 --- a/release.sh +++ b/release.sh @@ -584,24 +584,10 @@

Re: [PATCH util/modular] release.sh: Add support for mesa-demos

On 23 February 2018 at 09:40, Andreas Boll wrote: > Signed-off-by: Andreas Boll > --- > release.sh | 34 ++ > 1 file changed, 22 insertions(+), 12 deletions(-) > > diff --git a/release.sh b/release.sh >

Re: [PATCH xserver 3/3] render: Fix default picture format initialization

On 2018-02-22 10:53 PM, Adam Jackson wrote: > "depth" for a picture format is the sum of bits of a/r/g/b, and not x. > The default format list was creating an x8r8g8b8 format at depth 32, > which is wrong. Likewise, servers supporting depth 30 would get an > x8r8g8b8 format at depth 30, which is

[PATCH util/modular] release.sh: Add support for mesa-demos

Signed-off-by: Andreas Boll --- release.sh | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/release.sh b/release.sh index ff89d2e..2045197 100755 --- a/release.sh +++ b/release.sh @@ -264,8 +264,10 @@