Re: [PATCH xf86-video-vmware] saa: Build compatibility with xserver 1.20

2018-03-14 Thread Thomas Hellstrom
Hi, Adam! On 03/05/2018 08:00 PM, Adam Jackson wrote: On Tue, 2017-11-07 at 15:45 -0500, Adam Jackson wrote: fbGetRotatedPixmap went away with 24bpp support, just treat it as NULL and we'll do the right thing. Ping? - ajax Thanks. Are you OK with the attached modification? Basically the

Re: [PATCH xserver 2/3] modesetting: Remove #ifdefs XF86_PDEV_SERVER_FD

2018-03-14 Thread Thomas Klausner
On Wed, Mar 14, 2018 at 01:33:28PM -0700, Alan Coopersmith wrote: > On 03/14/18 01:01 PM, Thomas Klausner wrote: > > I see a build failure in xorg-server-1.19.99.901 on NetBSD. > > Looks like the same failure I saw on Solaris and sent in a patch > for to revert the removal of that #ifdef. > >

Re: [PATCH xserver 2/3] modesetting: Remove #ifdefs XF86_PDEV_SERVER_FD

2018-03-14 Thread Alan Coopersmith
On 03/14/18 01:01 PM, Thomas Klausner wrote: > I see a build failure in xorg-server-1.19.99.901 on NetBSD. Looks like the same failure I saw on Solaris and sent in a patch for to revert the removal of that #ifdef. https://patchwork.freedesktop.org/patch/207937/ (In case my followup comment

Re: [PATCH xserver 2/3] modesetting: Remove #ifdefs XF86_PDEV_SERVER_FD

2018-03-14 Thread Thomas Klausner
I see a build failure in xorg-server-1.19.99.901 on NetBSD. GEN modesetting.4 driver.c: In function 'probe_hw': driver.c:247:38: error: dereferencing pointer to incomplete type 'struct xf86_platform_device' if (platform_dev && (platform_dev->flags & XF86_PDEV_SERVER_FD)) {

[PATCH xserver] build: Bump Mesa requirement to 17.1

2018-03-14 Thread Adam Jackson
gbm_bo_get_modifier is new in 17.1, which is 10 months old and two stable branches ago. Signed-off-by: Adam Jackson --- configure.ac| 2 +- glx/meson.build | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index

Re: [PATCH xserver v2 1/4] os: move xf86PrivsElevated here

2018-03-14 Thread Nicolai Hähnle
On 14.03.2018 14:36, Emil Velikov wrote: On 13 March 2018 at 21:46, Ben Crocker wrote: --- a/include/os.h +++ b/include/os.h @@ -368,6 +368,9 @@ System(const char *cmdline); #define Fclose(a) fclose(a) #endif +extern _X_EXPORT Bool +PrivsElevated(void); + Any

Re: [PATCH xserver] randr: Initialize RROuptutRec::nonDesktop

2018-03-14 Thread Keith Packard
Michel Dänzer writes: > Signed-off-by: Michel Dänzer Reviewed-by: Keith Packard

[PATCH xserver] randr: Initialize RROuptutRec::nonDesktop

2018-03-14 Thread Michel Dänzer
From: Michel Dänzer Flagged by valgrind: ==13695== Conditional jump or move depends on uninitialised value(s) ==13695==at 0x22461C: RRNoticePropertyChange (rrproperty.c:150) ==13695==by 0x22461C: RRChangeOutputProperty (rrproperty.c:263) ==13695==by 0x222FC4:

Re: [PATCH xserver] exa: promise not to touch the data when swapping pointers

2018-03-14 Thread Emil Velikov
On 13 March 2018 at 10:55, Eric Engestrom wrote: > exa/exa.c:525:10: warning: initialization discards ‘const’ qualifier from > pointer target type [-Wdiscarded-qualifiers] > swap(pExaGC, pGC, funcs); > ^ > > Signed-off-by: Eric Engestrom

Re: [PATCH xserver v2 1/4] os: move xf86PrivsElevated here

2018-03-14 Thread Emil Velikov
On 13 March 2018 at 21:46, Ben Crocker wrote: > --- a/include/os.h > +++ b/include/os.h > @@ -368,6 +368,9 @@ System(const char *cmdline); > #define Fclose(a) fclose(a) > #endif > > +extern _X_EXPORT Bool > +PrivsElevated(void); > + Any particular reason why this is

Re: [PATCH xserver v2 3/4] xfree86: replace all uses of xf86PrivsElevated with PrivsElevated

2018-03-14 Thread Emil Velikov
On 13 March 2018 at 21:46, Ben Crocker wrote: > -extern _X_EXPORT Bool > -xf86PrivsElevated(void); > FWIW, I cannot spot any external users of the symbol, so removing it should be fine. -Emil ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH xserver v3 23/24] xwayland: Cut off upper 32bit of queued vblank delay

2018-03-14 Thread Michel Dänzer
On 2018-03-13 04:00 PM, Roman Gilg wrote: > This ensures the same behavior as in Present's fake counter and xfree86. > > At the moment clients might do put vblanks too far into the future, because > the fake vblank code in Present and the xfree86 driver tolerate cut off upper > 32bit due to an 64

Re: [PATCH xserver] Xext/saver: Swap ScreenSaverSuspend 'suspend' field. Handle old XCB clients.

2018-03-14 Thread Mihai Moldovan
* On 03/14/2018 05:19 AM, Keith Packard wrote: > I'll take that as a 'Reviewed-by', unless you have some objection. Sure, go ahead! signature.asc Description: OpenPGP digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: