Re: [PATCH xserver] glamor: Work around GEM usage

2018-05-23 Thread Mark Kettenis
> From: Thomas Hellstrom > Date: Wed, 23 May 2018 22:58:05 +0200 > > On 05/23/2018 08:00 PM, Adam Jackson wrote: > > On Wed, 2018-05-23 at 11:14 +0200, Thomas Hellstrom wrote: > >> KMS drivers are not required to support GEM. In particular, vmwgfx > >> doesn't support

Re: [PATCH xserver] glamor: Work around GEM usage

2018-05-23 Thread Thomas Hellstrom
On 05/23/2018 08:00 PM, Adam Jackson wrote: On Wed, 2018-05-23 at 11:14 +0200, Thomas Hellstrom wrote: KMS drivers are not required to support GEM. In particular, vmwgfx doesn't support flink and handles and names are identical. Getting a bo name should really be part of a lower level API, if

Re: [PATCH xserver] glamor: Work around GEM usage

2018-05-23 Thread Adam Jackson
On Wed, 2018-05-23 at 11:14 +0200, Thomas Hellstrom wrote: > KMS drivers are not required to support GEM. In particular, vmwgfx > doesn't support flink and handles and names are identical. > Getting a bo name should really be part of a lower level API, if needed, > but in the mean time work around

Re: [PATCH xserver 2/2] glamor: Propagate glamor_fds_from_pixmap error in glamor_fd_from_pixmap

2018-05-23 Thread Emil Velikov
On 23 May 2018 at 10:43, Michel Dänzer wrote: > From: Michel Dänzer > > glamor_fds_from_pixmap returns 0 on error, but we were treating that as > success, continuing with uninitialized stride and fd values. > > Also bail if the offset isn't 0, same as

Re: [PATCH xserver] glamor: Work around GEM usage

2018-05-23 Thread Thomas Hellstrom
On 05/23/2018 11:14 AM, Thomas Hellstrom wrote: KMS drivers are not required to support GEM. In particular, vmwgfx doesn't support flink and handles and names are identical. Getting a bo name should really be part of a lower level API, if needed, but in the mean time work around this by setting

[PATCH xserver 2/2] glamor: Propagate glamor_fds_from_pixmap error in glamor_fd_from_pixmap

2018-05-23 Thread Michel Dänzer
From: Michel Dänzer glamor_fds_from_pixmap returns 0 on error, but we were treating that as success, continuing with uninitialized stride and fd values. Also bail if the offset isn't 0, same as in dri3_fd_from_pixmap. Fixes: c8c276c9569b "glamor: Implement

[PATCH xserver 1/2] glamor: Always return 0 from glamor_fds_from_pixmap on error

2018-05-23 Thread Michel Dänzer
From: Michel Dänzer This matches what glamor_egl_fds_from_pixmap and dri3_fds_from_pixmap do and what proc_dri3_buffers_from_pixmap expects. Fixes: c8c276c9569b "glamor: Implement PixmapFromBuffers and BuffersFromPixmap" Signed-off-by: Michel Dänzer

[PATCH xserver] glamor: Work around GEM usage

2018-05-23 Thread Thomas Hellstrom
KMS drivers are not required to support GEM. In particular, vmwgfx doesn't support flink and handles and names are identical. Getting a bo name should really be part of a lower level API, if needed, but in the mean time work around this by setting the name identical to the handle if GEM isn't