On Thu, 2018-06-28 at 12:39 -0700, Keith Packard wrote:
> Lyude Paul writes:
>
> > Looks good! One nitpick I'm not 100% sure about:
> > > +#define CHECK_FOR_REQUIRED_ARGUMENT() \
> > > +if (((i + 1) >= argc) || (!argv[i + 1])) {
> > > \
> > > +
Lyude Paul writes:
> Looks good! One nitpick I'm not 100% sure about:
>> +#define CHECK_FOR_REQUIRED_ARGUMENT() \
>> +if (((i + 1) >= argc) || (!argv[i + 1])) {
>> \
>> + ErrorF("Required argument to %s not specified\n", argv[i]); \
>> + UseMsg();
Before DIX structures are allocated for crtcs and outputs, we don't
want to call DIX randr code with NULL pointers. This can happen if the
driver sets video modes early in server initialization, which Nouveau
does in zaphod mode.
Cc: thellst...@vmware.com
Fixes:
The DIX crtc and output structures are freed when their resources are
destroyed, which happens before CloseScreen is called. As a result, we
know these pointers are invalid and referencing them during any of the
remaining CloseScreen sequence will be bad.
Signed-off-by: Keith Packard
Cc:
Hi Mike:
I’ve checked amd-staging-drm-next branch with the commit point
“35d594ef218696edc92cf6a1175c1a4a9c7c2aa6” (4.18.0-rc1). Please checkout that
commit, and apply the attached patch. ASUS PA328 display could only give 4K@30,
and attached Xorg log shows YCbCr420 only 4K@60 modes are
