[PATCH xserver 4/4] man: Fix automake seddery

2018-05-07 Thread Adam Jackson
. Signed-off-by: Adam Jackson --- manpages.am | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/manpages.am b/manpages.am index 8a36b0c1c0..15056905c2 100644 --- a/manpages.am +++ b/manpages.am @@ -34,21 +34,21 @@ MAN_SUBSTS += -e &#

[PATCH xserver 3/4] glx: Be sure to set an error for ghost contexts

2018-05-07 Thread Adam Jackson
Otherwise the caller is going to return garbage memory for the error value. Signed-off-by: Adam Jackson --- glx/glxcmds.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 6785e9db38..54d452e587 100644 --- a/glx/glxcmds.c +++ b/glx

Re: [PATCH xserver 6/6] xwayland: Fix a 32-bit build warning.

2018-05-08 Thread Adam Jackson
On Mon, 2018-05-07 at 16:46 -0700, Eric Anholt wrote: > Signed-off-by: Eric Anholt Merged, thanks: remote: I: patch #221286 updated using rev e1ccd0fa0e1081edf8a2c69ce6e8e3f67a4aecba. remote: I: patch #221285 updated using rev 4ec02b573ef2424965d7ce2d33d150ddb92ec544. remote: I: patch #221288

Re: [PATCH xserver 0/4] Final cleanups and polish

2018-05-08 Thread Adam Jackson
On Mon, 2018-05-07 at 17:21 -0400, Adam Jackson wrote: > 1/4 is the only vaguely contentious one, the rest should all be > obviously correct. Merged these: remote: I: patch #221270 updated using rev cc66777d85f3509b0f9dfc9210d0a0415a2a388d. remote: I: patch #221271 updated usi

Re: [RFC] Fix attempt for Mesa + X-Server 1.20 + modesetting-ddx hangs on KDE5.

2018-05-08 Thread Adam Jackson
On Fri, 2018-05-04 at 15:45 +0200, Mario Kleiner wrote: > The real problem, if i understand it correctly, is the way the life-time > of dri3_drawables and loader_dri3_drawables is managed atm. by Mesa's > bindContext() functions. Whenever glXMakeCurrent() etc. are called to > assign new/different

Re: [PATCH xserver] modesetting: set gbm as dependency in meson build

2018-05-08 Thread Adam Jackson
On Wed, 2018-05-02 at 21:32 +0200, Roman Gilg wrote: > Modifiers support needs gbm as a dependency. Without setting the dependency > included headers are not found reliably and the build might fail if the > headers are not placed in the default system include paths. > > Signed-off-by: Roman Gilg

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-09 Thread Adam Jackson
On Tue, 2018-05-08 at 11:42 +0200, Michel Dänzer wrote: > Idle notify events shouldn't need special treatment, since the pixmap > XIDs of the buffers will be different between loader_dri3_drawable > incarnations, aren't they? We're destroying loader_dri3_drawable structs at MakeCurrent time, but

Re: [PATCH xserver] meson: Fix module_dir configuration (v2)

2018-05-09 Thread Adam Jackson
On Thu, 2018-05-03 at 09:03 +1000, Peter Hutterer wrote: > On Wed, May 02, 2018 at 12:54:26PM -0700, Aaron Plattner wrote: > > meson.build has code to set the module_dir variable to > > ${libdir}/xorg/modules if the module_dir option string is empty. > > However, this has several problems: > > > >

Re: [PATCH synaptics] eventcomm: if we get a read error other than EAGAIN, remove the fd

2018-05-14 Thread Adam Jackson
ssages. Great > way to test file systems and their ability to handle out of space scenarios > but otherwise a bit pointless. Those FS developers should write their own > tests instead of relying on the synaptics driver! > > Signed-off-by: Peter Hutterer

Re: [ANNOUNCE] xorg-server 1.20.0

2018-05-14 Thread Adam Jackson
On Sat, 2018-05-12 at 07:48 +0200, Thomas Klausner wrote: > On Fri, May 11, 2018 at 03:40:18PM -0700, Matt Turner wrote: > > On Fri, May 11, 2018 at 2:28 PM, Thomas Klausner wrote: > > > xf86-video-intel-2.99.917: > > > > > > checking whether to include DRI1 support... no > > > configure: error:

Re: [PATCH xserver 0/3] meson fixes

2018-05-14 Thread Adam Jackson
On Sun, 2018-05-13 at 19:36 +0100, Jon Turney wrote: > Small fixes to meson build for problems I noticed when trying to package > 1.20.0 > > Jon Turney (3): > meson: install xwinclip and Xwinrc man pages > meson: don't install xorg wrapper manpages if suid-wrapper isn't being > used > m

Re: [PATCH] DRI2: Sync radeonsi_pci_ids.h from Mesa

2018-05-14 Thread Adam Jackson
On Mon, 2018-05-14 at 09:52 -0400, Alex Deucher wrote: > On Sun, May 13, 2018 at 9:31 AM, Bas Nieuwenhuizen > wrote: > > Fixes DRI2 client driver name mapping for newer AMD GPUs with the > > modesetting driver, allowing the DRI2 extension to initialize. > > > > Fixes using GL with the modesetting

Stepping back

2018-05-14 Thread Adam Jackson
tl;dr: I will not be release manager for 1.21, nor for anything thereafter either, and this time that's probably permanent. I won't make this too long to read though, it's not complicated. In a technical sense, I don't feel that I've been an effective release manager, evidenced if by nothing else

Re: [ANNOUNCE] xorg-server 1.20.0

2018-05-15 Thread Adam Jackson
On Tue, 2018-05-15 at 12:51 +0200, Thomas Klausner wrote: > > Those specific fixes could probably be cherry-picked to the version > > you're trying to build, but it may be worthwhile to update to git > > master anyway. > > I'm packaging for NetBSD, and we prefer to package tarballs, not git > mas

Re: Stepping back

2018-05-15 Thread Adam Jackson
On Tue, 2018-05-15 at 10:13 +0100, Daniel Stone wrote: > We've been facing the same question in Wayland. Here's what I wrote up > about what I think we should do with that: > https://lists.freedesktop.org/archives/wayland-devel/2018-May/038100.html > > Personally I think having longer discussio

Re: glamor_init: clamp GLSL to 120 if platform doesn't have instanced arrays

2018-05-16 Thread Adam Jackson
On Tue, 2018-05-15 at 21:51 +0200, Lukas F. Hartmann wrote: > Hi, > > I upgraded Xwayland and the assorted libraries from git masters today, > and noticed that glamor wouldn't work anymore on i.MX6/etnaviv. The > error was: > > No provider of glVertexAttribDivisor found. Requires one of: > D

Re: maxHValue/maxVValue replacement?

2018-05-18 Thread Adam Jackson
On Fri, 2018-05-18 at 08:34 +0200, Thomas Klausner wrote: > Some old drivers use maxHValue/maxVValue, which xorg-server-1.20.0 > does not provide any longer. What is the proper replacement? The only two I was able to find were mach64: https://cgit.freedesktop.org/xorg/driver/xf86-video-mach64/com

Re: [PATCH xserver 1/3] os/WaitFor: Check timers on every iteration

2018-05-21 Thread Adam Jackson
On Tue, 2018-04-17 at 16:32 -0400, Adam Jackson wrote: > 11:31 < pharris> "os/WaitFor: Check timers on every iteration" has my > reviewed-by. We've been shipping an equivalent patch for a > while. > 11:32 < pharris>

Re: [PATCH xserver 1/2] xfree86: Fix O_CLOEXEC usage in lnx_platform

2018-05-21 Thread Adam Jackson
On Fri, 2018-05-18 at 08:39 -0700, Keith Packard wrote: > Michel Dänzer writes: > > > From: Michel Dänzer > > > > It was passing O_CLOEXEC as permission bits instead of as a flag. > > Both are > > Reviewed-by: Keith Packard Merged, thanks: remote: I: patch #224006 updated using rev ab53e2

Re: [PATCH xserver] glamor: Work around GEM usage

2018-05-23 Thread Adam Jackson
On Wed, 2018-05-23 at 11:14 +0200, Thomas Hellstrom wrote: > KMS drivers are not required to support GEM. In particular, vmwgfx > doesn't support flink and handles and names are identical. > Getting a bo name should really be part of a lower level API, if needed, > but in the mean time work around

Re: [PATCH xserver] Xext/shm: Refuse to work for remote clients

2018-06-04 Thread Adam Jackson
On Mon, 2018-06-04 at 16:47 +0300, Alexander Volkov wrote: > diff --git a/Xext/shm.c b/Xext/shm.c > index fc8441c43..41ab0e2b6 100644 > --- a/Xext/shm.c > +++ b/Xext/shm.c > @@ -1302,6 +1302,10 @@ static int > ProcShmDispatch(ClientPtr client) > { > REQUEST(xReq); > + > +if (!client->lo

Re: Obtaining Xorg DDX commit privilege

2018-06-06 Thread Adam Jackson
On Wed, 2018-06-06 at 00:37 +0200, Kevin Brace wrote: > Regarding patch #5, it is based on the observation that starting X > Server with probing option does not really do anything inside PreInit > recall back, hence, there is no need to probe the monitor via VBE. This pattern is common among the

[PATCH xserver] glamor: Enable modifier support for xfree86 too

2018-06-06 Thread Adam Jackson
This was left disabled in 1.20.0, it's time to start being sure it works. Signed-off-by: Adam Jackson --- glamor/glamor_egl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index 123e9f28d4..4a4ca4bd86 100644 --- a/g

Re: [PATCH xserver] exa: Use PictureMatchFormat for source-only picture format description

2018-06-06 Thread Adam Jackson
ixels (v2.1)" > Signed-off-by: Michel Dänzer I'm not entirely sure why a source-only picture would have ->format but not ->pFormat? Still, if that's the case, this would definitely be a correct fix, so. Reviewed-by: Adam Jackson - ajax ___

Re: Obtaining Xorg DDX commit privilege

2018-06-06 Thread Adam Jackson
On Tue, 2018-06-05 at 05:00 +0200, Kevin Brace wrote: > Hi everyone, > > I hope I am doing this right. > More than a week ago, I requested Xorg DDX commit privilege. > > https://bugs.freedesktop.org/show_bug.cgi?id=106605 > > Unfortunately, there has been no action taken so far. > I do have Open

Re: Obtaining Xorg DDX commit privilege

2018-06-07 Thread Adam Jackson
On Thu, 2018-06-07 at 00:10 +0200, Kevin Brace wrote: > I was thinking that it is not really desirable to let VBE start > tinkering with I2C bus related registers this early in the PreInit > callback, That's probably a reasonable intuition, these days. I was just trying to describe the context be

Re: [PATCH xserver] xfree86: Inline xf86{Read, Write}Mmio{8, 16, 32} on alpha

2018-06-07 Thread Adam Jackson
now gone, we can just make the functions static inline > in compiler.h and avoid all of this. > > Bugzilla: https://bugs.gentoo.org/548906 > Tested-by: Christopher May-Townsend > Signed-off-by: Matt Turner Reviewed-by: Adam Jackson - ajax ___

Re: [PATCH xserver] present/wnmd: Preserve window pixmap's screen_x/y on flip

2018-06-07 Thread Adam Jackson
Add window flip mode" > Signed-off-by: Michel Dänzer Reviewed-by: Adam Jackson - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

gitlab migration

2018-06-08 Thread Adam Jackson
I'd like us to start moving repos and bug tracking into gitlab. Hopefully everyone's aware that gitlab exists and why fdo projects are migrating to it. If not, the thread about Mesa's migration provides some useful background: https://lists.x.org/archives/mesa-dev/2018-May/195634.html This should

[PATCH xserver] configure: Remove unused CONFIGFILE

2018-06-11 Thread Adam Jackson
This isn't used for anything, which is just as well, because /etc/xorg.conf is not in fact a path xserver will try to use. Bugzilla: https://bugs.freedesktop.org/8890 Signed-off-by: Adam Jackson --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configu

[PATCH xserver] xfree86: Makefile shouldn't rely on superuser being named 'root'

2018-06-11 Thread Adam Jackson
From: Michał Górny Change the 'chown' statement in Makefile.am to use the numeric UID of superuser instead of relying on the name 'root'. Bugzilla: https://bugs.freedesktop.org/27726 Signed-off-by: Adam Jackson Signed-off-by: Michał Górny --- hw/xfree86/Makefile.am | 4

Mass bugzilla closing

2018-06-12 Thread Adam Jackson
To help get the bz backlog down, I'm mass-closing anything that hasn't been touched in over six years and isn't obviously still valid. Apologies for the spam, and we should all feel bad about just how many bugs that closes. - ajax ___ xorg-devel@lists.x.

Re: [PATCH xorg-proto] Remove libdir from pc files.

2018-06-13 Thread Adam Jackson
On Wed, 2018-06-13 at 06:58 -0700, Keith Packard wrote: > Jeremy Puhlman writes: > > > Currently the pc files define libdir, however they are installed into > > /usr/share, which means they should be architecture agnostic. > > Makes sense to me; none of these install any libraries. > > Reviewed

Re: [PATCH xserver] Xext/shm: Refuse to work for remote clients

2018-06-14 Thread Adam Jackson
On Tue, 2018-06-05 at 13:05 +0300, Alexander Volkov wrote: > Avoid access to System V shared memory segment on the X server side > for clients forwarded via SSH. Also prevent them from hanging while > waiting for the reply from the ShmCreateSegment request. > > v2: Allow ShmQueryVersion request ev

Re: A question about XCompositeRedirectSubwindows

2018-06-20 Thread Adam Jackson
On Tue, 2018-06-19 at 17:35 -0700, Jasper St. Pierre wrote: > First off, there's a super high latency cost here. There is a latency cost, but I think it's worth being honest about it. I'm on whatever iteration of the Dell XPS laptop was a Skylake, and: 200 trep @ 0.0131 msec ( 76100.0/

Re: [PATCH] glx/vndcmds: Fix vendor hash table key size

2018-06-21 Thread Adam Jackson
On Wed, 2018-06-20 at 13:37 +, Vladimir Panteleev wrote: > The keySize parameter of the hashing/comparison functions was > incorrectly specified to be sizeof(void*), even though the keys of > this hashtable are CARD32. > > Fixes address sanitizer failure on 64-bit builds. Merged, thanks: rem

Re: Fw: merging imake fork

2018-06-21 Thread Adam Jackson
On Tue, 2018-06-19 at 22:11 -0700, Keith Packard wrote: > Alan Coopersmith writes: > > > and the most likely outcome will be many people recommending you move > > to anything but Imake, and maybe offering to make you the maintainer of > > X.Org's > > version so we can stop paying attention to it

Re: Gathering EGLStream related changed for Xwayland for a pull request

2018-06-21 Thread Adam Jackson
On Wed, 2018-06-20 at 19:31 -0400, Lyude Paul wrote: > Time's up! Merge request now live at > > https://gitlab.freedesktop.org/ajax/xserver/merge_requests/1 > > (yes, this is going to go back up into the cgit repo for now if any readers > were wondering. we haven't switched to gitlab entirely ye

Re: gitlab migration

2018-06-29 Thread Adam Jackson
On Fri, 2018-06-08 at 14:08 -0400, Adam Jackson wrote: > I'd like us to start moving repos and bug tracking into gitlab. > Hopefully everyone's aware that gitlab exists and why fdo projects are > migrating to it. If not, the thread about Mesa's migration provides

Re: [PATCH] meson: Add configuration of listening on tcp, unix and local

2018-07-02 Thread Adam Jackson
On Fri, 2018-06-29 at 09:44 +0200, Laurent Carlier wrote: > You've forgotten the gitlab repo I have a (non-automatic) personal mirror on gitlab, but we've not properly moved yet. If you're interested in following that progress, see: https://gitlab.freedesktop.org/freedesktop/freedesktop/issues/4

Re: gitlab migration

2018-07-02 Thread Adam Jackson
On Mon, 2018-07-02 at 10:23 -0700, Keith Packard wrote: > Adam Jackson writes: > > > I'd like us to start moving repos and bug tracking into gitlab. > > I would also like to get to a merge-request model at some > point. However, I think we can take this in stages and

Re: [PATCH xserver 2/2] xfree86: Wrap RRCrtcIsLeased and RROutputIsLeased to check for DIX structures

2018-07-03 Thread Adam Jackson
On Thu, 2018-06-28 at 11:45 -0700, Keith Packard wrote: > Before DIX structures are allocated for crtcs and outputs, we don't > want to call DIX randr code with NULL pointers. This can happen if the > driver sets video modes early in server initialization, which Nouveau > does in zaphod mode. > >

Re: [PATCH xserver] xf86-video-modesetting: Lease planes as well if using atomic

2018-07-03 Thread Adam Jackson
On Wed, 2018-06-27 at 10:41 +0100, Daniel Stone wrote: > Hi, > > On Wed, 27 Jun 2018 at 00:35, Keith Packard wrote: > > @@ -3251,6 +3251,9 @@ drmmode_create_lease(RRLeasePtr lease, int *fd) > > > > nobjects = ncrtc + noutput; > > > > +if (ms->atomic_modeset) > > +nobjects += nc

Re: [PATCH xserver] meson: ensure the libc has RPC functions when secure-rpc is enabled

2018-07-03 Thread Adam Jackson
On Fri, 2018-06-22 at 12:49 -0400, Lyude Paul wrote: > Currently our meson.build just makes the assumption that the libc is > going to provide RPC functions. This doesn't actually seem to be the > case on Fedora, which causes compilation to fail unexpectedly: > > ../../Projects/xserver/os/rpcauth.

Re: gitlab migration (including account update plans, please read)

2018-07-09 Thread Adam Jackson
On Mon, 2018-07-02 at 10:23 -0700, Keith Packard wrote: > For the first step, I'd like to propose moving the x server git > repository to gitlab in the coming week, with the switch-over happening > on the morning of July 9. This is now done: https://gitlab.freedesktop.org/xorg/xserver The old g

Re: [PATCH] modesetting: Fix 16 bit depth/bpp mode

2018-07-10 Thread Adam Jackson
On Mon, 2017-01-02 at 14:42 -0500, Adam Jackson wrote: > On Thu, 2016-12-22 at 15:41 +0100, Stefan Agner wrote: > > When setting DefaultDepth to 16 in the Screen section, the current > > code requests a 32 bpp framebuffer, however the X-Server seems to > > assumes 16 bpp.

Re: gitlab migration (including account update plans, please read)

2018-07-23 Thread Adam Jackson
On Mon, 2018-07-09 at 14:30 -0400, Adam Jackson wrote: > Currently the xorg group in gitlab is derived from the pre-existing > freedesktop LDAP group. This is a bit excessive, there's over 250 > people in the group in total and not even a fifth of those are > regularly active.

Re: gitlab migration (including account update plans, please read)

2018-07-23 Thread Adam Jackson
On Mon, 2018-07-23 at 11:23 -0400, Adam Jackson wrote: > Nobody did, so, this is done now. > > My earlier assertion about the git url not being changed is only true > for pulls. For pushes, you will indeed need to update the remote to the > new URL: > > $ git remote s

[PATCH xserver 1/7] dix: Add 'paintable' bit to the window state (v2)

2018-07-24 Thread Adam Jackson
A paintable window is a window whose pixels are (potentially) modifiable by rendering commands. Right now that just means the same thing as viewable; it will soon also include unmapped windows with backing store set to Always. v2: Set paintable in dix not ddx (Keith Packard) Signed-off-by: Adam

[PATCH xserver 0/7] Implement backing store's Always mode (version... something)

2018-07-24 Thread Adam Jackson
This is a resend of a series I wrote forever ago and nobody dared review. It probably needs some additional review and rethinking, but it definitely shouldn't keep languishing on my hard drive. The core issue is that Always windows need to have their pixels allocated before the window is ever mapp

[PATCH xserver 2/7] mi: miValidateTree based on paintable not viewable

2018-07-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- mi/mivaltree.c | 108 ++--- 1 file changed, 58 insertions(+), 50 deletions(-) diff --git a/mi/mivaltree.c b/mi/mivaltree.c index ea6889fdc0..f47cfa4571 100644 --- a/mi/mivaltree.c +++ b/mi/mivaltree.c @@ -164,14 +164,16

[PATCH xserver 3/7] mi: Mark/validate based on paintable not viewable

2018-07-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- mi/miwindow.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/mi/miwindow.c b/mi/miwindow.c index 39c279e184..1b910d9bea 100644 --- a/mi/miwindow.c +++ b/mi/miwindow.c @@ -151,7 +151,7 @@ miMarkOverlappedWindows

[PATCH xserver 6/7] dix: Switch window unmap to mark normally instead of UnmapValData

2018-07-24 Thread Adam Jackson
--- dix/window.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dix/window.c b/dix/window.c index 55290577d9..34bed93d93 100644 --- a/dix/window.c +++ b/dix/window.c @@ -2870,7 +2870,7 @@ UnmapWindow(WindowPtr pWin, Bool fromConfigure) if (SubStrSend(pWin, pParent))

[PATCH xserver 4/7] mi: Shortcut miDoCopy/miCopyArea based on paintable not realized

2018-07-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- mi/mibitblt.c | 4 ++-- mi/micopy.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mi/mibitblt.c b/mi/mibitblt.c index 2de5bf8fd5..8d70e5494e 100644 --- a/mi/mibitblt.c +++ b/mi/mibitblt.c @@ -92,9 +92,9 @@ miCopyArea(DrawablePtr

[PATCH xserver 5/7] dix: Update window state based on paintable not viewable

2018-07-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- dix/window.c | 69 1 file changed, 32 insertions(+), 37 deletions(-) diff --git a/dix/window.c b/dix/window.c index ea3920c869..55290577d9 100644 --- a/dix/window.c +++ b/dix/window.c @@ -1589,7 +1589,7

[PATCH xserver 7/7] composite: Implement backing store's Always mode

2018-07-24 Thread Adam Jackson
Keep the pixmap at unmap, always try to realize backing store, always mark them when marking, and update paintable when backed. Signed-off-by: Adam Jackson --- composite/compalloc.c | 2 +- composite/compinit.c | 24 +++-- composite/compint.h| 8 ++ composite

Re: [PATCH xserver v2] xwayland: rotate logical size for RRMode

2018-07-25 Thread Adam Jackson
On Thu, 2018-07-19 at 09:18 +0200, Olivier Fourdan wrote: > Hi, > > On Mon, Jul 16, 2018 at 10:47 AM Simon Ser wrote: > > > Reviewed-by: Olivier Fourdan Merged, thanks: remote: remote: I: patch #238455 updated using rev ce2dde9ed0243a18ae18af0879134f7c1afbd700. remote: remote: I: 1 p

Re: [PATCH v2 xserver] xwayland: Enable DRI3 for glamor

2018-07-25 Thread Adam Jackson
On Wed, 2018-07-25 at 16:33 +0200, Olivier Fourdan wrote: > glamor_fds_from_pixmap() will bail out early if DRI3 is not enabled, > unfortunately Xwayland's glamor code would not set it as enabled which > would lead to blank pixmaps when using texture from pixmap. > > Make sure to mark DRI3 as enab

Re: modesetting: Fix cirrus 24bpp breakage

2018-07-25 Thread Adam Jackson
On Thu, 2018-07-19 at 14:38 +0200, Stefan Dirsch wrote: > From: Takashi Iwai > > The recent rewrite of modesetting driver broke the 24bpp support. > As typically found on cirrus KMS, it leads to a blank screen, spewing > the error like: > failed to add fb -22 > (EE) modeset(0): failed to set

More gitlab migration (this time it's personal)

2018-07-26 Thread Adam Jackson
If you want to follow anything I'm working on, follow it here: https://gitlab.freedesktop.org/ajax/xserver/ I'll be using merge requests under that repo to track the progress of my own development branches, and issues to track known defects that someone should work on. I won't be looking at bugzi

Re: xmodmap really slow

2018-07-30 Thread Adam Jackson
On Thu, 2018-07-26 at 12:25 +0100, Alan Hourihane wrote: > Anyone tried just doing this recently > > xmodmap -pke > /tmp/keydump > xmodmap /tmp/keydump > > And watch the Xserver hang for quite some time. Seems to be nearly instantaneous against an Xvfb, but did cause a noticable hiccup with

Re: [PATCH app/fonttosfnt 2/5] README: update repository URL to gitlab

2018-07-31 Thread Adam Jackson
On Tue, 2018-07-31 at 11:53 +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > README | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Adam Jackson And a pre-emptive r-b for the same change to every other repo, I suppose. I can script tha

Re: gitlab migration (including account update plans, please read)

2018-08-01 Thread Adam Jackson
On Wed, 2018-08-01 at 14:38 +0200, Guillem Jover wrote: > It would be nice if the xorg.modules (from modular) got updated too, so > that some of this could be automated locally. :) My goodness, we have written this down so many slightly different ways. I've pushed some updates that I hope are rig

Re: xserver: Changes to 'server-1.20-branch'

2018-08-02 Thread Adam Jackson
On Thu, 2018-08-02 at 10:47 +0200, Michel Dänzer wrote: > On 2018-08-01 08:10 PM, GitLab Mirror wrote: > > New branch 'server-1.20-branch' available with the following commits: > > I'd like to nominate https://patchwork.freedesktop.org/patch/232490/ for > 1.20.1 as well. Hrargh. That patch doesn'

Re: [PATCH xserver 6/6] meson: Automatically detect HAVE_PTHREAD_SETNAME_NP

2018-08-02 Thread Adam Jackson
On Thu, 2018-08-02 at 15:22 +1000, Peter Hutterer wrote: > On Wed, Aug 01, 2018 at 01:49:54PM -0700, Eric Anholt wrote: > > Signed-off-by: Eric Anholt > > series Reviewed-by: Peter Hutterer 4/6 doesn't go too far enough, but this all looks good. Merged, thanks: remote: remote: I: patch #242143

[PATCH app/luit] Retire this fork of luit

2018-08-07 Thread Adam Jackson
We're not seriously maintaining this tool, we should stop pretending. Signed-off-by: Adam Jackson --- README | 27 +-- 1 file changed, 5 insertions(+), 22 deletions(-) diff --git a/README b/README index 825d09e..f60d34f 100644 --- a/README +++ b/README @@ -3,26

gitlab archives (was Re: [PATCH app/luit] Retire this fork of luit)

2018-08-08 Thread Adam Jackson
On Tue, 2018-08-07 at 12:03 -0400, Adam Jackson wrote: > We're not seriously maintaining this tool, we should stop pretending. > > Signed-off-by: Adam Jackson Merged (and archived the project): remote: remote: I: patch #243108 updated using rev 2aaa5d75f1b92a5383af676dbd

[PATCH xserver] autotools: Handle case when bindir var in xkbcomp.pc is absent

2018-08-09 Thread Adam Jackson
From: "vadym.shovkoplias" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107521 Fixes: 726839459cb (autotools: Derive xkb configuration from xkbcomp.pc) Signed-off-by: vadym.shovkoplias --- configure.ac | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure.a

Re: [PATCH xserver] autotools: Handle case when bindir var in xkbcomp.pc is absent

2018-08-09 Thread Adam Jackson
On Thu, 2018-08-09 at 12:25 -0400, Adam Jackson wrote: > From: "vadym.shovkoplias" Apologies to Vadym, who had tried to send the same thing to the list but got blocked by moderation. > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107521 > Fixes: 726839459cb (au

Re: [PATCH xserver 06/10] meson: Add an option to build XSELINUX.

2018-08-09 Thread Adam Jackson
On Tue, 2018-08-07 at 16:23 -0700, Eric Anholt wrote: > Dependencies are ported from the automake build. The only part I > skipped was making sure we can find libaudit.h. Fair enough, but then: > +build_xselinux = get_option('xselinux') > +if build_xselinux > +if not build_xace > +er

Re: [PATCH xserver 10/10] meson: Add detection of libsystemd-daemon.

2018-08-09 Thread Adam Jackson
On Wed, 2018-08-08 at 10:37 +1000, Peter Hutterer wrote: > but either way, series is > Reviewed-by: Peter Hutterer Merged (except 6/10), thanks: remote: remote: I: patch #243247 updated using rev 513d52d58915f291c0f706b67b8dc73f45de109f. remote: remote: I: patch #243245 updated using r

Re: gitlab migration

2018-08-20 Thread Adam Jackson
On Mon, 2018-06-11 at 12:33 +0200, Michel Dänzer wrote: > As the maintainer of xf86-video-amdgpu and -ati, I'm fine with migrating > these to GitLab for Git and patch review. > > However, I'm not sure what to do about bugs/issues. My first thought was > to allow creating new issues in GitLab and

Re: Anyone have a backup of XFree86 CVS?

2018-08-20 Thread Adam Jackson
On Mon, 2018-02-05 at 17:00 -0500, Adam Jackson wrote: > Well that was fast! Got a copy of the cvsroot for 3.x/4.x, hooray. I'll > take a crack at importing that to git once xserver 1.20 is out. https://gitlab.freedesktop.org/ajax/xfre

gitlab group permissions update

2018-08-20 Thread Adam Jackson
gitlab groups are recursive, which means if you are a member of the 'xorg' group, your permission level for every project in that group is at least as high as your permission at the top level. Most of the existing accounts were set as Maintainer, at which level you can do things like read and set t

[PULL xserver] Remove old colormap special cases from xfree86

2018-08-22 Thread Adam Jackson
: xfree86: Remove the rest of ->SetOverscan (2018-08-20 14:55:35 -0400) ---- Adam Jackson (8): xf86cmap: Factor out private lookup xf86cmap: Remove numColors from the colormap private xf86cmap: Remove overscan machin

Re: [Pixman] [BUG] SIGSEGV in sse2_fill

2018-08-29 Thread Adam Jackson
continued from pixman@, original thread here: https://lists.freedesktop.org/archives/pixman/2018-August/004759.html On Wed, 2018-08-29 at 18:14 +0200, Frédéric Fauberteau wrote: > Le 2018-08-29 16:33, Adam Jackson a écrit : > > This is a curious backtrace though. You're crashing w

gitlab merge requests are (mostly) enabled

2018-09-10 Thread Adam Jackson
I've turned merge requests on for most modules. I haven't done the drivers yet (hopefully by the end of the day), and will continue to leave them disabled for the drivers whose maintainers have asked they be left disabled. In particular, merge requests are enabled for xserver now, and that's how I

Re: gitlab merge requests are (mostly) enabled

2018-09-10 Thread Adam Jackson
On Mon, 2018-09-10 at 10:28 -0400, Adam Jackson wrote: > If you haven't logged into patchwork yet and turned on notifications ^ Erk, that should say gitlab not patchwork. - ajax ___ xorg-devel@lists.x.or

Re: [PATCH xserver v2] glamor: add support for NV12 in Xv

2018-09-11 Thread Adam Jackson
On Tue, 2018-09-11 at 15:41 -0400, Alex Deucher wrote: > On Tue, Sep 11, 2018 at 1:30 PM Julien Isorce wrote: > > > > Useful when video decoders only output NV12. Currently > > glamor Xv only supports I420 and YV12. > > > > Note that Intel's sna supports I420, YV12, YUY2, UYVY, NV12. > > > > Te

Re: [PATCH xserver v8 05/14] modesetting: Use atomic modesetting API for pageflip if available

2018-10-01 Thread Adam Jackson
On Wed, 2018-09-12 at 11:01 +1000, Dave Airlie wrote: > On Wed, 28 Feb 2018 at 11:21, Daniel Stone wrote: > > > > +static Bool > > +drmmode_prop_info_copy(drmmode_prop_info_ptr dst, > > + const drmmode_prop_info_rec *src, > > + unsigned int num_props, > >

Re: [PATCH xserver v8 05/14] modesetting: Use atomic modesetting API for pageflip if available

2018-10-01 Thread Adam Jackson
On Mon, 2018-10-01 at 11:31 -0400, Adam Jackson wrote: > AFAICT the free(dst) is always wrong. The other places we use > drmmode_prop_info_copy, we're initializing an array in the middle of a > drmmode_{crtc,output}_private_rec. https://gitlab.freedesktop.org/xorg/xserver/mer

Re: [PATCH] xfree86: Only switch to original VT if it is active.

2018-10-12 Thread Adam Jackson
On Thu, 2018-10-11 at 16:45 +0200, Michal Srb wrote: > If the X server is terminated while its VT is not active, it should > not change the current VT. > --- > Changing the VT in that situation serves no purpose and can be confusing. > For example when a user's graphical session is terminated while

gitlab migration: xserver issues enabled

2018-10-15 Thread Adam Jackson
I've enabled filing gitlab issues for xserver, as people were trying to file bugs against xorg/meta (which is not the right place). Expect bugzilla migration to start happening later this week and take... well, I don't know how long, I'll be attempting to triage/close old issues as I go and I don't

Re: git access to sgi / xf86-video-impact

2018-10-16 Thread Adam Jackson
On Tue, 2018-10-16 at 17:02 +0200, René Rebe wrote: > I now requested access (rener) on the new gitlab site. The top-level 'xorg' group implies access to all subprojects, which we'd like to keep to a minimum. I've added you as a Maintainer to xorg/drivers/xf86-video-impact, if you need additional

Re: Mod4 + O is blocked from applications

2018-11-07 Thread Adam Jackson
On Mon, 2018-11-05 at 13:41 +0200, hoshi wrote: > Hi, I have tested on some user applications (Emacs, gedit,...) and > found that Mod4+O, Mod4+P is not sent to the applications. Instead, > they show the cursor (if it's hidden). I am not sure if this is due > to Xorg or other programs. I don't know

Re: libpciaccess on GNU/Hurd

2018-11-07 Thread Adam Jackson
On Mon, 2018-11-05 at 22:56 +1100, Damien Zammit wrote: > I wish to propose an additional api call to libpciaccess. > Before I submit a patch, I wish to get some feedback from the devs. > > In GNU/Hurd currently, applications use the x86 backend from > libpciaccess. This poses concurrency issues

Re: [PATCH xserver] xwayland: use wl_surface_damage_buffer

2018-11-07 Thread Adam Jackson
On Mon, 2018-11-05 at 18:25 +, Simon Ser wrote: > On Monday, November 5, 2018 3:24 PM, Pekka Paalanen > wrote: > > I don't think it's a good idea to break Xwayland completely on > > compositors that don't implement wl_surface version 4 or greater. > > > > It would make sense to bind wl_compo

Re: libpciaccess on GNU/Hurd

2018-11-07 Thread Adam Jackson
On Wed, 2018-11-07 at 18:27 +0100, Samuel Thibault wrote: > Adam Jackson, le mer. 07 nov. 2018 12:04:52 -0500, a ecrit: > > On Mon, 2018-11-05 at 22:56 +1100, Damien Zammit wrote: > > > > > I wish to propose an additional api call to libpciaccess. > > > Before I s

Re: libpciaccess on GNU/Hurd

2018-11-08 Thread Adam Jackson
On Wed, 2018-11-07 at 22:56 +0100, Samuel Thibault wrote: > Adam Jackson, le mer. 07 nov. 2018 15:09:58 -0500, a ecrit: > > Because the kernel is the one thing in a position to enforce access > > exclusion. > > root-owned processes can still use ioperm to get access to io p

Re: [PATCH] dix/window: Use ConfigureWindow instead of MoveWindow

2018-11-13 Thread Adam Jackson
On Mon, 2018-11-12 at 13:51 +0100, Michal Srb wrote: > The screensaver can regularly move its window to random offsets. It should > use the ConfigureWindow function instead of calling the Screen's MoveWindow > directly. Some MoveWindow implementations, such as compMoveWindow, rely on > Screen's Con

Re: Patch for glibc 2.25+ in xserver config/udev.c

2018-11-13 Thread Adam Jackson
On Mon, 2018-11-12 at 13:48 -0800, Manoj Gupta wrote: > Is this the right mailing list for this patch? If not, please advise. This is the right list, although we're generally moving to gitlab for patch submission: https://gitlab.freedesktop.org/xorg/xserver/ > diff --git a/config/udev.c b/confi

Re: [PATCH xorg-docs 1/4] Update docs for gitlab migration

2018-11-19 Thread Adam Jackson
//www.x.org/wiki/Development/Documentation/SubmittingPatches";> > + url="https://www.x.org/wiki/Development/Documentation/SubmittingPatches";> I've updated this wiki page to talk about gitlab first, and moved the email-based workflow to the end. Series is: Review

Re: [PATCH xserver] dix: do not send focus event when grab actually does not change

2018-11-19 Thread Adam Jackson
On Mon, 2018-11-19 at 18:06 +0100, Samuel Thibault wrote: > Hello, > > Ping? Tsk, thought I'd pushed this already. Merged, thanks: https://gitlab.freedesktop.org/xorg/xserver/merge_requests/77 - ajax ___ xorg-devel@lists.x.org: X.Org development Arch

What could it mean for a visual to have more than one depth?

2018-11-19 Thread Adam Jackson
I've been looking at cleaning up pixmap format and visual initialization. I'm having some difficulty understanding why the code is currently doing what it's doing. Perhaps someone has an idea. In the initial connection block, a DEPTH is a tuple of a depth and a list of visuals. A VISUALTYPE is a t

Re: Repos to archive?

2018-11-20 Thread Adam Jackson
On Tue, 2018-11-20 at 09:34 -0800, Eric Anholt wrote: > Alan Coopersmith writes: > > > While iterating over all the /xorg/ repos to update their READMEs > > (which I think I've now finished - let me know if you spot one I missed), > > I noticed a few more to consider archiving: > > I agree with

X server bugzilla is closed, please use gitlab instead

2018-11-20 Thread Adam Jackson
I've turned off new bug entry in bugzilla for the X server and the modesetting driver. Please use gitlab issues for all new reports: https://gitlab.freedesktop.org/xorg/xserver/issues Existing bugs can still be modified, but will eventually be migrated into gitlab as well. They've not been migrat

Re: [PATCH] Add 24-bit color support to exaGetPixmapFirstPixel

2018-12-17 Thread Adam Jackson
On Thu, 2018-12-13 at 22:32 -0600, Kevin Brace wrote: > It appears that people who developed EXA forgot that there used to be > graphics devices that used 24-bits (3 bytes) instead of 32-bits (4 bytes) > in order to display one pixel. The lack of 24-bit color support inside > exaGetPixmapFirstPixel

Re: [PATCH] Add 24-bit color support to exaGetPixmapFirstPixel

2018-12-18 Thread Adam Jackson
On Mon, 2018-12-17 at 23:54 +0100, Kevin Brace wrote: > The rendering is fine for the login screen as far as I am concerned, > so I would imagine that EXA can theoretically support 24 bpp, but no > one really tried since by the time EXA was developed, every new > graphics had 32 bpp support, and d

Re: xf86-video-vmware compilation issue with xserver built with meson

2019-01-14 Thread Adam Jackson
On Sat, 2019-01-12 at 12:18 +, Tuomo Rinne wrote: > The correct fix would be to use #ifdef statements in the xf86-video-vmware > driver correct? I'm happy to send a patch if this is the case. I think that's the best fix. xserver's never going to do #define XSERVER_LIBPCIACCESS 0 so using

Re: Xwayland on demand (Re: [PATCH xwayland 3/3] xwayland: Handle the case of windows being realized before redirection)

2019-01-16 Thread Adam Jackson
On Wed, 2019-01-16 at 11:52 +0200, Pekka Paalanen wrote: > What I think we would need is a way to launch Xwayland, but ensure it > does not process the real X11 apps until all the preparations (xrdb, > XWM init, etc.) have finished. What the preparations are exactly, only > the Wayland compositor

<    1   2   3   4   5   6   7   8   9   10   >