[PATCH xserver 3/4] glamor: Remove #if 0-ed picture dumping code.

I don't think anybody has run this code since it was pulled into the server. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_render.c | 5 - glamor/glamor_utils.h | 379 - 2 files changed, 384 deletions(-) diff --git a/

[PATCH xserver 4/4] glamor: Fix link failure on GLES2.

Current Mesa requires that the precision qualifier on uniforms matches between stages, even if (as in this case) the uniform isn't used in one of the stages. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_program.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH xserver 1/4] glamor: Require GL_OES_texture_border_clamp for GLES2.

The extension came out in 2000, and all Mesa-supported hardware that can do glamor supports it. We were already relying on the ARB version being present on desktop. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor.c| 19 +++ glamor/glamor_render.

[PATCH xserver 2/4] glamor: Remove many unused glamor util functions.

Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_utils.h | 171 -- 1 file changed, 171 deletions(-) diff --git a/glamor/glamor_utils.h b/glamor/glamor_utils.h index 561761167fd8..e6398692e3d6 100644 --- a/glamor/glamor_utils.h

[PATCH xserver 0/4] render cleanups

I started working on using sampler objects as a step toward doing sampler views, and found I wanted to delete a bunch of code first. Eric Anholt (4): glamor: Require GL_OES_texture_border_clamp for GLES2. glamor: Remove many unused glamor util functions. glamor: Remove #if 0-ed picture

Re: [PATCH xserver] test: Re-enable a couple of GetImage tests

Adam Jackson <a...@redhat.com> writes: > Fixed in 6c6f09aac. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/

Re: [PATCH] glamor: spans: fixup wrong count on glDrawArrays

Mark Yao writes: > since commit (9e9fcf5 glamor: Add a helper function for the common > GL_QUADS fallback pattern.), the glDrawArrays count change to nbox, > That is wrong, I think it maybe cause by fat finger. > > Signed-off-by: Mark Yao

Re: [PATCH xserver 3/3] glamor: Switch XY bitmap putimage function for small images

Keith Packard writes: > Use the glamor_put_image_xy_gl for small images as that is quite a bit > faster. I'd like to see some performance data in the commit messages. With that, this will all be r-b. Thanks! I'm hoping that once we do VAOs that will greatly improve our

Re: [PATCH xserver 0/3] glamor: Accelerate XY format images

Adam Jackson writes: > On Fri, 2016-09-30 at 22:43 -0700, Keith Packard wrote: > >>    1 2 Operation >>    -   - >>  10900.099900.0 ( 9.165)   PutImage XY 10x10 square 

[PATCH xserver] glamor: Properly handle mask formats without alpha.

Even if the pixmap's storage has alpha, it may have been uploaded with garbage in the alpha channel, so we need to force the shader to set alpha to 1. This was broken way back in 355334fcd99e4dce62e2be1e27290c9a74ea944f. Fixes rendercheck -t composite -f x8r8g8b8. Signed-off-by: Eric Anholt &l

Re: [PATCH 05/18] glamor: fix spelling mistakes

Adam Jackson writes: > On Sat, 2016-04-02 at 19:53 +0100, Eric Engestrom wrote: > >> -   the orginal slope and the slope which is vertical to it will not >> be correct. */ >> +   the orignal slope and the slope which is vertical to it will not >> be correct. */ >

Re: 2 patches for glamor on OpenBSD (without DRI3/XSHM_FENCE)

shouldn't fail on systems that don't support DRI3. v2: Drop stale commit message wording, fix compiler warning (by anholt) Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Eric Anholt <e...@anholt.net> and merged: To git+ssh://git.freedesktop.org/git/xorg/

Re: [PATCH 1/2] glamor: Add GLAMOR_ACCESS_WO

Michel Dänzer writes: > Adding Marek and Nicolai, maybe they have some feedback from a GL > (driver) perspective. > > > On 23/08/16 10:41 AM, Dave Airlie wrote: >> From: Michel Dänzer >> >> [airlied: rebased onto master - >> I left WO alone as it's

Re: [PATCH rendercheck] Report results on a per-test basis

Martin Peres <martin.pe...@linux.intel.com> writes: > On 21/10/16 19:18, Eric Anholt wrote: >> Martin Peres <martin.pe...@linux.intel.com> writes: >> >>> This allows a runner such as EzBench to track each test individually >>> and not limit the r

Re: [PATCH xts] xts5: Fix clang warning - non-void function DoLayout should return a value

Echelon9 writes: > From: Rhys Kidd > > Box.c:245:7: error: non-void function 'DoLayout' should return a value > [-Wreturn-type] > return; > ^ > Box.c:285:6: error: non-void function 'DoLayout' should return a

Re: [PATCH xserver] glamor: restore vfunc handlers on init failure

and DestroyPixmap() vfunc handlers in > case of failure when checking for the minimum requirements, so that if > any of the requirement is not met we don't leave the CloseScreen() and > DestroyPixmap() from glamor handlers in place. > > Bugzilla: https://bugzilla.redhat.com/show_bug.cg

Re: [PATCH xserver] glamor: Isolate GLX client code to its own library

Adam Jackson writes: > This is a step towards making libglamor_egl and Xwayland not link > against libGL (which brings in client-side libraries, which is just > icky). Is it actually necessary? Given that the epoxy GLX symbols always exist, and we're linking against epoxy, it

Re: [PATCH xserver] configure.ac: bump epoxy requirement to 1.2

Adam Jackson writes: > On Mon, 2016-10-24 at 12:19 -0700, Matt Turner wrote: >> On Mon, Oct 24, 2016 at 2:39 AM, Emil Velikov >> wrote: >> > > > From: Emil Velikov >> > >> > As pointed out in the ABI tracker[1], epoxy has

Re: [PATCH rendercheck] Report results on a per-test basis

Martin Peres writes: > This allows a runner such as EzBench to track each test individually > and not limit the resolution to groups. > > This feature can be triggered by using the -r parameter. I don't really see the point of this -- you need an external runner to

Re: [Bug] arm64: glamor: display abnormal when rotate screen

Mark yao writes: > Hi Eric > > We found some display problem when rotate the screen. > > You can see the abnormal display picture on attachment. > > Bug reproduce step: > 1, run lubuntu session. > 2, rotate screen: xrandr --output eDP-1 --rotate right > 3, run

Re: [Bug] arm64: glamor: display abnormal when rotate screen

Mark yao <mark@rock-chips.com> writes: > On 2016年11月15日 02:32, Eric Anholt wrote: >> Mark yao <mark@rock-chips.com> writes: >> >>> Hi Eric >>> >>> We found some display problem when rotate the screen. >>> >>> You c

Re: [PATCH xserver] configure: Enable glamor when building just Xwayland

Adam Jackson writes: > Signed-off-by: Adam Jackson > --- > configure.ac | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 6fd853b..93c81a6 100644 > --- a/configure.ac > +++ b/configure.ac > @@

Re: [PATCH xserver] configure: Enable glamor when building just Xwayland

Alan Coopersmith <alan.coopersm...@oracle.com> writes: > On 11/22/16 04:58 PM, Eric Anholt wrote: >> Adam Jackson <a...@redhat.com> writes: >> >>> Signed-off-by: Adam Jackson <a...@redhat.com> >>> --- >>> configure.ac | 5 + >

Re: [PATCH xts] Don't sleep(2) at the beginning of Xt test setup

Adam Jackson <a...@redhat.com> writes: > Regeneration is fast enough these days, we can skip this. This > eliminates about 40 minutes of wall time from a full xts run. If not sleeping is a problem, we should figure out a way to make regeneration not racy. Sleeps aren't OK. Revie

Re: [PATCH] glproto: Fix typo in X_GLXSetClientInfo2ARB definition

nfo2ARB 35 Mesa and xserver don't seem to rely on the typoed name. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 1/3] xfree86: Clean up DPMS support

Adam Jackson writes: > Rather than setting up a per-screen private, just conditionally > initialize ScrnInfoRec::DPMSSet based on the config options, and inspect > that to determine whether DPMS is supported. > > We also move the "turn the screen back on at CloseScreen" logic

Re: [PATCH rendercheck 0/5] Convert to meson.

Mark Kettenis <mark.kette...@xs4all.nl> writes: >> From: Eric Anholt <e...@anholt.net> >> Date: Fri, 24 Mar 2017 13:17:45 -0700 >> >> Having bitten off a bit more than I can chew in 3 days with the X >> Server (hw/xfree86/sdksyms.c is the worst), I dec

Re: [PATCH xserver 1/3] xfree86: Clean up DPMS support

k on at CloseScreen" logic into the > DPMS extension's (new) reset hook. This would be a behavior change for > the non-xfree86 servers, if any of them had non-stub DPMS support. > > Signed-off-by: Adam Jackson <a...@redhat.com> I took another look today, and this seri

[PATCH rendercheck 2/5 v2] Add a meson build system.

Meson allows the configure step to be run faster (.3 seconds compared to autogen.sh's 3.9 seconds on my system) and a full rebuild (touch rendercheck.h; make) to run faster (.05s instead of .07s). Rendercheck is pretty much the best case scenario for autotools, with limited configure-time

Re: [PATCH xserver 3/3] kdrive: Remove dead slots from KdCardFuncs

Adam Jackson <a...@nwnk.net> writes: > On Mon, 2017-03-27 at 12:35 -0400, Adam Jackson wrote: >> On Fri, 2017-03-24 at 13:44 -0700, Eric Anholt wrote: >> >> > This is the only functional change I spotted: SaveScreen is now >> > going to >> > retu

Re: [PATCH xserver] xfree86: Remove driver entity hooks and private

Adam Jackson writes: > No driver is using these, as far as I know. If we're going to leave the args in place for xf86ConfigPciEntity, could we assert that init/enter/leave are NULL, to catch if a driver *did* exist that used them? The docs for xf86ConfigPciEntity() should

Re: [PATCH xserver 3/2] Rewrite the byte swapping macros.

Peter Hutterer <peter.hutte...@who-t.net> writes: > On Mon, Mar 27, 2017 at 03:11:03PM -0700, Eric Anholt wrote: >> The clever pointer tricks were actually not working, and we were doing >> the byte-by-byte moves in general. By just doing the memcpy and >> obviou

Re: [PATCH xserver 1/3] xfree86: Clean up DPMS support

Adam Jackson <a...@redhat.com> writes: > On Fri, 2017-03-24 at 10:34 -0700, Eric Anholt wrote: >> > Adam Jackson <a...@redhat.com> writes: >> >> > Rather than setting up a per-screen private, just conditionally >> > initialize ScrnInfoRec::

[PATCH rendercheck 0/5] Convert to meson.

to meson. I ended up not finishing the travis-ci work because the build time of running 17 autogen.sh's on travis was so long that I got bored. Eric Anholt (5): Fix a printf format warning. Add a meson build system. Remove the autotools build system. Convert the manpage for Meson's

[PATCH rendercheck 2/5] Add a meson build system.

Meson allows the configure step to be run faster (.3 seconds compared to autogen.sh's 3.9 seconds on my system) and a full rebuild (touch rendercheck.h; make) to run faster (.05s instead of .07s). Rendercheck is pretty much the best case scenario for autotools, with limited configure-time

[PATCH rendercheck 3/5] Remove the autotools build system.

--- .gitignore | 79 - Makefile.am | 43 --- autogen.sh | 17 - configure.ac| 29 - main.c | 6 - man/Makefile.am | 38 --- 6

[PATCH rendercheck 1/5] Fix a printf format warning.

--- rendercheck.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rendercheck.h b/rendercheck.h index 1c392e8d69fd..7dc9dc95c38d 100644 --- a/rendercheck.h +++ b/rendercheck.h @@ -37,7 +37,7 @@ static inline void errx(int eval, const char *fmt, ...) { va_start(args, fmt);

[PATCH rendercheck 5/5] Explain how to build using meson in the README.

--- README | 8 1 file changed, 8 insertions(+) diff --git a/README b/README index f5af0b0c64eb..2f8ec1ab0e46 100644 --- a/README +++ b/README @@ -10,3 +10,11 @@ Tests currently include: - Linear gradients - Repeating sources/masks at POT and non-POT sizes - Some regression tests for

[PATCH rendercheck 4/5] Convert the manpage for Meson's configure script.

--- man/rendercheck.man | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/rendercheck.man b/man/rendercheck.man index b7be417d5c37..8b7dccab7725 100644 --- a/man/rendercheck.man +++ b/man/rendercheck.man @@ -1,5 +1,5 @@ .ds q \N'34' -.TH rendercheck 1 __xorgversion__ +.TH

Re: [PATCH xserver 3/3] kdrive: Remove dead slots from KdCardFuncs

hange I spotted: SaveScreen is now going to return FALSE instead of TRUE. Given that we haven't actually blanked the screen, this seems like an appropriate return value. With a note in the commit message about this behavior change (or, even better, if DPMS was pulled into a separate commit), the series wil

Re: [PATCH xserver 3/2] Rewrite the byte swapping macros.

Keith Packard <kei...@keithp.com> writes: > [ Unknown signature status ] > Eric Anholt <e...@anholt.net> writes: > >> Unaligned accesses trap on some platforms, and I don't think we're >> guaranteed that the caller has the pointer aligned (at least, the >&

[PATCH xserver 2/7] kdrive: Remove vestiges of TSLIB support.

The actual code was gone in 27819950e4158326e0f83a30f2e8968b932625ef, but some checks remained. --- configure.ac | 5 ++--- include/dix-config.h.in| 6 -- include/kdrive-config.h.in | 3 --- include/xorg-server.h.in | 3 --- 4 files changed, 2 insertions(+), 15

[PATCH xserver 6/7] xserver: Unifdef HAVE_CONFIG_H

The X Server never generates a global config.h, and instead all these paths are including dix-config.h or xorg-config.h. --- hw/xfree86/modes/xf86Crtc.c | 3 --- hw/xfree86/modes/xf86Cursors.c | 3 --- hw/xfree86/modes/xf86DiDGA.c | 3 --- hw/xfree86/modes/xf86EdidModes.c | 3 ---

[PATCH xserver 7/7] ephyr: Remove the -fakexa option.

ARE. - * - * Authors: - *Eric Anholt <e...@anholt.net> - * - */ - -#ifdef HAVE_DIX_CONFIG_H -#include -#endif - -#include "ephyr.h" -#include "exa_priv.h" -#include "fbpict.h" - -#define EPHYR_TRACE_DRAW 0 - -#if EPHYR_TRACE_DRAW -#define TRACE_DRAW() Error

[PATCH xserver 3/7] kdrive: Drop kdrive-config.h.

It had nothing left in it that was used but wasn't in dix-config.h. --- configure.ac | 7 +-- hw/kdrive/ephyr/Makefile.am | 1 + hw/kdrive/ephyr/ephyr.c | 4 ++-- hw/kdrive/ephyr/ephyr_draw.c | 4 ++-- hw/kdrive/ephyr/ephyr_glamor_xv.c | 4 ++--

[PATCH xserver 0/7] meson prep work

of the time it takes to ./configure. In the process, I've run into some silly stuff in our tree that could be cleaned up independently of whether we go with meson. Eric Anholt (7): kdrive: Unifdef KDRIVE_EVDEV. kdrive: Remove vestiges of TSLIB support. kdrive: Drop kdrive-config.h. xserver

[PATCH xserver 5/7] glamor: Fix some formatting that confused the unifdef command.

--- glamor/glamor_priv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glamor/glamor_priv.h b/glamor/glamor_priv.h index 27f95521dd3d..7b92f35705f4 100644 --- a/glamor/glamor_priv.h +++ b/glamor/glamor_priv.h @@ -910,7 +910,7 @@ int glamor_xv_put_image(glamor_port_private

[PATCH xserver 1/7] kdrive: Unifdef KDRIVE_EVDEV.

ajax deleted the evdev driver in the removal of fbdev and the linux backend. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/kdrive/ephyr/ephyrinit.c | 10 -- hw/kdrive/src/kinput.c | 25 - include/kdrive-config.h.in | 3 --- 3 files chang

[PATCH xserver 4/7] xserver: Check the right HAVE_*_CONFIG_H.

--- hw/xfree86/exa/examodule.c | 2 +- hw/xwayland/xwayland-shm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/exa/examodule.c b/hw/xfree86/exa/examodule.c index 76f780ab6d6f..0bbd93e34015 100644 --- a/hw/xfree86/exa/examodule.c +++

[PATCH rendercheck v3 3/4] Simplify manpage variable substitution for Meson.

The previous code was contorting itself to do the substitution in the same source format as the xorg automake macros. Now that automake is gone, we can simplify it. Signed-off-by: Eric Anholt <e...@anholt.net> --- man/rendercheck.man | 2 +- meson.build | 15 --- 2

[PATCH rendercheck v3 4/4] Explain how to build using meson in the README.

Signed-off-by: Eric Anholt <e...@anholt.net> --- README | 8 1 file changed, 8 insertions(+) diff --git a/README b/README index f5af0b0c64eb..2f8ec1ab0e46 100644 --- a/README +++ b/README @@ -10,3 +10,11 @@ Tests currently include: - Linear gradients - Repeating sources/masks

[PATCH rendercheck v3 2/4] Remove the autotools build system.

Signed-off-by: Eric Anholt <e...@anholt.net> --- .gitignore | 79 - Makefile.am | 43 --- autogen.sh | 17 - configure.ac| 29 - main.c | 6

[PATCH rendercheck v3 1/4] Add a meson build system.

autodetection, non-recursive make, and no libtool, so it seems like an interesting test-case to start with for meson conversion. v2: Add missing check for err.h v3: Add a linebreak after printing the version (by Peter), fix manpage variable substitution (anholt). Signed-off-by: Eric Anholt &l

Re: [PATCH rendercheck 4/5] Convert the manpage for Meson's configure script.

Peter Hutterer <peter.hutte...@who-t.net> writes: > On Fri, Mar 24, 2017 at 01:17:49PM -0700, Eric Anholt wrote: >> --- >> man/rendercheck.man | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/man/rendercheck.man b/ma

Re: [PATCH xserver v2] xfree86: Remove driver entity hooks and private

Adam Jackson <a...@redhat.com> writes: > No driver is using these, as far as I know. > > v2: Tripwire the entity hook arguments to xf86Config*Entity, fix > documentation (Eric Anholt) Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc De

Re: [PATCH rendercheck] Skip shmblend if SHM pixmaps aren't supported

Aaron Plattner writes: > Some drivers don't support SHM pixmaps, but rendercheck doesn't care and tries > to use them anyway. This causes the test to abort: Reviewed and pushed. Thanks! signature.asc Description: PGP signature

[PATCH xserver] Add unit tests for the byte swapping macros.

Peter noted a weirdness in my new bswap code, which could use some tests to justify it. Signed-off-by: Eric Anholt <e...@anholt.net> --- test/misc.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/test/misc.c b/test/misc.c index ae46cc

[PATCH xserver 2/2] glx: Use the same endian swapping as the rest of the server.

This dumps a ton of configure-time checks for system endian macros. Given that we're marking the mixed-endian fixup code as cold, getting at the system macros is a waste of code. Signed-off-by: Eric Anholt <e...@anholt.net> --- configure.ac

[PATCH xserver 1/2] configure: Stop checking for XdmcpWrap

As far back as the initial import, it seems to have been exposed, and there's no explanation why the test happened in the initial xserver import. Signed-off-by: Eric Anholt <e...@anholt.net> --- configure.ac | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/configur

[PATCH xserver 3/2] Rewrite the byte swapping macros.

The clever pointer tricks were actually not working, and we were doing the byte-by-byte moves in general. By just doing the memcpy and obvious byte swap code, we end up generating actual byte swap instructions, thanks to optimizing compilers. text data bss dec hex

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

Martin Peres writes: > On 26/01/17 14:37, Martin Peres wrote: >> Despite all the careful planing of the kernel, a link may become >> insufficient to handle the currently-set mode. At this point, the >> kernel should mark this particular configuration as being broken

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

Manasi Navare <manasi.d.nav...@intel.com> writes: > On Thu, Mar 30, 2017 at 05:37:55PM -0700, Eric Anholt wrote: >> Martin Peres <martin.pe...@linux.intel.com> writes: >> >> > On 26/01/17 14:37, Martin Peres wrote: >> >> Despite all the

Re: [PATCH xserver] glamor: Fix dashed line rendering.

Eric Anholt <e...@anholt.net> writes: > We were binding the screen pixmap as the dash and sampling its alpha, > which is usually just 1.0 (no dashing at all). > > Please cherry-pick this to active stable branches. Pushed. Thanks everyone! signature.asc Descript

Re: [PATCH xserver] glamor: Fix dashed line rendering.

Keith Packard <kei...@keithp.com> writes: > [ Unknown signature status ] > Eric Anholt <e...@anholt.net> writes: > >> We were binding the screen pixmap as the dash and sampling its alpha, >> which is usually just 1.0 (no dashing at all). >> >> Plea

Re: [PATCH xserver] glamor: avoid a crash if texture allocation failed

Olivier Fourdan writes: > Texture creation in _glamor_create_tex() can fail if a GL_OUT_OF_MEMORY > is raised, in which case the texture returned is zero. > > But the texture value is not checked in glamor_create_fbo() and glamor > will abort in glamor_pixmap_ensure_fb()

Re: [PATCH] dri2: Sync i965_pci_ids.h from Mesa.

Kenneth Graunke <kenn...@whitecape.org> writes: > Copied from Mesa with no modifications. Gives us Geminilake PCI IDs. > > Signed-off-by: Kenneth Graunke <kenn...@whitecape.org> Acked-by: Eric Anholt <e...@anholt.net> signature.asc

Re: [PATCH xserver v3] autobind GPUs to the screen

s autobinding through the servers cmdline or a > xorg.conf snippet. I think this is a sensible default. It also helped with getting X up on my VC4 + CLCD platform. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature

Re: [PATCH xserver] dix: Remove PRIVATE_DAMAGE

Adam Jackson <a...@redhat.com> writes: > None of this is actually wired up to anything, so we can also remove the > devPrivates from the DamageRec. The DamageExtRec is what would need > devPrivates for selinux labeling, in principle. Reviewed-by: Eric Anholt <e...@anholt.ne

Re: [PATCH xserver] glamor: Paint first and last pixel of lines

Keith Packard writes: > [ Unknown signature status ] > Adam Jackson writes: > >> Is there some reason you believe GL's rasterisation rules for lines >> match fb's zero-width lines? Section 14.5.1 of the 4.5 spec looks quite >> a bit looser than fb to me. > > I

[PATCH xserver] glamor: Fix dashed line rendering.

We were binding the screen pixmap as the dash and sampling its alpha, which is usually just 1.0 (no dashing at all). Please cherry-pick this to active stable branches. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_dash.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [PATCH xdriinfo] Fix xdriinfo not working with glvnd

ble. Hopefully nothing is relying on this working without an X connection being possible. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/arc

Re: [PATCH xserver 1/4] xfree86: Remove 24bpp pixmap format support (v2)

ant. All other drivers support 32bpp. Configurations that > explicitly request 24bpp in order to fit in VRAM will be broken now > though. I am so happy to see all this ugly code gone. Series is: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature __

Re: [PATCH xserver 2/2] glamor: Avoid software fallback for planemasked ZPixmap GetImage

Adam Jackson writes: > Same trick as in fb: just do a normal GetImage and deal with the > planemask on the CPU if you have to. Since the software fallback hit for > glamor is pretty brutal, this is a much more impressive win for glamor > than it was for fb: > > 11100.0

Re: [PATCH xserver 1/2] fb: Handle ZPixmap planemask in GetImage the other way around

of dword access is a win, but then the MergeRop isn't just a single & operation. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.or

Re: [PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

Martin Peres writes: > Despite all the careful planing of the kernel, a link may become > insufficient to handle the currently-set mode. At this point, the > kernel should mark this particular configuration as being broken > and potentially prune the mode before

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

Manasi Navare <manasi.d.nav...@intel.com> writes: > On Fri, Mar 31, 2017 at 01:08:41PM -0700, Eric Anholt wrote: >> Manasi Navare <manasi.d.nav...@intel.com> writes: >> >> > On Thu, Mar 30, 2017 at 05:37:55PM -0700, Eric Anholt wrote: >> >> Ma

Re: [PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

Martin Peres <martin.pe...@linux.intel.com> writes: > On 11/04/17 04:47, Eric Anholt wrote: >> Martin Peres <martin.pe...@linux.intel.com> writes: >> >>> Despite all the careful planing of the kernel, a link may become >>> insufficient to

Re: [PATCH util/modular] xorg.modules: Update for mesonic rendercheck

Jon Turney writes: > Signed-off-by: Jon Turney Tested and pushed. Thanks! signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH xserver 5/5] glamor: Use GL_RGBA format for 8-bit depth

Olivier Fourdan writes: > For some hardware, GL_RGBA is the safest option for textures to bind to > an FBO for depth 8 as GL_ALPHA might be unsupported. > > This allows using glamor-xv on hardware that don't support GL_ALPHA > textures attaching to an FBO, such as nouveau on

Re: [PATCH xserver] glamor: an FBO is not needed for Xv pixmaps

ill lead to a > crash of the Xserver. This affects Xwayland, Xephyr, modesetting driver > with glamor accel. > > But the use of an FBO is not actually needed for glamox-xv, so by > disabling FBO at pixmap creation, we can avoid the issue entirely. > > Fix suggested by Eric Anholt &l

[PATCH xserver 1/2] xorg: Change __XCONFIGFILE__ to XCONFIGFILE (and DIR) to fix scan.c.

parser/scan.c was checking for #ifdef XCONFIGFILE and XCONFIGDIR and defaulting to "xorg.conf", and "xorg.conf.d", so if you had changed __XCONFIGFILE__ to anything else, it would have got out of sync. Settle on the name without gratuitous underscores. Signed-off-by: Eric Anh

[PATCH xserver 2/2] Remove default defines of some directories.

The build defines these, so having the defaults is just a way for the build system's configuration to get out of sync with the code. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/xfree86/parser/Makefile.am | 1 - hw/xfree86/parser/scan.c | 15 --- xkb/ddx

[PATCH xserver 2/3] Add unit tests for the byte swapping macros.

Peter noted a weirdness in my new bswap code, which could use some tests to justify it. Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> --- test/misc.c | 43 +++ 1 file changed, 43 inserti

[PATCH xserver 1/3] Rewrite the byte swapping macros.

filename before: 2240807 51552 132016 2424375 24fe37 hw/xfree86/Xorg after: 2215167 51552 132016 2398735 249a0f hw/xfree86/Xorg Signed-off-by: Eric Anholt <e...@anholt.net> --- doc/Xserver-spec.xml | 2 +- glx/glxbyteorder.h | 21 include/misc.h

[PATCH xserver 3/3] Remove support for unaligned swaps.

it. text data bssdec hexfilename before: 2215167 51552 132016 2398735 249a0f hw/xfree86/Xorg after: 2214919 51552 132016 2398487 249917 hw/xfree86/Xorg Signed-off-by: Eric Anholt <e...@anholt.net> --- include/misc.h | 15 +++ test/misc.c

Re: [PATCH xserver 2/2] glamor: Always purge the FBO cache in BlockHandler

Michel Dänzer writes: > From: Michel Dänzer > > Or if the cache watermark is reached, whichever comes earlier. > > This slightly simplifies the FBO cache management, and prevents it from > potentially holding entries for a long time, while preserving

Re: [PATCH xserver] vfb: Bump default depth to 24

too" caveat. I would be pretty OK with that plan, but for this patch, at least: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archiv

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

Daniel Vetter <dan...@ffwll.ch> writes: > On Fri, Mar 31, 2017 at 05:22:09PM -0700, Eric Anholt wrote: >> Manasi Navare <manasi.d.nav...@intel.com> writes: >> >> > On Fri, Mar 31, 2017 at 01:08:41PM -0700, Eric Anholt wrote: >> >>

Re: [PATCH xserver] xephyr: Check for host XVideo support before trying to use it

handler. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] glx: Remove enter/leave server API

d-off-by: Adam Jackson <a...@redhat.com> Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 1/3] Rewrite the byte swapping macros.

Keith Packard <kei...@keithp.com> writes: > [ Unknown signature status ] > Eric Anholt <e...@anholt.net> writes: > >> It doesn't find anything. > > Sounds like we can just remove the memcpy then. So, is that a reviewed-by for #1, since #3 removes the memcpy?

Re: [PATCH xserver] glx: Allow arbitrary context attributes for direct contexts

Adam Jackson writes: > For direct contexts, most context attributes don't require any > particular awareness on the part of the server. Examples include > GLX_ARB_create_context_no_error and GLX_ARB_context_flush_control, where > all of the behavior change lives in the renderer;

[PATCH xserver 1/3] glamor: Scissor rectangle drawing to the bounds of the rects.

) to avoid overhead on desktop GL. No performance difference on i965 with x11perf -rect1 -repeat 1 -reps 1 (n=50) Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_rects.c | 26 ++ glamor/glamor_utils.h | 35 +++ 2 files chang

[PATCH xserver 3/3] glamor: Scissor Render composite operations to the bounds of the drawing.

-comppixwin10 -repeat 1 -reps 1 on i965 by 3.21191% +/- 1.79977% (n=50). Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_render.c | 25 + 1 file changed, 25 insertions(+) diff --git a/glamor/glamor_render.c b/glamor/glamor_render.c index 52f073

[PATCH xserver 2/3] glamor: Scissor CopyArea to the bounds of the drawing.

Like the previous fix to rectangles, this reduces the area drawn on tiled renderers by letting the CPU-side tile setup know what tiles might be drawn at all. Surprisingly, it improves x11perf -copypixwin1 -repeat 1 -reps 1 on i965 by 2.93185% +/- 1.5561% (n=90). Signed-off-by: Eric Anholt &l

[PATCH xserver] meson: Fix xwayland build since xwayland-keyboard-grab.

The version detect was erroring out with 1.9 protos installed, and we weren't building the new code. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/xwayland/meson.build | 3 +++ meson.build | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/xw

[PATCH xserver 6/7] sync: Convert from "CARD64" to int64_t.

The extension was using the name CARD64 to represent 64-bit values, with a #define from CARD64 to XSyncValue, a struct with a pair of 32-bit values representing a signed 64-bit value. Now that stdint.h exists, let's just use that instead. Signed-off-by: Eric Anholt <e...@anholt.net> ---

[PATCH xserver 5/7] test: Add basic SYNC tests.

I couldn't find any, and I was modifying the implementation, so I had to write some. I would like the test to end with a "make sure there weren't any stray unchecked errors", but I didn't figure out how to do that. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/vfb/meso

[PATCH xserver 1/7] test: Remove unused ddxstubs.c

Signed-off-by: Eric Anholt <e...@anholt.net> --- test/Makefile.am | 1 - test/ddxstubs.c | 97 2 files changed, 98 deletions(-) delete mode 100644 test/ddxstubs.c diff --git a/test/Makefile.am b/test/Makefile.am index 15f0b5

[PATCH xserver 2/7] meson: Move Xvfb build under an option.

Autotools also had it as an option. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/meson.build| 4 +++- meson_options.txt | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/meson.build b/hw/meson.build index c0d2db3f5c85..96c1559c348b 100644 --- a/hw/meson

<    4   5   6   7   8   9   10   11   >