[PATCH xserver 4/7] test: Return error from simple-xinit if the client crashes.

I want to be able to call client tests with simple-xinit, so assertion failures should be an error. Signed-off-by: Eric Anholt <e...@anholt.net> --- test/simple-xinit.c | 8 1 file changed, 8 insertions(+) diff --git a/test/simple-xinit.c b/test/simple-xinit.c index 89189a

[PATCH xserver 3/7] meson: Add Xvfb and Xephyr-glamor testing.

The Xvfb tests are passing and Xephyr-glamor is failing for me, but it fails identically on autotools. Signed-off-by: Eric Anholt <e...@anholt.net> --- meson.build | 1 + test/meson.build | 24 test/scripts/xephyr-

[PATCH xserver 7/7] sync: Clean up a bit of header formatting.

Signed-off-by: Eric Anholt <e...@anholt.net> --- miext/sync/misyncstr.h | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/miext/sync/misyncstr.h b/miext/sync/misyncstr.h index 084ca4c82d9d..a0a0a98146b4 100644 --- a/miext/sync/misyncstr.h +++ b/miex

Re: [PATCH xserver 5/7] test: Add basic SYNC tests.

Keith Packard <kei...@keithp.com> writes: > [ Unknown signature status ] > Eric Anholt <e...@anholt.net> writes: > >> I couldn't find any, and I was modifying the implementation, so I had >> to write some. I would like the test to end with a "make sure there

[PATCH xserver 1/3] glamor: Scissor rectangle drawing to the bounds of the rects.

) to avoid overhead on desktop GL. No performance difference on i965 with x11perf -rect1 -repeat 1 -reps 1 (n=50) v2: Clamp rectangle bounds addition. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_rects.c | 26 ++ glamor/glamor_utils.

[PATCH xserver 3/3] glamor: Scissor Render composite operations to the bounds of the drawing.

-comppixwin10 -repeat 1 -reps 1 on i965 by 3.21191% +/- 1.79977% (n=50). v2: Make the jump to the exit land after scissor disable. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_render.c | 25 + 1 file changed, 25 insertions(+) diff --git a/

[PATCH xserver 2/3] glamor: Scissor CopyArea to the bounds of the drawing.

Like the previous fix to rectangles, this reduces the area drawn on tiled renderers by letting the CPU-side tile setup know what tiles might be drawn at all. Surprisingly, it improves x11perf -copypixwin1 -repeat 1 -reps 1 on i965 by 2.93185% +/- 1.5561% (n=90). Signed-off-by: Eric Anholt &l

Re: [PATCH xserver 6/7] sync: Convert from "CARD64" to int64_t.

Keith Packard <kei...@keithp.com> writes: > [ Unknown signature status ] > Eric Anholt <e...@anholt.net> writes: > >> The extension was using the name CARD64 to represent 64-bit values, >> with a #define from CARD64 to XSyncValue, a struct with a pair of >>

Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

Daniel Stone writes: > On 28 July 2017 at 16:51, Keith Packard wrote: >> Michel Dänzer writes: >>> Declaring where? Once a pixmap is created, it only has a depth, no >>> format, so there's nothing to base on that e.g. CopyArea

Re: [PATCH xserver v2] meson: Fix epoll detection

Peter Harris writes: > The epoll code depends on epoll_create1, not epoll_create. Reviewed and pushed. Thanks! signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH xserver] meson: Fix epoll detection

Peter Harris writes: > On 2017-08-11 5:50 AM, Peter Hutterer wrote: >> On Tue, Aug 08, 2017 at 11:16:13AM -0400, Peter Harris wrote: >>> The epoll code depends on epoll_create1, not epoll_create. >>> >>> The trinary " ? 1 : false" is used because HAVE_EPOLL_CREATE1 is

Re: [PATCH xserver 2/3] glamor: Scissor CopyArea to the bounds of the drawing.

Mark Marshall <markmarshal...@gmail.com> writes: > On 1 August 2017 at 22:59, Eric Anholt <e...@anholt.net> wrote: >> Like the previous fix to rectangles, this reduces the area drawn on >> tiled renderers by letting the CPU-side tile setup know what til

Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

Daniel Stone writes: > DRI3 version 1.1 adds support for explicit format modifiers, including > multi-planar buffers. I still want proper 64-bit values, and I don't think the little XSync mess will be much of a blocker. > Signed-off-by: Daniel Stone

Re: [RFC dri3proto 01/16] Add modifier/multi-plane requests, bump to v1.1

Daniel Stone <dan...@fooishbar.org> writes: > On 17 June 2017 at 02:21, Eric Anholt <e...@anholt.net> wrote: >> With the Present extension, we started putting CARD64s on the wire. >> Let's use them here, too. > > Mm, we did have that originally, but anyone includi

Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

Michel Dänzer <mic...@daenzer.net> writes: > [ Unknown signature status ] > On 27/07/17 07:38 AM, Eric Anholt wrote: >> Michel Dänzer <mic...@daenzer.net> writes: >> >>> [ Unknown signature status ] >>> On 26/07/17 06:20 AM, Eric Anholt wrote:

Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

Michel Dänzer <mic...@daenzer.net> writes: > [ Unknown signature status ] > On 26/07/17 06:20 AM, Eric Anholt wrote: >> Daniel Stone <dani...@collabora.com> writes: >> >>> DRI3 version 1.1 adds support for explicit format modifiers, including >>>

Re: [PATCH xserver] glamor: remove no longer needed KHR_gl_texture_2D_image requirement

Emil Velikov writes: > From: Emil Velikov > > The code that needed it was introduced with commit 7cfd9cc2327 ("Add > DRI3 support to glamor") back in 2013. And was nuked a couple of years > ago with commit 51984dddfcc ("glamor: Delay making

[PATCH xserver 0/3] meson build for xserver

/ # make equivalent ninja -C build/ install # make install equivalent ninja -C build/ test# make check equivalent Eric Anholt (3): dix: Remove a redundant #define Use #ifdef instead of #if for features to make Meson easier. Add a Meson build system alongside autotools. Xext

[PATCH xserver 3/3] Add a Meson build system alongside autotools.

replace autotools. meson is faster to generate the build, faster to run the bulid, shorter to write the build files in, and less error-prone than autotools. Signed-off-by: Eric Anholt <e...@anholt.net> --- Xext/meson.build | 61 + Xi/meson

[PATCH xserver 2/3] Use #ifdef instead of #if for features to make Meson easier.

We mostly use #ifdef throughout the tree, and this lets the generated config.h files just be #define TOKEN instead of #define TOKEN 1. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_priv.h| 4 ++-- hw/xfree86/common/xf86.h| 2 +- hw/x

[PATCH xserver 1/3] dix: Remove a redundant #define

Found when the meson conversion set the symbol to defined, instead of defined to 1. Signed-off-by: Eric Anholt <e...@anholt.net> --- dix/dispatch.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dix/dispatch.c b/dix/dispatch.c index 78ac095b1fb8..a2df1e0e6dca

Re: [PATCH xserver] os: Handle SIGABRT

dded to their lists, too: - xf86Init.c's notrapSignals case - quartz.c's QuartzInitOutput() that also tries to not trap signals. With that fixed, it will be: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___

Re: [PATCH xserver 2/3] Use #ifdef instead of #if for features to make Meson easier.

Aaron Plattner writes: > We try to do exactly the opposite in our internal driver build, because > it's too easy to accidentally do something like > > #ifdef GLAMOUR_HAS_GBM > > And mistakes like that don't always cause obvious build failures like > this would. So we build

Re: [PATCH xserver 1/3] Rewrite the byte swapping macros.

Keith Packard <kei...@keithp.com> writes: > [ Unknown signature status ] > Eric Anholt <e...@anholt.net> writes: > >> #define swapll(x) do { \ >> +uint64_t temp; \ >> if (sizeof(*(x)) != 8) \ >> wr

[PATCH xserver] modesetting: Add the "DPI" connector type.

The number for it was merged to drm_mode.h in kernel 4.7, and the output_names[] array just requires that we slot in new strings in order. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 1 + 1 file changed, 1 insertion(+) diff --gi

Re: [PATCH xserver 1/3] Rewrite the byte swapping macros.

Keith Packard <kei...@keithp.com> writes: > [ Unknown signature status ] > Eric Anholt <e...@anholt.net> writes: > >> The reason to think so is that the previous code had this weird stuff to >> explicitly handle unaligned. I rip out the unaligned support in

[PATCH xserver 2/2] Remove default defines of some directories.

The build defines these, so having the defaults is just a way for the build system's configuration to get out of sync with the code. v2: Drop #ifndefs around the other two defines. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/xfree86/parser/Makefile.am | 1 - hw/xfree86/parser/

Re: [PATCH xserver 4/9] meson: Build libglx.so

Adam Jackson writes: > Signed-off-by: Adam Jackson > --- > glx/meson.build| 5 + > hw/xfree86/dixmods/meson.build | 15 +++ > meson.build| 2 ++ > 3 files changed, 22 insertions(+) > > diff --git

Re: [PATCH xserver 1/9] First round of meson fixes

well, the fact that you can then pass it as a link_with to > another static library and have it work like you expect makes up for it. I'd say that pattern was the hardest thing to adjust to with meson, for me. One whitespace comment, two optional changes, otherwise it's all: Reviewed-by: E

Re: [PATCH xserver 0/3] meson build for xserver

Adam Jackson <a...@nwnk.net> writes: > On Tue, 2017-04-25 at 16:02 -0700, Eric Anholt wrote: > >> meson build/ -Dxephyr=true  # ./configure equivalent >> mesonconf build/ -Ddmx=yes  # Turns on a feature later. > > I also found useful: > > mesonconf build

[PATCH xserver 2/2] meson: Fix glx build with DRI2 disabled.

A common meson pattern is to use empty arrays for optional sources and dependencies, since it generally iterates over trees of arrays looking for values. A value of '' will actually go looking for ''. Signed-off-by: Eric Anholt <e...@anholt.net> --- glx/meson.build | 2 +- 1 file chan

Re: [PATCH xserver] Makefile.am: add the meson files to the tarball

ly reasonable solution when using autotool's make dist. Hopefully we can stop that soon. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver 1/2] meson: use link_with for Xorg's shared modules as well as Xorg.

I converted Xorg when meson 0.40 came out, but fumbled my grep and forgot that I had instances of the .extract_all_objects() workaround in dixmods, too. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/xfree86/dixmods/meson.build | 8 1 file changed, 4 insertions(+), 4 del

Re: [PATCH xserver 5/9] meson: Build libwfb.so

Adam Jackson writes: > Signed-off-by: Adam Jackson > --- > fb/meson.build | 10 ++ > hw/xfree86/dixmods/meson.build | 12 > 2 files changed, 22 insertions(+) > > diff --git a/fb/meson.build b/fb/meson.build > index

[PATCH xserver 1/2] travis: Set prefix to /usr, so we find xkbcomp.

Signed-off-by: Eric Anholt <e...@anholt.net> --- test/scripts/build-travis-deps.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/scripts/build-travis-deps.sh b/test/scripts/build-travis-deps.sh index 213b51f6f161..b87c65d3e397 100755 --- a/test/scripts/build-

[PATCH xserver 2/2] travis: Request a new docker image with xkb-data and xkbcomp installed.

on Travis. Signed-off-by: Eric Anholt <e...@anholt.net> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 00d7a485a29f..edeed0d90972 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,7 +7,7 @@ before_install: - if [[ "$TRA

[PATCH xserver 6/7 v2] sync: Convert from "CARD64" to int64_t.

, let's just use that here, instead. v2: Fix alarm delta changes. Signed-off-by: Eric Anholt <e...@anholt.net> --- Xext/sync.c | 302 +++- Xext/syncsrv.h | 23 ++-- include/misc.h | 25 miext/sync/misync.c

[PATCH xserver 5.5/7] test: Extend sync tests to cover alarm delta and waitvalue changes.

This would be squashed into the other tests. Signed-off-by: Eric Anholt <e...@anholt.net> --- test/sync/sync.c | 71 ++-- 1 file changed, 69 insertions(+), 2 deletions(-) diff --git a/test/sync/sync.c b/test/sync/sync.c index c39774

Re: [PATCH xserver] glx: Allow arbitrary context attributes for direct contexts

Adam Jackson <a...@redhat.com> writes: > On Fri, 2017-07-28 at 09:56 -0700, Eric Anholt wrote: >> Adam Jackson <a...@redhat.com> writes: >> >> > For direct contexts, most context attributes don't require any >> > particular awarenes

Re: [PATCH xserver 1/3] glamor: Scissor rectangle drawing to the bounds of the rects.

Michel Dänzer <mic...@daenzer.net> writes: > On 02/08/17 05:59 AM, Eric Anholt wrote: >> Scissors provide a critical hint to tiled renderers as to what tiles >> need to be load/stored because they could be modified by the >> rendering. >> >> The bounds calc

Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

Keith Packard <kei...@keithp.com> writes: > [ Unknown signature status ] > Eric Anholt <e...@anholt.net> writes: > >> That's what both patch 5 of this series and pixman say the depth is for >> bgrx. I think things have only worked because nobody uses bgrx8

Re: [RFC xserver 05/16] DRI3/Glamor: Implement PixmapFromBuffers request

Daniel Stone writes: > From: Louis-Francis Ratté-Boulianne > > Signed-off-by: Louis-Francis Ratté-Boulianne > Signed-off-by: Daniel Stone > --- > +{ .format = DRM_FORMAT_ARGB2101010, .depth = 30,

Re: [PATCH v2 xserver] Makefile.am: add the meson files to the tarball

Peter Hutterer <peter.hutte...@who-t.net> writes: > While we're shipping both build systems, we'll likely have 'make dist' > generated tarballs - those tarballs should be buildable with meson to > have more exposure. > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t

[PATCH xserver] meson: Fix kdrive build.

Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/kdrive/ephyr/meson.build | 1 - hw/kdrive/src/meson.build | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/kdrive/ephyr/meson.build b/hw/kdrive/ephyr/meson.build index cf1cfd5e0c6f..615649865c1e 100644 --- a/hw/kdrive/ephyr/meson

Re: [PATCH xserver 2/2] Makefile.am: make 'make distcheck' verify the meson build

Adam Jackson <a...@redhat.com> writes: > Signed-off-by: Adam Jackson <a...@redhat.com> Cute. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org devel

Re: [PATCH xserver 5/7] meson: Make XV optional

Julien Cristau <jcris...@debian.org> writes: > On Mon, May 8, 2017 at 10:13:52 -0700, Eric Anholt wrote: > >> Optional XV seems a bit silly to me. Could we just do something >> like: >> >> build_xv = build_xorg || build_dmx || build_ephyr? > > FW

Re: [RFC PATCH xserver] xfree86: build a shared lib identical to Xorg

cy(link_with : xorgserver_lib) Elsewhere we have no ' ' before ':'. Other than that, Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.or

Re: [PATCH xserver 4/7] meson: Make driprotos and libdrm optional

Jon Turney <jon.tur...@dronecode.org.uk> writes: > On 08/05/2017 21:28, Jon Turney wrote: >> On 08/05/2017 18:12, Eric Anholt wrote: >>> Jon Turney writes: >>>> +libxserver_dri3 = '' >>> >>> Pretty sure this should be = [] >> >> Y

Re: [PATCH] Improved autoconfig drivers matching

Adam Jackson writes: > On Mon, 2017-05-01 at 18:03 +0900, Michel Dänzer wrote: >> On 28/04/17 04:11 AM, Adam Jackson wrote: >> > Fixed up (and rebased and made meson-aware) and merged: >> > >> > To ssh://git.freedesktop.org/git/xorg/xserver >> >    1549e3037..112d0d7d0  master

Re: [PATCH xf86-video-ati] Use plain glamor_egl_create_textured_screen().

Michel Dänzer <mic...@daenzer.net> writes: > On 17/05/17 03:04 AM, Eric Anholt wrote: >> Since 5064ffab631 (2014), glamor's implementation of _ext just drops the >> back_pixmap arg, which we were passing NULL (the default) to anyway. >> >> Signed-off-by: Eric An

[PATCH xserver 2/2] glamor_egl: Automatically choose a GLES2 context if desktop GL fails.

GLES2 support has been requested multiple times, and we've had this code laying around trying to implement it. The GLES2 implementation is not quite there yet (some pixel transfer failures), but it shouldn't take much fixing at this point. Signed-off-by: Eric Anholt <e...@anholt.net> ---

[PATCH xserver 1/2] glamor_egl: Remove check for KHR_surfaceless_context_*

Those extensions don't exist. There's only surfaceless_context. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_egl.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index a82c1f790997..9527caad2b37

[PATCH xf86-video-ati] Use plain glamor_egl_create_textured_screen().

Since 5064ffab631 (2014), glamor's implementation of _ext just drops the back_pixmap arg, which we were passing NULL (the default) to anyway. Signed-off-by: Eric Anholt <e...@anholt.net> --- src/radeon_glamor.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

Re: [PATCH xserver 4/4] meson: Detect strlcat/strlcpy/reallocarray in libbsd

Peter Harris <phar...@opentext.com> writes: > If we're linking with libbsd anyway, we might as well use the functions > it provides instead of compiling our replacements. > > Signed-off-by: Peter Harris <phar...@opentext.com> This series is: Reviewed-by: Eric Anholt &

Re: [PATCH xserver] xfree86: fix autoConfigDevice() regression that skipped all but the first driver match

Aaron Plattner <aplatt...@nvidia.com> writes: > On 05/09/2017 04:51 PM, Eric Anholt wrote: >> Aaron Plattner <aplatt...@nvidia.com> writes: >> >>> Commit 112d0d7d01b9 lost the initialization of the variable i in the loop >>> to add >&g

Re: [PATCH xserver] xfree86: fix autoConfigDevice() regression that skipped all but the first driver match

he while loop back to a for loop. > > Reported-by: Michel Dänzer <mic...@daenzer.net> > Reported-by: Peter Hutterer <peter.hutte...@who-t.net> > Reported-by: Eric Anholt <e...@anholt.net> > Cc: Adam Jackson <a...@redhat.com> > Fixes: 112d0d7d01b9 ("xfree86:

Re: [PATCH xserver 2/2] meson: Make VBE and VGAHW modules optional

Jon Turney <jon.tur...@dronecode.org.uk> writes: > Don't build them on platforms where they aren't meaningful. > > Note that autoconf defines WITH_VGAHW when building the VGAHW module, but > that doesn't seem to be used anywhere, so we just drop that. both patches are: Review

Re: [PATCH xserver 3/3] Add meson.build for XWin server

Jon Turney writes: > This needs a meson with PRs #1784, #1792 and #1794 > > Future work: remove conditionals which are always on, and simplify redundant > CYGDEBUG conditionals This looks pretty good! Just a few little cleanups I see. > --- > hw/meson.build

Re: [PATCH xserver 2/3] hw/xwin: Remove pretense of Xv support

Jon Turney <jon.tur...@dronecode.org.uk> writes: That's some seriously unhelpful stub code! These first two are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH xserver 1/2] misprite: Remove some dead cache variables

Adam Jackson <a...@redhat.com> writes: > Unused since Keith ported misprite to damage in '04. Nice. Both patches are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.

[PATCH xserver 02/12] glamor_egl: Unifdef GLAMOR_HAS_GBM.

We only build this code with GBM, and supporting non-GBM well would be invasive. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_egl.c | 34 -- 1 file changed, 34 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c

[PATCH xserver 10/12] glamor_egl: Drop warning about indirect GLX and GLES2.

Indirect GLX uses its own context and doesn't care what glamor is using. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_egl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index 6bc9b5383f08..a82c1f790997 100644 --- a/

[PATCH xserver 04/12] glamor_egl: Drop the has_gem flag.

We're using GBM, so we know we've got GEM. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_egl.c | 35 +++ 1 file changed, 7 insertions(+), 28 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index f68d153114df..bf23dc

[PATCH xserver 05/12] glamor_egl: Always require the gbm-based image import path.

to implement as texture import. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_egl.c | 55 ++--- 1 file changed, 27 insertions(+), 28 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index bf23dc8ed16c..21cf3c

[PATCH xserver 11/12] glamor_egl: Automatically choose a GLES2 context if desktop GL fails.

GLES2 support has been requested multiple times, and we've had this code laying around trying to implement it. The GLES2 implementation is not quite there yet (some pixel transfer failures), but it shouldn't take much fixing at this point. Signed-off-by: Eric Anholt <e...@anholt.net> ---

[PATCH xserver 03/12] modesetting: Drop code for GLAMOR && !GLAMOR_HAS_GBM.

The glamor_egl module that the GLAMOR paths are using is only built if GLAMOR_HAS_GBM is true, and there's no plan for implementing the module without GBM. Simplify modesetting's code as a result. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/xfree86/drivers/modesetting/

[PATCH xserver 01/12] glamor_egl: Print a useful identifying string on initialization.

The EGL version is not used anywhere in the glamor code, so it's not interesting. And when saying that we've started using GL acceleration, it's nice to know what GL we're actually using. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_egl.c | 17 +++-- 1 file c

[PATCH xserver 09/12] glamor_egl: Avoid flink names in glamor_egl_create_textured_pixmap().

Using flink is banned on render nodes, and they needlessly expose our screen pixmap contents to any authenticated client. This also incidentally drops the dependency on EGL_MESA_drm_image. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_egl.

[PATCH xserver 06/12] glamor_egl: Drop unnecessary check for KHR_gl_renderbuffer_image.

I couldn't find it being used anywhere in the history of the code. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_egl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index 21cf3c801242..c59aaa832f63 100644 --- a/glamor/glamor

[PATCH xserver 08/12] glamor_egl: Drop dead "cpp" field

It's been unused since the initial import. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_egl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index abfdbf2a3129..ea047b4c422e 100644 --- a/glamor/glamor_egl.c +++ b/glamor/glamor

[PATCH xserver 07/12] glamor_egl: Drop dead gl_context_depth.

This was replaced in 4afe15d8bfd575c010ed1868697a7922a37ab378, but not deleted. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_egl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index c59aaa832f63..abfdbf2a3129 100644 --- a/

[PATCH xserver 12/12] glamor_egl: Drop glamor_egl_create_textured_screen_ext().

The function hasn't been doing anything useful since keithp's resource freeing fixes in 2014. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor.h | 14 -- glamor/glamor_egl.c | 8 2 files changed, 4 insertions(+), 18 deletions(-) diff --git a/

[PATCH xserver] meson: Fix enabling of xshmfence.

I misspelled the enable flag, so DRI3 would throw BadImplementation when you tried to start any GL app. Same as in c7be7a688a78a34f61b90c0d95914e14b90b0cdc, we also convert it to #ifdef for consistency. Signed-off-by: Eric Anholt <e...@anholt.net> --- Xext/sync.c | 4 ++-- i

[PATCH xserver] dmx: Remove includes of glxtokens.h

Our top-level glx.h include already provides all of the tokens we use, and fixes redefinition warnings in the meson build. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/dmx/glxProxy/glxcmds.c | 1 - hw/dmx/glxProxy/glxcmdsswap.c | 1 - 2 files changed, 2 deletions(-) diff --gi

Re: [PATCH xserver] meson: Fix enabling of xshmfence.

Peter Hutterer <peter.hutte...@who-t.net> writes: > On Thu, Jun 01, 2017 at 04:48:07PM -0700, Eric Anholt wrote: >> I misspelled the enable flag, so DRI3 would throw BadImplementation >> when you tried to start any GL app. Same as in >> c7be7a688a78a34f61b90c0d95914e

Re: [PATCH 3/2 xserver] travis: Enable ccache.

Aaron Plattner <aplatt...@nvidia.com> writes: > On 06/01/2017 01:59 PM, Eric Anholt wrote: >> We bind-mount the cache directory into the container. Cuts build time >> from about 4 minutes to 2. >> >> Signed-off-by: Eric Anholt <e...@anholt.net> >&g

Re: [PATCH xserver 3/4] glamor: Drop glamor_set_screen_pixmap().

Keith Packard <kei...@keithp.com> writes: > [ Unknown signature status ] > Eric Anholt <e...@anholt.net> writes: > >> All that was left here was updating the FBO's size. However, the FBO >> size was always set correctly already through >> glamor_set_pix

[PATCH 3/2 xserver] travis: Enable ccache.

We bind-mount the cache directory into the container. Cuts build time from about 4 minutes to 2. Signed-off-by: Eric Anholt <e...@anholt.net> --- .travis.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index e10cfe1e134f..0a136b

Re: [PATCH xserver 3/4] glamor: Drop glamor_set_screen_pixmap().

Keith Packard <kei...@keithp.com> writes: > [ Unknown signature status ] > Eric Anholt <e...@anholt.net> writes: > >> All that was left here was updating the FBO's size. However, the FBO >> size was always set correctly already through >> glamor_set_pix

Re: [PATCH xserver] glamor: Store the actual EGL/GLX context pointer in lastGLContext

Michel Dänzer writes: > From: Michel Dänzer > > Fixes subtle breakage which could sometimes trigger after a server reset > with multiple screens using glamor: > > Screen A enters glamor_close_screen last and calls various cleanup > functions, which at

Re: [PATCH xserver 3/3] Add meson.build for XWin server

Jon Turney <jon.tur...@dronecode.org.uk> writes: > On 23/05/2017 00:17, Eric Anholt wrote: >> Jon Turney <jon.tur...@dronecode.org.uk> writes: >> >>> This needs a meson with PRs #1784, #1792 and #1794 >>> >>> Future work: remove co

[PATCH xserver 2/4] glamor: Stop tracking the screen_fbo.

This means we no longer get "s" for on-screen drawing in glamor_debug, and there's only "m" (CPU memory) or "f" (Any GPU memory, aka FBOs). That seems fine to me. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor.c | 1 - glamor/glamor_core.c

[PATCH xserver 3/4] glamor: Drop glamor_set_screen_pixmap().

All that was left here was updating the FBO's size. However, the FBO size was always set correctly already through glamor_set_pixmap_texture() from whoever had attached a new BO to the pixmap. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor.c

[PATCH xserver 4/4] glamor: Remove the "delayed fallback" code.

The usage of this died with the old core rendering code. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_debug.h | 29 - glamor/glamor_priv.h | 2 -- 2 files changed, 31 deletions(-) diff --git a/glamor/glamor_debug.h b/glamor/glamor_debug.h

[PATCH xserver 1/4] glamor_egl: Stop saving the EGL major/minor version.

We don't use them for anything. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor_egl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index 354c30f68ea5..193a04409ee8 100644 --- a/glamor/glamor_egl.c +++ b/

Re: [PATCH xserver] glamor: Store the actual EGL/GLX context pointer in lastGLContext

Michel Dänzer <mic...@daenzer.net> writes: > [ Unknown signature status ] > On 01/06/17 03:00 AM, Eric Anholt wrote: >> Michel Dänzer <mic...@daenzer.net> writes: >> >>> From: Michel Dänzer <michel.daen...@amd.com> >>> >>> Fixes sub

[PATCH xserver 2/2] travis: Add a build script for Travis CI.

This currently does a meson build using a docker image I've prepared. The Dockerfile source is at: https://github.com/anholt/xserver-travis Docker proved to be necessary to cut the build time per Travis push. If some day we end up using meson in more of the X stack, we may be able to move

[PATCH xserver 1/2] meson: Fix test for whether we've built glamor-EGL.

This matches the test we use for going into the glamor_egl subdir in ../../meson.build. --- hw/xfree86/drivers/modesetting/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/drivers/modesetting/meson.build b/hw/xfree86/drivers/modesetting/meson.build index

Re: [RFC dri3proto 01/16] Add modifier/multi-plane requests, bump to v1.1

Daniel Stone writes: > DRI3 version 1.1 adds support for explicit format modifiers, including > multi-planar buffers. > > Signed-off-by: Daniel Stone > --- > dri3proto.h | 142 > +++- > 1

[PATCH xserver] meson: Use link_whole() not link_with(), for the Xorg dixmods.

I clearly hadn't run ninja test, since fb no longer had any of the fb symbols in it. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/xfree86/dixmods/meson.build | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/xfree86/dixmods/meson.build b/hw/xfree86/d

Re: [PATCH xserver resend] xf86: dri2: Use va_gl as vdpau_driver for Intel i965 GPUs

Hans de Goede writes: > The modesetting driver (which now often is used with Intel GPUs), > relies on dri2_probe_driver_name() to get the dri and vdpau driver > names, before this commit it would always assign the same name to > the 2 names. But the vdpau driver for i965

Re: [PATCH xserver 5/7] meson: Make XV optional

Jon Turney writes: > Signed-off-by: Jon Turney > --- > meson.build | 11 ++- > meson_options.txt | 3 +++ > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index

Re: [PATCH xserver 7/7] meson: An empty array is not a dependency object

e) > if gbm_dep.found() We've certainly got a cleanup of gbm_dep to do, but I'm fine with this for now. Meson folks agreed that this was the best workaround, though "[].found() == false" may be available in the future. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc

Re: [PATCH xserver 6/7] meson: Refine build_dbus

he contents of > dbus-core.h are turned off. I got confused by dbus/hal/systemd requirements several times. Thanks for fixing it up. Acked-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.

Re: [PATCH app/xdpyinfo] Use XRANDR 1.2 extension for reporting dimensions and resolution per output

Pali Rohár writes: > [ Unknown signature status ] > On Saturday 06 May 2017 13:28:17 Julien Cristau wrote: >> On Fri, May 5, 2017 at 10:08:14 +0200, Pali Rohár wrote: >> > PING. >> > >> > I would like to know if there is some problem with this and >> > something needs to

Re: [PATCH xserver 4/7] meson: Make driprotos and libdrm optional

y stated as: build_modesetting = libdrm_dep.version().version_compare('>= 2.4.46') It's a bit of an odd choice (modesetting driver if you have dri1/2/3 enabled, or if libdrm happened to be found anyway), but that should be true so often I don't think it's worth worrying about. > # XXX: A

Re: [PATCH libpciaccess] linux: support 32 bit PCI domains (v3)

compatibility, though it still only supports one > domain and will never be better. > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=101744 > Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Desc

Re: [PATCH xserver 1/2] glx: Fix glXQueryContext for GLX_FBCONFIG_ID and GLX_RENDER_TYPE

rd -- QueryContext and QueryContextInfoEXT are both returning the same values, and the existing values we were giving were only for QCIE. This seems to be OK because the proto is the same for both, and the glX call must be picking the attributes it cares about out of the reply. So, with the glx

Re: [PATCH xserver 2/2] glx: Implement GLX_EXT_no_config_context

Adam Jackson writes: > Only enabled for the DRI backends at the moment. In principle WGL/CGL > could support this - it's sort of implied by GL 3.0 support - but in > practice I don't know that it would actually work. > > This is currently a draft extension, under review at: > >

Re: [PATCH xserver 1/2] Build: Use dri3proto/libdrm CFLAGS

Daniel Stone <dani...@collabora.com> writes: > Make sure we get the CFLAGS required for building DRI3 into the > command line. > > Signed-off-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Eric Anholt <e...@anholt.net> signature.

<    5   6   7   8   9   10   11   >