[PATCH synaptic 2/2] config: don't autoprobe when device was set

. Signed-off-by: Giuseppe Bilotta giuseppe.bilo...@gmail.com --- src/synaptics.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/synaptics.c b/src/synaptics.c index 89398f5..e0b93a0 100644 --- a/src/synaptics.c +++ b/src/synaptics.c @@ -275,7 +275,7 @@ SetDeviceAndProtocol

[PATCH xrandr] xrandr: document that we accept '--dpi output'

Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- man/xrandr.man | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/man/xrandr.man b/man/xrandr.man index 73d337c..5742286 100644 --- a/man/xrandr.man +++ b/man/xrandr.man @@ -41,7 +41,7 @@

[PATCH xrandr] xrandr: suppress misleading indentation warning

the conditional. This is not the case, and recent GCC warns about this. Move the assignment to after we print the value we want to print, which (1) doesn't mislead about the indentation, and (2) makes logical sense as the _next_ entry is what won't be the first. Signed-off-by: Giuseppe Bilotta

Re: [PATCH xserver] tests: link against libos too

On Sat, Jan 14, 2017 at 12:27 PM, Mihail Konev wrote: > Thanks and sorry for late response. > With dtrace being present, this breaks the build. > Conditioned patch attached. Just tried with my patch reversed and yours applied, works for me, thanks. -- Giuseppe "Oblomov" Bilotta

[PATCH xserver] tests: link against libos too

Without it, compiling tests fails due to the xsha1 functions defined in libos and referenced from HashGlyph in render. Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- test/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/Makefile.am

Re: [PATCH xrandr v2 1/2] xrandr: allow a single value for --scale

Hello, On Fri, Jul 14, 2017 at 2:46 AM, Aaron Plattner wrote: >> -.IP "\-\-scale \fIx\fPx\fIy\fP" >> -Changes the dimensions of the output picture. Values superior to 1 will >> lead to >> +.IP "\-\-scale \fIx\fP[x\fIy\fP]" >> +Changes the dimensions of the output picture.

[PATCH xrandr v3 2/3] xrandr: stricter --scale argument parsing

We used to accept something like --scale 2x3junk as a valid input (scaling x by 2 and y by 3), even though this isn't really a valid scaling factor. Fix by making sure there is nothing after the parsed number(s). Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- xrandr

[PATCH xrandr v3 0/3] xrandr: improve --scale option parsing

in the --scale paragraph of the man page. v2: rebased on current head. v3: fix code indentation, add grammar fix patch Giuseppe Bilotta (3): xrandr: allow a single value for --scale xrandr: stricter --scale argument parsing xrandr.man: grammar tuning man/xrandr.man | 14 -- xrandr.c

[PATCH xrandr v3 1/3] xrandr: allow a single value for --scale

This allows using e.g. --scale 0.5 as a shorthand for --scale 0.5x0.5 Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- man/xrandr.man | 7 --- xrandr.c | 8 ++-- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/man/xrandr.man b/man/xrandr.man

[PATCH xrandr v3 3/3] xrandr.man: grammar tuning

Rephrase the --scale option paragraph to improve English and be more consistent in choice of plurals and tense. Also ensure that each sentence starts on a new line in the roff source. Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- man/xrandr.man | 11 ++- 1 file c

[PATCH xrandr 0/2] xrandr: improve --scale option parsing

A couple of trivial patches. The first one allows the specification of a single scaling value (--scale 2 for --scale 2x2), the second makes parsing stricter by refusing the value if there is junk after an assumingly valid scaling factor (2x3a or 4j). Giuseppe Bilotta (2): xrandr: allow a single

[PATCH xrandr 2/2] xrandr: stricter --scale argument parsing

We used to accept something like --scale 2x3junk as a valid input (scaling x by 2 and y by 3), even though this isn't really a valid scaling factor. Fix by making sure there is nothing after the parsed number(s). Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- xrandr

[PATCH xrandr 1/2] xrandr: allow a single value for --scale

This allows using e.g. --scale 0.5 as a shorthand for --scale 0.5x0.5 Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- man/xrandr.man | 7 --- xrandr.c | 8 ++-- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/man/xrandr.man b/man/xrandr.man

[PATCH xrandr v2 2/2] xrandr: stricter --scale argument parsing

We used to accept something like --scale 2x3junk as a valid input (scaling x by 2 and y by 3), even though this isn't really a valid scaling factor. Fix by making sure there is nothing after the parsed number(s). Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- xrandr

[PATCH xrandr v2 1/2] xrandr: allow a single value for --scale

This allows using e.g. --scale 0.5 as a shorthand for --scale 0.5x0.5 Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- man/xrandr.man | 7 --- xrandr.c | 8 ++-- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/man/xrandr.man b/man/xrandr.man

[PATCH xrandr v2 0/2] xrandr: improve --scale option parsing

A couple of trivial patches. The first one allows the specification of a single scaling value (--scale 2 for --scale 2x2), the second makes parsing stricter by refusing the value if there is junk after an assumingly valid scaling factor (2x3a or 4j). v2: rebased on current head. Giuseppe Bilotta

Re: [PATCH v2 app/xrandr] Document that --dpi and --fbmm options set DPI of whole X screen

On Wed, Nov 1, 2017 at 11:25 AM, Pali Rohár wrote: > Hello, can somebody process this my patch? > > There are no objections for a long time and Walter already reviewed it. > > On Monday 07 August 2017 18:45:22 walter harms wrote: >> Sorry, i had the idea you already got my

Re: [PATCH v2 app/xrandr] Document that --dpi and --fbmm options set DPI of whole X screen

On Wed, Nov 1, 2017 at 9:14 PM, Pali Rohár <pali.ro...@gmail.com> wrote: > On Wednesday 01 November 2017 21:04:17 Giuseppe Bilotta wrote: >> >> Personally, I disagree with the statement that the core DPI value has >> no useful meaning in multi-monitor configurati

Re: [PATCH v2 app/xrandr] Document that --dpi and --fbmm options set DPI of whole X screen

On Wed, Nov 1, 2017 at 9:35 PM, Adam Jackson <a...@nwnk.net> wrote: > On Wed, 2017-11-01 at 21:04 +0100, Giuseppe Bilotta wrote: > >> (Heck, I would even argue that the core DPI should be set to the >> primary monitor DPI by default, regardless of whether the system has

Re: [PATCH] modesetting: fail PreInit() if the device has zero connectors

On Fri, Nov 3, 2017 at 10:09 AM, Hans de Goede wrote: > Weird, on my XPS15 9550 where the nvidia GPU does not have/drives any > outputs > I do get 2 devices in xrandr --listproviders as expected. You may want to > start > with figuring out why the normal setup where you load

Re: [PATCH v2 app/xrandr] Document that --dpi and --fbmm options set DPI of whole X screen

On Thu, Nov 2, 2017 at 6:20 PM, Pali Rohár wrote: > > But back to my documentation update patch. It is needed to rework it? > And if yes, how, In light of my opinion on the relevant of the core DPI value, here's my take on it, chunk by chunk: > -Sets the reported values

[PATCH xserver] dix/window: fix typos

--- dix/window.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dix/window.c b/dix/window.c index ead4dc27f..8789a5ece 100644 --- a/dix/window.c +++ b/dix/window.c @@ -456,9 +456,9 @@ TraverseTree(WindowPtr pWin, VisitWindowProcPtr func, void *data) /* *

Re: [PATCH xserver] xkb: initialize tsyms

On Mon, Nov 6, 2017 at 4:41 PM, Eric Engestrom <eric.engest...@imgtec.com> wrote: > On Friday, 2017-11-03 21:38:51 +0100, Giuseppe Bilotta wrote: >> This fixes some “Conditional jump depends on uninitialized value(s)” >> errors spotted by valgrind. >> >>

[PATCH xserver 0/3] randr valgrind cleanups

fix the leaks related to dynamic creation and destruction of crtcs and outputs (hopefull correctly, this time ;-)) Giuseppe Bilotta (3): randr: rrGetScreenResources: initialize memory randr: always realloc crtcs and outputs randr: free crtc->outputs on destroy randr/rrcrtc.c |

[PATCH xserver 3/3] randr: free crtc->outputs on destroy

Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- randr/rrcrtc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/randr/rrcrtc.c b/randr/rrcrtc.c index c904fa035..39af679b2 100644 --- a/randr/rrcrtc.c +++ b/randr/rrcrtc.c @@ -878,6 +878,7 @@ RRCrtcDestroyResource(void

[PATCH xserver 2/3] randr: always realloc crtcs and outputs

realloc() unconditionally, and ensure that the fields are properly initialized. Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- randr/rrcrtc.c | 9 +++-- randr/rroutput.c | 9 +++-- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/randr/rrcrtc.c b

[PATCH xserver 1/3] randr: rrGetScreenResources: initialize memory

Similarly to bb766ef11227bd8c71ac65845d1930edd0eda40d, ensure that the extra padding is set to 0. Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- randr/rrscreen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/randr/rrscreen.c b/randr/rrscreen.c

[PATCH xserver] xkb: initialize tsyms

This fixes some “Conditional jump depends on uninitialized value(s)” errors spotted by valgrind. Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- xkb/xkbUtils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xkb/xkbUtils.c b/xkb/xkbUtils.c index 25b

Re: [PATCH xserver 4/5] randr: properly cleanup on crtc and output destroy

On Mon, Nov 6, 2017 at 10:54 PM, Adam Jackson <a...@nwnk.net> wrote: > On Sat, 2017-11-04 at 23:06 +0100, Giuseppe Bilotta wrote: >> Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> >> --- >> randr/rrcrtc.c | 6 ++ >> randr/rroutput.c | 5 +

[PATCH xserver] xkb: small clarification

--- xkb/xkbUtils.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) On Tue, Nov 7, 2017 at 10:55 AM, Eric Engestrom wrote: > I think this patch is good, because it explicitly shows the NoSymbol > value that is tested later on. The implicit 0s are fine, but I think

[PATCH xserver 3/5] randr: ProcRRGetOutputInfo: initialize memory

the padding, but I'm not sure it's more convenient.) Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- randr/rroutput.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/randr/rroutput.c b/randr/rroutput.c index a8efec409..647f19a52 100644 --- a/randr/rroutput.c

[PATCH xserver 4/5] randr: properly cleanup on crtc and output destroy

Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- randr/rrcrtc.c | 6 ++ randr/rroutput.c | 5 + 2 files changed, 11 insertions(+) diff --git a/randr/rrcrtc.c b/randr/rrcrtc.c index 2eb9fbdc8..90922484f 100644 --- a/randr/rrcrtc.c +++ b/randr/rrcrtc.c @@ -873,6 +

[PATCH xserver 1/5] xkb: initialize tsyms

This fixes some “Conditional jump depends on uninitialized value(s)” errors spotted by valgrind. Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- xkb/xkbUtils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xkb/xkbUtils.c b/xkb/xkbUtils.c index 25b

[PATCH xserver 5/5] glx: free fbconfigs on destroy

Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- glx/glxscreens.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/glx/glxscreens.c b/glx/glxscreens.c index 99bf6dd27..73444152a 100644 --- a/glx/glxscreens.c +++ b/glx/glxscreens.c @@ -423,8 +423,15 @@ __glXScre

[PATCH xserver 0/5] misc valgrind cleanups

to avoid overcomplicating the code. (Most of the remaining leaks are Mesa's responsbility, with the glsl_types not being properly freed, and affect Xephyr only via swrast_dri, so they are not part of this series. Giuseppe Bilotta (5): xkb: initialize tsyms Xephyr: free driverPrivates on Fini

[PATCH xserver 2/5] Xephyr: free driverPrivates on Fini

--- hw/kdrive/ephyr/ephyr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/kdrive/ephyr/ephyr.c b/hw/kdrive/ephyr/ephyr.c index d064f5154..acf389c1d 100644 --- a/hw/kdrive/ephyr/ephyr.c +++ b/hw/kdrive/ephyr/ephyr.c @@ -1303,6 +1303,7 @@ MouseDisable(KdPointerInfo * pi) static void

Re: [PATCH xserver] present: Only send PresentCompleteNotify events to the presenting client

On Fri, Oct 20, 2017 at 6:30 PM, Michel Dänzer wrote: > From: Michel Dänzer > > We were sending the events to all clients listening for them on the > window. But clients can get confused by events from another client, and > I can't imagine any case

Re: [PATCH] Add NonDesktop output property and behaviors.

On Fri, Oct 20, 2017 at 6:08 PM, Keith Packard <kei...@keithp.com> wrote: > Giuseppe Bilotta <giuseppe.bilo...@gmail.com> writes: > >> (I actually wish I had some free time to put my coding hands where my >> mouth is 8-P). > > I'd say it's more about waiting unt

[PATCH xserver] configure.ac: unconditionally enable kdrive

net> Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- configure.ac | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ec98f52c0..caf10dc98 100644 --- a/configure.ac +++ b/configure.ac @@ -594,7 +594,6 @@ AC_ARG_ENABLE(standal

Re: [PATCH] Add NonDesktop output property and behaviors.

On Fri, Oct 20, 2017 at 3:25 AM, Keith Packard <kei...@keithp.com> wrote: > Giuseppe Bilotta <giuseppe.bilo...@gmail.com> writes: > >> FWIW, some Razer laptop models have a touchpad that doubles as a >> secondary display. Not sure if it's worth mentioning (it does

Re: [PATCH] Add NonDesktop output property and behaviors.

mething like that, to avoid silly crashes in some clients); * if a non-desktop device is attached (e.g. HMD), the corresponding output is redirected to the first available (i.e. no-output) X Screen. Is this too crazy an idea? Best regards, Giuseppe Bilotta _

Re: [PATCH] Add NonDesktop output property and behaviors.

On Fri, Oct 20, 2017 at 8:35 PM, Aaron Plattner wrote: > > From Giuseppe: >> >> For the aforementioned touchpad/display, for example, one could envision >> a “detached” mode where it acts like, say, the Apple Touch Bar, and an >> “attached” mode where it's used like a

Some considerations about RANDR Monitors

Hello, I noticed is that for 'tracking' Monitors, the pixel information follows the rotation, but the physical size does not. I'm assuming this is intentional, as it fits what is mentioned in randrproto (which was however written before the Monitor type was introduced). > To avoid multiplicative

[PATCH xserver] rrmonitor: allocate using the correct type

Monitor outputs are of type RROutput, not RRCrtc. (Which are both XID, so this makes no difference in practice, other than being technically correct.) Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- randr/rrmonitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH xrandr v4 2/5] xrandr: stricter --scale argument parsing

On Mon, Feb 5, 2018 at 10:44 AM, walter harms <wha...@bfs.de> wrote: > > Am 05.02.2018 02:47, schrieb Giuseppe Bilotta: >> { >> double sx, sy; >> + char junk; >> if (!config_output) argerr ("%s must be used after --outp

Re: Making Composite better for interactive apps

On Sat, Feb 3, 2018 at 9:23 PM, Keith Packard wrote: > (To be clear, what I'm proposing won't break anything that already > works -- the Auto List is entirely driven by the compositor, so if you > don't use it, you don't get this functionality.) > > But, yes, Compton wouldn't

Re: Making Composite better for interactive apps

On Sun, Feb 4, 2018 at 11:19 PM, Keith Packard <kei...@keithp.com> wrote: > Giuseppe Bilotta <giuseppe.bilo...@gmail.com> writes: > >> Ah, good point. So Compton wouldn't break anyway, at worst it couldn't >> use the feature reliably. > > Having any rea

Re: Making Composite better for interactive apps

On Mon, Feb 5, 2018 at 12:47 AM, Keith Packard wrote: > It's interesting to note > that we could have done the same thing for all of the redirected window > management requests in the core protocol, simplifying applications > tremendously... I'm not sure I follow. >> The

Re: Making Composite better for interactive apps

On Mon, Feb 5, 2018 at 2:17 AM, Keith Packard <kei...@keithp.com> wrote: > Giuseppe Bilotta <giuseppe.bilo...@gmail.com> writes: > >> I'm not sure I follow. > > Imagine if MapWindow blocked until the window was actually mapped by the > Window Manager. I'm not

[PATCH xrandr v4 5/5] xrandr.man: document the monitor manipulation options

--- man/xrandr.man | 23 +++ 1 file changed, 23 insertions(+) diff --git a/man/xrandr.man b/man/xrandr.man index 9f976ad..aa82724 100644 --- a/man/xrandr.man +++ b/man/xrandr.man @@ -72,6 +72,10 @@ xrandr \- primitive command line interface to RandR extension

[PATCH xrandr v4 4/5] xrandr: allow single value for --gamma

Similarly to --scale, accept a single value to be used for all three components, and refuse values with extra junk after the acceptable values. --- man/xrandr.man | 9 ++--- xrandr.c | 15 +++ 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/man/xrandr.man

[PATCH xrandr v4 3/5] xrandr.man: grammar tuning

Rephrase the --scale option paragraph to improve English and be more consistent in choice of plurals and tense. Also ensure that each sentence starts on a new line in the roff source. Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- man/xrandr.man | 11 ++- 1 file c

[PATCH xrandr v4 0/5] xrandr: improve option parsing and documentation

introduced, the largest of which is the documentation of the xrandr monitor options. v2: rebased on current head. v3: fix code indentation, add grammar fix patch v4: single value accepted for --gamma too, monitor options documented. Giuseppe Bilotta (5): xrandr: allow a single value for --scale

[PATCH xrandr v4 1/5] xrandr: allow a single value for --scale

This allows using e.g. --scale 0.5 as a shorthand for --scale 0.5x0.5 Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- man/xrandr.man | 7 --- xrandr.c | 8 ++-- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/man/xrandr.man b/man/xrandr.man

[PATCH xrandr v4 2/5] xrandr: stricter --scale argument parsing

We used to accept something like --scale 2x3junk as a valid input (scaling x by 2 and y by 3), even though this isn't really a valid scaling factor. Fix by making sure there is nothing after the parsed number(s). Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- xrandr

Re: Making Composite better for interactive apps

Hello, On Sat, Feb 3, 2018 at 5:48 AM, Keith Packard wrote: > Hrm. This makes me wonder what to do if the auto-listed window is a > direct child of the root and its geometry changes. In that case, the > Compositing Manager wouldn't have enough control over the display as the >

Re: Making Composite better for interactive apps

On Mon, Feb 5, 2018 at 4:27 AM, Keith Packard <kei...@keithp.com> wrote: > Giuseppe Bilotta <giuseppe.bilo...@gmail.com> writes: > >> I'm not sure if this could be implemented without making the server >> more susceptible to DOS attacks, though (basically the same

Re: Making Composite better for interactive apps

On Mon, Feb 5, 2018 at 9:24 PM, Keith Packard wrote: > What we want is for the compositing manager to get a clean snapshot of > the system and to then be able to present that on the screen each > frame. That means disallowing *all* changes for the duration of the > construction

[PATCH xorgproto] randr: MONITORINFO has outputs, not crtcs

--- randrproto.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/randrproto.txt b/randrproto.txt index c06bc90..f57301d 100644 --- a/randrproto.txt +++ b/randrproto.txt @@ -2363,14 +2363,14 @@ A.1.1 Common Types added in version 1.5 of the protocol 4 ATOM

Re: [PATCH xrandr v4 2/5] xrandr: stricter --scale argument parsing

On Tue, Feb 6, 2018 at 1:01 AM, Keith Packard <kei...@keithp.com> wrote: > Giuseppe Bilotta <giuseppe.bilo...@gmail.com> writes: > >> I'm not a big fan of strtod because with it it's impossible to know if >> a conversion actually happened. xrandr --scale ' '

Re: Making Composite better for interactive apps

On Tue, Feb 6, 2018 at 11:03 PM, Keith Packard wrote: >> Why would there be a need for the server to send an event to the CM? > > My thinking is that the X server would lock the window system from > changes and then deliver an event to the Compositing Manager. Otherwise, > the

Re: [PATCH xorgproto] randr: MONITORINFO has outputs, not crtcs

ource). I would have actually been more verbose in the commit message if I had known why it was wrong in the first place (I assume it's some leftover from during the development of the protocol itself). Shall I respin mentioning this in the commit message? > Am 06.02.2018 02:03, schrieb Gius

Re: Making Composite better for interactive apps

On Tue, Feb 6, 2018 at 3:39 AM, Keith Packard <kei...@keithp.com> wrote: > Giuseppe Bilotta <giuseppe.bilo...@gmail.com> writes: >> I'm coming at this from the assumption that a Compositing Manager >> would try to pump out frames as frequently as possible, in order to

Re: [PATCH xrandr v4 2/5] xrandr: stricter --scale argument parsing

On Tue, Feb 6, 2018 at 8:03 PM, Keith Packard <kei...@keithp.com> wrote: > Giuseppe Bilotta <giuseppe.bilo...@gmail.com> writes: >> I'll add the positive check for both scale and gamma and respin the patch. > > Thanks. Actually, it just occurred to me that a ne

Re: [PATCH xrandr v4 2/5] xrandr: stricter --scale argument parsing

On Tue, Feb 6, 2018 at 3:43 AM, Keith Packard wrote: > No, strtod requires a non-empty sequence of digits. Woah. My whole life is a lie … (I guess it's my fault for never bothering to actually verify this.) > strtod is actually not a terrible function (surprising for libc, I

Re: Window scaling (aka owner sizes)

Hello Keith, On Mon, Aug 27, 2018 at 8:25 AM Keith Packard wrote: > I'm doing a bit of work to help support applications that want to run at > a small fixed size. Wonderful endeavor. > The basic plan is to make the size-as-seen-by-the-owner different from > the size seen by the rest of the

Re: Window scaling (aka owner sizes)

On Mon, Aug 27, 2018 at 7:38 PM Keith Packard wrote: > Giuseppe Bilotta writes: > > I guess the only way in which this can fail is if a client tries to > > draw its own decorations (or something) “outside” of their own window, > > assuming that origin+width or origin+height

Re: Window scaling (aka owner sizes)

On Fri, Aug 31, 2018 at 6:53 AM Keith Packard wrote: > The root window size shouldn't be all that interesting to applications; > they really need to know the monitor sizes and positions, and that > information is available via RandR and Xinerama. So, I'm not all that > concerned about root window

Re: [PATCH v3 app/xrandr] Document that --dpi and --fbmm options set DPI of whole X screen

ed-off-by: Pali Rohár <pali.ro...@gmail.com> FWIW, Reviewed-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> > --- > man/xrandr.man | 19 +++ > 1 file changed, 15 insertions(+), 4 deletions(-) > > diff --git a/man/xrandr.man b/man/xrandr.man > index aa8

Re: [PATCH app/xdpyinfo v2] Use XRANDR 1.2 extension for reporting dimensions and resolution per output

On Sun, Apr 8, 2018 at 4:33 PM, Pali Rohár wrote: > The main problem is that majority of users use xdpyinfo for getting DPI > of their monitors. And in the case of multiple monitors, they'll have to get used to using `xdpyinfo -ext RANDR`, provided support for that

Re: [PATCH app/xdpyinfo v2] Use XRANDR 1.2 extension for reporting dimensions and resolution per output

Hello, I took the liberty of moving the last paragraph of your email to the top because the reply I'm giving to that part covers both. On Wed, Apr 4, 2018 at 11:26 AM, Pali Rohár wrote: >> >> -printf (" dimensions:%dx%d pixels (%dx%d millimeters)\n", >> >> -

Re: [PATCH app/xdpyinfo v2] Use XRANDR 1.2 extension for reporting dimensions and resolution per output

On Wed, Apr 4, 2018 at 5:12 PM, Adam Jackson wrote: > On Tue, 2018-04-03 at 22:15 +0200, Pali Rohár wrote: >> Gently reminder of this patch. Can you comment/review it? > > Nack. The whole point of (that part of) xdpyinfo is to show you what > was sent in the initial connection

Re: [PATCH xserver] os: Call FlushClient() before sending FD-passing messages

On Tue, Apr 10, 2018 at 5:14 AM, Keith Packard wrote: >> libxcb stores received file descriptors in the buffer of size 16 >> (XCB_MAX_PASS_FD). >> Whether it's possible that the X server will send more than 16 fds in a >> single reply >> and overflow the libxcb's buffer? > > It

Re: [PATCH app/xdpyinfo v2] Use XRANDR 1.2 extension for reporting dimensions and resolution per output

On Sun, Apr 8, 2018 at 8:25 PM, Pali Rohár <pali.ro...@gmail.com> wrote: > On Sunday 08 April 2018 19:22:28 Giuseppe Bilotta wrote: >> The values reported by xdpyinfo aren't bogus, they are what the core >> protocol is providing. > > For users as human readable output

Re: [PATCH app/xdpyinfo v3] Use XRANDR 1.2 extension for reporting dimensions and resolution per output

On Wed, Apr 18, 2018 at 3:33 PM, Pali Rohár wrote: > On Thursday 12 April 2018 16:34:15 Adam Jackson wrote: >> This should print the RANDR data in a separate stanza after the main >> output, like the other extensions do. Again: the purpose of the core of >> xdpyinfo is to

Re: [PATCH v3 app/xrandr] Document that --dpi and --fbmm options set DPI of whole X screen

Hello, On Fri, Mar 23, 2018 at 4:53 PM, Pali Rohár <pali.ro...@gmail.com> wrote: > On Monday 12 March 2018 09:19:57 Giuseppe Bilotta wrote: >> On Sat, Mar 10, 2018 at 4:23 PM, Pali Rohár <pali.ro...@gmail.com> wrote: >> > Explicitly document and make it clear th

Re: [PATCH app/xdpyinfo v2] Use XRANDR 1.2 extension for reporting dimensions and resolution per output

Hello Pali, I like the idea of this patch, wasn't aware of its existence, thanks for pinging me about it. A few comments below: On Tue, Apr 3, 2018 at 10:15 PM, Pali Rohár wrote: >> @@ -455,27 +462,75 @@ print_screen_info(Display *dpy, int scr) >> double xres, yres;

[PATCH xrandr v5 6/6] xrandr: gamma and scaling factors must be positive

Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- xrandr.c | 5 + 1 file changed, 5 insertions(+) diff --git a/xrandr.c b/xrandr.c index f6c425f..7f1e867 100644 --- a/xrandr.c +++ b/xrandr.c @@ -2979,6 +2979,9 @@ main (int argc, char **argv) arger

[PATCH xrandr v5 2/6] xrandr: stricter --scale argument parsing

We used to accept something like --scale 2x3junk as a valid input (scaling x by 2 and y by 3), even though this isn't really a valid scaling factor. Fix by making sure there is nothing after the parsed number(s). Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- xrandr

[PATCH xrandr v5 3/6] xrandr.man: grammar tuning

Rephrase the --scale option paragraph to improve English and be more consistent in choice of plurals and tense. Also ensure that each sentence starts on a new line in the roff source. Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- man/xrandr.man | 11 ++- 1 file c

[PATCH xrandr v5 4/6] xrandr: allow single value for --gamma

Similarly to --scale, accept a single value to be used for all three components, and refuse values with extra junk after the acceptable values. Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- man/xrandr.man | 9 ++--- xrandr.c | 15 +++ 2 files chang

[PATCH xrandr v5 0/6] xrandr: improve option parsing and documentation

for positive values The patchset is also available from: git://git.oblomov.eu/xorg/xrandr parse-doc-fixes up to c9755465412cbcf533d3c512397773949a26e55f. Giuseppe Bilotta (6): xrandr: allow a single value for --scale xrandr: stricter --scale argument parsing xrandr.man: grammar tuning

[PATCH xrandr v5 5/6] xrandr.man: document the monitor manipulation options

Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- man/xrandr.man | 23 +++ 1 file changed, 23 insertions(+) diff --git a/man/xrandr.man b/man/xrandr.man index 9f976ad..aa82724 100644 --- a/man/xrandr.man +++ b/man/xrandr.man @@ -72,6 +72,10 @@

[PATCH xrandr v5 1/6] xrandr: allow a single value for --scale

This allows using e.g. --scale 0.5 as a shorthand for --scale 0.5x0.5 Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- man/xrandr.man | 7 --- xrandr.c | 8 ++-- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/man/xrandr.man b/man/xrandr.man

[PATCH xorgproto] Spelling and grammar fixes

Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> --- compositeproto.txt | 6 +++--- dri2proto.txt | 10 +- presentproto.txt | 2 +- randrproto.txt | 8 renderproto.txt| 2 +- xv-protocol-v2.txt | 2 +- 6 files changed, 15 insertions(

Re: [PATCH xrandr v5 0/6] xrandr: improve option parsing and documentation

On Fri, Mar 2, 2018 at 1:58 AM, Keith Packard <kei...@keithp.com> wrote: > Giuseppe Bilotta <giuseppe.bilo...@gmail.com> writes: > >> Giuseppe Bilotta (6): >> xrandr: allow a single value for --scale >> xrandr: stricter --scale argument parsing >>

Re: [PATCH app/xrandr] Fix checking for valid argument of --dpi

ngs, and then set the virtual framebuffer physical dimensions from the DPI). Cheers, Giuseppe Bilotta ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH app/xdpyinfo v4] Use XRANDR 1.2 extension for reporting dimensions and resolution per output

Hello, this is still not acceptable. _Do not alter the main section output_, and move the XRANDR-specific information into its own extension-dedicated output function, instead of hacking around it with the print_none_info function. On Mon, May 7, 2018 at 11:34 PM Pali Rohár wrote: > -xres =

Re: Physical vs logical DPI on X

appreciate if Qt spearheaded the separation of DPI scaling from UI scaling (with a separate root window property or XSETTING or whatever), but I understand if this is considered being “too much” (especially since AFAIK other OSes/display servers don't have the concept either, but feel free to corre