Re: [PATCH libXi 7/7] Refactor XGetExtensionVersion.

On Sat, Nov 01, 2014 at 08:00:57PM +0200, Michal Srb wrote: > _XiGetExtensionVersion was called from XGetExtensionVersion and from > _XiCheckExtInit. When called from _XiCheckExtInit, nothing accounted for the > fact that it can return ((XExtensionVersion *) NoSuchExtension) in case of > error. Als

Re: [PATCH libXi 5/7] XIGrabDevice: Unlock display in error path.

On Sat, Nov 01, 2014 at 08:00:55PM +0200, Michal Srb wrote: > Signed-off-by: Michal Srb > --- > src/XIGrabDevice.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/src/XIGrabDevice.c b/src/XIGrabDevice.c > index a8c5697..4ba91eb 100644 > --- a/src/XIGrabDevice.c >

[PATCH v2] dix: silence compiler warning comparing CARD32 to -1

window.c:3246:36: warning: comparison of constant -1 with expression of type 'CARD32' (aka 'unsigned int') is always true [-Wtautological-constant-out-of-range-compare] if (optional->backingBitPlanes != ~0L) ~~ ^ ~~~ Signed

[PATCH v2] include: fix documentation for list.h

Signed-off-by: Peter Hutterer --- include/list.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/list.h b/include/list.h index 455c670..39f1985 100644 --- a/include/list.h +++ b/include/list.h @@ -117,7 +117,7 @@ struct xorg_list { * Example: * xorg_list_init(&

[PATCH 8/9] dix: silence compiler warning comparing CARD32 to -1

window.c:3246:36: warning: comparison of constant -1 with expression of type 'CARD32' (aka 'unsigned int') is always true [-Wtautological-constant-out-of-range-compare] if (optional->backingBitPlanes != ~0L) ~~ ^ ~~~ Signed-off-by: P

[PATCH 6/9] xwayland: declare fatal log handler as noreturn

xwayland.c:661:1: warning: function 'xwl_log_handler' could be declared with attribute 'noreturn' [-Wmissing-noreturn] Signed-off-by: Peter Hutterer --- hw/xwayland/xwayland.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xway

[PATCH 0/9] Couple of compiler warning fixes

A couple of compiler warning fixes, like most warning fixes attempts I got demotivated quickly, so this is nowhere near the lot. Some of these affect the server build (with clang), others like the first 3 affect drivers simply because they headers are included through a couple of subheaders. Take

[PATCH 2/9] include: fix documentation for list.h

Signed-off-by: Peter Hutterer --- include/list.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/list.h b/include/list.h index 455c670..9154e1c 100644 --- a/include/list.h +++ b/include/list.h @@ -117,7 +117,7 @@ struct xorg_list { * Example: * xorg_list_init(&

[PATCH 5/9] xfree86: drop double-typedef of DBusConnection

Just include dbus.h, it's been typedef'd there since 2003. Signed-off-by: Peter Hutterer --- hw/xfree86/common/Makefile.am | 4 include/dbus-core.h | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/common/Makefile.am b/hw/xfree86/common/M

[PATCH 7/9] dix: silence compiler warning

depends on MAX_BUTTONS which is somewhat arbitrarily chosen. We don't expect this to ever change, but just in case leave the condition there so the code is correct if we drop the number down. Signed-off-by: Peter Hutterer --- dix/inpututils.c | 2 ++ 1 file changed, 2 insertions(+) diff --

[PATCH 3/9] include: change RegionSize() to take a size_t

ller, but maybe that motivates someone to fix it. Signed-off-by: Peter Hutterer --- include/regionstr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/regionstr.h b/include/regionstr.h index 4a0725d..515e93f 100644 --- a/include/regionstr.h +++ b/include/regionst

[PATCH 1/9] include: fix compiler warning about casting int to uint16_t

~~~ Function sig is a uint16_t, so just force the cast. Signed-off-by: Peter Hutterer --- include/misc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/misc.h b/include/misc.h index 9c2f573..f5b85ee 100644 --- a/include/misc.h +++ b/include/misc.h @@ -138,7 +138,7 @@

[PATCH 4/9] Xext: fix clang compiler warning

shm.c:1150:24: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if ((shmdesc->addr == ((char *) -1))) { Signed-off-by: Peter Hutterer --- Xext/shm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Xext/shm.c b/Xext/shm.c index b787

Re: [PATCH] xkbcomp: Improved -w option parsing

On Mon, Oct 27, 2014 at 10:50:30AM +0100, Vincent Lefevre wrote: > This patch improves -w option parsing even further, for cases like > "xkbcomp -w6 4.xkb out.xkb" (which were not handled by the fix of > #66344). Moreover, though this form can be regarded as ambiguous, > the warning level is still

Re: config: revert quirk for the Evoluent Vertical Mouse

On Fri, Oct 10, 2014 at 11:36:32AM -0700, Dmitry Torokhov wrote: > On Friday, October 10, 2014 11:12:11 AM Dmitry Torokhov wrote: > > On Thu, May 15, 2014 at 12:54:40PM +1000, Peter Hutterer wrote: > > > This quick makes the mouse behaviour more obvious (LMR buttons

Re: [PATCH] dix: Untwist transformAbsolute logic, eliminate uninitialized value warnings

t whether the ValuatorMask includes X/Y values > 2) If either are missing, back-convert the current values into ox/oy > 3) When X/Y are present, set ox/oy to the current value > 4) Transform > 5) Store X/Y values if changed or if they were set before. > > Signed-off-by: Keith Pac

Re: [PATCH 2/2] xkb: Initialize 'bad' Atom in _XkbSetNamesCheck

lientPtr client, DeviceIntPtr dev, > { > XkbDescRec *xkb; > CARD32 *tmp; > -Atom bad; > +Atom bad = None; > > tmp = data; > xkb = dev->key->xkbInfo->desc; > -- > 2.1.1 Reviewed-by: Peter Hutterer for both Cheers, Peter __

Re: xf86-input-evdev not working with touch device with MT only axes

On Mon, Oct 27, 2014 at 11:15:10AM +, Pasrshuram Thombare wrote: > I am using xf86-input-evdev(2.8.1) for touch device with MT only axes, but > I am getting following error. > > "evdev: found only multitouch-axes. That shouldn't happen. > evdev: failed to initialize for absolute axes." > > I

[PATCH inputproto] specs: rename EVENTMASK to EVTYPEMASK

-off-by: Peter Hutterer --- specs/XI2proto.txt | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/specs/XI2proto.txt b/specs/XI2proto.txt index e3636ac..697dd89 100644 --- a/specs/XI2proto.txt +++ b/specs/XI2proto.txt @@ -672,9 +672,9 @@ Data types device

Re: [PATCH evdev 2/2] Always report all valuators on absolute devices

On Sat, Sep 27, 2014 at 10:08:39PM +0200, Éric Brunet wrote: > When dealing with a device identified as a tablet, both Qt and gtk seem to > ignore the position as reported by the X server, but rather compute > themselves the position from the raw valuator values (In order to achieve > better precis

Re: vmmouse kernel driver

On Fri, Sep 26, 2014 at 02:44:15PM +0200, Hans de Goede wrote: > Hi, > > On 09/26/2014 09:06 AM, Thomas Hellstrom wrote: > > Hi! > > > > On 09/26/2014 03:36 AM, Peter Hutterer wrote: > >> On Wed, Sep 24, 2014 at 11:12:50AM +0200, Thomas Hellstrom wrote: >

Re: vmmouse kernel driver

On Wed, Sep 24, 2014 at 11:12:50AM +0200, Thomas Hellstrom wrote: > While looking at a vmmouse kernel driver, I wonder how the Xorg evdev > driver can be configured to receive both absolute and relative events > from the same device as the vmmouse sometimes sends absolute events and > sometimes rel

Re: [PATCH 2/2] Use unique display name for each xi2 test program

On Mon, Sep 22, 2014 at 02:02:26PM -0700, Keith Packard wrote: > Peter Hutterer writes: > > > On Sun, Sep 21, 2014 at 09:49:06AM -0700, Alan Coopersmith wrote: > >> make -j 8 check was sporadically failing in different xi2 tests. > >> After adding the asserts in th

Re: [PATCH 2/2] Use unique display name for each xi2 test program

since this > covers enough platforms for me. Reviewed-by: Peter Hutterer for both Cheers, Peter > > configure.ac |4 +++- > include/dix-config.h.in|7 +++ > test/xi2/protocol-common.c | 11 +++ > 3 files changed, 21 insertions(+),

Re: X.Org looking for projects and mentors for the Outreach Program for Women

be great if we had a nice range of projects available by then. Note that unlike GSoC, the scope is not limited to coding (see below). Cheers, Peter On Fri, Sep 05, 2014 at 09:01:44AM +1000, Peter Hutterer wrote: > Hi everyone, > > X.Org will join the Outreach Program for Women (O

Re: [PATCH synaptics] Use ABS_MT events for the palm detection when supported

On Tue, Sep 16, 2014 at 05:20:15PM +0200, Gabriele Mazzotta wrote: > Use ABS_MT_TOUCH_MAJOR and ABS_MT_PRESSURE instead of ABS_TOOL_WIDTH > and ABS_PRESSURE when supported so that the pressure and the width of > all the fingers is taken into account for the palm detection. > > This also fixes the

Re: [PATCH synaptics] Limit the movement to 20 mm per event

On Tue, Sep 16, 2014 at 08:57:56AM +0600, Alexander E. Patrakov wrote: > 16.09.2014 07:08, Peter Hutterer wrote: > >Touchpads are limited by a fixed sampling rate (usually 80Hz). Some finger > >changes may happen too fast for this sampling rate, resulting in two distinct >

Re: [PATCH synaptics] Limit the movement to 20 mm per event

On Tue, Sep 16, 2014 at 09:17:12AM +0600, Alexander E. Patrakov wrote: > Oops, sorry. I really must sleep more. I replied with a libinput patch to a > synaptics patch. > > As I no longer use synaptics and don't want to figure out whether the code > there allows to say "this is a new finger", I jus

[PATCH synaptics] Limit the movement to 20 mm per event

5 the touchpad's diagonal instead. Signed-off-by: Peter Hutterer --- See the git repo below for a simple script to verify valid movement deltas on your device if you feel like it: https://github.com/whot/input-data-analysis/tree/master/touchpad-max-delta Max I got was 9mm on the x220 and 1

[PATCH synaptics 4/4] When resetting, reset the open slots to -1

open_slots holds the slot index, resetting it to 0 is a bad idea. And make sure that we do reset after DEVICE_INIT. We already do so on DEVICE_CLOSE, but after the first DEVICE_ON the data could still be random. Signed-off-by: Peter Hutterer --- src/synaptics.c | 8 +++- 1 file changed, 7

[PATCH synaptics 2/4] Shut up a coverity warning

xf86-input-synaptics-1.8.0/src/synaptics.c:498: var_compare_op: Comparing "end_str" to null implies that "end_str" might be null. end_str can't be null, so no need for this check and no need to get Coverity all confused. Signed-off-by: Peter Hutterer --- src/synaptics

[PATCH synaptics 1/4] Mark some switch case fallthroughs with comments

Just to make it explicit Signed-off-by: Peter Hutterer --- src/ps2comm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/ps2comm.c b/src/ps2comm.c index ed2f751..c474c07 100644 --- a/src/ps2comm.c +++ b/src/ps2comm.c @@ -582,12 +582,15 @@ PS2ReadHwStateProto(InputInfoPtr pInfo

[PATCH synaptics 3/4] eventcomm: add missing axis labels to avoid array overrun

And warn when we run out of labels. Signed-off-by: Peter Hutterer --- src/eventcomm.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/eventcomm.c b/src/eventcomm.c index faaa57d..e789f0e 100644 --- a/src/eventcomm.c +++ b/src/eventcomm.c @@ -843,7 +843,7

Re: Feedback on Synaptics with ClickPad

ion item). > > > >What I took seriously was > > > >On 2014-09-09 03:29, Peter Hutterer wrote: > >> > >>not sure where you have your ClickFinger option set, but it's not > >>found by > >>the driver, otherwise it would show up here. I t

Re: Feedback on Synaptics with ClickPad

On Mon, Sep 08, 2014 at 07:29:44PM +, Thierry Moreau wrote: > > first of all thanks for supporting this fairly new pointer device > configuration. > > I encounter this because I install Linux from a barebone distribution (Crux > 3.1) for reasons unrelated to the X system. > > Configuration s

Re: [PATCH] Make list tests actually test lists

code will work differently in a non-debug build. > Did you intend to use a comparison ("==") instead? > > Fixing those to be == caused test_nt_list_insert to start failing as > part assumed append order, part assumed insert order, so it had to be > fixed to use consistent ordering. &

Re: [PATCH] [synaptic] swipe actions based on the tree-fingers touch

Hi Arkadiusz, sorry about the delay on the review here. On Fri, Apr 25, 2014 at 07:31:44PM +0200, Arkadiusz Bokowy wrote: > When touchpad can report more then 2 active fingers, we can generate action > based on swipe gesture. It includes upward, downward, to the left and to the > right swipes. To

Re: [PATCH synaptics] Use cumulative relative touch movements while scrolling

On Thu, Aug 14, 2014 at 08:03:42PM +0200, Gabriele Mazzotta wrote: > Signed-off-by: Gabriele Mazzotta sorry about the delay, merged, 90d1930..ec0901e master -> master Cheers, Peter > --- > src/eventcomm.c | 8 +--- > src/synaptics.c | 8 +--- > 2 files changed, 10 insertions(+),

X.Org looking for projects and mentors for the Outreach Program for Women

Hi everyone, X.Org will join the Outreach Program for Women (OPW) in Round 9 (December 2014 - March 2015). The OPW is "open to anyone who was assigned female at birth and anyone who identifies as a woman, genderqueer, genderfluid, or genderfree regardless of gender presentation or assigned sex at

[PATCH synaptics] eventcomm: ensure we're on the same clock as the server

nally setting the timer func if we get any events, which is a separate issue anyway. Signed-off-by: Peter Hutterer --- src/eventcomm.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/eventcomm.c b/src/eventcomm.c index 845f547..4a646af 100644 --- a/src/even

Re: [PATCH v2 evdev] Make the slot-state per slot

it's more obvious. Technically the default case can be dumped now or could trigger a BUG_ macro but I'll skip that for now. thanks for the review Cheers, Peter > revieded-by wharms > Am 15.08.2014 05:57, schrieb Peter Hutterer: > > The previous approach only had the

[PATCH v2 evdev] Make the slot-state per slot

if a touchpoint starts before the device is enabled. Signed-off-by: Peter Hutterer --- Changes to v1: - replace the convoluted if/else with a switch src/evdev.c | 75 +++-- src/evdev.h | 5 - 2 files changed, 52 insertions(+), 28 deletions(-

Re: [PATCH synaptics] Prevent two-finger taps from being ignored

On Sun, Jul 27, 2014 at 12:58:18PM +0200, Gabriele Mazzotta wrote: > When two fingers are used, the coordinates of only one of them is taken into > account. This can lead to sudden variations of the absolute coordinates when > two-fingers taps are performed if the finger considered changes. > >

[PATCH evdev 2/2] If only IgnoreRelativeAxes is set, init like a normal relative device

explicitely want relative axes but leave the abs axes as-is, proceed as normal. Signed-off-by: Peter Hutterer --- src/evdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/evdev.c b/src/evdev.c index 045d780..d1b4f96 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1917,7

[PATCH evdev 1/2] Fix axis initialization for devices with abs x/y and rel scrollwheels

device setting the two Ignore*Axis options both to "off", the axes are still overwritten. The wheels will work, other axes only if the same number of abs axes exists. And it keeps the current memory leak too, but it's marked with a FIXME now. Signed-off-by: Peter Hutterer --- s

[PATCH evdev] Make the slot-state per slot

if a touchpoint starts before the device is enabled. Signed-off-by: Peter Hutterer --- src/evdev.c | 66 +++-- src/evdev.h | 5 - 2 files changed, 46 insertions(+), 25 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 30f809b..5a39d

Re: [PATCH] xkb: ignore floating slave devices when updating from master (#81885)

ping? On Mon, Aug 04, 2014 at 10:47:03AM +1000, Peter Hutterer wrote: > Introduced in 45fb3a934dc0db51584aba37c2f9d73deff9191d. When a device is > enabled, the master's locked state is pushed to the slave. If the device is > floating, no master exists and we triggered a NULL-point

[PATCH synaptics] Use libevdev's per-device logging functions instead of the global handler

Signed-off-by: Peter Hutterer --- configure.ac| 7 +++ src/eventcomm.c | 48 +--- 2 files changed, 36 insertions(+), 19 deletions(-) diff --git a/configure.ac b/configure.ac index 4b3a726..0a2bfb6 100644 --- a/configure.ac +++ b/configu

Re: [PATCH] xkbcomp: Improved -w option parsing

On Thu, Aug 07, 2014 at 09:44:39AM +0200, Vincent Lefevre wrote: > On 2014-08-07 15:46:51 +1000, Peter Hutterer wrote: > > whoah, this is pretty much a perfect example of how not to use goto... > > adding three lines for error and exist isn't that hard, jumping from one

Re: [PATCH] xkbcomp: Improved -w option parsing

On Mon, Aug 04, 2014 at 03:27:49PM +0200, Vincent Lefevre wrote: > This patch improves -w option parsing even further, for cases like > "xkbcomp -w6 4.xkb out.xkb" (which were not handled by the fix of > #66344). Moreover, though this form can be regarded as ambiguous, > the warning level is still

Re: [PATCH synaptics] conf: increase top software button area to 15%

On 6/08/2014 16:35 , Eric Anholt wrote: Peter Hutterer writes: We had reports that the top software button area is hard to hit for those using the trackpoint and clicking the buttons with their thumb. Analysis of event recordings (3 different people) for left, right and middle clicks shows

[PATCH synaptics] conf: increase top software button area to 15%

outliers up to 12mm) from the top of the touchpad. That maps to 15%. Interestingly, the middle button is not affected by this, presumably the haptic feedback of the little dots sticking out from the surface make hitting the button easier. Signed-off-by: Peter Hutterer --- conf/50-synaptics.conf

Re: [PATCH] BellProc: Send bell event on core protocol bell when requested

ell > from ringing: if no BellProc() is set for the device, no attempt > is made to ring a bell. > This patch ensures that an XKB bell event is sent also when > the core protocol bell is rung end thus an appropriate action > can be taken by a client. > > Signed-off-by: Egbert E

[PATCH] xkb: ignore floating slave devices when updating from master (#81885)

ktop.org/show_bug.cgi?id=81885> Signed-off-by: Peter Hutterer --- dix/devices.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dix/devices.c b/dix/devices.c index 7f079ff..9e1c546 100644 --- a/dix/devices.c +++ b/dix/devices.c @@ -416,7 +416,7 @@ EnableDevice(DeviceIntPt

Re: [PATCH] xfree86: [v2] Remove duplicate InputInfoPtr typedef from xf86Xinput.h

> Signed-off-by: Keith Packard looks good, I take it you did do a rebuild from scratch with this just to be on the safe side? with that Reviewed-by: Peter Hutterer Cheers, Peter > --- > hw/xfree86/common/xf86Xinput.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-)

Re: Problem compiling X server

case? I skipped the > configuration and installation of mesa, So I don't know if it affects this > process. it does. you need to have the .pc files installed in your PKG_CONFIG_PATH http://who-t.blogspot.com.au/2014/05/configure-fails-with-no-package-foo.html Cheers, Peter > On Thu, Jul 24

Re: Problem compiling X server

On Thu, Jul 24, 2014 at 08:37:07AM +0100, Check Nyah wrote: > Hi Dave, > > I've already looked at the Damage layer and current impedance layer codes > from the drvmodelv3 you gave me. But i'm having problems compiling the X > server. I executed This script >

Re: Touchscreen auto-configuration for multi-display systems

On Wed, Jul 23, 2014 at 09:25:17AM -0400, Taylor Braun-Jones wrote: > Hi all, > > I recently setup a touchscreen display on a dual-head system where the > touchscreen display was on the left. Of course this doesn't work out of the > box. I had to spend time learning about `xinput --map-to-output`.

Re: [PATCH] gcc 4.2 doesn't accept 2 typedef declarations of the same type.

On Wed, Jul 16, 2014 at 11:33:02PM -0700, Keith Packard wrote: > Matthieu Herrb writes: > > > It's currenlty not true at least for xf86-input synaptics. But if > > Peter is willing to fix that, I'm ok with that solution (it was the > > first I used, until I also built the synaptics driver). > >

Re: [PATCH 1/1] mieq: Fix a crash regression in mieqProcessDeviceEvent

#5: 0x00010001ba80 > > X11.bin`server_thread(arg=0x000101208220) + 64 at quartzStartup.c:66 > >frame #6: 0x7fff89bb9899 libsystem_pthread.dylib`_pthread_body + 138 > >frame #7: 0x7fff89bb972a libsystem_pthread.dylib`_pthread_start + 137 > >frame #8: 0x7f

Re: [PATCH] xfree86: Remove stale /usr/share/X11/xorg.conf.d hard-code from the xorg.conf man page

;) > --- > Sorry I forgot about this when I was fixing the sysconfigdir thing. > > I fixed this paragraph to conform to the "new sentences start on their own > lines" man page requirement while I was at it. Reviewed-by: Peter Hutterer Cheers, Peter > > hw/xfr

[PULL] screensaver/dpms fix, sysconfigdir, pointer accel revert

2014-07-14 15:05:58 +1000) Aaron Plattner (1): xfree86: Only support one sysconfigdir Peter Hutterer (3): os: prevent negative array index access (#80890) xfree86: don't force the screensaver off on DPMS unblank, merely suggest it Revert "dix: fix up coordi

Re: [PATCH vmmouse] Fix wheel button labels

On Sat, Jul 12, 2014 at 07:29:24AM +0200, Loïc Yhuel wrote: > Wheel is using buttons 4/5, but btn_labels array is 0-based. > It matches mouse and evdev drivers, and fixes wheel in Qt5.3. pushed, thanks. 336f863..de58228 master -> master Cheers, Peter > --- > src/vmmouse.c | 8 >

Re: [PATCH] Fix locking bugs with XIAllowTouchEvents() and XIUngrabTouchBegin()

On Fri, Jul 11, 2014 at 03:13:54PM -0400, otay...@redhat.com wrote: > From: "Owen W. Taylor" > > Fix two places where the display was double locked when an API > function chained to an implementation that also locks the display. > --- > src/XIAllowEvents.c | 7 +-- > src/XIPassiveGrab.c | 1

Re: [PATCH v2] xfree86: Only support one sysconfigdir

On Fri, Jul 11, 2014 at 03:56:35PM -0700, Aaron Plattner wrote: > When the X server is compiled with --prefix set to something other than /usr, > then it ends up with a nonstandard sysconfigdir in its .pc file. This causes > various other components to install their xorg.conf.d snippets there. >

Re: [PATCH] xfree86: support multiple sysconfigdir paths

On Thu, Jul 10, 2014 at 04:04:40PM -0700, Aaron Plattner wrote: > When the X server is compiled with --prefix set to something other than /usr, > then it ends up with a nonstandard sysconfigdir in its .pc file. This causes > various other components to install their xorg.conf.d snippets there. >

[PATCH] xfree86: don't force the screensaver off on DPMS unblank, merely suggest it

time on the devices. https://bugzilla.gnome.org/show_bug.cgi?id=731241 Signed-off-by: Peter Hutterer --- hw/xfree86/common/xf86DPMS.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/common/xf86DPMS.c b/hw/xfree86/common/xf86DPMS.c index 14d1f45..2b5a3ed 100644 --- a

Re: [PATCH libXi 2/2] XIPassiveGrab: Fix completely broken locking in XIGrabTouchBegin

On Wed, Jul 09, 2014 at 06:45:06AM -0400, Jasper St. Pierre wrote: > But all the other existing code that uses _XiCheckExtInit expects it to > unlock on error, but not on success. Peter wrote this code, though, so I'll > let him have the final say. yeah, if someone wants to fix this on a global sc

Re: [PATCH] os: prevent negative array index access (#80890)

On Tue, Jul 08, 2014 at 08:12:22AM +0200, Julien Cristau wrote: > On Tue, Jul 8, 2014 at 09:24:18 +1000, Peter Hutterer wrote: > > > If an empty string is provided to LogMessageVerbSigSafe, the length of the > > printed string is 0. > > > Do we know who calls th

[PATCH] os: prevent negative array index access (#80890)

If an empty string is provided to LogMessageVerbSigSafe, the length of the printed string is 0. Read-only access only and the only effect it had was adding a linebreak or not. X.Org Bug 80890 <http://bugs.freedesktop.org/show_bug.cgi?id=80890> Signed-off-by: Peter Hutterer --- Keith,

Re: evdev: workaround for missing ABS_X/Y on multitouch devices (mostly Android)

On Thu, Jun 26, 2014 at 10:47:01PM +0100, Colin Macdonald wrote: > On 25/06/14 02:39, Peter Hutterer wrote: > > it's doable, and with libevdev fairly simple nowadays, we'd only > > have to call libevdev_set_abs_info() and be done with it. Send a > > patch and I'

[PATCH util-modular 2/2] release.sh: fix tarball path for libinput

Signed-off-by: Peter Hutterer --- release.sh | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/release.sh b/release.sh index 8e1af53..345ca09 100755 --- a/release.sh +++ b/release.sh @@ -552,13 +552,18 @@ process_module() { fi if [ x"$section"

[PATCH util-modular 1/2] release.sh: fix a couple of missing tag_name vs tar_name substitutions

Signed-off-by: Peter Hutterer --- some changes are hard to catch when you're doing dry-runs only... release.sh | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/release.sh b/release.sh index 6909225..8e1af53 100755 --- a/release.sh +++ b/release.sh @@ -97,7

Re: evdev: workaround for missing ABS_X/Y on multitouch devices (mostly Android)

On Tue, Jun 24, 2014 at 10:47:14AM +0100, Colin Macdonald wrote: > Hi, > > I filed this as > [https://bugs.freedesktop.org/show_bug.cgi?id=80470]. But perhaps > worthy of maillist discussion... > > 1) The Kernel spec says multitouch devices should give ABS_X and > ABS_Y events as well as ABS_MT

[PULL] coordinate scaling fix for external monitors

d90b5f83010248be65b2039b0b2d0b9e6a4e93cf: dix: fix up coordinate scaling when external monitors are present (2014-06-23 11:04:55 +1000) Peter Hutterer (1): dix: fix up coordinate scaling when external monitors are present dix/getevents.c | 80

Re: [PATCH util/modular] Add a link to the PGP signature in the announcement email.

On Sat, Jun 21, 2014 at 01:54:26PM +0200, Stephen Kitt wrote: > Hi, > > Tarballs are now signed correctly, witness the recent evemu release. It would > be nice if the announcement email mentioned the availability of these > signatures. > > Signed-off-by: Stephen Kitt > --- > release.sh | 1 + >

Re: [PATCH] make wording of ScrollDelta options clearer

On Thu, Jun 19, 2014 at 08:39:56PM +0200, Zsolt Dollenstein wrote: > --- > man/synaptics.man | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/man/synaptics.man b/man/synaptics.man > index 76756be..a40d2e7 100644 > --- a/man/synaptics.man > +++ b/man/synaptics.

Re: xorg-c-mode for emacs ?

On Mon, Jun 09, 2014 at 11:48:07AM +0200, walter harms wrote: > ok, i found this > http://www.x.org/wiki/CodingStyle/ > > the linux kernel docs have a hints adjusting emacs, > it would be nice if someone could provide the same here. Except for the server and some driver modules, we don't have a c

Re: [PATCH] LibX11: rm redundant null checks

On Sat, Jun 07, 2014 at 11:54:34AM +0200, walter harms wrote: > > remove more redundant NULL checks > note that _XkbFree() is realy Xfree() > > Signed-off-by: Harms pushed, with whitespace fixes and a typo fixed. Next time please: * make sure the whitespaces match what is used in surrounding co

Re: [PATCH synaptics] Add movement constraints to clickpads to prevent cursor jumps

On Tue, Jun 17, 2014 at 12:35:53AM +0600, Alexander E. Patrakov wrote: > 16.06.2014 16:37, Peter Hutterer wrote: > >On 15/06/2014 03:48 , Alexander E. Patrakov wrote: > >>1. I decide to place the pointer somewhere and left-click. > >>2. I place the right index finger on

Re: [PATCH] libX11: rm redundante NULL checks

On Sat, Jun 07, 2014 at 03:17:27PM +0200, walter harms wrote: > > This patch removes the last remaining NULL checks for Xfree() > > Signed-off-by: Harms pushed with a couple of indentation fixes, thanks. Cheers, Peter > > --- > src/GetWMProto.c| 2 +- > src/xkb/XKBGAlloc.c

Re: [PATCH:libX11] Start adding Unicode 7.0 support to compose table

On Mon, Jun 16, 2014 at 03:18:31PM -0700, Alan Coopersmith wrote: > New characters defined in http://www.unicode.org/charts/PDF/U1F300.pdf > > Signed-off-by: Alan Coopersmith > --- > nls/en_US.UTF-8/Compose.pre |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/nls/en_US.UTF-8/Compo

Re: [PATCH synaptics] Add movement constraints to clickpads to prevent cursor jumps

On 15/06/2014 03:48 , Alexander E. Patrakov wrote: 14.06.2014 20:44, Gabriele Mazzotta wrote: On Saturday 14 June 2014 17:47:27, Alexander E. Patrakov wrote: 13.06.2014 15:22, Gabriele Mazzotta wrote: It appears that 71652fe ("Ignore motion the first X ms after a clickpad click") is not enoug

Re: [PATCH V2] libX11: do not shadow variables

On Mon, Jun 09, 2014 at 03:43:49PM +0200, walter harms wrote: > > I noted by chance that i made a mistake when generating my > former version of "do not shadow variables". this time it should be complet. > > unshadow a few variables that fixes: > imCallbk.c:627:15: warning: symbol 'len' shadows a

[PATCH] dix: fix up coordinate scaling when external monitors are present

resolution-independent. Signed-off-by: Peter Hutterer --- ok, this whole thing is a mess, this just fixes the current broken bit in a slightly improved broken way. needs some grand redesign at some point, but not today. dix/getevents.c | 80 ++--- 1 f

Re: [PATCH util/modular] Add gpg signing to release.sh

On Mon, Jun 09, 2014 at 12:10:48PM +0200, Stephen Kitt wrote: > On Sun, 08 Jun 2014 21:48:52 -0400, Gaetan Nadon wrote: > > On 14-06-07 03:57 PM, Stephen Kitt wrote: > > > > > > #-- > > > +# Functio

Re: [PATCH mi 1/1] mi: Build fix: mieqProcessDeviceEvent returns void

ted. > > Regression-from: 9fb08310b51b46736f3ca8dbc04efdf502420403 > > Signed-off-by: Jeremy Huddleston Sequoia > CC: Peter Hutterer whoops, sorry Reviewed-by: Peter Hutterer Cheers, Peter > --- > mi/mieq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[PATCH evdev] Hook up libevdev's new device log function

Signed-off-by: Peter Hutterer --- configure.ac | 7 +++ src/evdev.c | 33 + 2 files changed, 40 insertions(+) diff --git a/configure.ac b/configure.ac index 1325424..0db1dec 100644 --- a/configure.ac +++ b/configure.ac @@ -49,6 +49,13 @@ PKG_CHECK_MODULES

Re: [PATCH util/modular] Add gpg signing to release.sh

On Sun, Jun 01, 2014 at 03:13:13PM +0200, Stephen Kitt wrote: > From 7d967b5ec2122a3f85730587be6d8a424fac9cdc Mon Sep 17 00:00:00 2001 > From: Stephen Kitt > Date: Sun, 1 Jun 2014 14:46:01 +0200 > Subject: [PATCH util/modular] Add gpg signing to release.sh > > gpg-sign the git tag and the generat

[PATCH 1.5/4 util-modular] release.sh: force /bin/bash

Trying to meet a hard-to-test standard of /bin/sh is unnecessary for a script that's only run by maintainers. For now, simply force bash but don't change any of the script, over time we can update this to support true bashism like [[ ]]. Signed-off-by: Peter Hutterer --- release.sh

Re: [PATCH util-modular 2/4] release.sh: move the bit to extract the section into a function

On Thu, May 29, 2014 at 05:53:51PM -0400, Gaetan Nadon wrote: > On 14-05-29 12:51 AM, Peter Hutterer wrote: > > No functional changes intended > > > > Signed-off-by: Peter Hutterer > > --- > > release.sh | 128 > > +++---

Re: [PATCH util-modular 2/4] release.sh: move the bit to extract the section into a function

On Thu, May 29, 2014 at 05:18:32PM -0400, Gaetan Nadon wrote: > On 14-05-29 12:51 AM, Peter Hutterer wrote: > > No functional changes intended > > > > Signed-off-by: Peter Hutterer > > --- > > release.sh | 128 > > +++---

Re: [PATCH] XI2: Fix XI_TouchOwnershipChangedMask value

On Thu, May 29, 2014 at 12:24:46PM +0200, Daniel Martin wrote: > A none existing define > XI_TouchOwnershipChanged > had been used to set the value of XI_TouchOwnershipChangedMask. Fix this > by using > XI_TouchOwnership. > > Signed-off-by: Daniel Martin whoops, thank you. merged Cheers

[PATCH util-modular 4/4] release.sh: add the hooks for the wayland repositories

: Peter Hutterer --- release.sh | 50 +- 1 file changed, 41 insertions(+), 9 deletions(-) diff --git a/release.sh b/release.sh index 0c86c34..e5774c2 100755 --- a/release.sh +++ b/release.sh @@ -216,12 +216,13 @@ get_section() { module_url

[PATCH util-modular 2/4] release.sh: move the bit to extract the section into a function

No functional changes intended Signed-off-by: Peter Hutterer --- release.sh | 128 +++-- 1 file changed, 74 insertions(+), 54 deletions(-) diff --git a/release.sh b/release.sh index abfcc29..a05b0c9 100755 --- a/release.sh +++ b

[PATCH util-modular 3/4] release.sh: move fetching the section up so we can do stuff with it

This enables us to query the section earlier in the process, specifically before assigning the tag name which comes in the next commit. Signed-off-by: Peter Hutterer --- release.sh | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/release.sh b/release.sh index

[PATCH util-modular 1/4] release.sh: split tar_name and tag_name into two separate variables

This has no effect at this point as the tag name and the tar name are always identical. Prep work for wayland repository support. Signed-off-by: Peter Hutterer --- release.sh | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/release.sh b/release.sh index

[PULL] accumulated patches

ry at: git://people.freedesktop.org/~whot/xserver for-keith for you to fetch changes up to cfaf2abbac3f01e57d00845d8908bf01559263f9: man: drop specific mention of DontZap in -retro (#71113) (2014-05-24 20:05:53 +1000) Peter Hutter

[PATCH 1/2] xfree86: fix wrong DontZap documentation (#71113)

X.Org Bug 71113 <http://bugs.freedesktop.org/show_bug.cgi?id=71113> Signed-off-by: Peter Hutterer --- hw/xfree86/xorgconf.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/xorgconf.cpp b/hw/xfree86/xorgconf.cpp index cd6d4a9..a903438 100644 --- a/hw/x

[PATCH 2/2] man: drop specific mention of DontZap in -retro (#71113)

DontZap off is the default anyway, don't mention it specifically to avoid confusion X.Org Bug 71113 <http://bugs.freedesktop.org/show_bug.cgi?id=71113> Signed-off-by: Peter Hutterer --- man/Xserver.man | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/man/Xs

<    4   5   6   7   8   9   10   11   12   13   >