Re: [PATCH:xf86-input-mouse 1/4] Enable MSE_MISC on NetBSD as well.

Can I assume that these are ok to push after so long without negative comments? :) Thomas On Sat, Oct 19, 2013 at 01:26:31AM +0200, Thomas Klausner wrote: Any comments on these four patches? Thanks, Thomas On Mon, Aug 19, 2013 at 11:14:30AM +0200, Thomas Klausner wrote: Otherwise we

Re: [PATCH] Avoid starting a comment with */*

On Mon, Mar 10, 2014 at 06:31:33PM -0400, Peter Harris wrote: Even though -Wcomment doesn't mind it (in gcc or clang), the appearance of */* confuses the syntax highlighter of some editors (eg. vim), and causes warnings in MSVC. Signed-off-by: Peter Harris phar...@opentext.com ... diff

[PATCH:libXaw] Fix abs() usage.

For long arguments, use labs(). From Jörg Sonnenberger jo...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- src/Text.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Text.c b/src/Text.c index a1ae74a..8100122 100644 --- a/src/Text.c +++ b/src/Text.c

[PATCH:libXpm] Fix abs() usage.

For long arguments, use labs(). From Jörg Sonnenberger jo...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- src/create.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/create.c b/src/create.c index 98678d8..d013da9 100644 --- a/src/create.c +++ b

[PATCH:mkfontscale 1/2] Only include config.h if it exists.

Signed-off-by: Thomas Klausner w...@netbsd.org --- hash.c| 2 ++ mkfontscale.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/hash.c b/hash.c index 3adfb68..d834222 100644 --- a/hash.c +++ b/hash.c @@ -20,7 +20,9 @@ THE SOFTWARE. */ +#ifdef HAVE_CONFIG_H #include config.h

[PATCH:mkfontscale 2/2] Add some const.

Signed-off-by: Thomas Klausner w...@netbsd.org --- mkfontscale.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mkfontscale.c b/mkfontscale.c index 036a0b4..a81e60a 100644 --- a/mkfontscale.c +++ b/mkfontscale.c @@ -66,7 +66,7 @@ #define QUOTE(x) #x #define

Re: [PATCH:mkfontscale 2/2] Add some const.

Sorry, I got the commit message wrong. Here's the right one: From fc5a9c8fa6e405c144892849a3a3d40a8513a8f7 Mon Sep 17 00:00:00 2001 From: Thomas Klausner w...@netbsd.org Date: Tue, 18 Mar 2014 23:15:20 +0100 Subject: [PATCH:mkfontscale 2/2] Avoid const warnings. clang complains about both

[PATCH:libXpm] Fix abs() usage.

From: Jörg Sonnenberger jo...@netbsd.org For long arguments, use labs(). Signed-off-by: Thomas Klausner w...@netbsd.org --- src/create.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/create.c b/src/create.c index 98678d8..d013da9 100644 --- a/src/create.c +++ b

[PATCH:libXaw] Fix abs() usage.

From: Jörg Sonnenberger jo...@netbsd.org For long arguments, use labs(). Signed-off-by: Thomas Klausner w...@netbsd.org --- src/Text.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Text.c b/src/Text.c index a1ae74a..8100122 100644 --- a/src/Text.c +++ b/src/Text.c

Re: [PATCH:libXpm] Fix abs() usage.

On Tue, Mar 18, 2014 at 06:51:28PM -0700, Matt Turner wrote: On Tue, Mar 18, 2014 at 2:57 PM, Thomas Klausner w...@netbsd.org wrote: For long arguments, use labs(). From Jörg Sonnenberger jo...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- The author of this patch

Re: [PATCH:libXpm] Fix abs() usage.

On Wed, Mar 19, 2014 at 01:17:42AM -0700, Matt Turner wrote: On Wed, Mar 19, 2014 at 12:53 AM, Thomas Klausner w...@netbsd.org wrote: On Tue, Mar 18, 2014 at 06:51:28PM -0700, Matt Turner wrote: On Tue, Mar 18, 2014 at 2:57 PM, Thomas Klausner w...@netbsd.org wrote: For long arguments, use

[PATCH 1/2] NetBSD: add AMD64Architecture, fix Arm32Architecture.

Signed-off-by: Thomas Klausner w...@netbsd.org --- Imake.cf | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Imake.cf b/Imake.cf index 2b6c649..9e438e7 100644 --- a/Imake.cf +++ b/Imake.cf @@ -238,8 +238,9 @@ XCOMM $XFree86: xc/config/cf/Imake.cf,v 3.88 2003/12/16 21:30

[PATCH 2/2] Always include xorg.cf for GccAliasingArgs.

(regardless of server support on this plattform) Signed-off-by: Thomas Klausner w...@netbsd.org --- NetBSD.cf | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/NetBSD.cf b/NetBSD.cf index 7d1afa0..7d9aadd 100644 --- a/NetBSD.cf +++ b/NetBSD.cf @@ -596,10 +596,6

[PATCH:cf 1/2] NetBSD: add AMD64Architecture, fix Arm32Architecture.

Signed-off-by: Thomas Klausner w...@netbsd.org --- Imake.cf | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Imake.cf b/Imake.cf index 2b6c649..9e438e7 100644 --- a/Imake.cf +++ b/Imake.cf @@ -238,8 +238,9 @@ XCOMM $XFree86: xc/config/cf/Imake.cf,v 3.88 2003/12/16 21:30

[PATCH:cf 2/2] Always include xorg.cf for GccAliasingArgs.

(regardless of server support on this plattform) Signed-off-by: Thomas Klausner w...@netbsd.org --- NetBSD.cf | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/NetBSD.cf b/NetBSD.cf index 7d1afa0..7d9aadd 100644 --- a/NetBSD.cf +++ b/NetBSD.cf @@ -596,10 +596,6

Re: [PATCH 1/2] NetBSD: add AMD64Architecture, fix Arm32Architecture.

Sorry for sending these without proper module name in the subject, I've resent them. Thomas On Thu, Mar 20, 2014 at 11:33:40AM +0100, Thomas Klausner wrote: Signed-off-by: Thomas Klausner w...@netbsd.org --- Imake.cf | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH:xf86-video-ast 2/3] Use proper type.

Two other places in this file already use uint32_t when passing it to PCI_READ_LONG. Signed-off-by: Thomas Klausner w...@netbsd.org --- src/ast_vgatool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ast_vgatool.c b/src/ast_vgatool.c index 73d379c..5181eb0 100644

[PATCH:xf86-video-ast 3/3] Fix ASTPutImage function to match interface.

Signed-off-by: Thomas Klausner w...@netbsd.org --- src/ast_driver.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ast_driver.c b/src/ast_driver.c index 5f7fa8e..8bf55ba 100644 --- a/src/ast_driver.c +++ b/src/ast_driver.c @@ -129,7 +129,8 @@ static Bool ASTModeInit

[PATCH:xf86-video-ast 1/3] Move an extern declaration into the scope it is used.

Signed-off-by: Thomas Klausner w...@netbsd.org --- src/ast_accel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ast_accel.c b/src/ast_accel.c index 71eeb79..52e19e3 100644 --- a/src/ast_accel.c +++ b/src/ast_accel.c @@ -54,6 +54,8 @@ /* Driver specific headers

Re: [PATCH:cf 1/2] NetBSD: add AMD64Architecture, fix Arm32Architecture.

On Sat, Mar 22, 2014 at 02:33:21PM -0700, Alan Coopersmith wrote: On 03/20/14 05:36 AM, Thomas Klausner wrote: Signed-off-by: Thomas Klausner w...@netbsd.org --- Imake.cf | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Imake.cf b/Imake.cf index 2b6c649..9e438e7

[PATCH:libxtrans 2/2] Cast ctype(3) function arguments to unsigned char.

Fixes warnings on at least NetBSD. Signed-off-by: Thomas Klausner w...@netbsd.org --- Xtrans.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Xtrans.c b/Xtrans.c index 9a6dfbc..ada53d3 100644 --- a/Xtrans.c +++ b/Xtrans.c @@ -164,8 +164,8 @@ TRANS(SelectTransport) (const

[PATCH:libxtrans 1/2] Add missing headers for free() and strlen().

Signed-off-by: Thomas Klausner w...@netbsd.org --- Xtrans.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Xtrans.c b/Xtrans.c index 735d7b8..9a6dfbc 100644 --- a/Xtrans.c +++ b/Xtrans.c @@ -48,6 +48,8 @@ from The Open Group. */ #include ctype.h +#include stdlib.h +#include string.h

[PATCH:xsetroot] Remove unnecessary parentheses.

Signed-off-by: Thomas Klausner w...@netbsd.org --- xrandr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xrandr.c b/xrandr.c index e08a7d6..c51bee3 100644 --- a/xrandr.c +++ b/xrandr.c @@ -3266,13 +3266,13 @@ main (int argc, char **argv) nelements

[PATCH:drm 2/4] Only define variable when it's used.

Signed-off-by: Thomas Klausner w...@netbsd.org --- intel/test_decode.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/intel/test_decode.c b/intel/test_decode.c index b710f34..f9127cf 100644 --- a/intel/test_decode.c +++ b/intel/test_decode.c @@ -90,7 +90,10

[PATCH:drm 4/4] Add missing header includes.

unistd.h for close() and xf86drm.h for drmOpen(). Signed-off-by: Thomas Klausner w...@netbsd.org --- tests/radeon/radeon_ttm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/radeon/radeon_ttm.c b/tests/radeon/radeon_ttm.c index 246fd99..ac3297a 100644 --- a/tests/radeon/radeon_ttm.c

[PATCH:drm 3/4] Remove unused static function.

Signed-off-by: Thomas Klausner w...@netbsd.org --- nouveau/bufctx.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/nouveau/bufctx.c b/nouveau/bufctx.c index 23d6f09..4f76e5d 100644 --- a/nouveau/bufctx.c +++ b/nouveau/bufctx.c @@ -44,12 +44,6 @@ struct nouveau_bufref_priv

[PATCH:drm 1/4] Remove superfluous parentheses.

Signed-off-by: Thomas Klausner w...@netbsd.org --- radeon/radeon_surface.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/radeon/radeon_surface.c b/radeon/radeon_surface.c index 15127d4..101c8f3 100644 --- a/radeon/radeon_surface.c +++ b/radeon

Re: [PATCH:xf86-input-mouse 4/4] For wsmouse, keep 3-button emulation status.

Hi Alan! Thanks for the review. On Tue, Mar 25, 2014 at 05:32:17PM -0700, Alan Coopersmith wrote: On 08/19/13 02:14 AM, Thomas Klausner wrote: With a multiplexed device like wsmouse it does not make sense to kill emulate3buttons on the first button-3-pressed event. The button-3 pressed may

Re: [PATCH:xf86-input-mouse 3/4] Make wsmouse (re-)init the version.

On Tue, Mar 25, 2014 at 05:33:25PM -0700, Alan Coopersmith wrote: On 08/19/13 02:14 AM, Thomas Klausner wrote: This makes sure that the xserver and the mouse speak the same protocol version. From Matthew R. Green m...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- src

different sign warning in libX11

Hi! clang's unhappy: src/ModMap.c:86:15: error: passing 'KeyCode *' (aka 'unsigned char *') to parameter of type 'const char *' converts between pointers to integer types with different sign [-Werror,-Wpointer-sign] Data(dpy, modifier_map-modifiermap, mapSize);

bug in xman/handler.c: array compared to NULL

Hi! clang rightfully complains about this code in handler.c: void SaveFormattedPage(Widget w, XEvent * event, String * params, Cardinal * num_params) { ManpageGlobals *man_globals; char cmdbuf[BUFSIZ], error_buf[BUFSIZ]; if (*num_params != 1) {

Re: [PATCH xf86-video-vmware] configure: fix build without xatracker

On Tue, Apr 01, 2014 at 10:11:13AM +0200, Julien Cristau wrote: ACTION-IF-NOT-FOUND is the fourth argument to PKG_CHECK_MODULES, not the fifth. Debian bug#743239 https://bugs.debian.org/743239 Reviewed-by: Thomas Klausner w...@netbsd.org Signed-off-by: Julien Cristau jcris...@debian.org

xauth warning: WRITES macro

Hi! clang doesn't like the WRITES macro xauth uses: process.c:867:3: warning: if statement has empty body [-Wempty-body] WRITES(STDERR_FILENO, \n); ^ process.c:641:57: note: expanded from macro 'WRITES' #define WRITES(fd, S) {if(write((fd), (S), strlen((S;}

[PATCH:libXfont] Fix functions to match X11/fonts/font.h prototypes.

Signed-off-by: Thomas Klausner w...@netbsd.org --- src/util/patcache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/patcache.c b/src/util/patcache.c index 2101015..5efe258 100644 --- a/src/util/patcache.c +++ b/src/util/patcache.c @@ -128,7 +128,7 @@ Hash

Re: [PATCH:libXfont] Fix functions to match X11/fonts/font.h prototypes.

Hm, that's the patch I need when compiling against fontsproto-2.1.2. Ignore it. So we have libXfont-1.4.7 only compiling against fontsproto-2.1.2 and not fontsproto-2.1.3, but no release for 2.1.3 yet. Thomas On Tue, Apr 15, 2014 at 06:41:35PM +0200, Thomas Klausner wrote: Signed-off

Re: [PATCH:libXfont 2/2] Require fontsproto 2.1.3 for matching function prototypes

For the series: Reviewed-by: Thomas Klausner w...@netbsd.org Thomas On Sun, Apr 20, 2014 at 06:23:40PM -0700, Alan Coopersmith wrote: Building current libXfont git against fontsproto 2.1.2 causes clang complaints of: patcache.c:130:1: error: conflicting types for 'CacheFontPattern

Re: [PATCH:libXfont-1.4 v2] Require fontsproto 2.1.3 for matching function prototypes

Looks good. Reviewed-By: Thomas Klausner w...@netbsd.org On Mon, Apr 21, 2014 at 07:31:59AM -0700, Alan Coopersmith wrote: Building libXfont-1.4.x against fontsproto 2.1.3 causes clang complaints of: patcache.c:130:1: error: conflicting types for 'CacheFontPattern' CacheFontPattern

[PATCH:xman 2/2] Fix shadow warning.

Signed-off-by: Thomas Klausner w...@netbsd.org --- handler.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/handler.c b/handler.c index 87a928e..fec793d 100644 --- a/handler.c +++ b/handler.c @@ -587,17 +587,17 @@ Search(Widget w, XEvent * event, String * params

[PATCH:xman 1/2] Fix tautology to the intended check.

From: Jörg Sonnenberger jo...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- handler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/handler.c b/handler.c index e61687e..87a928e 100644 --- a/handler.c +++ b/handler.c @@ -320,7 +320,7 @@ SaveFormattedPage

Re: [PATCH:xman 1/2] Fix tautology to the intended check.

On Fri, May 23, 2014 at 10:10:19AM +0200, walter harms wrote: Am 23.05.2014 07:44, schrieb Alan Coopersmith: On 05/21/14 03:17 PM, Thomas Klausner wrote: From: Jörg Sonnenberger jo...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- handler.c | 2 +- 1 file

Re: [PATCH:drm 1/4] Remove superfluous parentheses.

Can someone please review this series? (I can push it myself.) Thanks, Thomas On Sun, Mar 30, 2014 at 02:26:47PM +0200, Thomas Klausner wrote: Signed-off-by: Thomas Klausner w...@netbsd.org --- radeon/radeon_surface.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions

Re: [PATCH:drm 1/4] Remove superfluous parentheses.

On Sat, Jul 12, 2014 at 12:46:15PM -0700, Alan Coopersmith wrote: On 07/12/14 07:46 AM, Thomas Klausner wrote: Can someone please review this series? (I can push it myself.) You might find more interested parties on dri-devel than on xorg-devel. Thank you for the hint, I've just sent

Re: [PATCH:libXaw] Fix abs() usage.

Review please! Thanks, Thomas On Wed, Mar 19, 2014 at 08:52:46AM +0100, Thomas Klausner wrote: From: Jörg Sonnenberger jo...@netbsd.org For long arguments, use labs(). Signed-off-by: Thomas Klausner w...@netbsd.org --- src/Text.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH:libXaw] Fix abs() usage.

On Wed, Jul 16, 2014 at 03:50:35PM -0700, Matt Turner wrote: On Wed, Jul 16, 2014 at 9:44 AM, Thomas Klausner w...@netbsd.org wrote: Review please! Thanks, Thomas Reviewed-by: Matt Turner matts...@gmail.com Please apply to libXaw3d as well. Thanks for the review. I've fixed

[PATCH:libpciaccess] Implement the kernel_has_driver() method for NetBSD.

From: Matthew Green m...@netbsd.org This has the benefit of stopping the vesa driver from loading on hardware that has been claimed by a kernel driver and thus shouldn't be using vesa. Signed-off-by: Thomas Klausner w...@netbsd.org --- src/netbsd_pci.c | 24 1 file

Re: [PATCH] Update manpage with the proper location of system.twmrc file

On Mon, Aug 04, 2014 at 04:48:58PM +0200, walter harms wrote: Am 04.08.2014 16:39, schrieb Laurent Carlier: Signed-off-by: Laurent Carlier lordhea...@gmail.com --- man/Makefile.am | 2 ++ man/twm.man | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH:xf86-video-vmware] Add 2560x1440 to supported resolutions.

Native resolution on iMac 27. Reported missing by Benjamin Lorenz in http://gnats.netbsd.org/49094 Signed-off-by: Thomas Klausner w...@netbsd.org --- src/svga_modes.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/svga_modes.h b/src/svga_modes.h index 97d869e..c3aa1a3 100644 --- a/src

[PATCH] Fix format string.

From: Joerg Sonnenberger jo...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- hw/xfree86/os-support/bsd/ppc_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/os-support/bsd/ppc_video.c b/hw/xfree86/os-support/bsd/ppc_video.c index 947a686

[PATCH:xf86-video-ast] Use proper type.

Two other places in this file already use uint32_t when passing it to PCI_READ_LONG. Signed-off-by: Thomas Klausner w...@netbsd.org --- src/ast_vgatool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ast_vgatool.c b/src/ast_vgatool.c index d028ad7..7e96d2b 100644

Re: [PATCH:libpciaccess] Implement the kernel_has_driver() method for NetBSD.

On Sat, Aug 30, 2014 at 09:37:47PM +0200, Matthieu Herrb wrote: B0;309;0cOn Sat, Jul 26, 2014 at 10:10:28PM +0200, Thomas Klausner wrote: From: Matthew Green m...@netbsd.org This has the benefit of stopping the vesa driver from loading on hardware that has been claimed by a kernel driver

[bug 50940] sessreg-1.0.7: Compilation error in sessreg.c -- undefined *TMPX paths

Jeremy Huddleston has asked me to send the patch I submitted for the bug report in the subject to this list for review. My bug report was: Compilation of sessreg-1.0.7 on NetBSD-6.99.7/amd64 fails with: --- sessreg.o --- CC sessreg.o sessreg.c:257:16: error: use of undeclared identifier

Integrating NetBSD patches?

Hi! I'm currently looking at migrating the changes NetBSD has in its copy of xorg in the NetBSD CVS tree into pkgsrc. (Just to get an overview if I'll manage to do that or if it's too much effort). This means extracting all the local patches. I guess that most of these haven't been fed upstream

Re: Integrating NetBSD patches?

On Tue, Jul 10, 2012 at 01:22:26PM -0700, Keith Packard wrote: They'd need to be rebased on top of the current development branches of each repository. That can vary from trivial to a huge amount of work. Starting with simple fixes to learn where the pitfalls are is probably a good idea. Ok,

[PATCH] Do not unconditionally define DEBUG.

--- lisp/re/re.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/re/re.c b/lisp/re/re.c index fca7e28..f4c1246 100644 --- a/lisp/re/re.c +++ b/lisp/re/re.c @@ -31,7 +31,7 @@ #include stdio.h #include rep.h -#define DEBUG + /* * Types */ -- 1.7.11.1

Patches from NetBSD's xsrc

The simplest patch I could find first, for xedit: [PATCH] Do not unconditionally define DEBUG. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[xinit] XSLASHGLOB

Hi! While looking at NetBSD xsrc patches I found one for xinit. Index: xinit/dist/xinitrc.cpp === RCS file: /cvsroot/xsrc/external/mit/xinit/dist/xinitrc.cpp,v retrieving revision 1.1.1.3 retrieving revision 1.2 diff -u -r1.1.1.3

[xkbdata] colemak support

Another patch to NetBSD xsrc adds Colemak data to xkbdata. The files are marked: 2006-01-01 Shai Coleman, http://colemak.com/ . Public domain. so they should be safe to include. I didn't find an anongit repository for xkbdata, so the two files are added as attachment with corresponding

[PATCH libFS] Fix a prototype error

Another simple fix, this time for libFS -- a broken prototype. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH libFS] Fix a prototype error

Per NetBSD PR 41899 from Henning Petersen. Signed-off-by: Thomas Klausner w...@netbsd.org --- src/FSlibInt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/FSlibInt.c b/src/FSlibInt.c index db9cc47..a04d3cd 100644 --- a/src/FSlibInt.c +++ b/src/FSlibInt.c @@ -1194,7

[PATCH xman] avoid PIC macro

Lots of compiler setting recommendations include -DPIC -fPIC for compiling position-independent code. This patch avoids a problem with that in xman. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

[PATCH] Rename PIC to XMAN_PIC to avoid problems with -DPIC compilations.

Signed-off-by: Thomas Klausner w...@netbsd.org --- misc.c | 2 +- vendor.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/misc.c b/misc.c index 8818aa8..7592996 100644 --- a/misc.c +++ b/misc.c @@ -764,7 +764,7 @@ ConstructCommand(cmdbuf, path, filename, tempfile

Re: [xkbdata] colemak support

On Thu, Jul 12, 2012 at 06:51:04AM -0700, Alan Coopersmith wrote: xkbdata is long dead - xkeyboard-config replaced it shortly after the X11R7.0 release. Thanks for the info. Upon checking further, NetBSD has already switched to xkeyboard-config (in 2009 or so) but just didn't remove xkbdata

Re: [PATCH] Do not unconditionally define DEBUG.

On Wed, Jul 11, 2012 at 05:56:45PM -0700, Alan Coopersmith wrote: Works for me. Applied pushed to git master: To ssh://git.freedesktop.org/git/xorg/app/xedit 33dacad..ce36f7b master - master Thank you! As Matt noted, please include the module name in the [PATCH module] header for

[PATCH xman] Changed patch after suggestion by Walter Harms

The same patch as before, but with s/XMAN/ROFF/ -- pick either version :) [PATCH] Rename PIC to ROFF_PIC to avoid problems with -DPIC ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

[PATCH] Rename PIC to ROFF_PIC to avoid problems with -DPIC compilations. From Christos Zoulas chris...@netbsd.org.

Signed-off-by: Thomas Klausner w...@netbsd.org --- misc.c | 2 +- vendor.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/misc.c b/misc.c index 8818aa8..abe410e 100644 --- a/misc.c +++ b/misc.c @@ -764,7 +764,7 @@ ConstructCommand(cmdbuf, path, filename, tempfile

Re: [PATCH] Rename PIC to XMAN_PIC to avoid problems with -DPIC compilations.

On Thu, Jul 12, 2012 at 07:00:52PM +0200, walter harms wrote: I see, to be fair i do not know the code but the names are roff/nroff precompiler therefore i would expect a name like roff_pic. Fine with me, I've just resent the patch with the change as suggested. Pick either, I don't really

libdrm-2.4.37: use ETIMEDOUT instead of ETIME?

Hi! libdrm-2.4.37 added a use of ETIME (from errno(3)) in intel/intel_bufmgr_gem.c. This errno is not defined on (at least) DragonFly BSD. A Linux man page for errno(3) says: ETIME Timer expired (POSIX.1 (XSI STREAMS option)) (POSIX.1 says STREAM

Re: libdrm-2.4.37: use ETIMEDOUT instead of ETIME?

On Tue, Jul 17, 2012 at 07:02:56AM -0700, Matt Turner wrote: On Mon, Jul 16, 2012 at 11:34 AM, Thomas Klausner w...@netbsd.org wrote: libdrm-2.4.37 added a use of ETIME (from errno(3)) in intel/intel_bufmgr_gem.c. This errno is not defined on (at least) DragonFly BSD. A Linux man page

Re: libdrm-2.4.37: use ETIMEDOUT instead of ETIME?

On Tue, Jul 17, 2012 at 12:04:26PM -0700, Matt Turner wrote: I was asking mostly out of curiosity, but at the same time I don't think compiling this (libdrm_intel) is useful without KMS. Ok, that might be. So unless I'm wrong on that point I've got to question why you're bothering to ship

[PATCH:libXv] Uppercase SH arguments.

Signed-off-by: Thomas Klausner w...@netbsd.org --- man/XvListImageFormats.man | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/man/XvListImageFormats.man b/man/XvListImageFormats.man index c5159e5..51e5a2e 100644 --- a/man/XvListImageFormats.man +++ b/man

Re: [PATCH] Do not unconditionally define DEBUG.

On Mon, Jul 16, 2012 at 10:26:37PM -0700, Alan Coopersmith wrote: Sorry, that's what I get for relying on memory instead of testing - the = was a mistake, it should be a space, as in: git config format.subjectprefix PATCH:xscope (actually tested this time to be sure) Ok, thanks, that

[PATCH:libXt 1/2] Avoid referencing something that isn't defined. Bring in the definition from another manual page.

From Quentin Garnier c...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- man/XtAppCreateShell.man | 1 + 1 file changed, 1 insertion(+) diff --git a/man/XtAppCreateShell.man b/man/XtAppCreateShell.man index 3d09f88..73218e6 100644 --- a/man/XtAppCreateShell.man +++ b/man

[PATCH:libXt 2/2] Fix DEBUG build (TMparse.c:376:1: error: overflow in implicit constant conversion)

From Christos Zoulas chris...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- src/TMparse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/TMparse.c b/src/TMparse.c index d233644..5594cad 100644 --- a/src/TMparse.c +++ b/src/TMparse.c @@ -372,8 +372,8

[PATCH:libXTrap] Fix memset usage.

From Joerg Sonnenberger jo...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- src/XEConTxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/XEConTxt.c b/src/XEConTxt.c index e2dff16..d075c4f 100644 --- a/src/XEConTxt.c +++ b/src/XEConTxt.c @@ -69,7 +69,7

[PATCH:libXext] Avoid having macros expand code to be: ((f) ? (f)-m1 : NULL)-m2

From Matthew R. Green m...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- src/XSync.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/XSync.c b/src/XSync.c index df7c435..5775293 100644 --- a/src/XSync.c +++ b/src/XSync.c @@ -107,8 +107,8 @@ static

Re: [PATCH:libXTrap] Fix memset usage.

On Fri, Jul 20, 2012 at 08:40:26AM +0200, Rémi Cardona wrote: Le 18/07/2012 16:47, Thomas Klausner a écrit : -(void)memset(tc,0L,sizeof(tc)); +(void)memset(tc,0L,sizeof(*tc)); I'd say you might as well drop the useless cast too. There are twelve memsets with casts, only

libXTrap patches

Original patch, marked as reviewed, and memset cleanup requested by Rémi Cardona. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH:libXTrap 1/2] Fix memset usage.

From Joerg Sonnenberger jo...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org Reviewed-by: Rémi Cardona remi.card...@free.fr --- src/XEConTxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/XEConTxt.c b/src/XEConTxt.c index e2dff16..d075c4f 100644 --- a/src

[PATCH:libXTrap 2/2] Remove unnecessary memset return value casts to void.

Signed-off-by: Thomas Klausner w...@netbsd.org --- src/XEConTxt.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/XEConTxt.c b/src/XEConTxt.c index d075c4f..531ced2 100644 --- a/src/XEConTxt.c +++ b/src/XEConTxt.c @@ -69,7 +69,7 @@ XETC

Re: [PATCH:libXTrap] Fix memset usage.

On Fri, Jul 20, 2012 at 09:32:10PM +0200, Rémi Cardona wrote: It's definitely worth an extra patch if it's more widespread than just this bit. Ok, done and sent. In any case, the previous patch is: Reviewed-by: Rémi Cardona remi.card...@free.fr Thanks, noted in the new version of the

NetBSD patches: how to move forward

Hi! No comments and no commits for my patches in the last week. Is there a procedure I should follow so these don't get dropped, or should I just be more patient because it's holiday season? :) Should I keep sending patches in the meantime? (Lots more to come.) Thanks, Thomas

Re: NetBSD patches: how to move forward

On Mon, Jul 30, 2012 at 03:50:39PM -0700, Alan Coopersmith wrote: Even during non-holiday seasons, patience is advisable for patches outside the well-maintained areas (Xserver, active drivers). There's only a few of us who go through the rest so we try not to let stuff slip through, even if we

Fix build on NetBSD-5

Fix compilation on systems that don't provide O_CLOEXEC. I wonder if it will work as intended, or if more is needed. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

[PATCH:xrdb] Add a command line flag -cppargs which allows passing arguments to cpp (while still complying with the access(2) check for the cpp executable).

See thread starting at http://mail-index.netbsd.org/tech-x11/2009/12/01/msg000687.html --- man/xrdb.man | 4 xrdb.c | 27 +++ 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/man/xrdb.man b/man/xrdb.man index e30b0d5..d024210 100644 ---

New keyboard config files for some Sharp hardware

Keyboard config files for 5 Sharp machines, from Nonaka Kimihiro non...@netbsd.org. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH:xkeyboard-config 1/4] Added keyboard config files for Sharp Zaurus SL-C3x00.

From: Nonaka Kimihiro non...@netbsd.org --- symbols/sharp_vndr/sl-c3x00 | 74 + 1 file changed, 74 insertions(+) create mode 100644 symbols/sharp_vndr/sl-c3x00 diff --git a/symbols/sharp_vndr/sl-c3x00 b/symbols/sharp_vndr/sl-c3x00 new file mode

[PATCH:xkeyboard-config 3/4] Added keyboard config files for Sharp WS011SH/WS020SH.

From: Nonaka Kimihiro non...@netbsd.org --- symbols/sharp_vndr/ws011sh | 78 ++ symbols/sharp_vndr/ws020sh | 67 +++ 2 files changed, 145 insertions(+) create mode 100644 symbols/sharp_vndr/ws011sh create mode

[PATCH:xkeyboard-config 2/4] Added keyboard config files for Sharp WS003SH/WS007SH.

From: Nonaka Kimihiro non...@netbsd.org --- symbols/sharp_vndr/ws003sh | 73 ++ symbols/sharp_vndr/ws007sh | 73 ++ 2 files changed, 146 insertions(+) create mode 100644 symbols/sharp_vndr/ws003sh create

[PATCH:xkeyboard-config 4/4] Hook new Sharp keyboard config files into the build.

From: Nonaka Kimihiro non...@netbsd.org --- configure.in | 1 + rules/base.ml_s.part | 5 + symbols/sharp_vndr/Makefile.am | 8 3 files changed, 14 insertions(+) create mode 100644 symbols/sharp_vndr/Makefile.am diff --git a/configure.in b/configure.in

xwininfo: const in iconv

When compiling xwininfo on NetBSD, I get: xwininfo.c:1912:6: warning: passing argument 2 of 'iconv' from incompatible pointer type /usr/include/iconv.h:46:8: note: expected 'const char ** restrict' but argument is of type 'char **' In NetBSD's xsrc we use the attached patch to fix this. I

Re: xwininfo: const in iconv

On Fri, Aug 24, 2012 at 06:14:20PM -0700, Alan Coopersmith wrote: I think that's already taken care of via the AM_ICONV autoconf macro that checks for the constness of the pointer and sets ICONV_CONST appropriately, but we don't seem to have released a tarball with that fix (commit

[PATCH:xwininfo] Get rid of a number of warnings. Signed-off-by: Thomas Klausner w...@netbsd.org

--- xwininfo.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/xwininfo.c b/xwininfo.c index f1126e6..a9f1e96 100644 --- a/xwininfo.c +++ b/xwininfo.c @@ -251,7 +251,7 @@ static Bool window_id_format_dec = False; static iconv_t

Re: xwininfo: const in iconv

On Sat, Aug 25, 2012 at 10:51:10AM -0700, Alan Coopersmith wrote: These are the lines: xwininfo.c:static xcb_screen_t *screen; xwininfo.c:scale_init (xcb_screen_t *screen) Patch attached. Looks good to me. xwininfo.c: In function ‘wm_size_hints_reply’: xwininfo.c:707:40:

Re: New keyboard config files for some Sharp hardware

On Thu, Aug 23, 2012 at 08:05:44AM -0700, Alan Coopersmith wrote: On 08/23/12 08:00 AM, Thomas Klausner wrote: Keyboard config files for 5 Sharp machines, from Nonaka Kimihiro non...@netbsd.org. xkeyboard-config has it's own mailing list for patch submission: http://www.freedesktop.org

[PATCH:xwininfo 2/2] Mark usage() as not returning.

Signed-off-by: Thomas Klausner w...@netbsd.org --- xwininfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xwininfo.c b/xwininfo.c index a9f1e96..34d7702 100644 --- a/xwininfo.c +++ b/xwininfo.c @@ -278,6 +278,7 @@ static size_t strlcat (char *dst, const char *src, size_t dstsize

Re: xwininfo: const in iconv

On Sat, Aug 25, 2012 at 04:29:48PM -0700, Alan Coopersmith wrote: On 08/25/12 03:11 PM, Thomas Klausner wrote: I've just sent a patch to the mailing list which fixes all but two of them. xwininfo.c: In function ‘usage’: xwininfo.c:282:1: warning: function might be possible candidate

xcursor-themes - why no index.theme files?

Subject basically says it, but: Why are no index.theme file installed for the cursor themes from xcursor-themes? Thomas ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: xcursor-themes - why no index.theme files?

On Fri, Sep 21, 2012 at 11:38:44AM +0200, Alan Coopersmith wrote: On 09/20/12 10:45 PM, Thomas Klausner wrote: Subject basically says it, but: Why are no index.theme file installed for the cursor themes from xcursor-themes? Because no one submitted a patch to add them? It's hard to know

Re: xcursor-themes - why no index.theme files?

On Fri, Sep 21, 2012 at 11:55:57AM +0200, Alan Coopersmith wrote: They work fine for me without the index.theme with libXcursor in the GNOME 2.x Appearance preferences. Perhaps something else has added a index.themes requirement without telling us? Or perhaps I'm setting it up incorrectly.

Re: fd passing for X

On Fri, Oct 05, 2012 at 01:46:57PM -0700, Keith Packard wrote: I did a bunch of experiments with fd passing in Linux to see how it might work in X. Do you have a test program I could run on NetBSD to see if it works there as well? Thomas ___

  1   2   3   4   5   >