[PATCH xserver v2 4/4] glx: honor LIBGL_DRIVERS_PATH when loading DRI drivers

2018-03-13 Thread Ben Crocker
Hähnle <nicolai.haeh...@amd.com> Reviewed-by: Ben Crocker <bcroc...@redhat.com> Reviewed-by: Antoine Martin <anto...@nagafix.co.uk> Tested-by: Ben Crocker <bcroc...@redhat.com> --- glx/glxdricommon.c | 38 ++ 1 file changed, 34 insertions(+), 4

[PATCH xserver v2 2/4] os: use PrivsElevated instead of a manual check

2018-03-13 Thread Ben Crocker
From: Nicolai Hähnle <nicolai.haeh...@amd.com> Signed-off-by: Nicolai Hähnle <nicolai.haeh...@amd.com> Reviewed-by: Ben Crocker <bcroc...@redhat.com> Reviewed-by: Antoine Martin <anto...@nagafix.co.uk> Tested-by: Ben Crocker <bcroc...@redhat.com> --- os/uti

[PATCH xserver v2 1/4] os: move xf86PrivsElevated here

2018-03-13 Thread Ben Crocker
From: Nicolai Hähnle <nicolai.haeh...@amd.com> Having different types of code all trying to check for elevated privileges is a bad idea. This implementation is the most thorough one. Signed-off-by: Nicolai Hähnle <nicolai.haeh...@amd.com> Reviewed-by: Ben Crocker <bcroc...@redha

[PATCH xserver v2 0/4] Improve elevated priv check, honor LIBGL_DRIVERS_PATH

2018-03-13 Thread Ben Crocker
Submit Nicolai Hähnle's four-patch series improving the checks for elevated privileges and culminating in using the runtime environmental control LIBGL_DRIVERS_PATH when searching for driver .so's, as Mesa, and hence Glamor, already do. The fourth patch prevents a conflict that can arise if, for

[PATCH xserver v2 3/4] xfree86: replace all uses of xf86PrivsElevated with PrivsElevated

2018-03-13 Thread Ben Crocker
From: Nicolai Hähnle <nicolai.haeh...@amd.com> Signed-off-by: Nicolai Hähnle <nicolai.haeh...@amd.com> Reviewed-by: Ben Crocker <bcroc...@redhat.com> Reviewed-by: Antoine Martin <anto...@nagafix.co.uk> Tested-by: Ben Crocker <bcroc...@redhat.com> --- hw/xfree86/c

Re: [xserver,1/4] os: move xf86PrivsElevated here

2018-03-13 Thread Ben Crocker
Antoine, thanks for the suggestion and the additional review. V2 patch series forthcoming. -- Ben On Sat, Mar 10, 2018 at 11:58 PM, Antoine Martin <anto...@nagafix.co.uk> wrote: > On 09/03/18 05:11, Ben Crocker wrote: > > Sent that a little too soon; please consider "Revi

Re: [xserver,1/4] os: move xf86PrivsElevated here

2018-03-08 Thread Ben Crocker
Sent that a little too soon; please consider "Reviewed-by: Ben Crocker < bcroc...@redhat.com>" to be added after each of the "Signed-off-by: Nicolai Haehnle < nicolai.haeh...@amd.com>" lines. Also please note that I rebased Nicolai's original patch, https://patchw

[xserver,1/4] os: move xf86PrivsElevated here

2018-03-08 Thread Ben Crocker
From: Nicolai Hähnle From: Nicolai Hähnle Having different types of code all trying to check for elevated privileges is a bad idea. This implementation is the most thorough one. Signed-off-by: Nicolai Hähnle ---

[PATCH xserver] Fix a segfault that occurs if xorg.conf.d is absent:

2016-11-15 Thread Ben Crocker
#include "xf86Config.h". In xf86readConfigFile, change the open-code call to calloc to a call to the new xf86allocateConfig function. In xf86AutoConfig.c, add a call to the new xf86allocateConfig function to the beginning of xf86AutoConfig to make sure the XF86ConfigRec struct is allocated.