Re: [PATCH xserver] modesetting: Fix and improve ms_kernel_msc_to_crtc_msc()

ting: Remove ms_crtc_msc_to_kernel_msc()." applied to master first. That one should also apply to 1.19, but this one is for 1.20 only. -mario > On Sun, 6 May 2018 at 06:35 Mario Kleiner <mario.kleiner...@gmail.com> > wrote: >> >> The old 32-Bit wraparound handling didn't

Re: [Mesa-dev] [RFC] Fix attempt for Mesa + X-Server 1.20 + modesetting-ddx hangs on KDE5.

a last weekend where i bisected this issue and did > not recheck when opening the actual bugreport (sorry for that) > > [1] https://bugs.freedesktop.org/show_bug.cgi?id=106372 > > Greetings, > > Tobias > > > > On 5/4/18 3:45 PM, Mario Kleiner wrote: >> >>

[PATCH xserver] modesetting: Fix and improve ms_kernel_msc_to_crtc_msc()

this seems to be broken for at least server 1.16 to 1.19. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Adam Jackson <a...@redhat.com> Cc: Keith Packard <kei...@keithp.com> Cc: Michel Dänzer <michel.daen...@amd.com> --- hw/xfree86/drivers/modesetting/dr

Re: [Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

On Sat, May 5, 2018 at 4:44 PM, Roman Gilg wrote: > Without this patch plasmashell on Xserver/Mesa master freezes on me > when opening the launcher menu (Kickoff). With the patch haven't > experienced freezes yet. > > Haven't tested the Steam client yet. Might be a different

Re: [PATCH xserver] modesetting: Remove ms_crtc_msc_to_kernel_msc().

lve the same problem for mapping 32-bit sbc to 64-bit sbc and dealing with wraparound. Just to say, maybe wait a little bit longer with server 1.20 release to get this fixed. thanks, -mario On Fri, May 4, 2018 at 2:41 PM, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Mario, > > On

Re: [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

On Sat, May 5, 2018 at 4:08 AM, Mike Lothian wrote: > I definately saw the steam bug with patch 1 but not with plasmashell, > I started seeing it with patch 2 but it seemed to fix itself > I had two hangs of kwin_x11 within the last 6 hours when alt-tabbing between windows,

Re: [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

uot;, > draw->width, draw->height, draw->drawable, draw->eid); >^~ > ../mesa-/src/loader/loader_dri3_helper.c:1454:7: note: include > ‘’ or provide a declaration of ‘printf’ > cc1: some warnings being treated as errors > > Cheers > > Mike > >

Re: [PATCH xserver] modesetting: Remove ms_crtc_msc_to_kernel_msc().

team freezes on itself? -mario > Cheers > > Mike > > On 4 May 2018 at 14:02, Mario Kleiner <mario.kleiner...@gmail.com> wrote: >> Hi Daniel, Eero, >> >> On Fri, May 4, 2018 at 2:41 PM, Daniel Stone <dan...@fooishbar.org> wrote: >>> Hi Mario, >>&

Re: [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

anks for looking into this issue :D >> >> Tested-by: Mike Lothian <m...@fireburn.co.uk> >> >> I'll give the other patch a whirl now >> >> Cheers >> >> Mike >> >> On 4 May 2018 at 14:45, Mario Kleiner <mario.kleiner...@gmail.com>

[PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

completed, to prevent misdelivery of PresentNotify events to the right X-Window, but the wrong incarnation of the associated loader_dri3_drawable. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: xorg-devel@lists.x.org Cc: dan...@fooishbar.org Cc: eero.t.tammi...@intel.com

[RFC] Fix attempt for Mesa + X-Server 1.20 + modesetting-ddx hangs on KDE5.

Two patches, solving the same problem in two different ways, the 1st one ready to go, the 2nd one would need the debug statements removed. Only apply one of those for testing, the 2nd one will be useless with the 1st one applied, but demonstrates the problem. So X-Server 1.20 RC +

[PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

voke the occassional ORPHAN event. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: xorg-devel@lists.x.org Cc: dan...@fooishbar.org Cc: eero.t.tammi...@intel.com Cc: m...@fireburn.co.uk --- src/loader/loader_dri3_helper.c | 24 1 file changed, 24 inser

Re: [PATCH xserver] modesetting: Remove ms_crtc_msc_to_kernel_msc().

Hi Daniel, Eero, On Fri, May 4, 2018 at 2:41 PM, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Mario, > > On 4 May 2018 at 13:14, Mario Kleiner <mario.kleiner...@gmail.com> wrote: >> Indeed, i found a Mesa bug yesterday which can cause Mesa's >> PresentPixmap r

Re: last call for 1.20 (was Re: [PATCH xserver] present: fix msc offset calculation in window mode)

Hi ajax, this one just sent out: "[PATCH xserver] modesetting: Remove ms_crtc_msc_to_kernel_msc().", should really make it into server 1.20, as it did bad things during my testing yesterday. Looking at the counterpart ms_kernel_msc_to_crtc_msc() in current modesetting-ddx makes me a bit nervous

[PATCH xserver] modesetting: Remove ms_crtc_msc_to_kernel_msc().

mit is one major source of the extra fragility. Also my own tests fail for any swap scheduled more than 1000 vblanks into the future, which is not uncommon for some scientific applications. Iow. modesetting's swap scheduling seems to be more robust without this function afaics. Signed-off-b

Re: [PATCH xserver] xwayland: Avoid using epoxy_has_egl()

XT_device_base"); > + return epoxy_has_egl_extension(NULL, "EGL_EXT_device_base"); > } > Reviewed-by: Mario Kleiner <mario.kleiner...@gmail.com> ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] dri3: Fix DRI3.2 support for drivers other than modesetting-ddx.

On Wed, Apr 25, 2018 at 2:23 AM, Mike Lothian wrote: > > The plasmashell & steam freezes aren't present with the Intel or AMDGPU > DDXs, only modesetting > > I'm quite happy to mark https://bugs.freedesktop.org/show_bug.cgi?id=105851 > as resolved and look into the

[PATCH xserver 2/4] dri3: Robustly clamp to 1.0 if not all screens support 1.2

n't support the v1.2 hooks. Make sure all hooks are defined before reporting v1.2. Also make clamping of reported version to minimum of client or server robust against possible future clients with possible majorVersion >= 2.0. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc:

[PATCH xserver 4/4] modesetting: Don't leak gbm_bo's in ms_present_check_flip().

Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Daniel Stone <dani...@collabora.com> Cc: Adam Jackson <a...@redhat.com> --- hw/xfree86/drivers/modesetting/present.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/xfree86/drivers/modesetting/present.c b/

[PATCH xserver 3/4] glamor: Don't fail in glamor_get_formats if not dmabuf_capable.

he current server generation, instead of pointless retesting at every invocation. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> --- glamor/glamor_egl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index 9edb509

[PATCH xserver 1/4] dri3: Fix error handling in dri3_buffer_from_pixmap request.

ddm-greeter to start up under nouveau-ddx with DRI3 enabled and DRI3 protocol version properly clamped to 1.0 by the server (see followup patch). Fixes: 75bba3aedcb0 ("dri3: Use single-FD screen call for single-FD request") Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc:

Re: [PATCH xserver 3/3] xwayland: Add glamor egl_backend for EGLStreams

Mini bug report: My build of server 1.20-rc5 now fails on Ubuntu 16.04 due to lack of epoxy_has_egl(): CC Xwayland-xwayland-glamor.o xwayland-glamor.c: In function ‘xwl_glamor_egl_supports_device_probing’: xwayland-glamor.c:58:12: error: implicit declaration of function ‘epoxy_has_egl’

Re: [PATCH xserver] dri3: Fix DRI3.2 support for drivers other than modesetting-ddx.

On Wed, Apr 25, 2018 at 8:50 PM, Adam Jackson wrote: > On Wed, 2018-04-25 at 00:23 +, Mike Lothian wrote: > >> Hi Mario >> >> Thanks for fixing this, that's xserver 1.20 working with the Intel and >> AMDGPU DDXs on my laptop with Kwin >> >> The plasmashell & steam freezes

[PATCH xserver] dri3: Fix DRI3.2 support for drivers other than modesetting-ddx.

Ivybridge and NVidia Pascal. Fixes: 6e7c40f62db6 ("dri3: Add multi-planar/modifier buffer requests") Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Daniel Stone <dani...@collabora.com> Cc: Louis-Francis Ratté-Boulianne <l...@collabora.com> --- dri3/d

[PATCH xserver] modesetting: Only use modifiers on kms drivers which do support them.

an use it unconditionally. Tested on intel-kms, radeon-kms, nouveau-kms. Fixes failure on NVidia Pascal. Fixes: 2f807c2324b4 ("modesetting: Add support for multi-plane pixmaps when page-flipping") Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Daniel Stone <

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

der weston + Xwayland either so far, just wanted to get something out before going to bed. But the bug that is fixed in this patch is so obvious, once discovered, it could only make things work worse by "unblocking" other so far dormant bugs :) -mario > Cheers > > Mike > &

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

Hi again, with the fresh x-server patch i just sent out, the EGL + DRI3 problems under KDE are gone, at least as tested on an old Intel Ironlake and GeForce Tesla. I still see some more problems beyond those, which may or may not be related to the new DRI3.1/3.2 stuff. On KDE-5 the KDE panel

[PATCH xserver] dri3: Fix dri3_buffers_from_pixmap request.

uffer requests") Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Daniel Stone <dani...@collabora.com> Cc: Louis-Francis Ratté-Boulianne <l...@collabora.com> --- dri3/dri3_request.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dri3/dri3_req

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

> wrote: > Hi Mario, > > On 4 April 2018 at 17:40, Mario Kleiner <mario.kleiner...@gmail.com> wrote: >> On Wed, Apr 4, 2018 at 6:19 PM, Daniel Stone <dan...@fooishbar.org> wrote: >>> Ugh. I've applied your pageflip patch, lfrb's two-patch atomic fix >>>

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

On Wed, Apr 4, 2018 at 6:19 PM, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Mario, > > On 4 April 2018 at 06:22, Mario Kleiner <mario.kleiner...@gmail.com> wrote: >> Ok, so it's probably a mesa bug in the egl dri3 backend caused by the >> new DRI3.1 multibuf

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

ine again. Otherwise i get failure on all gpu's and drivers, as tested with ati-ddx,nouveau-ddx,modesetting-ddx under glamor or exa. This tested on current xserver master and Linux drm-next. Bedtime here, -mario On Tue, Apr 3, 2018 at 7:17 PM, Mario Kleiner <mario.kleiner...@gmail.com&

[PATCH xserver] modesetting: Fix page flipping harder under DRI 3.2.

uot;modesetting: Check if buffer format is supported when flipping") Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/drivers/modesetting/drmmo

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

Will check it later when i'm at the machines. But does Ivybridge/Gen-7 even have CCS? I can't test with something more modern Intel atm. -mario On Tue, Apr 3, 2018 at 5:57 PM, Daniel Stone <dan...@fooishbar.org> wrote: > On 3 April 2018 at 16:36, Mario Kleiner <mario.kleiner...@gmai

Re: Patch to cherry-pick from master into 1.19 branch

skill set - Or maybe at least i don't know the magic repos or commands to do that easily. -mario On Tue, Apr 3, 2018 at 5:53 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Tue, Apr 3, 2018 at 11:17 AM, Mario Kleiner > <mario.kleiner...@gmail.com>

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

this? -mario On Tue, Apr 3, 2018 at 4:47 PM, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Mario, > > On 3 April 2018 at 15:44, Mario Kleiner <mario.kleiner...@gmail.com> wrote: >> Those are fine according to my testing, they fix mode-setting under >> both depth24

Patch to cherry-pick from master into 1.19 branch

Hi Adam, b5f9fcd50a999a00128c0cc3f6e7d1f66182c9d5 ("xfree86/modes: Adapt xf86Randr12CrtcComputeGamma() for depth 30. (v2)") would be really good to have in server 1.19.7, so xf86-video-intel/nouveau can operate at screen depth 30 and keep gamma table updates via xf86vidmode and randr functional,

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

; break; @@ -124,7 +138,7 @@ drmmode_is_format_supported(ScrnInfoPtr scrn, uint32_t format, uint64_t modifier if (!found) return FALSE; } - +xf86DrvMsg(0, X_ERROR, "CANFLIP\n"); return TRUE; } -mario On Thu, Mar 29, 2018 at

[PATCH xserver] modesetting: Don't deref crtc->scrn in drmmode_output_dpms()

crtc might be a NULL pointer. Use output->scrn instead. Fixes crashes from some call paths of drmmode_output_dpms(), e.g., when called from xf86DisableUnusedFunctions(). Fixes: ba0c75177239 ("modesetting: Fix up some XXX from removing GLAMOR_HAS_DRM_*") Signed-off-by:

Re: [PATCH xserver] modesetting: Fix up some XXX from removing GLAMOR_HAS_DRM_*

A new crasher, this time while trying to play with the non-desktop property. On Thu, Mar 22, 2018 at 7:47 PM, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- > hw/xfree86/drivers/modesetting/drmmode_display.c | 75 > +--- >

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

ancis > > On Tue, 2018-03-27 at 10:10 +0200, Olivier Fourdan wrote: >> Hi, >> >> On Mon, Mar 26, 2018 at 7:54 PM, Mario Kleiner <mario.kleiner.de@gmai >> l.com> wrote: >> > [...] >> > I haven't had time to retest with the latest patch on master

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

-transparent or translucent pixmaps. > > Thank you, > > -- > Louis-Francis > > On Fri, 2018-03-23 at 15:07 +0100, Mario Kleiner wrote: >> Unfortunately not the real fix. I developed the same patch like you >> propose in that bugzilla as a 1st try: >> >>

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

of a fullscreen wayland surface/buffer via pageflipping (in compositor-drm.c drm_output_check_scanout_format()). -mario On Fri, Mar 23, 2018 at 9:03 AM, Olivier Fourdan <ofour...@redhat.com> wrote: > Hi > > On Wed, Mar 21, 2018 at 10:09 PM, Mario Kleiner <mario.kleiner...@gmail.com&g

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

o what we do in weston for the direct scanout path? Create buffers in ARGB, but submit them as XRGB for scanout? -mario On Wed, Mar 21, 2018 at 5:27 PM, Adam Jackson <a...@nwnk.net> wrote: > On Mon, 2018-03-12 at 17:11 +, Daniel Stone wrote: >> On 12 March 2018 at 16:57, M

[PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

uot;modesetting: Check if buffer format is supported when flipping") Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/drivers/modesetting/drmmo

[PATCH xserver] glamor/xwayland: Add depth 30 format mapping for DRI 3.2 as well.

Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> --- glamor/glamor_egl.c | 2 ++ hw/xwayland/xwayland-glamor.c | 4 2 files changed, 6 insertions(+) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index 8389d5f..eccc795 100644 --- a/glamor/glamor_egl.c +++ b/

Re: [PATCH xserver] glx: Only assign 8 bpc fbconfigs for composite visuals.

On 02/12/2018 09:46 PM, Adam Jackson wrote: On Fri, 2018-02-09 at 15:20 +0200, Timo Aaltonen wrote: On 07.02.2018 16:18, Mario Kleiner wrote: Thanks for the review and merge. This also needs to get picked into the server 1.19 branch. Are there plans to tag a new 1.19.7 release soon? I'm

[PATCH xserver] modesetting: Fix fallback for lack of new vblank kernel API.

to drmWaitVblank() and then fail there, instead of failing in the new api, but the end result would be the same. Fixes: 44d5f2eb8a2f ("xf86-video-modesetting: Support new vblank kernel API [v2]") Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Keith Packard <kei...@keithp.c

[PATCH xserver 7/7] modesetting: Enable screen color depth 30 support.

glamor now supports depth 30, so allow use of it. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Reviewed-by: Eric Anholt <e...@anholt.net> Reviewed-by: Antoine Martin <anto...@nagafix.co.uk> --- hw/xfree86/drivers/modesetting/driver.c | 1 + hw/xfree86/d

[PATCH xserver 4/7] glamor: Bump version to 1.0.1 to signal depth 30 support.

Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Reviewed-by: Antoine Martin <anto...@nagafix.co.uk> --- glamor/glamor_eglmodule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glamor/glamor_eglmodule.c b/glamor/glamor_eglmodule.c index dd4664b..32

[PATCH xserver 6/7] modesetting: Adapt xf86HandleColorMaps() for > 24 color depth. (v2)

iow. the server would always run with a default identity gamma lut. v2: Simplify as proposed by Michel. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Reviewed-by: Antoine Martin <anto...@nagafix.co.uk> (v1) --- hw/xfree86/drivers/modesetting/drmmode_display.c | 14 +++

[PATCH xserver 5/7] xfree86/modes: Adapt xf86Randr12CrtcComputeGamma() for depth 30. (v2)

oposed by Ville. Now reaches the max index of the palette and deals with non-power-of-two sizes. Thanks. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Reviewed-by: Antoine Martin <anto...@nagafix.co.uk> (v1) Cc: <ville.syrj...@linux.intel.com> --- hw/xfree86/

Depth 30 enablement for modesetting-ddx and fixups for glamor. Rev 3

Revision 3, with r-b's by Antoine Martin tacked on, thanks. Antoine, i left that one /* XXX handle 2 10 10 10 and 1555 formats; ... */ comment in place. As far as i understand it is meant to be a todo for depth 30 and depth 16 formats with alpha channel, and the current code only handles 10 bpc

[PATCH xserver 2/7] glamor: Fix loose ends in color depth 30 support.

This makes it work properly with OpenGL based desktop compositing, as tested with EGL and GLX based compositing under OpenGL-2/3, and also artifact free with XRender based 2D compositing. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Reviewed-by: Eric Anholt <e...@anholt.net&

[PATCH xserver 3/7] glamor: Enable composite acceleration for rgb10 formats. (v2)

Specifically for xrgb2101010 format. Tested on KDE Plasma-5 with XRender based composite acceleration backend. Much smoother and faster. (v2) Dropped argb2101010, because of depth 32 confusion with argb, as pointed out by Eric. Thanks! Signed-off-by: Mario Kleiner <mario.klei

[PATCH xserver 1/7] glamor: Make Xv extension initialize at depth 30.

Support x-screens of depth 30, so init doesn't fail. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Reviewed-by: Eric Anholt <e...@anholt.net> Reviewed-by: Antoine Martin <anto...@nagafix.co.uk> --- hw/xfree86/glamor_egl/glamor_xf86_xv.c | 4 ++-- 1 file changed,

Depth 30 enablement for modesetting-ddx and fixups for glamor. Rev 2

2nd revision of the server/modesetting-ddx/glamor patches for depth 30, following Eric's and Michel's suggestions (thanks!).. These ones tested on nouveau, amd, intel with the modesetting ddx + glamor and also (for glamor again) against the latest ati-ddx and amdgpu-ddx, which now can use depth

[PATCH xserver 7/7] modesetting: Enable screen color depth 30 support.

glamor now supports depth 30, so allow use of it. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Reviewed-by: Eric Anholt <e...@anholt.net> --- hw/xfree86/drivers/modesetting/driver.c | 1 + hw/xfree86/drivers/modesetting/drmmode_display.c | 3 ++- 2 file

[PATCH xserver 3/7] glamor: Enable composite acceleration for rgb10 formats. (v2)

Specifically for xrgb2101010 format. Tested on KDE Plasma-5 with XRender based composite acceleration backend. Much smoother and faster. (v2) Dropped argb2101010, because of depth 32 confusion with argb, as pointed out by Eric. Thanks! Signed-off-by: Mario Kleiner <mario.klei

[PATCH xserver 4/7] glamor: Bump version to 1.0.1 to signal depth 30 support.

Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> --- glamor/glamor_eglmodule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glamor/glamor_eglmodule.c b/glamor/glamor_eglmodule.c index dd4664b..326af3a 100644 --- a/glamor/glamor_eglmodule.c +++ b/

[PATCH xserver 5/7] xfree86/modes: Adapt xf86Randr12CrtcComputeGamma() for depth 30.

(uses XF86VidMode extension) and some RandR based gamma ramp animation. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> --- hw/xfree86/modes/xf86RandR12.c | 99 ++ 1 file changed, 72 insertions(+), 27 deletions(-) diff --git a/hw/xfree86/modes/x

[PATCH xserver 1/7] glamor: Make Xv extension initialize at depth 30.

Support x-screens of depth 30, so init doesn't fail. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Reviewed-by: Eric Anholt <e...@anholt.net> --- hw/xfree86/glamor_egl/glamor_xf86_xv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree8

[PATCH xserver 6/7] modesetting: Adapt xf86HandleColorMaps() for > 24 color depth.

iow. the server would always run with a default identity gamma lut. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/xfree86/drivers/mo

[PATCH xserver 2/7] glamor: Fix loose ends in color depth 30 support.

This makes it work properly with OpenGL based desktop compositing, as tested with EGL and GLX based compositing under OpenGL-2/3, and also artifact free with XRender based 2D compositing. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Reviewed-by: Eric Anholt <e...@a

Re: [PATCH xserver 1/5] modesetting: Don't call xf86HandleColorMaps() at screen depth 30.

On 02/09/2018 10:45 AM, Michel Dänzer wrote: On 2018-02-09 07:24 AM, Mario Kleiner wrote: On 02/08/2018 03:55 PM, Michel Dänzer wrote: On 2018-02-08 12:14 PM, Mario Kleiner wrote: As it turns out, doing so will make any gamma table updates silently fail, because xf86HandleColorMaps() hooks

Re: [PATCH xserver 1/5] modesetting: Don't call xf86HandleColorMaps() at screen depth 30.

On 02/08/2018 03:55 PM, Michel Dänzer wrote: On 2018-02-08 12:14 PM, Mario Kleiner wrote: As it turns out, doing so will make any gamma table updates silently fail, because xf86HandleColorMaps() hooks the .LoadPalette function to xf86RandR12LoadPalette() if the .gamma_set function is supported

Re: [PATCH xserver 1/5] modesetting: Don't call xf86HandleColorMaps() at screen depth 30.

On 02/08/2018 10:09 PM, Adam Jackson wrote: On Thu, 2018-02-08 at 12:14 +0100, Mario Kleiner wrote: That in turn is a problem, because the size of the hw lut crtc->gamma_size is fixed to 256 slots on all kms-drivers when using the legacy gamma_set ioctl, What exactly is the non-legacy io

[PATCH xserver 5/5] glamor: Enable composite acceleration for rgb10 formats.

argb2101010 and xrgb2101010. Seems to work fine, but not sure if because of dumb luck or because it is meant to be. (Re)viewer discretion advised! Tested on KDE Plasma-5 with XRender based composite acceleration backend. Much smoother and faster. Signed-off-by: Mario Kleiner <mario.klei

[PATCH xserver 4/5] glamor: Fix loose ends in color depth 30 support.

This makes it work properly with OpenGL based desktop compositing, as tested with EGL and GLX based compositing under OpenGL-2/3, and also artifact free with XRender based 2D compositing. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> --- glamor/glamor.c | 6 --

[PATCH xserver 2/5] modesetting: Enable screen color depth 30 support.

glamor now supports depth 30, so allow use of it. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> --- hw/xfree86/drivers/modesetting/driver.c | 1 + hw/xfree86/drivers/modesetting/drmmode_display.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --gi

Depth 30 enablement for modesetting-ddx and fixups for glamor.

These patches against master teach the modesetting ddx color depth 30 support. They also fix a few loose ends in the new glamor depth 30 enablement, which caused psychedelic colors under desktop composition on all gpus depending on the color depth on the different windows - some worked fine, some

[PATCH xserver 1/5] modesetting: Don't call xf86HandleColorMaps() at screen depth 30.

e updates via xf86vidmode extension and RandR working. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_

[PATCH xserver 3/5] glamor: Make Xv extension initialize at depth 30.

Support x-screens of depth 30, so init doesn't fail. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> --- hw/xfree86/glamor_egl/glamor_xf86_xv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/glamor_egl/glamor_xf86_xv.c b/hw/xfree86/glam

Re: [PATCH xserver] glx: Only assign 8 bpc fbconfigs for composite visuals.

On 02/06/2018 08:04 PM, Adam Jackson wrote: On Mon, 2018-02-05 at 11:25 +0100, Thomas Hellstrom wrote: On 02/05/2018 11:20 AM, Mario Kleiner wrote: Commit 91c42093b248 ("glx: Duplicate relevant fbconfigs for compositing visuals") adds many new depth 32 fbconfigs as composite visua

[PATCH xserver] glx: Only assign 8 bpc fbconfigs for composite visuals.

for composite visuals. Fixes: 91c42093b248 ("glx: Duplicate relevant fbconfigs for compositing visuals") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104597 Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Thomas Hellstrom <thellst...@vmware

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

On 05/05/2017 04:25 PM, Keith Packard wrote: Pekka Paalanen writes: I disagree on the details, more below. Such a RandR request is something I would not like to have to replicate on Wayland. The display server contains the policy, it should not just expose everything

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

On 04/10/2017 08:11 PM, Keith Packard wrote: Mario Kleiner <mario.kleiner...@gmail.com> writes: as input from a highly interested future user of such api's: Thanks much for taking a look at this. My use cases run about 98% of the time in fullscreen exclusive mode and want as

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

On 04/04/2017 06:48 PM, Keith Packard wrote: Daniel Vetter writes: Yeah I think that's a pretty neat idea to reduce the lease complexity even more. If the VR compositor is unhappy and wants a different mode, it can simply nuke the lease and as for a new one. Forgot to say

[PATCH 1/4] modesetting: Allow/Fix use of multiple ZaphodHead outputs per x-screen.

or three ZaphodHeads per one, two or three x-screens. Also tested on nouveau and intel dual-display setups with one or two x-screens. Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com --- hw/xfree86/drivers/modesetting/driver.c | 4 +++ hw/xfree86/drivers/modesetting/driver.h

[PATCH 2/4] modesetting: Take shift in crtc positions for ZaphodHeads configs into account.

with hard-wired outputs now work. Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com --- hw/xfree86/drivers/modesetting/drmmode_display.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c b/hw/xfree86/drivers

ZaphodHeads improvements for xf86-video-modesetting

These are some additional fixes to go on top of Dave's ZaphodHeads(v2) patch for the modesetting ddx. Patch 1/2 copy and paste ported from similar patches already in radeon/amdgpu/nouveau ddx. Patch 2/4 is copy and paste port of a patch which is pending for nouveau-ddx, on the mailing list but so

[PATCH 3/4] modesetting: Add ZaphodHeads description to man page.

Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com --- hw/xfree86/drivers/modesetting/modesetting.man | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/xfree86/drivers/modesetting/modesetting.man b/hw/xfree86/drivers/modesetting/modesetting.man index 9cb27d7..e13a4e2 100644

[PATCH 4/4] modesetting: Add more missing options to man page.

Descriptions for Options PageFlip and SWCursor. Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com --- hw/xfree86/drivers/modesetting/modesetting.man | 8 1 file changed, 8 insertions(+) diff --git a/hw/xfree86/drivers/modesetting/modesetting.man b/hw/xfree86/drivers/modesetting

Re: [PATCH] [RFC] modesetting: add zaphod support (v2)

Hi Dave, thanks for implementing this! This one is Reviewed-and-tested-by: Mario Kleiner mario.kleiner...@gmail.com I tested on intel/nouveau/radeon-kms with different combos of one/two/three x-screen with one/two/three ZaphohHeads outputs and also regular single-x-screen multi-display

Re: [PATCH] present: Fix missed notify MSC computation

, NULL, NULL, NULL, - PresentOptionAsync, + divisor == 0 ? PresentOptionAsync : 0, target_msc, divisor, remainder, NULL, 0); } Reviewed-by: Mario Kleiner mario.kleiner

Re: [PATCH 1/2] present: Improve scaling of vblank handler

-and-tested-by: Mario Kleiner mario.kleiner...@gmail.com -mario ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/2] present: Fix presentation of flips out of order

good to me, also no problems during testing on top of current master, so Reviewed-and-tested-by: Mario Kleiner mario.kleiner...@gmail.com -mario ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: [xf86-video-nouveau] dri2: Enable BufferAge support

support TripleBuffer, we don't have to worry about setting the copying the flags field when injecting the third buffer. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Maarten Lankhorst maarten.lankho...@ubuntu.com Cc: Mario Kleiner mario.kleiner...@gmail.com --- src/nouveau_dri2.c | 7

Re: [PATCH 5/5] modesetting: Implement page flipping support for Present.

On 04/28/2015 06:31 AM, Kenneth Graunke wrote: On Tuesday, April 21, 2015 05:58:44 PM Kenneth Graunke wrote: Based on code by Keith Packard, Eric Anholt, and Jason Ekstrand. v2: - Fix double free and flip_count underrun (caught by Mario Kleiner). - Don't leak flip_vblank_event on the error_out

Re: [RFC 5/5] modesetting: Implement page flipping support for Present.

flip, so the FB would be in use? Not sure though... Feel free to add a Reviewed-and-Tested-by: Mario Kleiner mario.kleiner...@gmail.com for the bits i tested and reviewed if that helps. The other patches in the series seem to be fine, thanks, -mario +for (i = 0; i config-num_crtc; i

Re: [PATCH 0/3] present: Improve interactions with compositing manager

Hi Keith and Owen, it's a bit too late for XOrg 1.17, but i reviewed and tested Keith's patchset, after rebasing the 3rd patch on top of 1.17-rc2. The series has my Reviewed-and-Tested-by: Mario Kleiner mario.kleiner...@gmail.com My patch 1/3 is Keith's patch 3/3, just rebased and with my

[PATCH 2/3] present: Extend compositor optimization to presents 1 vblank into future.

?) Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com Tested-by: Mario Kleiner mario.kleiner...@gmail.com --- present/present.c | 90 +-- 1 file changed, 68 insertions(+), 22 deletions(-) diff --git a/present/present.c b/present/present.c

[PATCH 1/3] present: When composited, get the bits into the window pixmap immediately (v2)

Packard kei...@keithp.com Reviewed-by: Mario Kleiner mario.kleiner...@gmail.com v2 (mario): Trivial rebase on top of 1.17.0-rc2 Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com Tested-by: Mario Kleiner mario.kleiner...@gmail.com --- present/present.c | 19 ++- 1 file changed

Re: [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

On 12/16/2014 09:23 AM, Keith Packard wrote: Mario Kleiner mario.kleiner...@gmail.com writes: The 0 case is good for benchmarking. Sure, but the current code does benchmarking just fine. In fact, because it doesn't copy queued frames that aren't the most recent before the vblank, benchmarks

Re: [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

On 12/17/2014 04:17 AM, Keith Packard wrote: Mario Kleiner mario.kleiner...@gmail.com writes: Hmm. For benchmarking i think i'd consider that a mild form of cheating. You get higher fps because you skip processing like the whole gpu blit overhead and host processing overhead for queuing

Re: [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

On 12/17/2014 05:49 AM, Keith Packard wrote: Mario Kleiner mario.kleiner...@gmail.com writes: It's just that i need access to both, the old behaviour i described, and the new drop frame behaviour, and i need a way to select what i want at runtime via api without the need for easily overwhelmed

Re: [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

On 12/15/2014 06:46 AM, Keith Packard wrote: Mario Kleiner mario.kleiner...@gmail.com writes: Restores proper immediate tearing swap behaviour for OpenGL bufferswap under DRI3/Present. Hrm. I'd love for this to be controlled by the GLX_EXT_swap_control_tear extension, but that one uses

[PATCH] sna: Also fix ZaphodHeads on Linux kernels older than 3.19

() function. Fixes fdo bug #84744 on older kernels. Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com --- src/sna/sna_display.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/sna/sna_display.c b/src/sna/sna_display.c index 163..a7ad6cc 100644 --- a/src

Re: [PATCH 2/2] present: Fix use of vsynced pageflips and honor PresentOptionAsync. (v3)

On 12/05/2014 12:56 AM, Eric Anholt wrote: Mario Kleiner mario.kleiner...@gmail.com writes: Pageflips for Pixmap presents were not synchronized to vblank on drivers with support for PresentCapabilityAsync, due to some missing init for vblank-sync_flips. The PresentOptionAsync flag

[PATCH 1/2] present: Avoid crashes in DebugPresent(), a bit more info.

quite a bit more easy. Please also cherry-pick this for a 1.16.x stable update. Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com Reviewed-by: Eric Anholt e...@anholt.net --- present/present.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/present/present.c b

DRI3/Present fixes for XServers 1.16 and 1.17rc - reviewed

Ok, the final patchset. I made the changes Eric Anholt proposed, retested, and got them reviewed by him. With those on top of XServer 1.16.2, DRI3/Present works for me on all drivers and backends (intel sna, uxa and nouveau exa, glamor), single and dual-display fullscreen and windowed,

  1   2   >