Re: [PATCH xserver v2 1/4] os: move xf86PrivsElevated here

2018-03-14 Thread Nicolai Hähnle
On 14.03.2018 14:36, Emil Velikov wrote: On 13 March 2018 at 21:46, Ben Crocker wrote: --- a/include/os.h +++ b/include/os.h @@ -368,6 +368,9 @@ System(const char *cmdline); #define Fclose(a) fclose(a) #endif +extern _X_EXPORT Bool +PrivsElevated(void); + Any

Re: [PATCH xserver v2 1/4] os: move xf86PrivsElevated here

2018-03-14 Thread Emil Velikov
On 13 March 2018 at 21:46, Ben Crocker wrote: > --- a/include/os.h > +++ b/include/os.h > @@ -368,6 +368,9 @@ System(const char *cmdline); > #define Fclose(a) fclose(a) > #endif > > +extern _X_EXPORT Bool > +PrivsElevated(void); > + Any particular reason why this is

[PATCH xserver v2 1/4] os: move xf86PrivsElevated here

2018-03-13 Thread Ben Crocker
From: Nicolai Hähnle Having different types of code all trying to check for elevated privileges is a bad idea. This implementation is the most thorough one. Signed-off-by: Nicolai Hähnle Reviewed-by: Ben Crocker