Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Kristian Høgsberg
On Sun, Oct 17, 2010 at 12:58 PM, Aaron Plattner aplatt...@nvidia.com wrote: This change does not solve the problem it claims to solve because it makes two assumptions about the driver that are not always true: 1. that it sends rendering requests to the GPU immediately, which can   kill

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Keith Packard
On Sun, 17 Oct 2010 09:58:50 -0700, Aaron Plattner aplatt...@nvidia.com wrote: This change does not solve the problem it claims to solve because it makes two assumptions about the driver that are not always true: 1. that it sends rendering requests to the GPU immediately, which can kill

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Aaron Plattner
Thanks for this discussion. More precise semantics are always better. Comments below: On Wed, Oct 20, 2010 at 11:05:29AM -0700, Keith Packard wrote: On Sun, 17 Oct 2010 09:58:50 -0700, Aaron Plattner aplatt...@nvidia.com wrote: This change does not solve the problem it claims to solve

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Keith Packard
On Wed, 20 Oct 2010 11:35:46 -0700, Aaron Plattner aplatt...@nvidia.com wrote: By sending X protocol to explicitly fence the GL rendering with the X rendering, which is the whole purpose of James's XDamageSubtractAndTrigger request. Otherwise, the driver has to implicitly fence all rendering

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Aaron Plattner
On Wed, Oct 20, 2010 at 01:54:35PM -0700, Keith Packard wrote: On Wed, 20 Oct 2010 11:35:46 -0700, Aaron Plattner aplatt...@nvidia.com wrote: By sending X protocol to explicitly fence the GL rendering with the X rendering, which is the whole purpose of James's XDamageSubtractAndTrigger

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Aaron Plattner
On Wed, Oct 20, 2010 at 02:57:27PM -0700, Keith Packard wrote: On Wed, 20 Oct 2010 14:29:33 -0700, Aaron Plattner aplatt...@nvidia.com wrote: Then you're implementing what sounds like a nice vendor-specific feature. There isn't any other mechanism provided today to perform the

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Aaron Plattner
On Wed, Oct 20, 2010 at 03:03:59PM -0700, Aaron Plattner wrote: On Wed, Oct 20, 2010 at 02:57:27PM -0700, Keith Packard wrote: On Wed, 20 Oct 2010 14:29:33 -0700, Aaron Plattner aplatt...@nvidia.com wrote: The driver can do that by enabling ReportAfter from a damage create hook.

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Keith Packard
On Wed, 20 Oct 2010 15:03:59 -0700, Aaron Plattner aplatt...@nvidia.com wrote: Fine, but will you be willing to move this call to the drivers that need it when we have a real sync extension? I don't see the point -- it doesn't change anything visible to clients or drivers, other than to

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Francisco Jerez
Keith Packard kei...@keithp.com writes: On Wed, 20 Oct 2010 15:03:59 -0700, Aaron Plattner aplatt...@nvidia.com wrote: Fine, but will you be willing to move this call to the drivers that need it when we have a real sync extension? I don't see the point -- it doesn't change anything

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Keith Packard
On Thu, 21 Oct 2010 01:38:58 +0200, Francisco Jerez curroje...@riseup.net wrote: Nouveau uses the hardware interchannel synchronization primitives on demand (it kicks in when two channels have references to the same BO): the nouveau DRM guarantees that two command buffers rendering to/from

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Keith Packard
On Sun, 17 Oct 2010 09:58:50 -0700, Aaron Plattner aplatt...@nvidia.com wrote: This commit broke the Compiz Wallpaper plugin. Applied. d738175..1a0d932 master - master -- keith.pack...@intel.com pgpLWHcy0M8Wk.pgp Description: PGP signature

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Francisco Jerez
Keith Packard kei...@keithp.com writes: On Thu, 21 Oct 2010 01:38:58 +0200, Francisco Jerez curroje...@riseup.net wrote: Nouveau uses the hardware interchannel synchronization primitives on demand (it kicks in when two channels have references to the same BO): the nouveau DRM guarantees

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Kristian Høgsberg
On Wed, Oct 20, 2010 at 7:45 PM, Keith Packard kei...@keithp.com wrote: On Sun, 17 Oct 2010 09:58:50 -0700, Aaron Plattner aplatt...@nvidia.com wrote: In addition to the above, this commit also broke the Compiz Wallpaper plugin. Ok, as usual, Dave Airlie is right here -- independent of

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Aaron Plattner
On Wed, Oct 20, 2010 at 03:49:47PM -0700, Keith Packard wrote: On Wed, 20 Oct 2010 15:03:59 -0700, Aaron Plattner aplatt...@nvidia.com wrote: Fine, but will you be willing to move this call to the drivers that need it when we have a real sync extension? I don't see the point -- it

[PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-17 Thread Aaron Plattner
This change does not solve the problem it claims to solve because it makes two assumptions about the driver that are not always true: 1. that it sends rendering requests to the GPU immediately, which can kill performance on some GPUs, and 2. that the GPU processes all requests from multiple