Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function. (v3)

2012-06-20 Thread Kristian Høgsberg
On Tue, Jun 19, 2012 at 11:53 PM, Christopher James Halse Rogers christopher.halse.rog...@canonical.com wrote: xwayland drivers need access to their screen private data to authenticate. Now that drivers no longer have direct access to the global screen arrays, this needs to be passed in as

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function. (v3)

2012-06-20 Thread Keith Packard
Christopher James Halse Rogers christopher.halse.rog...@canonical.com writes: xwayland drivers need access to their screen private data to authenticate. Now that drivers no longer have direct access to the global screen arrays, this needs to be passed in as function context. v2: Don't break

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function.

2012-06-19 Thread Kristian Høgsberg
On Mon, Jun 18, 2012 at 12:58 PM, Keith Packard kei...@keithp.com wrote: Christopher James Halse Rogers christopher.halse.rog...@canonical.com writes: +typedef int (*DRI2AuthMagic2ProcPtr) (ScreenPtr pScreen, int fd, uint32_t magic); Bikeshed -- seems like the 'fd' parameter is not needed

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function.

2012-06-19 Thread Christopher James Halse Rogers
On Tue, 2012-06-19 at 14:38 -0400, Kristian Høgsberg wrote: On Mon, Jun 18, 2012 at 12:58 PM, Keith Packard kei...@keithp.com wrote: Christopher James Halse Rogers christopher.halse.rog...@canonical.com writes: +typedef int (*DRI2AuthMagic2ProcPtr) (ScreenPtr pScreen, int fd, uint32_t

[PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function. (v3)

2012-06-19 Thread Christopher James Halse Rogers
xwayland drivers need access to their screen private data to authenticate. Now that drivers no longer have direct access to the global screen arrays, this needs to be passed in as function context. v2: Don't break ABI v3: Paint the bikeshed blue; drop fd from AuthMagic2ProcPtr prototype

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function.

2012-06-18 Thread Michel Dänzer
On Mon, 2012-06-18 at 11:52 +1000, Christopher James Halse Rogers wrote: xwayland drivers need access to their screen private data to authenticate. Now that drivers no longer have direct access to the global screen arrays, this needs to be passed in as function context. v2: Don't break ABI

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function.

2012-06-18 Thread Kristian Høgsberg
On Sun, Jun 17, 2012 at 9:52 PM, Christopher James Halse Rogers christopher.halse.rog...@canonical.com wrote: xwayland drivers need access to their screen private data to authenticate. Now that drivers no longer have direct access to the global screen arrays, this needs to be passed in as

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function.

2012-06-18 Thread Keith Packard
Christopher James Halse Rogers christopher.halse.rog...@canonical.com writes: +typedef int (*DRI2AuthMagic2ProcPtr) (ScreenPtr pScreen, int fd, uint32_t magic); Bikeshed -- seems like the 'fd' parameter is not needed in this API? I'll note that in the implementation of the wrapper, you pull

[PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function.

2012-06-17 Thread Christopher James Halse Rogers
xwayland drivers need access to their screen private data to authenticate. Now that drivers no longer have direct access to the global screen arrays, this needs to be passed in as function context. v2: Don't break ABI Signed-off-by: Christopher James Halse Rogers