Re: [PATCH] render: don't bother with animated cursors on floating slaves (#39989)

2012-02-15 Thread Jon TURNEY 
On 26/01/2012 21:43, Colin Harrison wrote:
 On my Windows build this patch...
 
 diff --git a/render/animcur.c b/render/animcur.c
 index 4cf1fdf..0f174fd 100644
 --- a/render/animcur.c
 +++ b/render/animcur.c
 @@ -208,6 +208,9 @@ AnimCurDisplayCursor (DeviceIntPtr pDev,
  AnimCurScreenPtras = GetAnimCurScreen(pScreen);
  Bool ret;
  
 +if (IsFloating(pDev))
 + return FALSE;
 +
  Unwrap (as, pScreen, DisplayCursor);
  if (IsAnimCur(pCursor))
  {
 
 causes the 'default'  cursor to disappear...(I like to party_like_its 1989!)
 
 I always need a cursor as when the X root window isn't hidden on Windows you
 can't easily control anything as the 'black or stippled X window' blots out
 Microsoft's stuff :)

I did a bit of testing with -retro and the Xorg DDX, and I see the same thing,
the saltire cursor is missing initially.

However, reverting this commit didn't help. This seems to be a regression
since 1.10, present in 1.11.  Bisecting pointed to dc57f89 Switch to use
IsFloating()
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] render: don't bother with animated cursors on floating slaves (#39989)

2012-02-15 Thread Peter Hutterer 
X.Org Bug 39989 http://bugs.freedesktop.org/show_bug.cgi?id=39989

This is the corrected version after the initial fix in
bbb6b8c834e0e1491ca14403b5d0840dd14380d3.

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
 render/animcur.c |3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/render/animcur.c b/render/animcur.c
index 31cbab9..11f30ad 100644
--- a/render/animcur.c
+++ b/render/animcur.c
@@ -208,6 +208,9 @@ AnimCurDisplayCursor (DeviceIntPtr pDev,
 AnimCurScreenPtras = GetAnimCurScreen(pScreen);
 Bool   ret;
 
+if (!IsMaster(pDev)  IsFloating(pDev))
+   return FALSE;
+
 Unwrap (as, pScreen, DisplayCursor);
 if (IsAnimCur(pCursor))
 {
-- 
1.7.7.5

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] render: don't bother with animated cursors on floating slaves (#39989)

2012-02-15 Thread Colin Harrison 
Hi,

On Wed, Feb 15, 2012 Peter Hutterer wrote:
 This is the corrected version after the initial fix in
bbb6b8c834e0e1491ca14403b5d0840dd14380d3.

Works for me.

Thanks,
Colin Harrison

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] render: don't bother with animated cursors on floating slaves (#39989)

2012-01-26 Thread Colin Harrison 
Hi,

On my Windows build this patch...

diff --git a/render/animcur.c b/render/animcur.c
index 4cf1fdf..0f174fd 100644
--- a/render/animcur.c
+++ b/render/animcur.c
@@ -208,6 +208,9 @@ AnimCurDisplayCursor (DeviceIntPtr pDev,
 AnimCurScreenPtras = GetAnimCurScreen(pScreen);
 Bool   ret;
 
+if (IsFloating(pDev))
+   return FALSE;
+
 Unwrap (as, pScreen, DisplayCursor);
 if (IsAnimCur(pCursor))
 {

causes the 'default'  cursor to disappear...(I like to party_like_its 1989!)

I always need a cursor as when the X root window isn't hidden on Windows you
can't easily control anything as the 'black or stippled X window' blots out
Microsoft's stuff :)

Thanks,
Colin

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] render: don't bother with animated cursors on floating slaves (#39989)

2012-01-09 Thread Jeremy Huddleston 
Sounds reasonable

Reviewed-by: Jeremy Huddleston jerem...@apple.com

Sent from my iPad

On Jan 8, 2012, at 17:20, Peter Hutterer peter.hutte...@who-t.net wrote:

 In the case of floating slave devices that is reattached to a master with an
 animated cursor, that cursor may jump outside it's window confines. Since
 floating slaves never display a cursor anyway, we might as well short-cut
 this and exit early.
 
 X.Org Bug 39989 http://bugs.freedesktop.org/show_bug.cgi?id=39989
 
 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
 Tested-by: Harald Judt h.j...@gmx.at
 --- 
 render/animcur.c |3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
 
 diff --git a/render/animcur.c b/render/animcur.c
 index 4cf1fdf..0f174fd 100644
 --- a/render/animcur.c
 +++ b/render/animcur.c
 @@ -208,6 +208,9 @@ AnimCurDisplayCursor (DeviceIntPtr pDev,
 AnimCurScreenPtras = GetAnimCurScreen(pScreen);
 Boolret;
 
 +if (IsFloating(pDev))
 +return FALSE;
 +
 Unwrap (as, pScreen, DisplayCursor);
 if (IsAnimCur(pCursor))
 {
 -- 
 1.7.7.4
 ___
 xorg-devel@lists.x.org: X.Org development
 Archives: http://lists.x.org/archives/xorg-devel
 Info: http://lists.x.org/mailman/listinfo/xorg-devel
 
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] render: don't bother with animated cursors on floating slaves (#39989)

2012-01-08 Thread Peter Hutterer 
In the case of floating slave devices that is reattached to a master with an
animated cursor, that cursor may jump outside it's window confines. Since
floating slaves never display a cursor anyway, we might as well short-cut
this and exit early.

X.Org Bug 39989 http://bugs.freedesktop.org/show_bug.cgi?id=39989

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Tested-by: Harald Judt h.j...@gmx.at
--- 
 render/animcur.c |3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/render/animcur.c b/render/animcur.c
index 4cf1fdf..0f174fd 100644
--- a/render/animcur.c
+++ b/render/animcur.c
@@ -208,6 +208,9 @@ AnimCurDisplayCursor (DeviceIntPtr pDev,
 AnimCurScreenPtras = GetAnimCurScreen(pScreen);
 Bool   ret;
 
+if (IsFloating(pDev))
+   return FALSE;
+
 Unwrap (as, pScreen, DisplayCursor);
 if (IsAnimCur(pCursor))
 {
-- 
1.7.7.4
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel