On 22 May 2010 03:05:56 +0200, Soeren Sandmann sandm...@daimi.au.dk wrote:
Didn't realize that the hand-rolled changes commit used to be part
of this. The comment I have on that part is that it seems to preserve
the macro versions of some ops rather than the function versions.
Right, I
On 22 May 2010 03:09:49 +0200, Soeren Sandmann sandm...@daimi.au.dk wrote:
- * to miValidateTree. Bob Scheifler changed the representation to be more
+ * to ValidateTree. Bob Scheifler changed the representation to be more
But miValidateTree still exists.
That's weird. None of the sed
On Sat, May 22, 2010 at 12:20 AM, Keith Packard kei...@keithp.com wrote:
I've split up the patch which removes the 'mi' prefix from the region
function names and the file rename into two patches.
If you want the s/mi// rename to be purely mechanical, I think you
need another commit first that
On Sat, 22 May 2010 11:34:20 -0700, Jamey Sharp ja...@minilop.net wrote:
On Sat, May 22, 2010 at 12:20 AM, Keith Packard kei...@keithp.com wrote:
I've split up the patch which removes the 'mi' prefix from the region
function names and the file rename into two patches.
If you want the
It looks like renaming miSubtractSpans to SubtractSpans was an accident?
With that fixed, this looks perfectly sensible.
Reviewed-by: Jamey Sharp ja...@minilop.net
Jamey
___
xorg-devel@lists.x.org: X.Org development
Archives:
On Fri, 21 May 2010 13:27:20 -0700, Jamey Sharp ja...@minilop.net wrote:
It looks like renaming miSubtractSpans to SubtractSpans was an accident?
With that fixed, this looks perfectly sensible.
Yeah, the sed script was a bit incautious. I've fixed the sed script and
regenerated the branch.
On Fri, May 21, 2010 at 3:14 PM, Keith Packard kei...@keithp.com wrote:
On Fri, 21 May 2010 13:27:20 -0700, Jamey Sharp ja...@minilop.net wrote:
It looks like renaming miSubtractSpans to SubtractSpans was an accident?
With that fixed, this looks perfectly sensible.
Yeah, the sed script was a
On Fri, 21 May 2010 15:36:07 -0700, Jamey Sharp ja...@minilop.net wrote:
Seems like the deletions of mi prefixes in region.c should still go
in this first commit, though, not in Change region implementation
from macros to inline functions. The latter looks kind of broken now.
Yeah, you're
Keith Packard kei...@keithp.com writes:
There isn't any reason to have this in mi. Everything except the file
rename was done with the included script 'fix-miregion'.
Would it be useful to split this commit into two: one that just
renames the file and one that is the result of running the
Keith Packard kei...@keithp.com writes:
There isn't any reason to have this in mi. Everything except the file
rename was done with the included script 'fix-miregion'.
Didn't realize that the hand-rolled changes commit used to be part
of this. The comment I have on that part is that it seems to
Keith Packard kei...@keithp.com writes:
There isn't any reason to have this in mi. Everything except the file
rename was done with the included script 'fix-miregion'.
There is a search-and-replace bug here:
- * to miValidateTree. Bob Scheifler changed the representation to be more
+ * to
11 matches
Mail list logo
