Re: [PATCH 1/5] Replace DDXBEFORERESET with a more general way of doing DDX-specific hooks

On 07/04/2010 18:32, Jamey Sharp wrote: I'm confused about whether multiple declarations of the same global are allowed. In this case, ddxHooks is declared in both xwin/InitOutput.c and dispatch.c. But as far as I can tell, this can't hurt any DDX except Xwin, and I assume you've tested that it

[PATCH 1/5] Replace DDXBEFORERESET with a more general way of doing DDX-specific hooks

If we use DDXBEFORERESET to control if the DIX calls ddxBeforeReset(), all DDX built at the same time must provide that function, whether they need it or not. Instead use (a structure of) function pointers, which can be initialized as required by the specific DDX Signed-off-by: Jon TURNEY

Re: [PATCH 1/5] Replace DDXBEFORERESET with a more general way of doing DDX-specific hooks

I'm confused about whether multiple declarations of the same global are allowed. In this case, ddxHooks is declared in both xwin/InitOutput.c and dispatch.c. But as far as I can tell, this can't hurt any DDX except Xwin, and I assume you've tested that it works there, so I'd guess it's fine. :-)