Re: [PATCH v2] Print git describe output into the log file.

2010-04-19 Thread Daniel Stone
On Fri, Apr 16, 2010 at 11:00:50AM -0700, Dan Nicholson wrote: On Fri, Apr 16, 2010 at 10:32 AM, Gaetan Nadon mems...@videotron.ca wrote: On Fri, 2010-04-16 at 06:31 -0700, Dan Nicholson wrote: It might be nicer, but could get messy when you consider all the corner cases. True, and the

Re: [PATCH v2] Print git describe output into the log file.

2010-04-19 Thread Dan Nicholson
On Mon, Apr 19, 2010 at 12:05 AM, Daniel Stone dan...@fooishbar.org wrote: On Fri, Apr 16, 2010 at 11:00:50AM -0700, Dan Nicholson wrote: On Fri, Apr 16, 2010 at 10:32 AM, Gaetan Nadon mems...@videotron.ca wrote: On Fri, 2010-04-16 at 06:31 -0700, Dan Nicholson wrote: It might be nicer, but

Re: [PATCH v2] Print git describe output into the log file.

2010-04-18 Thread Jon TURNEY
On 16/04/2010 18:54, Gaetan Nadon wrote: On Fri, 2010-04-16 at 16:32 +0100, Jon TURNEY wrote: I think this needs to be .PHONY, and use git describe --dirty above to properly note when there are uncommitted changes included in the build. The --dirty option is available since 1.6.6.2 only,

[PATCH v2] Print git describe output into the log file.

2010-04-16 Thread Peter Hutterer
Run git describe on build and push the output into xorg-git-version.h. Then print that out in the logfile. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Changes to first version: - target is PHONY to always regenerate - script reshuffled, no == anymore - don't print anything if no

Re: [PATCH v2] Print git describe output into the log file.

2010-04-16 Thread Dan Nicholson
On Thu, Apr 15, 2010 at 11:04 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Run git describe on build and push the output into xorg-git-version.h. Then print that out in the logfile. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Changes to first version: - target is PHONY

Re: [PATCH v2] Print git describe output into the log file.

2010-04-16 Thread Jon TURNEY
On 16/04/2010 11:21, Kristian Høgsberg wrote: On Fri, Apr 16, 2010 at 2:04 AM, Peter Hutterer + +xorg-git-version.h: + sh $(top_srcdir)/GIT-GENERATE-VERSION + +.PHONY: xorg-git-version.h Make it depend on .git/$(git symbolic-ref HEAD) instead of using phony? I think this needs to be

Re: [PATCH v2] Print git describe output into the log file.

2010-04-16 Thread Gaetan Nadon
On Fri, 2010-04-16 at 06:31 -0700, Dan Nicholson wrote: It might be nicer, but could get messy when you consider all the corner cases. True, and the mess can be contained in a macro. Reusing the design for ChangeLog is worth a shot. Not to mention the script brings a mess of it's own in the

Re: [PATCH v2] Print git describe output into the log file.

2010-04-16 Thread Alan Coopersmith
Gaetan Nadon wrote: On Fri, 2010-04-16 at 06:31 -0700, Dan Nicholson wrote: It might be nicer, but could get messy when you consider all the corner cases. True, and the mess can be contained in a macro. And putting it in a macro in xorg-macros may be worthwhile too, since I can imagine other

Re: [PATCH v2] Print git describe output into the log file.

2010-04-16 Thread Dan Nicholson
On Fri, Apr 16, 2010 at 10:32 AM, Gaetan Nadon mems...@videotron.ca wrote: On Fri, 2010-04-16 at 06:31 -0700, Dan Nicholson wrote: It might be nicer, but could get messy when you consider all the corner cases. True, and the mess can be contained in a macro. Reusing the design for ChangeLog

Re: [PATCH v2] Print git describe output into the log file.

2010-04-16 Thread Gaetan Nadon
On Fri, 2010-04-16 at 11:00 -0700, Dan Nicholson wrote: On Fri, Apr 16, 2010 at 10:32 AM, Gaetan Nadon mems...@videotron.ca wrote: On Fri, 2010-04-16 at 06:31 -0700, Dan Nicholson wrote: It might be nicer, but could get messy when you consider all the corner cases. True, and the mess