() retHi,
On Fri, Sep 7, 2018 at 1:16 PM Olivier Fourdan wrote:
>
> > > On 04/09/2018 16:27, Roman Gilg wrote:
> > >
> > > Ok, I just got a failing assert in xwl_present_flips_stop with the patch
> > > when opening a context menu in Steam.
> > > Seems the xwl_present_flips_stop call is coming
Hi,
On Wed, Sep 5, 2018 at 1:13 PM Olivier Fourdan wrote:
> Hi,
> On Tue, Sep 4, 2018 at 6:28 PM Lionel Landwerlin
> wrote:
> >
> > Oh well...
> > I'm sure you'll be able to fix it faster than me :)
> >
> > -
> > Lionel
> >
> >
> [...]
>
> If I read bug 107314 correctly, the crash occurs after
Hi,
On Tue, Sep 4, 2018 at 6:28 PM Lionel Landwerlin
wrote:
>
> Oh well...
> I'm sure you'll be able to fix it faster than me :)
>
> -
> Lionel
>
> On 04/09/2018 16:27, Roman Gilg wrote:
>
> Ok, I just got a failing assert in xwl_present_flips_stop with the patch when
> opening a context menu
Oh well...
I'm sure you'll be able to fix it faster than me :)
-
Lionel
On 04/09/2018 16:27, Roman Gilg wrote:
Ok, I just got a failing assert in xwl_present_flips_stop with the
patch when opening a context menu in Steam. Seems the
xwl_present_flips_stop call is coming in too late now after
Ok, I just got a failing assert in xwl_present_flips_stop with the patch
when opening a context menu in Steam. Seems the xwl_present_flips_stop call
is coming in too late now after the presenting window has already been
changed.
>
#0 __GI_raise (sig=sig@entry=6) at
So I have it running now without problems for a few days. I tested it once
with CS:GO and Hitman and there were no crashes. I can't test the suspend
recovery because this is currently not working due to a problem in KWin.
Tested-by: Roman Gilg
___
On Mon, Aug 27, 2018 at 2:06 AM Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> v2: Still notify aborted flips (Roman)
I also want to test it later this week when I've finished some other work,
but for now:
Reviewed-by: Roman Gilg
___
When a vblank has been marked as aborted, it's going to be free in the
flip_notify function when stopped. We can't notify it after it's
stopped because the pointer is invalid.
Valgrind backtrace:
==5331== Invalid read of size 8
==5331==at 0x212B4D: present_vblank_notify (present_vblank.c:34)