Re: [PATCH xserver] dix: don't free() stack memory

2018-03-13 Thread Keith Packard
Eric Engestrom writes: > I'll look at the code more closely to figure out when the free is > needed, but I just saw this warning and had a look, this isn't code I'm > familiar with *at all*, so I might just end up giving up if I can't > figure it out easily enough :/

Re: [PATCH xserver] dix: don't free() stack memory

2018-03-13 Thread Eric Engestrom
On Tuesday, 2018-03-13 12:09:40 +0100, Michel Dänzer wrote: > On 2018-03-13 11:56 AM, Eric Engestrom wrote: > > In function ‘doImageText’, > > inlined from ‘ImageText’ at dix/dixfonts.c:1513:5: > > dix/dixfonts.c:1492:9: warning: attempt to free a non-heap object > > ‘local_closure’

Re: [PATCH xserver] dix: don't free() stack memory

2018-03-13 Thread Michel Dänzer
On 2018-03-13 11:56 AM, Eric Engestrom wrote: > In function ‘doImageText’, > inlined from ‘ImageText’ at dix/dixfonts.c:1513:5: > dix/dixfonts.c:1492:9: warning: attempt to free a non-heap object > ‘local_closure’ [-Wfree-nonheap-object] > free(c); > ^ > > Signed-off-by:

[PATCH xserver] dix: don't free() stack memory

2018-03-13 Thread Eric Engestrom
In function ‘doImageText’, inlined from ‘ImageText’ at dix/dixfonts.c:1513:5: dix/dixfonts.c:1492:9: warning: attempt to free a non-heap object ‘local_closure’ [-Wfree-nonheap-object] free(c); ^ Signed-off-by: Eric Engestrom --- dix/dixfonts.c |