Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-19 Thread Michel Dänzer
On 19/08/16 04:57 PM, Emil Velikov wrote: > On 19 August 2016 at 03:09, Michel Dänzer wrote: >> On 19/08/16 11:02 AM, Yu, Qiang wrote: >>> >>> Each point of the patch set is not broken. Patches are arranged like >>> this to show how I do it: >>> 1. create a pageflip.c to host

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-19 Thread Emil Velikov
On 19 August 2016 at 03:09, Michel Dänzer wrote: > On 19/08/16 11:02 AM, Yu, Qiang wrote: >> >> Each point of the patch set is not broken. Patches are arranged like >> this to show how I do it: >> 1. create a pageflip.c to host common page flip code >> 2. copy amdgpu DDX DRI2

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-18 Thread Keith Packard
Michel Dänzer writes: > This does mean though that if one has only up to patch 3 applied (e.g. > during a bisection), one is exposed to the issues fixed by patch 4. So > maybe patch 4 should be squashed into patch 3. That's a very important point -- developing code in small

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-18 Thread Yu, Qiang
l; amd-...@lists.freedesktop.org Subject: Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support Hi Qiang, On 17 August 2016 at 11:29, Qiang Yu <qiang...@amd.com> wrote: > Hi guys, > > This patch set is for adding DRI2 page flip support to modesetting > driver. I mainly take

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-18 Thread Michel Dänzer
On 19/08/16 11:02 AM, Yu, Qiang wrote: > > Each point of the patch set is not broken. Patches are arranged like > this to show how I do it: > 1. create a pageflip.c to host common page flip code > 2. copy amdgpu DDX DRI2 page flip code to modesetting dri2.c > 3. merge common DRI2 and present page

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-18 Thread Michel Dänzer
On 19/08/16 01:56 AM, ⚛ wrote: > > There is some confusion at > https://www.phoronix.com/forums/forum/phoronix/latest-phoronix-articles/891632-dri2-page-flipping-patches-for-the-generic-modesetting-ddx > about this patch. Confusion in the Phoronix forums? No way! ;) > There was no previous

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-18 Thread Yu, Qiang
ct: Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support On 17/08/16 07:29 PM, Qiang Yu wrote: > Hi guys, > > This patch set is for adding DRI2 page flip support to modesetting > driver. I mainly take reference of amdgpu DDX and reuse present > page flip code in the modesettin

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-18 Thread
Hello There is some confusion at https://www.phoronix.com/forums/forum/phoronix/latest-phoronix-articles/891632-dri2-page-flipping-patches-for-the-generic-modesetting-ddx about this patch. There was no previous DRI2 page flipping support in modesetting? What is improved by the patch? Thanks.

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-18 Thread Emil Velikov
Hi Qiang, On 17 August 2016 at 11:29, Qiang Yu wrote: > Hi guys, > > This patch set is for adding DRI2 page flip support to modesetting > driver. I mainly take reference of amdgpu DDX and reuse present > page flip code in the modesetting driver. > > Regards, > Qiang > > Qiang

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-18 Thread Michel Dänzer
On 17/08/16 07:29 PM, Qiang Yu wrote: > Hi guys, > > This patch set is for adding DRI2 page flip support to modesetting > driver. I mainly take reference of amdgpu DDX and reuse present > page flip code in the modesetting driver. > > Regards, > Qiang > > Qiang Yu (6): > modesetting: make

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-17 Thread Martin Peres
On 17/08/16 13:29, Qiang Yu wrote: Hi guys, This patch set is for adding DRI2 page flip support to modesetting driver. I mainly take reference of amdgpu DDX and reuse present page flip code in the modesetting driver. Regards, Qiang Qiang Yu (6): modesetting: make ms_do_pageflip generic for

[PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-17 Thread Qiang Yu
Hi guys, This patch set is for adding DRI2 page flip support to modesetting driver. I mainly take reference of amdgpu DDX and reuse present page flip code in the modesetting driver. Regards, Qiang Qiang Yu (6): modesetting: make ms_do_pageflip generic for share with DRI2 modesetting: move