Re: [PATCH xserver 00/13] GLX 1.4 cleanup and GLX_EXT_libglvnd

[Adam Jackson]

On Wed, 2016-03-30 at 13:11 +0100, Emil Velikov wrote:

> There's a few small suggestions - of which the "print a warning if the
> WGL extension is missing" (patch 5&7) and Eric's "use strdup over
> malloc/memset" (patch 13) being somewhat serious. With those addressed
> the series is
> Reviewed-by: Emil Velikov 
> 
> Would be great to hear from Jon about patches 5 & 7 though. I suspect
> that without the warnings he'll have lots of 'fun' moments debugging.

Merged this series, with v2 of 7 and 13, and more elaborate commit
message for 6:

remote: I: patch #77728 updated using rev 
3a21da59e59cf11a9113d71e3431c4bd394ff1e8.
remote: I: patch #78130 updated using rev 
410aec82556def5395f51299bcefbeb7d0bda604.
remote: I: patch #78127 updated using rev 
f95645c6f70019316f8ad77b7beb84530fc0505f.
remote: I: patch #78129 updated using rev 
b2ef7df476af619903ef7f6b6962b371ae14306c.
remote: I: patch #78125 updated using rev 
9b2fc6d98691966f1c9186edad956f78c31f3698.
remote: I: patch #78124 updated using rev 
15af78fc56569dc3b6a7f2c5a6a49edb602111b7.
remote: I: patch #78758 updated using rev 
77bdaa1313aa55191b49ec73c1e377928ca294fe.
remote: I: patch #78128 updated using rev 
2a72789ee8e88f612dff48ebe2ebe9fecda7a95d.
remote: I: patch #78135 updated using rev 
36bcbf76dcc7e88cac093f8fb656c525bfeaf65d.
remote: I: patch #78131 updated using rev 
23cce73221c0b96e7778da34616f8c3f4d6aa819.
remote: E: failed to find patch for rev 
e21de4bf3c5ff8cbb9c5ea023d04162e5e56b3df.
remote: I: patch #78132 updated using rev 
2e8781ead3067b195baec2e76a28091575679383.
remote: I: patch #78750 updated using rev 
b08526eecf1e165ed9ec2e6b571a5a616a9b696e.
remote: I: 12 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   44e1c97..b08526e  master -> master

- ajax
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 00/13] GLX 1.4 cleanup and GLX_EXT_libglvnd

[Emil Velikov]

Hi Adam,

On 23 March 2016 at 22:46, Adam Jackson  wrote:
> The previous series didn't quite do what I expected, because xwin and
> xquartz didn't set the extension enable bits the same way as DRI. This
> series moves the enable bits into the common GLX screen data, fixes the
> default enable state to apply to all backends, and moves more of the
> setup boilerplate code into the core.
>
> The last patch finishes support for GLX_EXT_libglvnd by returning a
> vendor library string in glXQueryServerString. This is to enable libglvnd
> to select the correct implementation for applications that address multiple
> GL screens (or displays). At the moment this extension is only exposed for
> non-OSX and non-Windows builds, as libglvnd really isn't functional there.
> The swrast backend simply hardcodes the vendor to mesa. The DRI2 backend
> allows you to override the vendor string with Option "GlxVendorLibrary"
> in xorg.conf, in either the Device or Screen sections.
>
There's a few small suggestions - of which the "print a warning if the
WGL extension is missing" (patch 5&7) and Eric's "use strdup over
malloc/memset" (patch 13) being somewhat serious. With those addressed
the series is
Reviewed-by: Emil Velikov 

Would be great to hear from Jon about patches 5 & 7 though. I suspect
that without the warnings he'll have lots of 'fun' moments debugging.

-Emil
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver 00/13] GLX 1.4 cleanup and GLX_EXT_libglvnd

[Adam Jackson]

The previous series didn't quite do what I expected, because xwin and
xquartz didn't set the extension enable bits the same way as DRI. This
series moves the enable bits into the common GLX screen data, fixes the
default enable state to apply to all backends, and moves more of the
setup boilerplate code into the core.

The last patch finishes support for GLX_EXT_libglvnd by returning a
vendor library string in glXQueryServerString. This is to enable libglvnd
to select the correct implementation for applications that address multiple
GL screens (or displays). At the moment this extension is only exposed for
non-OSX and non-Windows builds, as libglvnd really isn't functional there.
The swrast backend simply hardcodes the vendor to mesa. The DRI2 backend
allows you to override the vendor string with Option "GlxVendorLibrary"
in xorg.conf, in either the Device or Screen sections.

 glx/extension_string.c   |5 +-
 glx/extension_string.h   |1 
 glx/glxcmds.c|   22 +
 glx/glxdri2.c|   83 +++---
 glx/glxdriswrast.c   |   39 +---
 glx/glxext.c |2 
 glx/glxscreens.c |   44 +-
 glx/glxscreens.h |   16 +-
 hw/xfree86/man/xorg.conf.man |6 ++
 hw/xquartz/GL/indirect.c |   40 +---
 hw/xwin/glx/indirect.c   |  102 ---
 11 files changed, 114 insertions(+), 246 deletions(-)

- ajax

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel