Re: [PATCH xserver 1/2] glx: Stop printing messages about what GLX extensions we enable

[Emil Velikov]

On 13 December 2017 at 16:44, Adam Jackson  wrote:
> glxinfo already exists, use it.
>
Seconded.
Reviewed-by: Emil Velikov 

If anyone really wants the server to log these a patch that calls
LogMessageVerb() within __glXEnableExtension() wouldn't be too bad.
It'll be more complete + less spammy than what we have now ;-)

-Emil
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 1/2] glx: Stop printing messages about what GLX extensions we enable

[Eric Anholt]

Adam Jackson  writes:

> glxinfo already exists, use it.

Yes, please.

Reviewed-by: Eric Anholt 


signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver 1/2] glx: Stop printing messages about what GLX extensions we enable

[Adam Jackson]

glxinfo already exists, use it.

Signed-off-by: Adam Jackson 
---
 glx/glxdri2.c  | 29 +++--
 glx/glxdriswrast.c |  3 ---
 2 files changed, 3 insertions(+), 29 deletions(-)

diff --git a/glx/glxdri2.c b/glx/glxdri2.c
index 2e24b56e6c..28d5a3a9c0 100644
--- a/glx/glxdri2.c
+++ b/glx/glxdri2.c
@@ -827,10 +827,7 @@ initializeExtensions(__GLXscreen * screen)
 extensions = dri->core->getExtensions(dri->driScreen);
 
 __glXEnableExtension(screen->glx_enable_bits, "GLX_MESA_copy_sub_buffer");
-LogMessage(X_INFO, "AIGLX: enabled GLX_MESA_copy_sub_buffer\n");
-
 __glXEnableExtension(screen->glx_enable_bits, "GLX_EXT_no_config_context");
-LogMessage(X_INFO, "AIGLX: enabled GLX_EXT_no_config_context\n");
 
 if (dri->dri2->base.version >= 3) {
 __glXEnableExtension(screen->glx_enable_bits,
@@ -841,45 +838,27 @@ initializeExtensions(__GLXscreen * screen)
  "GLX_EXT_create_context_es_profile");
 __glXEnableExtension(screen->glx_enable_bits,
  "GLX_EXT_create_context_es2_profile");
-LogMessage(X_INFO, "AIGLX: enabled GLX_ARB_create_context\n");
-LogMessage(X_INFO, "AIGLX: enabled GLX_ARB_create_context_profile\n");
-LogMessage(X_INFO,
-   "AIGLX: enabled GLX_EXT_create_context_es{,2}_profile\n");
 }
 
 if (DRI2HasSwapControl(pScreen)) {
 __glXEnableExtension(screen->glx_enable_bits, "GLX_INTEL_swap_event");
 __glXEnableExtension(screen->glx_enable_bits, "GLX_SGI_swap_control");
-LogMessage(X_INFO, "AIGLX: enabled GLX_INTEL_swap_event\n");
-LogMessage(X_INFO, "AIGLX: enabled GLX_SGI_swap_control\n");
 }
 
 /* enable EXT_framebuffer_sRGB extension (even if there are no sRGB 
capable fbconfigs) */
-{
-__glXEnableExtension(screen->glx_enable_bits,
- "GLX_EXT_framebuffer_sRGB");
-LogMessage(X_INFO, "AIGLX: enabled GLX_EXT_framebuffer_sRGB\n");
-}
+__glXEnableExtension(screen->glx_enable_bits, "GLX_EXT_framebuffer_sRGB");
 
 /* enable ARB_fbconfig_float extension (even if there are no float 
fbconfigs) */
-{
-__glXEnableExtension(screen->glx_enable_bits, 
"GLX_ARB_fbconfig_float");
-LogMessage(X_INFO, "AIGLX: enabled GLX_ARB_fbconfig_float\n");
-}
+__glXEnableExtension(screen->glx_enable_bits, "GLX_ARB_fbconfig_float");
 
 /* enable EXT_fbconfig_packed_float (even if there are no packed float 
fbconfigs) */
-{
-__glXEnableExtension(screen->glx_enable_bits, 
"GLX_EXT_fbconfig_packed_float");
-LogMessage(X_INFO, "AIGLX: enabled GLX_EXT_fbconfig_packed_float\n");
-}
+__glXEnableExtension(screen->glx_enable_bits, 
"GLX_EXT_fbconfig_packed_float");
 
 for (i = 0; extensions[i]; i++) {
 if (strcmp(extensions[i]->name, __DRI_TEX_BUFFER) == 0) {
 dri->texBuffer = (const __DRItexBufferExtension *) extensions[i];
 __glXEnableExtension(screen->glx_enable_bits,
  "GLX_EXT_texture_from_pixmap");
-LogMessage(X_INFO,
-   "AIGLX: GLX_EXT_texture_from_pixmap backed by buffer 
objects\n");
 }
 
 if (strcmp(extensions[i]->name, __DRI2_FLUSH) == 0 &&
@@ -891,8 +870,6 @@ initializeExtensions(__GLXscreen * screen)
 dri->dri2->base.version >= 3) {
 __glXEnableExtension(screen->glx_enable_bits,
  "GLX_ARB_create_context_robustness");
-LogMessage(X_INFO,
-   "AIGLX: enabled GLX_ARB_create_context_robustness\n");
 }
 
 #ifdef __DRI2_FLUSH_CONTROL
diff --git a/glx/glxdriswrast.c b/glx/glxdriswrast.c
index adc97df93e..caad9a1fe7 100644
--- a/glx/glxdriswrast.c
+++ b/glx/glxdriswrast.c
@@ -351,10 +351,7 @@ initializeExtensions(__GLXscreen * screen)
 int i;
 
 __glXEnableExtension(screen->glx_enable_bits, "GLX_MESA_copy_sub_buffer");
-LogMessage(X_INFO, "IGLX: enabled GLX_MESA_copy_sub_buffer\n");
-
 __glXEnableExtension(screen->glx_enable_bits, "GLX_EXT_no_config_context");
-LogMessage(X_INFO, "IGLX: enabled GLX_EXT_no_config_context\n");
 
 if (dri->swrast->base.version >= 3) {
 __glXEnableExtension(screen->glx_enable_bits,
-- 
2.14.3

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel