Re: [PATCH xserver 1/5] xfree86/modes: Refactor xf86_use_hw_cursor_argb to use xf86_use_hw_cursor

Michel Dänzer writes: > Sounds good to me. > > One thing that might be nice to do as part of your patch would be moving > the xf86_config->cursor = NULL assignment from xf86_cursors_init to > xf86_hide_cursors. That way xf86_config->cursor would always be NULL > while the

Re: [PATCH xserver 1/5] xfree86/modes: Refactor xf86_use_hw_cursor_argb to use xf86_use_hw_cursor

On 09.03.2016 12:46, Keith Packard wrote: > Michel Dänzer writes: > >> Unfortunately, the reality is that at least the radeon and amdgpu >> drivers do use it. > > Even modesetting uses it; there isn't any other public interface to get > the current cursor. > > What do you

Re: [PATCH xserver 1/5] xfree86/modes: Refactor xf86_use_hw_cursor_argb to use xf86_use_hw_cursor

Michel Dänzer writes: > Unfortunately, the reality is that at least the radeon and amdgpu > drivers do use it. Even modesetting uses it; there isn't any other public interface to get the current cursor. What do you think about eliminating the RefCursor/FreeCursor bits and

Re: [PATCH xserver 1/5] xfree86/modes: Refactor xf86_use_hw_cursor_argb to use xf86_use_hw_cursor

On 09.03.2016 05:57, Keith Packard wrote: > Michel Dänzer writes: > >> It seems to work fine in my quick testing. However, I'm not sure it's >> worth it, given that v2 of patch 1 fixes holding on to the last HW >> cursor indefinitely, and given the churn it would cause for

Re: [PATCH xserver 1/5] xfree86/modes: Refactor xf86_use_hw_cursor_argb to use xf86_use_hw_cursor

Michel Dänzer writes: > It seems to work fine in my quick testing. However, I'm not sure it's > worth it, given that v2 of patch 1 fixes holding on to the last HW > cursor indefinitely, and given the churn it would cause for external > drivers. I guess I don't see how this

Re: [PATCH xserver 1/5] xfree86/modes: Refactor xf86_use_hw_cursor_argb to use xf86_use_hw_cursor

On 25.12.2015 03:06, Keith Packard wrote: > Michel Dänzer writes: > >> From: Michel Dänzer >> >> This reduces code duplication. >> >> One side effect of this change is that xf86_config->cursor will no longer >> be updated for cursors which cannot use

Re: [PATCH xserver 1/5] xfree86/modes: Refactor xf86_use_hw_cursor_argb to use xf86_use_hw_cursor

Michel Dänzer writes: > From: Michel Dänzer > > This reduces code duplication. > > One side effect of this change is that xf86_config->cursor will no longer > be updated for cursors which cannot use the HW cursor. That means we'll be holding on to

[PATCH xserver 1/5] xfree86/modes: Refactor xf86_use_hw_cursor_argb to use xf86_use_hw_cursor

From: Michel Dänzer This reduces code duplication. One side effect of this change is that xf86_config->cursor will no longer be updated for cursors which cannot use the HW cursor. Signed-off-by: Michel Dänzer --- The side effect might actually