Re: [PATCH xserver 2/2 v3] glamor: Avoid overflow between box32 and box16 box

2017-09-13 Thread Adam Jackson
On Wed, 2017-09-13 at 07:46 -0400, Olivier Fourdan wrote: > Hi all, > > Before I forget, would it be possible to consider these two patches for > glamor: > > https://patchwork.freedesktop.org/series/27940/ > > This patch was successfully tested by Fabrice here (the reproducer is in bug >

Re: [PATCH xserver 2/2 v3] glamor: Avoid overflow between box32 and box16 box

2017-09-13 Thread Olivier Fourdan
Hi all, Before I forget, would it be possible to consider these two patches for glamor: https://patchwork.freedesktop.org/series/27940/ This patch was successfully tested by Fabrice here (the reproducer is in bug #101894): https://lists.x.org/archives/xorg-devel/2017-July/054174.html And

Re: [PATCH xserver 2/2 v3] glamor: Avoid overflow between box32 and box16 box

2017-07-27 Thread Fabrice Bellet
On 07/26/17 at 04:00pm, Olivier Fourdan wrote: > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=101894 > Signed-off-by: Olivier Fourdan Tested-by: Fabrice Bellet It works for me, thanks, -- fabrice

[PATCH xserver 2/2 v3] glamor: Avoid overflow between box32 and box16 box

2017-07-26 Thread Olivier Fourdan
glamor_compute_transform_clipped_regions() uses a temporary box32 internally which is copied back to a box16 to init the regions16, thus causing a potential overflow. If an overflow occurs, the given region is invalid and the pixmap init region will fail. Simply check that the coordinates won't