Re: [PATCH xserver 6/6] mi: Mention extension loading in verbose logs

2018-02-21 Thread Emil Velikov 
On 21 February 2018 at 16:42, Adam Jackson  wrote:
> On Mon, 2018-02-19 at 15:18 +, Emil Velikov wrote:
>> From: Emil Velikov 
>>
>> Listing the extensions is useful, despite being annoying for normal
>> usecases. Print it only when extra (lvl 3) vebose is requested.
>
> I appreciate lowering the log verbosity, but this repeats both of the
> problems I mentioned when I took this printf out the first time: "a)
> we're printing a line for every extension, whether it's enabled or
> not, and b) we're not actually initializing the extension at this
> point." (8468e2443)
>
> Put it just before the call to ->initFunc in InitExtensions to fix both
> issues.
>
Ack. Patch updated [1] with a copy in your inbox, in case it helps.


> Merged 1-5, thanks:
>
Thanks
Emil

[1] https://patchwork.freedesktop.org/patch/205981/
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 6/6] mi: Mention extension loading in verbose logs

2018-02-21 Thread Adam Jackson 
On Mon, 2018-02-19 at 15:18 +, Emil Velikov wrote:
> From: Emil Velikov 
> 
> Listing the extensions is useful, despite being annoying for normal
> usecases. Print it only when extra (lvl 3) vebose is requested.

I appreciate lowering the log verbosity, but this repeats both of the
problems I mentioned when I took this printf out the first time: "a)
we're printing a line for every extension, whether it's enabled or
not, and b) we're not actually initializing the extension at this
point." (8468e2443)

Put it just before the call to ->initFunc in InitExtensions to fix both
issues.

Merged 1-5, thanks:

remote: I: patch #205455 updated using rev 
1310241e8d606687811c7394811fe337c3e4de11.
remote: I: patch #205456 updated using rev 
7fc757986947ad89d76fc0fd3d69f5fdeefc9055.
remote: I: patch #205457 updated using rev 
edc00e020310d8f53ebc16295c373fe84ec6ec87.
remote: I: patch #205458 updated using rev 
089a1b0f9fa2e80457dc3d5f05c84565c9113a21.
remote: I: patch #205459 updated using rev 
9237c5e2878c088a6cd26ea380763465a9e67012.
remote: I: 5 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   a05453266..9237c5e28  master -> master

- ajax
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver 6/6] mi: Mention extension loading in verbose logs

2018-02-19 Thread Emil Velikov 
From: Emil Velikov 

Listing the extensions is useful, despite being annoying for normal
usecases. Print it only when extra (lvl 3) vebose is requested.

Signed-off-by: Emil Velikov 
---
 mi/miinitext.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/mi/miinitext.c b/mi/miinitext.c
index e55073bf3..abe3fce8c 100644
--- a/mi/miinitext.c
+++ b/mi/miinitext.c
@@ -104,6 +104,7 @@ SOFTWARE.
 #include "nonsdk_extinit.h"
 #endif
 #include "micmap.h"
+#include "os.h"
 #include "globals.h"
 
 /* List of built-in (statically linked) extensions */
@@ -302,6 +303,9 @@ LoadExtensionList(const ExtensionModule ext[], int size, 
Bool builtin)
 return;
 
 for (i = 0; i < size; i++, newext++) {
+LogMessageVerb(X_INFO, 3, "Loading%s extension %s\n", builtin ?
+   " built-in" : "", ext[i].name);
+
 newext->name = ext[i].name;
 newext->initFunc = ext[i].initFunc;
 newext->disablePtr = ext[i].disablePtr;
-- 
2.16.0

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel