Re: Please revert Re: [PATCH 1/4] dix: Remove usage_class from pixmaps, store it in -drawable.class

2011-03-18 Thread Keith Packard
On Fri, 18 Mar 2011 14:35:01 +1000, Dave Airlie airl...@gmail.com wrote: Please revert 1564c82417d201de5b9a5ec5e7aa4ef14c45fbad (commit for this patch). Merged. d5b16b037b8fe12ba85c68c8289b6a8cc5e3a09d -- keith.pack...@intel.com pgp063pmEhgfw.pgp Description: PGP signature

Re: Please revert Re: [PATCH 1/4] dix: Remove usage_class from pixmaps, store it in -drawable.class

2011-03-18 Thread Adam Jackson
On 3/18/11 12:35 AM, Dave Airlie wrote: Hi Keith, Please revert 1564c82417d201de5b9a5ec5e7aa4ef14c45fbad (commit for this patch). The drivers used the top bits of the usage_hint to store driver private flags (intel, radeon, nouveau). With EXA we need to get at this data so if we migrate the

Re: Please revert Re: [PATCH 1/4] dix: Remove usage_class from pixmaps, store it in -drawable.class

2011-03-18 Thread Keith Packard
On Fri, 18 Mar 2011 14:56:45 -0400, Adam Jackson a...@nwnk.net wrote: Weak. I feel like there should be some cleaner way to do that. No argument here. The usage_hint is the only spot to stick driver-specific data in the create_pixmap call. -- keith.pack...@intel.com pgpX1hXx3T9ct.pgp

Please revert Re: [PATCH 1/4] dix: Remove usage_class from pixmaps, store it in -drawable.class

2011-03-17 Thread Dave Airlie
Hi Keith, Please revert 1564c82417d201de5b9a5ec5e7aa4ef14c45fbad (commit for this patch). The drivers used the top bits of the usage_hint to store driver private flags (intel, radeon, nouveau). With EXA we need to get at this data so if we migrate the pixmap we can create the correct type of