Re: xserver 1.20 RC1 tomorrow

[Adam Jackson]

On Wed, 2018-02-28 at 00:42 +, Daniel Stone wrote:

> > 3) https://patchwork.freedesktop.org/series/30946/
> > DMA fences for DRI3. Does have at least one ABI change that looks
> > essential, in misync.
> 
> I would certainly like to see this land, but there are some open
> questions it'd be great to get more feedback: namely, should we use
> the fences to schedule in-server (and not submit blits/flips until the
> fence has passed), or should we pass the fences into the client APIs
> (e.g. GPU command-stream wait on EGL-imported fences, KMS commit
> wait). The former is more obvious, but also a behavioural change from
> how we handled implicit fences previously.

I'm going to punt this to after 1.21 then, would rather not paint
ourselves into needless corners.

- ajax
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: xserver 1.20 RC1 tomorrow

[Adam Jackson]

On Wed, 2018-02-28 at 00:42 +, Daniel Stone wrote:
> Hi,
> 
> On 27 February 2018 at 21:59, Adam Jackson  wrote:
> > 2) https://patchwork.freedesktop.org/series/27289/
> > DRI3 v1.2. Has some ABI changes, but none that are essential, the old
> > single-fd API can either be kept as is, or implemented in terms opf the
> > new multiple-fd API.
> 
> Perhaps I'm being dense, but I can't see that this does have driver
> ABI changes? The old single-plane hooks are still in place, and the
> core has helpers to call them if possible (single-plane, no modifier,
> driver doesn't have newer hook). We do change the helper to be
> multi-FD rather than single FD, but that's just in dri3_priv.h, so
> presumably not ABI?

D'oh, you are correct. I was grepping for dri3_pixmap_from_fd and
didn't notice they were all substring matches.

- ajax
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: xserver 1.20 RC1 tomorrow

[Roman Gilg]

On Tue, Feb 27, 2018 at 10:59 PM, Adam Jackson  wrote:
> 4) https://patchwork.freedesktop.org/series/37274/
> Per-window flips for Xwayland. No xfree86 changes.

Michel gave me feedback on my patches in the last weeks and I did
changes to some parts because of that. I planned on posting a new
patch series with these changes replacing the current one. I can do
this today.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: xserver 1.20 RC1 tomorrow

[Daniel Stone]

Hi,

On 27 February 2018 at 21:59, Adam Jackson  wrote:
> 2) https://patchwork.freedesktop.org/series/27289/
> DRI3 v1.2. Has some ABI changes, but none that are essential, the old
> single-fd API can either be kept as is, or implemented in terms opf the
> new multiple-fd API.

Perhaps I'm being dense, but I can't see that this does have driver
ABI changes? The old single-plane hooks are still in place, and the
core has helpers to call them if possible (single-plane, no modifier,
driver doesn't have newer hook). We do change the helper to be
multi-FD rather than single FD, but that's just in dri3_priv.h, so
presumably not ABI?

> 3) https://patchwork.freedesktop.org/series/30946/
> DMA fences for DRI3. Does have at least one ABI change that looks
> essential, in misync.

I would certainly like to see this land, but there are some open
questions it'd be great to get more feedback: namely, should we use
the fences to schedule in-server (and not submit blits/flips until the
fence has passed), or should we pass the fences into the client APIs
(e.g. GPU command-stream wait on EGL-imported fences, KMS commit
wait). The former is more obvious, but also a behavioural change from
how we handled implicit fences previously.

> 4) https://patchwork.freedesktop.org/series/37274/
> Per-window flips for Xwayland. No xfree86 changes.

I'd quite like to give this another review pass, especially for
subsurfaces, but generally if Michel is happy than I am.

Cheers,
Daniel
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

xserver 1.20 RC1 tomorrow

[Adam Jackson]

I'd like to call the (xfree86) ABI frozen in RC1, and I think for the
remaining changes I'd like to see landed for 1.20 we can mostly land
them without ABI breaks. To enumerate:

1) https://patchwork.freedesktop.org/series/38022/ 
Xwayland streams support. No xfree86 changes.

2) https://patchwork.freedesktop.org/series/27289/
DRI3 v1.2. Has some ABI changes, but none that are essential, the old
single-fd API can either be kept as is, or implemented in terms opf the
new multiple-fd API.

3) https://patchwork.freedesktop.org/series/30946/
DMA fences for DRI3. Does have at least one ABI change that looks
essential, in misync. 

4) https://patchwork.freedesktop.org/series/37274/
Per-window flips for Xwayland. No xfree86 changes.

I'm not aware of any other major change series outstanding (that I
haven't myself written and failed to send). If you know of something
I've missed, please yell very loudly very soon.

Also, if you care about any of the above, patch review would be greatly
appreciated.

- ajax
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel