Re: [PATCH] test: write some event → XI1 conversion tests.

2011-02-21 Thread Daniel Stone
On Mon, Feb 21, 2011 at 03:44:31PM +1000, Peter Hutterer wrote: These tests don't test everything, but hey, life is short and I'm trying to have one. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital

Re: [PATCH] dix: a valuator count of 0 is valid (#34510)

2011-02-21 Thread Timo Aaltonen
On 21.02.2011 07:39, Peter Hutterer wrote: For all but motion and proximity events, having no valuators is ok. Regression from 1.9, keyboard events are not converted to protocol events. X.Org Bug 34510 http://bugs.freedesktop.org/show_bug.cgi?id=34510 Signed-off-by: Peter Hutterer

Re: [PATCH] exa/mixed: Partially restore deferred pixmap handling for frontbuffer.

2011-02-21 Thread Michel Dänzer
On Fre, 2011-02-18 at 14:23 +0100, Maarten Maathuis wrote: 2011/2/11 Maarten Maathuis madman2...@gmail.com: 2011/2/11 Michel Dänzer mic...@daenzer.net: On Don, 2011-02-10 at 20:44 +0100, Maarten Maathuis wrote: 2011/2/10 Michel Dänzer mic...@daenzer.net: On Don, 2011-02-10 at 20:15

Re: [PATCH] exa/mixed: Partially restore deferred pixmap handling for frontbuffer.

2011-02-21 Thread Ferry Huberts
On 02/21/2011 01:11 PM, Michel D�nzer wrote: On Fre, 2011-02-18 at 14:23 +0100, Maarten Maathuis wrote: 2011/2/11 Maarten Maathuis madman2...@gmail.com: 2011/2/11 Michel Dänzer mic...@daenzer.net: On Don, 2011-02-10 at 20:44 +0100, Maarten Maathuis wrote: 2011/2/10 Michel Dänzer

[PULL] XI1 keyboard conversion fix

2011-02-21 Thread Peter Hutterer
Keith, please pull those two into 1.10. the tests don't matter much, the first patch is a release blocker though (regression from 1.9, XI1 on keyboard events is broken). The following changes since commit b4ef34d4664e0eaac7211f7a22a2025958aa1527: Revert exa/mixed: Exclude frontbuffer from

Re: [PULL] XI1 keyboard conversion fix

2011-02-21 Thread Keith Packard
On Tue, 22 Feb 2011 08:58:12 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Peter Hutterer (2): dix: a valuator number of 0 is valid (#34510) test: write some event → XI1 conversion tests. Merged b4ef34d..93a7399 master - master -- keith.pack...@intel.com

Re: [PATCH:xdm 2/5] Add echoPasswdChar resource to set character to display

2011-02-21 Thread Alan Coopersmith
On 02/20/11 03:24 AM, Mark Kettenis wrote: From: Alan Coopersmith alan.coopersm...@oracle.com Date: Sat, 19 Feb 2011 22:36:38 -0800 Stop hardcoding it to '*'. Allows setting a resource with no value to display to advance the cursor without drawing text. What's the motivation for this

[PATCH v2 1/5] greeter: inline valueMask for xpm window to avoid shadowing argument

2011-02-21 Thread Alan Coopersmith
The Realize function names one of its arguments valueMask, and the valueMask variable in the inner scope is just used as a static set of mask flags, so just pass them directly to the function to reduce confusion and clear the gcc -Wshadow warning: Login.c: In function `Realize': Login.c:1901:

[PATCH v2 2/5] greeter: Add echoPasswdChar resource to set character to display

2011-02-21 Thread Alan Coopersmith
Stop hardcoding it to '*'. Allows setting a resource with no value to to advance the cursor without drawing text (as was previously the default). Resolves https://bugs.freedesktop.org/show_bug.cgi?id=32794 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- Replaces patch 2/5 3/5

[PATCH v2 3/5] greeter: Make sure text input areas stay inside the lines

2011-02-21 Thread Alan Coopersmith
Regression introduced by f8585c60831a8e5ddebce18bdd7e78d217a822c5 broke bounds checking for text displayed in input fields. Since this makes each TEXT_WIDTH value only be used once, just use them directly instead of storing the result in a variable. Signed-off-by: Alan Coopersmith

[PATCH v2 4/5] greeter: Replace several #ifdef XPM blocks with LOGO_W macro

2011-02-21 Thread Alan Coopersmith
Refactor code assuming compiler is smart enough to optimize out any that reduce to + 0 or - 0 if building without XPM defined. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- New in v2 of this series. Simplifies things a little for patch 5/5. greeter/Login.c | 39

[PATCH v2 5/5] greeter: Make sure cursor stays in bounds too

2011-02-21 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- New in v2 of this series. greeter/Login.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/greeter/Login.c b/greeter/Login.c index 545f937..90b72fc 100644 --- a/greeter/Login.c +++

Re: Spinning in _XReply

2011-02-21 Thread Jeremy Huddleston
So... what should we do about this? I just got another report about IDL not working with the new libX11 (http://xquartz.macosforge.org/trac/ticket/469), and my hunch is that the user will provide me with a spindump that points to this issue again. On Jan 29, 2011, at 19:24, Pat Kane wrote:

Re: Spinning in _XReply

2011-02-21 Thread Pat Kane
On Mon, Feb 21, 2011 at 7:51 PM, Jeremy Huddleston jerem...@apple.com wrote: So... what should we do about this? A good first step would be to try come up with a small-ish test case, or to at least figure out how to reproduce the problem on another system. I use EMACS on my RHEL6 and

[PATCH] test: add some tests for basic list manipulation.

2011-02-21 Thread Peter Hutterer
This has less purpose as a test but more as documentation on how to actually use the differnent list calls. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/Makefile.am |3 +- test/list.c | 176 ++ 2 files changed, 178

[PATCH] include: document list interface.

2011-02-21 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- include/list.h | 182 +++- 1 files changed, 180 insertions(+), 2 deletions(-) diff --git a/include/list.h b/include/list.h index 4ce20a8..3c8c754 100644 --- a/include/list.h +++

Re: Spinning in _XReply

2011-02-21 Thread Jeremy Huddleston
On Feb 21, 2011, at 19:03, Pat Kane wrote: On Mon, Feb 21, 2011 at 7:51 PM, Jeremy Huddleston jerem...@apple.com wrote: So... what should we do about this? A good first step would be to try come up with a small-ish test case, or to at least figure out how to reproduce the problem on

[Patch 0/8] Pointer barriers

2011-02-21 Thread Peter Hutterer
This patchset adds support for Pointer Barriers in the server (albeit without per-device support). Branch is available on cgit: http://cgit.freedesktop.org/~whot/xserver/log/?h=pointer-barriers Ajax already sent out the protocol/libXfixes patches a while ago, these are required for this branch

[PATCH 1/8] dix: Add IsFloating(device) wrapper.

2011-02-21 Thread Peter Hutterer
Simplifies check for floating devices. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/events.c |7 +++ include/dix.h |1 + 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/dix/events.c b/dix/events.c index 07f8b05..d2be84f 100644 --- a/dix/events.c +++

[PATCH 2/8] Add mode field to pointer movement hooks.

2011-02-21 Thread Peter Hutterer
Preparation work for pointer barriers. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/getevents.c | 12 +--- mi/mipointer.c | 19 ++- mi/mipointer.h |1 + 3 files changed, 28 insertions(+), 4 deletions(-) diff --git a/dix/getevents.c

[PATCH 3/8] mi: document miPointerSetCursorPosition

2011-02-21 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- mi/mipointer.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/mi/mipointer.c b/mi/mipointer.c index 0ecd915..250d26b 100644 --- a/mi/mipointer.c +++ b/mi/mipointer.c @@ -222,6 +222,30 @@

[PATCH 4/8] Add mode field to ConstrainCursorHarder.

2011-02-21 Thread Peter Hutterer
For Pointer Barriers, the movement mode is important and must be passed through. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- include/scrnintstr.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/scrnintstr.h b/include/scrnintstr.h index

[PATCH 5/8] mi: Call pScreen-ConstrainCursorHarder from the position update path

2011-02-21 Thread Peter Hutterer
From: Adam Jackson a...@redhat.com v2: Cover more paths, spotted by Daniel Stone. v3: pass down the mode field for movement mode. Reviewed-by: Daniel Stone dan...@fooishbar.org Signed-off-by: Adam Jackson a...@redhat.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- mi/mipointer.c

[PATCH 6/8] randr: Add RRConstrainCursorHarder

2011-02-21 Thread Peter Hutterer
From: Adam Jackson a...@redhat.com Confine cursor motion to within the bounds of a single CRTC, iff all the CRTCs within a ScreenRec are reachable from each other. If not you get the same cursor floats within the bounding rect behaviour you get now. v3: - Incorporate review feedback from

[PATCH 7/8] fixes: add support for Pointer Barriers

2011-02-21 Thread Peter Hutterer
From: Adam Jackson a...@redhat.com Pointer barriers block the movement of a pointer past a certain line, specified by the barrier. Movement through the barrier may be permitted for certain directions of movement. Algorithm used: For each movement, find the nearest-to-origin-of-movement barrier

[PATCH 8/8] xfixes: use struct list for pointer barriers.

2011-02-21 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- xfixes/cursor.c | 20 +--- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/xfixes/cursor.c b/xfixes/cursor.c index 3cafc24..1be6e18 100644 --- a/xfixes/cursor.c +++ b/xfixes/cursor.c @@ -116,7 +116,7 @@

Re: Spinning in _XReply

2011-02-21 Thread Pat Kane
On Mon, Feb 21, 2011 at 9:38 PM, Jeremy Huddleston jerem...@apple.com wrote: IDL is a data visualization package used a lot by astrophysicists \ (http://www.ittvis.com/ProductServices/IDL.aspx) Thanks, I'll take a look at IDL.  Should we actualy support calling _XReply from an error

Re: [PATCH evdev] Export device node as property.

2011-02-21 Thread Peter Hutterer
On Tue, Feb 08, 2011 at 07:42:31AM +0100, Lennart Poettering wrote: On Mon, 07.02.11 23:12, Daniel Stone (dan...@fooishbar.org) wrote: Hi, On Tue, Feb 08, 2011 at 08:32:16AM +1000, Peter Hutterer wrote: CC'ing Lennart, he can contribute more details I supposed. On Mon, Feb 07,

[PATCH v2 setxkbmap] man: multiple layouts can be specified (#34118)

2011-02-21 Thread Peter Hutterer
Same applies to variant. X.Org Bug 34118 http://bugs.freedesktop.org/show_bug.cgi?id=34118 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- I guess the matching should be explained with an example somewhere, but for now this will do man/setxkbmap.man | 10 ++ 1 files

Re: [PATCH setxkbmap] Set of macros converted to enum type.

2011-02-21 Thread Peter Hutterer
On Fri, Feb 18, 2011 at 11:00:55PM +0300, Lev Nezhdanov wrote: Signed-off-by: Van de Bugger van.de.bug...@gmail.com merged, thanks. for future patches, if you re-send a modified patch please use a prefix of [PATCH v2 setxkbmap] etc. so it is easier to find on a glance which one the most

[PATCH setxkbmap 1/2] Removed unused arg subdir in function findFileInPath()

2011-02-21 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- setxkbmap.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/setxkbmap.c b/setxkbmap.c index 0c43be5..1c9c89e 100644 --- a/setxkbmap.c +++ b/setxkbmap.c @@ -178,7 +178,7 @@ Bool setOptString(int

[PATCH setxkbmap 2/2] Removed unneeded arg name in applyConfig()

2011-02-21 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- setxkbmap.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/setxkbmap.c b/setxkbmap.c index 1c9c89e..6c678ff 100644 --- a/setxkbmap.c +++ b/setxkbmap.c @@ -181,7 +181,7 @@ Bool

Re: [PATCH setxkbap] Minor style fixes.

2011-02-21 Thread Peter Hutterer
On Fri, Feb 18, 2011 at 11:21:34PM +0300, Van de Bugger wrote: Few tabs replaced with spaces; pointers are written as list_t *list (no space between asterisk and variable name). --- merged, thanks. Cheers, Peter setxkbmap.c | 28 ++-- 1 files changed, 14

Re: [PATCH 10/20] Switch to use IsFloating()

2011-02-21 Thread Benjamin Tissoires
Hi Peter, Except two unnecessary parenthesis here, you can add my Reviewed-by for the series ;) On 02/18/2011 04:52 AM, Peter Hutterer wrote: This is not a straightforward search/replacement due to a long-standing issue. dev-u.master is the same field as dev-u.lastSlave. Thus, if dev is a