[ANNOUNCE] xserver 1.20 RC1

This is the first release candidate for xserver 1.20. Notable changes since 1.19 include: - RANDR 1.6, which enables leasing RANDR resources to a client for its exclusive use (e.g. head mounted displays) - Depth 30 support in glamor and the modesetting driver - A meson-based build system,

Re: xserver 1.20 RC1 tomorrow

On Wed, 2018-02-28 at 00:42 +, Daniel Stone wrote: > > 3) https://patchwork.freedesktop.org/series/30946/ > > DMA fences for DRI3. Does have at least one ABI change that looks > > essential, in misync. > > I would certainly like to see this land, but there are some open > questions it'd be

Fwd: [Bug 105287] X server requires "randrproto >= 1.6.0", but git head of randrproto is still at 1.5.0

Now that we've switched to the new xorgproto repo, should we add notices to the configure.ac of the old *proto repo like we've done for abandoned drivers to tell people who don't follow our mailing lists to switch over to it? -alan- Forwarded Message Subject:

Re: Fwd: [Bug 105287] X server requires "randrproto >= 1.6.0", but git head of randrproto is still at 1.5.0

On 02/28/18 01:37 PM, Keith Packard wrote: > Alan Coopersmith writes: > >> Xserver depending on specific version of xorgproto (which provides now all >> these headers), instead of there being separate pgkconfig file & check for >> each >> of the headers, would IMHO

Re: Fwd: [Bug 105287] X server requires "randrproto >= 1.6.0", but git head of randrproto is still at 1.5.0

Alan Coopersmith writes: > We've had two bugs filed this morning that xserver git is broken because > it depends on a non-existent randrproto, so while the other 20-something > protos would be nice, putting a "You need to use xorgproto git instead" > notice in

Re: Fwd: [Bug 105287] X server requires "randrproto >= 1.6.0", but git head of randrproto is still at 1.5.0

Alan Coopersmith writes: > Xserver depending on specific version of xorgproto (which provides now all > these headers), instead of there being separate pgkconfig file & check for > each > of the headers, would IMHO make this transition a lot clearer to everybody who

[PATCH xserver v2] fixing -logfile when used with -displayfd

Hi, v2 updated with the feedback from Alan: the LogSetDisplay function is the right place for this fix. Trivial way to reproduce the bug: Xorg -logfile /tmp/mylog -config /etc/xpra/xorg.conf -displayfd 2 The server then moans: Failed to rename log file "/tmp/mylog" to "/tmp/mylog": No such file

Re: [PATCH util/modular] xorg.modules: Replace individual proto modules with xorgproto

On Wed, Feb 28, 2018 at 7:04 AM, Jon Turney wrote: > Signed-off-by: Jon Turney > --- > xorg.modules | 845 > ++- > 1 file changed, 143 insertions(+), 702 deletions(-) > > diff

[PATCH util/modular] xorg.modules: Replace individual proto modules with xorgproto

Signed-off-by: Jon Turney --- xorg.modules | 845 ++- 1 file changed, 143 insertions(+), 702 deletions(-) diff --git a/xorg.modules b/xorg.modules index b34d14d..93bc8cf 100644 --- a/xorg.modules +++

[PATCH xorgproto] Spelling and grammar fixes

Signed-off-by: Giuseppe Bilotta --- compositeproto.txt | 6 +++--- dri2proto.txt | 10 +- presentproto.txt | 2 +- randrproto.txt | 8 renderproto.txt| 2 +- xv-protocol-v2.txt | 2 +- 6 files changed, 15 insertions(+), 15

Re: [PATCH xserver 3/7] randr: Support "non-desktop" property

On 2018-02-12 10:51 PM, Keith Packard wrote: > Tracks changes to the non-desktop property so that when non-zero, > outputs will always appear to be disconnected. > > Signed-off-by: Keith Packard > Reviewed-by: Adam Jackson This crashes on startup with a GPU

Re: [PATCH util/modular] xorg.modules: Replace individual proto modules with xorgproto

On 28 February 2018 at 13:04, Jon Turney wrote: > Signed-off-by: Jon Turney > --- > xorg.modules | 845 > ++- > 1 file changed, 143 insertions(+), 702 deletions(-) > > diff --git

Re: [PATCH xserver 3/7] randr: Support "non-desktop" property

On 2018-02-12 10:51 PM, Keith Packard wrote: > Tracks changes to the non-desktop property so that when non-zero, > outputs will always appear to be disconnected. > > Signed-off-by: Keith Packard > Reviewed-by: Adam Jackson [...] > @@ -442,6 +465,7 @@

Re: xserver 1.20 RC1 tomorrow

On Wed, 2018-02-28 at 00:42 +, Daniel Stone wrote: > Hi, > > On 27 February 2018 at 21:59, Adam Jackson wrote: > > 2) https://patchwork.freedesktop.org/series/27289/ > > DRI3 v1.2. Has some ABI changes, but none that are essential, the old > > single-fd API can either be kept

Re: [PATCH xorgproto v8 01/14] dri3: Add modifier/multi-plane requests, bump to v1.2

Daniel Stone writes: > From: Louis-Francis Ratté-Boulianne > > DRI3 version 1.2 adds support for explicit format modifiers, > including multi-planar buffers. Thanks for the awesome writeup on synchronization. It looks good to me. Reviewed-by: Keith

Re: [PATCH xorgproto] Spelling and grammar fixes

Giuseppe Bilotta writes: > Signed-off-by: Giuseppe Bilotta Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

[PATCH xserver v2 14/22] present: Add window flip mode

In contrast to screen flip mode this mode: * supports flips per windows (these windows currently need to have the same size as their parent windows with the same pixmap), * sends pixmap idle signals to the client only after the driver has given an additional event notify. This patch only

[PATCH xserver v2 20/22] xwayland: Add fallback timer for msc counting

When the compositor is not sending frame callbacks while we still wait on buffer release events fake a continuous msc counter with a timer. Having this timer is a prerequisite for queuing events. Signed-off-by: Roman Gilg --- hw/xwayland/xwayland-present.c | 70

[PATCH xserver v2 19/22] xwayland: Preliminary support for Present's new window flip mode

Introduce support for Present's window flip mode. The support is not yet complete, but works reasonable well for the most important use case, that is fullscreen applications. We take a Present flip and if the xwl_window->window has the same dimensions as the presenting window, the flip is

[PATCH xserver v2 21/22] xwayland: Implement queuing present vblanks

Queue present events to msc values. Fake msc events with a refresh rate of about 60fps when flips are not possible. When flips are executed rely on frame callbacks with a slow updating timer as fallback. This is important for applications, that want to limit their framerate. Signed-off-by: Roman

[PATCH xserver v2 22/22] xwayland: Guard against very late vblanks

Do not allow queuing events too far into the the future. The result can be a presentation freeze until the msc time is reached. At the moment clients might do this per accident, because the fake vblank code in Present and the xfree86 driver tolerate high 64bit msc values without freeze due to an

[PATCH xserver v2 18/22] xwayland: Add arguments to glamor_pixmap_get_wl_buffer

Add arguments to give the caller more information and control over the creation of a wl_buffer with GBM, in particular let the caller determine the size of the buffer. Signed-off-by: Roman Gilg --- hw/xwayland/xwayland-glamor.c | 19 +++ hw/xwayland/xwayland.c

Re: [PATCH xorgproto v8 02/14] presentproto: PresentCompleteModeSuboptimalCopy flag

On Wed, 2018-02-28 at 01:19 +, Daniel Stone wrote: > From: Louis-Francis Ratté-Boulianne > > If the Complete event has this mode, the client is not using > the more optimal format/modifier for the buffer allocation. The > client must explicitely inform the server that it

[PATCH xserver v2 16/22] present: Add cleanups for window flip mode

Make sure that vblanks and windows get cleaned up correctly in window flip mode. Signed-off-by: Roman Gilg --- present/present_screen.c | 33 - present/present_vblank.c | 2 ++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git

[PATCH xserver] randr: Fix a crash on initialization with GPU screens

RRSetChanged (immediately above) was immune to screens with no master, but RRTellChanged was not: Thread 1 "X" received signal SIGSEGV, Segmentation fault. RRTellChanged (pScreen=) at ../../randr/randr.c:576 576 mastersp = rrGetScrPriv(master); (gdb) bt #0

[PATCH xserver v2 02/22] present: Preliminary internal flip mode API

Add some basic function hooks to our future present-internal flip mode API, that will allow us to share functionality in between modes and move more code in separate files. Signed-off-by: Roman Gilg --- present/present_priv.h | 26 +++---

[PATCH xserver v2 00/22] Per window flips in Present with support for them in Xwayland

This revision provides changes requested by Michel Dänzer. In particular flips without copies in window flip mode are now possible and clients can queue flips on Xwayland. ___ xorg-devel@lists.x.org: X.Org development Archives:

[PATCH xserver v2 01/22] present: Move screen flip functionality in separate file

As a preperation for future flip mode alternatives move most of the functionality from 'present.c' into a separate file. Leave some functions needed by future other flip modes in 'present.c'. Signed-off-by: Roman Gilg --- present/Makefile.am| 1 + present/meson.build

Re: [PATCH v8 00/14] DRI3 multi-plane and modifier support

On Wed, 2018-02-28 at 01:45 +, Daniel Stone wrote: > Hi, > > On 28 February 2018 at 01:19, Daniel Stone > wrote: > > The major change is that the DRI3 protocol version has been bumped > > from > > 1.1 to 1.2, as there was previously a dri3proto-1.1 release, only > >

Re: [PATCH xserver 3/7] randr: Support "non-desktop" property

On Wed, 2018-02-28 at 16:35 +0100, Michel Dänzer wrote: > On 2018-02-12 10:51 PM, Keith Packard wrote: > > Tracks changes to the non-desktop property so that when non-zero, > > outputs will always appear to be disconnected. > > > > Signed-off-by: Keith Packard > > Reviewed-by:

[PATCH xserver v2 04/22] present: Add flip mode API hooks for several functions

Add 'queue_vblank', 'flush' and 're_execute' hooks, that are supposed to be shared with other flip modes. Signed-off-by: Roman Gilg --- present/present_priv.h | 12 present/present_scmd.c | 3 +++ 2 files changed, 15 insertions(+) diff --git

[PATCH xserver v2 07/22] present: Move timings adjustment in common part of flip mode API

To reduce future code duplication refactor timings adjustment out as a separate function. Signed-off-by: Roman Gilg --- present/present.c | 38 ++ present/present_priv.h | 7 +++ present/present_scmd.c | 34

[PATCH xserver v2 03/22] present: Move vblank functionality in seperate file

With the new internal flip mode API move vblank creation and so on into a seperate file, such that it can be shared between flip modes. Signed-off-by: Roman Gilg --- present/Makefile.am | 3 +- present/meson.build | 1 + present/present_priv.h | 44

[PATCH xserver v2 08/22] present: Add more hooks to internal flip mode API

Add hooks to query caps, get crtcs, abort vblanks and destroy a flip. Signed-off-by: Roman Gilg --- present/present.c| 28 present/present_priv.h | 33 + present/present_scmd.c | 38

[PATCH xserver v2 06/22] present: Add flip mode API hook for present_pixmap

Make present_pixmap a common function callable by any flip mode. Signed-off-by: Roman Gilg --- present/present.c | 57 ++ present/present_priv.h | 68 +++--- present/present_scmd.c | 54

[PATCH xserver v2 12/22] present: Adapt flip mode API hooks for window flip mode

Flipping pixmaps per window needs additional arguments in the flip mode API. Add these as preperation for window flip mode. Signed-off-by: Roman Gilg --- present/present_execute.c | 2 ++ present/present_priv.h| 10 +++--- present/present_scmd.c| 8 +---

[PATCH xserver v2 05/22] present: Refactor execute in separate file

To be shared by multiple flip modes, refactor execute functionality, such that logical chunks can go in new separate file. Signed-off-by: Roman Gilg --- present/Makefile.am | 1 + present/meson.build | 1 + present/present_execute.c | 116

[PATCH xserver v2 09/22] present: Refactor present_screen_init

To initialize easily different flip modes, refactor 'present_screen_init'. Signed-off-by: Roman Gilg --- present/present_screen.c | 46 +- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/present/present_screen.c

[PATCH xserver v2 10/22] present: Add present_window_priv properties for window flip mode

For window flip mode data about flips needs to be stored per window. Add properties to 'present_window_priv' and initialize them on creation. Signed-off-by: Roman Gilg --- present/present_priv.h | 10 ++ present/present_screen.c | 6 ++ 2 files changed, 16

[PATCH xserver v2 17/22] present: Add exported init function of window flip mode

Allow drivers now to initialize window flip mode. Signed-off-by: Roman Gilg --- present/present.h| 2 ++ present/present_screen.c | 23 ++- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/present/present.h b/present/present.h index

[PATCH xserver v2 13/22] present: Add driver facing window flip mode hooks

To enable special functionality of window flips introduce for window flips a separate set of driver facing function hooks. Signed-off-by: Roman Gilg --- present/present.h | 43 +++ present/present_priv.h | 1 + 2 files changed, 44

[PATCH xserver v2 15/22] present: In window flip mode report damage on flip to driver

Calculate damage before trying to flip and report it to the driver. This allows drivers to optimize their rendering. Signed-off-by: Roman Gilg --- present/present.h | 3 ++- present/present_wnmd.c | 24 +--- 2 files changed, 15 insertions(+), 12

[PATCH xserver v2 11/22] present: Add flip_idler vblank property

Introduce vblank property for flip modes, that demand explicite allowance by the driver for vblanks to become idle. Signed-off-by: Roman Gilg --- present/present_priv.h | 1 + present/present_vblank.c | 1 + 2 files changed, 2 insertions(+) diff --git

Re: [PATCH xserver 3/7] randr: Support "non-desktop" property

On 2018-02-28 05:27 PM, Adam Jackson wrote: > On Wed, 2018-02-28 at 16:35 +0100, Michel Dänzer wrote: >> On 2018-02-12 10:51 PM, Keith Packard wrote: >>> Tracks changes to the non-desktop property so that when non-zero, >>> outputs will always appear to be disconnected. >>> >>> Signed-off-by:

Re: [PATCH xserver v2 22/22] xwayland: Guard against very late vblanks

On 2018-02-28 05:37 PM, Roman Gilg wrote: > Do not allow queuing events too far into the the future. The result can be a > presentation freeze until the msc time is reached. > > At the moment clients might do this per accident, because the fake vblank code > in Present and the xfree86 driver

Re: [PATCH xserver v2 00/22] Per window flips in Present with support for them in Xwayland

On 2018-02-28 05:36 PM, Roman Gilg wrote: > This revision provides changes requested by Michel Dänzer. In particular > flips without copies in window flip mode are now possible and clients can > queue flips on Xwayland. Thanks for that. It would be even better if queuing flips worked from the

Re: [PATCH xserver 3/7] randr: Support "non-desktop" property

Michel Dänzer writes: > Yeah, the duplicate line was removed by e4e3447603b5 ("Add RandR leases > with modesetting driver support [v6]"). So it's harmless, except > possibly when bisecting. I stumbled over it when reporting the GPU > screen crash. Sorry for that -- I messed

Re: [PATCH xserver v2 22/22] xwayland: Guard against very late vblanks

On Wed, Feb 28, 2018 at 6:43 PM, Michel Dänzer wrote: > I'm unable to reproduce the issue you described with Steam (without this > patch series applied). I'd really like to know where the bogus target > MSC values you're seeing are coming from. What are the values of the >

Re: [PATCH xserver v2 01/22] present: Move screen flip functionality in separate file

Roman Gilg writes: > As a preperation for future flip mode alternatives move most of the > functionality from 'present.c' into a separate file. > > Leave some functions needed by future other flip modes in 'present.c'. > > Signed-off-by: Roman Gilg (I