Re: Missing swapl() in Xext/saver.c?

2018-03-11 Thread Keith Packard
Mihai Moldovan writes: > Hi > > > In > https://cgit.freedesktop.org/xorg/xserver/commit/?id=9edcae78c46286baff42e74bfe26f6ae4d00fe01 > the swapl() call for stuff->suspend was removed. That sounds like a bad idea > to me? > > xScreenSaverSuspendReq to this day defines it as a

Re: Missing swapl() in Xext/saver.c?

2018-03-11 Thread Mihai Moldovan
* On 03/12/2018 05:13 AM, Keith Packard wrote: > Oh. This is pretty bad. 'Bool' is not a valid type in protocol headers, > it should have been BOOL. And, BOOL is a single byte. But, it is Bool, > and I guess that is generally 4 bytes on most architectures. > > The XCB headers define this field as