[PATCH xserver 1/3] os/WaitFor: Check timers on every iteration

2018-04-15 Thread Chris Wilson
Currently we only check timer expiry if there are no client fd (or other input) waiting to be serviced. This makes it very easy to starve the timers with long request queues, and so miss critical timestamps. The timer subsystem is just another input waiting to be serviced, so evaluate it on every

[PATCH xserver 2/3] os/WaitFor: Use xorg_list_append()

2018-04-15 Thread Chris Wilson
Currently, we use xorg_list_add(new, head->prev) which is functionaly equivalent to xorg_list_append(), but with more pointer chasing, so reduce the strain on the reader and compiler by using the simpler append(). Signed-off-by: Chris Wilson --- os/WaitFor.c | 2 +- 1 file changed, 1 insertion(+

[PATCH xserver 3/3] os/WaitFor: Use the simpler xorg_list_for_each_entry()

2018-04-15 Thread Chris Wilson
As we are not freeing elements while iterating the list of timers, we can forgo using the safe variant, and reduce the number of pointer dances required for the insertion sort. Signed-off-by: Chris Wilson --- os/WaitFor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/os

Re: [PATCH xserver 1/2] xf86-video-modesetting: Add ms_queue_vblank helper

2018-04-15 Thread Chris Wilson
Quoting Keith Packard (2017-09-29 07:20:46) > This provides an API wrapper around the kernel interface for queueing > a vblank event, simplifying all of the callers. > > Signed-off-by: Keith Packard > --- > diff --git a/hw/xfree86/drivers/modesetting/dri2.c > b/hw/xfree86/drivers/modesetting/dri

[PATCH xserver] dri3: Fix dri3_buffers_from_pixmap request.

2018-04-15 Thread Mario Kleiner
Sending pixmap depth and bpp was omitted, so the Mesa X11 + EGL + DRI3 side of things always failed to dri3_create_image_khr_pixmap_from_buffers(), which led to failure of X11 + EGL compositing under DRI3 under, e.g., KDE Plasma 5. Fixes: 6e7c40f62db6 ("dri3: Add multi-planar/modifier buffer reque

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-15 Thread Mario Kleiner
Hi again, with the fresh x-server patch i just sent out, the EGL + DRI3 problems under KDE are gone, at least as tested on an old Intel Ironlake and GeForce Tesla. I still see some more problems beyond those, which may or may not be related to the new DRI3.1/3.2 stuff. On KDE-5 the KDE panel occa

[PATCH xserver] modesetting: Move GBM code inside #ifdef GLAMOR_HAS_GBM

2018-04-15 Thread Matt Turner
Fixes a compilation error without Glamor. Bugzilla: https://bugs.gentoo.org/653288 Signed-off-by: Matt Turner --- Unfortunately, there's more: Xwayland fails to link without Glamor. hw/xfree86/drivers/modesetting/drmmode_display.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletion