Re: [PATCH xserver] modesetting: Fix inverted check in dri2 WaitMSC

2018-04-17 Thread Walter Harms
> Frank Binns hat am 16. April 2018 um 22:17 > geschrieben: > > > Adam Jackson writes: > > > ms_queue_vblank() returns false on failure. > > > > Reported-by: Chris Wilson > > Signed-off-by: Adam Jackson >

Re: [PATCH xserver] dri3: Fix dri3_buffers_from_pixmap request.

2018-04-17 Thread Adam Jackson
On Mon, 2018-04-16 at 21:27 +, Mike Lothian wrote: > Tested-by: Mike Lothian remote: I: patch #217200 updated using rev 4e92c51ce4d6ab50c1507a23a01c6be0d1954d79. remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver

Re: [PATCH xserver] modesetting: Fix inverted check in dri2 WaitMSC

2018-04-17 Thread Adam Jackson
On Mon, 2018-04-16 at 22:58 +, Mike Lothian wrote: > I've applied this too as part of my testing, I don't see a dri3 file > - does that mean the dri2 one covers both dri2&3? It covers just DRI2. In the DRI3 model the equivalent operation lives in Present (.../present.c), and the code there

Re: Has anyone noticed severe performance regression since X Server 1.18?

2018-04-17 Thread Adam Jackson
On Tue, 2018-04-17 at 19:53 +0200, Kevin Brace wrote: > When EXA is in use, the performance is roughly something like Version > 1.11 > Version 1.15 > Version 1.18 / 1.19. Surely a profile would show different results between these points. There's something like 2000 commits between 1.15 and

Has anyone noticed severe performance regression since X Server 1.18?

2018-04-17 Thread Kevin Brace
Hi, Due to myself working on OpenChrome graphics (VIA Technologies Chrome integrated graphics) stack, I have increasingly noticed X Server performance issues since Version 1.18 since I use fairly old computers for DRM development. I posted about this while back, but got very little attention.

Re: [PATCH xserver 1/3] os/WaitFor: Check timers on every iteration

2018-04-17 Thread Adam Jackson
On Sun, 2018-04-15 at 15:40 +0100, Chris Wilson wrote: > Currently we only check timer expiry if there are no client fd (or > other input) waiting to be serviced. This makes it very easy to starve > the timers with long request queues, and so miss critical timestamps. > > The timer subsystem is

Re: [PATCH] glamor: fix glamor_xv_query_image_attributes() for odd-width images

2018-04-17 Thread Adam Jackson
On Tue, 2018-04-17 at 22:22 +0100, David Woodhouse wrote: > Images which are one pixel wider than a multiple of 8 are being handled > incorrectly. Other drivers round up the width to a multiple of two > before they start calculating. Do the same. > >

[PATCH] glamor: fix glamor_xv_query_image_attributes() for odd-width images

2018-04-17 Thread David Woodhouse
Images which are one pixel wider than a multiple of 8 are being handled incorrectly. Other drivers round up the width to a multiple of two before they start calculating. Do the same. https://bugzilla.gnome.org/show_bug.cgi?id=795235 Signed-off-by: David Woodhouse ---