Re: [ANNOUNCE] xorg-server 1.19.99.904

On Thu, Apr 12, 2018 at 1:18 AM, Thomas Klausner wrote: > On Wed, Apr 11, 2018 at 04:24:02PM -0500, Jeff Smith wrote: >> On Wed, Apr 11, 2018 at 2:44 AM, Thomas Klausner wrote: >> > I still see this build failure on NetBSD: >> > >> > sdksyms.c:1773:15: error:

Re: [PATCH xserver v2] xwayland: avoid using freed xwl_window on unrealize

On Wed, 2018-04-18 at 16:02 +0200, Olivier Fourdan wrote: > This is because UnrealizeTree() traverses the tree from top to bottom, > which invalidates the assumption that if the Window doesn't feature an > xwl_window on its own, it's the xwl_window of its first ancestor with > one. > > This

Re: [PATCH app/xdpyinfo v3] Use XRANDR 1.2 extension for reporting dimensions and resolution per output

On Thursday 12 April 2018 16:34:15 Adam Jackson wrote: > This should print the RANDR data in a separate stanza after the main > output, like the other extensions do. Again: the purpose of the core of > xdpyinfo is to tell you what the connection block says. Don't make it > print something else.

Re: [PATCH app/xdpyinfo v3] Use XRANDR 1.2 extension for reporting dimensions and resolution per output

On Wed, Apr 18, 2018 at 3:33 PM, Pali Rohár wrote: > On Thursday 12 April 2018 16:34:15 Adam Jackson wrote: >> This should print the RANDR data in a separate stanza after the main >> output, like the other extensions do. Again: the purpose of the core of >> xdpyinfo is to

[PATCH xserver] xwayland: avoid using freed xwl_window on unrealize

xwl_unrealize_window() would use freed xwl_window which can lead to various memory corruption and crashes, as reported by valgrind: Invalid read of size 8 at 0x42C802: xwl_present_cleanup (xwayland-present.c:84) by 0x42BA67: xwl_unrealize_window (xwayland.c:601) by 0x541EE9:

Re: [PATCH xserver] xwayland: avoid using freed xwl_window on unrealize

Hi Roman, (sorry for top posting, that's to keep the patch after the message) So, with that patch I just sent, there is no more access-after-free in unrealize() but as I said intially, ther eiare still acess-after-free in the pending buffers/events, i.e.: Invalid read of size 8 at

Re: Quick heads-up, Xwayland present code causing memory corruption and crashes

On Wed, Apr 18, 2018 at 11:25 AM, Olivier Fourdan wrote: > This is a quick heads up, I was experiencing random crashes in Xwayland > (very annoying in gnome-shell and it takes gnome-shell and the entire > session with it). while running skype with current Xwayladn from 1.20

Re: Quick heads-up, Xwayland present code causing memory corruption and crashes

Hi Roman, Thanks for your reply! On 18 April 2018 at 13:02, Roman Gilg wrote: > On Wed, Apr 18, 2018 at 11:25 AM, Olivier Fourdan > wrote: > > This is a quick heads up, I was experiencing random crashes in Xwayland > > (very annoying in gnome-shell and

[PATCH xserver v2] xwayland: avoid using freed xwl_window on unrealize

xwl_unrealize_window() would use freed xwl_window which can lead to various memory corruption and crashes, as reported by valgrind: Invalid read of size 8 at 0x42C802: xwl_present_cleanup (xwayland-present.c:84) by 0x42BA67: xwl_unrealize_window (xwayland.c:601) by 0x541EE9:

[PATCH xserver] meson: Fix indenting in glx/meson.build

No functional changes, just fixing a tabs vs. space error I noticed Signed-off-by: Lyude Paul --- glx/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/glx/meson.build b/glx/meson.build index dc7aab962..69d558e78 100644 --- a/glx/meson.build

Re: [PATCH xserver v2] xwayland: avoid using freed xwl_window on unrealize

On Wed, Apr 18, 2018 at 4:02 PM, Olivier Fourdan wrote: > diff --git a/hw/xwayland/xwayland-present.c b/hw/xwayland/xwayland-present.c > index f403ff701..e835a1399 100644 > --- a/hw/xwayland/xwayland-present.c > +++ b/hw/xwayland/xwayland-present.c > @@ -73,13 +73,9 @@

Re: [PATCH] Xwayland: Don't notify RR of an unchanged size

On Tue, 2018-04-17 at 18:44 -0400, Preston Carpenter wrote: > From: Timidger > > On Wayland compositors such as Sway and Way Cooler Xwayland windows will > be scaled twice if a TTY change occurs. This is due to sending the > output mode information twice, causing it to

[PATCH] Xwayland: Don't notify RR of an unchanged size

From: Timidger On Wayland compositors such as Sway and Way Cooler Xwayland windows will be scaled twice if a TTY change occurs. This is due to sending the output mode information twice, causing it to be applied twice to RandR. This patch does not notify RandR if the

Re: [PATCH] glamor: fix glamor_xv_query_image_attributes() for odd-width images

On Tue, 2018-04-17 at 17:34 -0400, Adam Jackson wrote: > On Tue, 2018-04-17 at 22:22 +0100, David Woodhouse wrote: > > > > > Images which are one pixel wider than a multiple of 8 are being > > handled > > incorrectly. Other drivers round up the width to a multiple of two > > before they start

Quick heads-up, Xwayland present code causing memory corruption and crashes

Hi all, This is a quick heads up, I was experiencing random crashes in Xwayland (very annoying in gnome-shell and it takes gnome-shell and the entire session with it). while running skype with current Xwayladn from 1.20 rc4. Running Xwayland in valgrind yields a lot of memory corruption when

[PATCH xserver] meson: Ensure we always build Xext/hashtable.c for glx

Seems that while glxvnd relies on some of the hashtable functions in Xext, we only build hashtable support for Xext if we're also building the res extension. This leads to some errors if you try to build glx without res enabled: glx/liblibglxvnd.a(vndcmds.c.o): In function