Re: [PATCH xserver] present: fix msc offset calculation in window mode

Hi, On 20 April 2018 at 18:11, Michel Dänzer wrote: > On 2018-04-20 05:10 PM, Roman Gilg wrote: > > Instead of getting the current msc value from the window, which might be > > different to old one directly take the last saved msc value saved in > > the window_priv struct.

Re: [PATCH xserver] present: fix msc offset calculation in window mode

On 2018-04-20 05:10 PM, Roman Gilg wrote: > Instead of getting the current msc value from the window, which might be > different to old one directly take the last saved msc value saved in > the window_priv struct. > > Signed-off-by: Roman Gilg > --- > present/present_wnmd.c |

[PATCH xserver 1/3] xwayland: Decouple GBM from glamor

From: Lyude Paul This takes all of the gbm related code in wayland-glamor.c and moves it into it's own EGL backend for Xwayland, xwayland-glamor-gbm.c. Additionally, we add the egl_backend struct into xwl_screen in order to provide hooks for alternative EGL backends such as

[PATCH xserver 3/3] xwayland: Add glamor egl_backend for EGLStreams

From: Lyude Paul This adds initial support for displaying Xwayland applications through the use of EGLStreams and nvidia's custom wayland protocol by adding another egl_backend driver. This also adds some additional egl_backend hooks that are required to make things work

[PATCH xserver 2/3] xwayland: Add xwayland-config.h

From: Lyude Paul Just a small autogenerated header that will soon contain more then just one macro. Signed-off-by: Lyude Paul --- configure.ac | 7 +++ hw/xwayland/xwayland.c | 10 ++ hw/xwayland/xwayland.h

[PATCH xserver 0/3] Rebased EGLStreams support

As usual, any patch that mostly moves code around ends up being the worst thing to rebase. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver] modesetting: Only use modifiers on kms drivers which do support them.

Use the DRM_CAP_ADDFB2_MODIFIERS query to make sure the kms driver supports modifiers in the addfb2 ioctl, and fall back to addfb ioctl without modifiers if modifiers are unsupported. E.g., as of Linux 4.17, nouveau-kms so far does not suppport modifiers and gets angry if

Re: [ANNOUNCE] xorg-server 1.19.99.904

On Fri, 2018-04-20 at 08:18 +0200, Thomas Klausner wrote: > extern __attribute__((visibility("default"))) > # 112 "../../dri3/dri3.h" 3 4 > __uint32_t > > # 113 "../../dri3/dri3.h" > drm_format_for_depth( > > > > I don't see the problem, do you? We're not expecting another

[PATCH xserver] present: fix msc offset calculation in window mode

Instead of getting the current msc value from the window, which might be different to old one directly take the last saved msc value saved in the window_priv struct. Signed-off-by: Roman Gilg --- present/present_wnmd.c | 7 +-- 1 file changed, 1 insertion(+), 6

[PATCH xserver] xwayland: restrict present cleanup to presenting and top parent window

Clean up only if the request points to the presenting window or its top parent window. Since in this case all events are removed unconditionally, always stop the timer. Signed-off-by: Roman Gilg --- hw/xwayland/xwayland-present.c | 16 1 file changed, 8

Re: [PATCH xserver] modesetting: Only use modifiers on kms drivers which do support them.

Hi, It seems to do the right thing, so: On Fri, 2018-04-20 at 19:59 +0200, Mario Kleiner wrote: > Use the DRM_CAP_ADDFB2_MODIFIERS query to make sure the kms > driver supports modifiers in the addfb2 ioctl, and fall back > to addfb ioctl without modifiers if modifiers are unsupported. > > E.g.,

Re: [PATCH xserver 1/3] xwayland: Decouple GBM from glamor

lgtm! for the whole series: Reviewed-by: Lyude Paul On Fri, 2018-04-20 at 14:38 -0400, Adam Jackson wrote: > From: Lyude Paul > > This takes all of the gbm related code in wayland-glamor.c and moves it > into it's own EGL backend for Xwayland,

Re: [ANNOUNCE] xorg-server 1.19.99.904

On Wed, Apr 18, 2018 at 10:13:36AM -0500, Jeff Smith wrote: > Here is something that may help in tracking down the cause of the > disappearing symbol. > 1: apply the following changes to sdksyms.sh > 2: re-run the build > (this will output what is being fed into awk from the pre-processor > into

Re: [PATCH xserver v2] xwayland: avoid using freed xwl_window on unrealize

Hi Daniel, On Thu, Apr 19, 2018 at 5:24 PM, Daniel Stone wrote: > [...] > The callback is passed as an argument to the function directly, so you > could just destroy that instead. > Sure, but that wouldn't solve the problem which is the callback occurs after the

Re: [PATCH xserver v2] xwayland: avoid using freed xwl_window on unrealize

Hey, On Thu, Apr 19, 2018 at 5:33 PM, Olivier Fourdan wrote: > > But there are still oddities, like some window remaining black for like > 2~3 seconds after re-mapping. > > Closing the skypeforlinux toplevel and restoring it by running it again > triggers the black window