[PATCH] dix: Simpler and faster XID hash

2011-01-19 Thread Adam Jackson
: 100 trep @ 0.0412 msec ( 24275.0/sec): QueryPointer After: 100 trep @ 0.0374 msec ( 26737.0/sec): QueryPointer Signed-off-by: Adam Jackson a...@redhat.com --- dix/resource.c | 18 +- 1 files changed, 1 insertions(+), 17 deletions(-) diff --git a/dix/resource.c b/dix

Re: [PATCH 1/2] mi: Call pScreen-ConstrainCursorHarder from the position update path

2011-01-19 Thread Adam Jackson
On Jan 19, 2011, at 9:27 PM, Daniel Stone wrote: On Wed, Jan 19, 2011 at 12:58:40AM -0500, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com --- mi/mipointer.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/mi/mipointer.c b/mi/mipointer.c index

Re: [PATCH] dix: Fix loop termination

2011-01-20 Thread Adam Jackson
- xorg crash with xtst Reviewed-by: Adam Jackson a...@redhat.com - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 1/5] dmx: warning fixes

2011-01-20 Thread Adam Jackson
to integer of different size dmxextension.c: In function ‘dmxDetachScreen’: dmxextension.c:1599:8: warning: cast to pointer from integer of different size Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/dmxextension.c | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff

[PATCH 0/5] DMX warning fixes

2011-01-20 Thread Adam Jackson
Getting tired of looking at these. Should all be uncontroversial. There's still a pile left in the glxproxy code (sigh), some cases where bison generates more stuff than it needs to, and a few cases of glibc deciding we're naughty for not checking the return value of write(2). This is all I have

[PATCH 3/5] dmx: warning fix

2011-01-20 Thread Adam Jackson
dmxinputinit.c: At top level: dmxinputinit.c:135:29: warning: ‘DMXCommonOth’ defined but not used DMXCommonOth is actually mentioned in a #if 0 block, so delete it and the block that references it. If anyone needs it, git remembers. Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/input

[PATCH 2/5] dmx: warning fix

2011-01-20 Thread Adam Jackson
exceeds maximum value for type Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/dmxgc.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/hw/dmx/dmxgc.c b/hw/dmx/dmxgc.c index 829200e..f10f9a0 100644 --- a/hw/dmx/dmxgc.c +++ b/hw/dmx/dmxgc.c @@ -383,12 +383,7

[PATCH 4/5] dmx: warning fixes

2011-01-20 Thread Adam Jackson
’: dmxinputinit.c:1041:36: warning: cast to pointer from integer of different size Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/input/dmxinputinit.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/dmx/input/dmxinputinit.c b/hw/dmx/input/dmxinputinit.c

[PATCH 5/5] xdmxconfig: warning fix

2011-01-20 Thread Adam Jackson
xdmxconfig.c: In function ‘dmxConfigCanvasDraw’: xdmxconfig.c:299:23: warning: ‘maxHeight’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/config/xdmxconfig.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/dmx

[PULL] Warning cleanups and misc fixes

2011-01-20 Thread Adam Jackson
The following changes since commit c6aa4755ec355101a62bef86dbb090262fe806f6: xkb/ddxLoad.c doesn't need paths.h any more (2011-01-18 15:22:04 -0800) are available in the git repository at: ssh://people.freedesktop.org/~ajax/xserver for-keithp Adam Jackson (9): dmx: warning fixes

[PATCH] xselinux: Fix GetDrawableContext

2011-01-20 Thread Adam Jackson
M_DRAWABLE_PIXMAP is the lookup mask to dixLookupDrawable, and _not_ the type value in the drawable itself. Signed-off-by: Adam Jackson a...@redhat.com --- Xext/xselinux_ext.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Xext/xselinux_ext.c b/Xext/xselinux_ext.c

[PATCH 0/8] More warning fixes and build cleanups

2011-01-23 Thread Adam Jackson
What it says on the box. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 2/8] int10: warning fix

2011-01-23 Thread Adam Jackson
helper_exec.c: In function 'pciCfg1in': helper_exec.c:507:4: warning: passing argument 2 of 'pci_device_cfg_read_u32' from incompatible pointer type /usr/include/pciaccess.h:153:5: note: expected 'uint32_t *' but argument is of type 'CARD32 *' Signed-off-by: Adam Jackson a...@redhat.com --- hw

[PATCH 4/8] xfree86: warning fix

2011-01-23 Thread Adam Jackson
det_monrec_source' and 'enum anonymous' xf86Crtc.c:1562:33: warning: comparison between 'enum det_monrec_source' and 'enum anonymous' Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/modes/xf86Crtc.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/modes

[PATCH 5/8] fb: Remove hw/xfree86/ from includes

2011-01-23 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- fb/Makefile.am |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/fb/Makefile.am b/fb/Makefile.am index f9f34c4..89f3bab 100644 --- a/fb/Makefile.am +++ b/fb/Makefile.am @@ -1,9 +1,5 @@ noinst_LTLIBRARIES = libfb.la

[PATCH 6/8] damage: Remove hw/xfree86/ from includes

2011-01-23 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- miext/damage/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/miext/damage/Makefile.am b/miext/damage/Makefile.am index 5958357..767a65a 100644 --- a/miext/damage/Makefile.am +++ b/miext/damage/Makefile.am

[PATCH 7/8] rootless: Remove hw/xfree86/ from includes

2011-01-23 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- miext/rootless/Makefile.am |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/miext/rootless/Makefile.am b/miext/rootless/Makefile.am index f09300d..c97bebe 100644 --- a/miext/rootless/Makefile.am +++ b/miext/rootless

[PATCH 8/8] shadow: Remove hw/xfree86/ from includes

2011-01-23 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- miext/shadow/Makefile.am |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/miext/shadow/Makefile.am b/miext/shadow/Makefile.am index a73d0ec..30f7bda 100644 --- a/miext/shadow/Makefile.am +++ b/miext/shadow/Makefile.am

[PATCH 00/11] glxproxy warning fixes

2011-02-08 Thread Adam Jackson
At least with my CFLAGS, this is all I'm getting that isn't about lack of prototypes or declarations. Most of these are pretty trivial but there's a couple that would fix actual bugs. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives:

[PATCH 01/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxcmds.c: In function ‘__glXChangeDrawableAttributes’: glxcmds.c:3464:8: warning: ‘screen’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxcmds.c | 31 --- 1 files changed, 12 insertions(+), 19 deletions

[PATCH 02/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxcmds.c: In function ‘__glXGetDrawableAttributes’: glxcmds.c:3295:8: warning: ‘screen’ may be used uninitialized in this function glxcmds.c:3298:8: warning: ‘attribs_size’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxcmds.c

[PATCH 03/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxcmds.c: In function ‘CreateContext.clone.6’: glxcmds.c:105:19: warning: ‘be_fbconfigId’ may be used uninitialized in this function glxcmds.c:104:14: warning: ‘be_vid’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxcmds.c |4

[PATCH 04/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxcmds.c: In function ‘CreateGLXPixmap’: glxcmds.c:1641:22: warning: ‘pGlxScreen’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxcmds.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/dmx/glxProxy

[PATCH 05/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxcmds.c: In function ‘CreateGLXPixmap’: glxcmds.c:1663:20: warning: comparison between pointer and integer glxcmds.c:1663:38: warning: comparison between pointer and integer Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxcmds.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 06/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
render2swap.c:264:13: warning: ‘swapArray’ defined but not used Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/render2swap.c | 54 - 1 files changed, 0 insertions(+), 54 deletions(-) diff --git a/hw/dmx/glxProxy/render2swap.c b/hw/dmx

[PATCH 07/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxsingle.c: In function ‘__glXDisp_ReadPixels’: glxsingle.c:760:11: warning: ‘buf’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxsingle.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/dmx/glxProxy

[PATCH 08/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxsingle.c: In function ‘__glXForwardAllWithReply’: glxsingle.c:300:10: warning: ‘be_buf’ may be used uninitialized in this function glxsingle.c:301:10: warning: ‘be_buf_size’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxsingle.c

[PATCH 09/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxsingle.c: In function ‘__glXForwardPipe0WithReply’: glxsingle.c:218:10: warning: ‘be_buf’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxsingle.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/dmx

[PATCH 10/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxvendor.c: In function ‘__glXVForwardAllWithReply’: glxvendor.c:284:10: warning: ‘be_buf’ may be used uninitialized in this function glxvendor.c:285:10: warning: ‘be_buf_size’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy

[PATCH 11/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxvendor.c: In function ‘__glXVForwardPipe0WithReply’: glxvendor.c:205:10: warning: ‘be_buf’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxvendor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/dmx

[PATCH 0/2] Pointer barriers, proto and lib

2011-02-09 Thread Adam Jackson
Protocol includes all the feedback from before, client library should be just about trivially correct. Would like to merge these before the weekend. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

[PATCH] fixesproto v5: Pointer barriers

2011-02-09 Thread Adam Jackson
v3: Review fixes: - INT16 not CARD16 for coordinates - BadDevice not BadMatch Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Adam Jackson a...@redhat.com --- COPYING|1 + fixesproto.txt | 92 +-- xfixesproto.h

[PATCH] libXfixes v5: Pointer barriers

2011-02-09 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac|2 +- include/X11/extensions/Xfixes.h | 14 +++ src/Cursor.c| 48 +++ 3 files changed, 63 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] libXfixes v5: Pointer barriers

2011-02-09 Thread Adam Jackson
Ignore this one, it doesn't handle multiple devices. On Feb 9, 2011, at 6:08 PM, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac|2 +- include/X11/extensions/Xfixes.h | 14 +++ src/Cursor.c| 48

[PATCH] fixes: Pointer barriers

2011-02-09 Thread Adam Jackson
This is pretty much a 'version 0' kind of thing, it looks right to me but reviews strongly needed. This assumes the calls to ConstrainCursorHarder actually happen, obviously. Signed-off-by: Adam Jackson a...@redhat.com --- include/protocol-versions.h |2 +- xfixes/cursor.c

[PATCH 1/2] Fix memory leak in mode validation

2011-02-14 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- src/vesa.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/vesa.c b/src/vesa.c index 2523d76..ef01881 100644 --- a/src/vesa.c +++ b/src/vesa.c @@ -391,6 +391,7 @@ VESAValidMode(int scrn, DisplayModePtr p, Bool flag, int

[PATCH 2/2] Be forgiving of character-cell size mismatches in mode sizes

2011-02-14 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- src/vesa.c | 28 +--- 1 files changed, 25 insertions(+), 3 deletions(-) diff --git a/src/vesa.c b/src/vesa.c index ef01881..61d3550 100644 --- a/src/vesa.c +++ b/src/vesa.c @@ -317,6 +317,30 @@ VESASetModeParameters

Re: [PATCH 2/2] Be forgiving of character-cell size mismatches in mode sizes

2011-02-14 Thread Adam Jackson
On Feb 14, 2011, at 1:12 PM, Matt Turner wrote: This looks like a good idea. For both patches: Reviewed-by: Matt Turner matts...@gmail.com Pushed, thanks. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 0/3] fix regressions from glx request length checks

2011-02-14 Thread Adam Jackson
] glx: fix request length check for CreateGLXPbufferSGIX [PATCH 2/3] glx: fix BindTexImageEXT length check [PATCH 3/3] glx: Work around wrong request lengths sent by mesa Anyone care to review v2 of these? ping... Reviewed-by: Adam Jackson a...@redhat.com - ajax

Re: [PATCH 2/8] int10: warning fix

2011-02-14 Thread Adam Jackson
On Feb 12, 2011, at 5:05 PM, Mark Kettenis wrote: From: Adam Jackson a...@redhat.com Date: Sun, 23 Jan 2011 23:18:06 -0500 helper_exec.c: In function 'pciCfg1in': helper_exec.c:507:4: warning: passing argument 2 of 'pci_device_cfg_read_u32' from incompatible pointer type /usr/include

Re: [PATCH/RFC] Move Trapezoids and Triangles code to pixman

2011-02-14 Thread Adam Jackson
tests! My hero. My only complaint was going to be about not dropping ps-Rasterize*, but of course exa and uxa are still using them, so we can't do that yet. Still, definite improvement. Reviewed-by: Adam Jackson a...@redhat.com - ajax ___ xorg-devel

Re: Window procedures in ScreenRec not populated by DDX driver. why?

2011-02-16 Thread Adam Jackson
On Feb 15, 2011, at 9:08 PM, kumar vemuri wrote: Hi Pauli, But some window procedures like the window painting procedures (ClearToBackground, CopyWindow and compositing) can be accelerated by hardware. a. Shouldnt these procedures be implemented by the driver (to get hw acceleration for

[PATCH] Turn shadowfb off on virtualized hardware

2011-02-17 Thread Adam Jackson
There's no benefit to shadowfb, since the framebuffer is in the same memory domain as host memory; all you're doing is adding extra copies. Signed-off-by: Adam Jackson a...@redhat.com --- src/vesa.c | 34 +++--- 1 files changed, 31 insertions(+), 3 deletions

[PATCH] Unbreak the .m.c rule

2011-02-22 Thread Adam Jackson
Some builds of gnu make apparently know how to go straight from .m to .o. That's great if your .m file is Objective C source, but for us, it's not. Signed-off-by: Adam Jackson a...@redhat.com --- xts5/common.mk |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/xts5

[PATCH] libXfixes v5: Pointer barriers

2011-02-23 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac|2 +- include/X11/extensions/Xfixes.h | 15 ++ src/Cursor.c| 58 +++ 3 files changed, 74 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] Unbreak the .m.c rule

2011-02-23 Thread Adam Jackson
On 2/23/11 8:53 AM, Dan Nicholson wrote: Peter, did we discuss some other way to fix this? Either way, this looks like the right thing to do. Reviewed-by: Dan Nicholsondbn.li...@gmail.com Pushed, thanks all. - ajax ___ xorg-devel@lists.x.org:

Re: [Patch 0/8] Pointer barriers

2011-02-23 Thread Adam Jackson
on where you're coming from. The barrier is intended to be on the edges between the pixels. I'll try to hammer this bit out. For the series through #6, where applicable: Reviewed-by: Adam Jackson a...@redhat.com The RANDR CRTC confine bit is very much worth landing on its own even

Re: [PULL] 1.10: warning fixes, ABI fix, and minor Fedora merge

2011-02-23 Thread Adam Jackson
On 2/23/11 6:57 PM, Peter Hutterer wrote: On Wed, Feb 23, 2011 at 01:48:23PM -0500, a...@redhat.com wrote: Peter Hutterer (1): Add mode field to ConstrainCursorHarder just in case that wasn't clear to all, this breaks the ABI. But we don't have any users for it yet anyway, so... Or

Re: [PULL] 1.10: warning fixes, ABI fix, and minor Fedora merge

2011-02-24 Thread Adam Jackson
On Wed, 2011-02-23 at 16:16 -0800, Keith Packard wrote: On Wed, 23 Feb 2011 13:43:54 -0500, a...@redhat.com wrote: are available in the git repository at: ssh://people.freedesktop.org/~ajax/xserver ..BRANCH.NOT.VERIFIED.. BRANCH.NOT.VERIFIED? o_O My request-pull script seems to have

Re: [PATCH xserver] Removing unused code

2011-02-24 Thread Adam Jackson
On Thu, 2011-02-24 at 21:40 +0500, Alexandr Shadchin wrote: Push, please (yet not forgotten :-) Cc'ing Keith so he sees this. In the future, please cc the release manager on reviewed patch requests. - ajax signature.asc Description: This is a digitally signed message part

[PATCH] vbe: Fix malloc size bug

2011-02-24 Thread Adam Jackson
==by 0x422778: main (main.c:205) Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/vbe/vbe.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/vbe/vbe.c b/hw/xfree86/vbe/vbe.c index bcda5ec..56e3ec4 100644 --- a/hw/xfree86/vbe/vbe.c +++ b/hw/xfree86/vbe

Re: [PATCH] vbe: Fix malloc size bug

2011-02-24 Thread Adam Jackson
On Thu, 2011-02-24 at 13:26 -0800, Alan Coopersmith wrote: On 02/24/11 01:11 PM, Adam Jackson wrote: diff --git a/hw/xfree86/vbe/vbe.c b/hw/xfree86/vbe/vbe.c index bcda5ec..56e3ec4 100644 --- a/hw/xfree86/vbe/vbe.c +++ b/hw/xfree86/vbe/vbe.c @@ -395,7 +395,7 @@ VBEGetVBEInfo(vbeInfoPtr

[PATCH] vbe: Fix malloc size bug

2011-02-25 Thread Adam Jackson
: InitOutput (xf86Init.c:519) ==14882==by 0x422778: main (main.c:205) Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/vbe/vbe.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/vbe/vbe.c b/hw/xfree86/vbe/vbe.c index bcda5ec..04132d9 100644 --- a/hw

Re: [PATCH] Delete RegionClipSpans()

2011-02-28 Thread Adam Jackson
On 2/26/11 2:07 PM, Søren Sandmann wrote: From: Søren Sandmann Pedersens...@redhat.com Nothing uses it. Signed-off-by: Soren Sandmanns...@redhat.com Reviewed-by: Adam Jackson a...@redhat.com and merged to xserver-next: http://cgit.freedesktop.org/~ajax/xserver/log/?h=xserver-next I'll

[PATCH] xext: Remove XCALIBRATE extension

2011-02-28 Thread Adam Jackson
Nobody can have been using this, it's never called from extension init. XI2 device properties should now be a functional replacement. Signed-off-by: Adam Jackson a...@redhat.com --- Xext/Makefile.am|7 - Xext/xcalibrate.c | 297

Re: 1.11 release process (was: [PULL] -next branch for 1.11)

2011-03-01 Thread Adam Jackson
On Mon, 2011-02-28 at 22:37 -0800, Jeremy Huddleston wrote: Yeah, and unless someone else wants to take over the stable release branch, I'm fine continuing on as server-1.10-branch manager. The process has been fairly smooth, so I think running 1.10 like I did 1.9 should be fine, but

Re: 1.11 release process (was: [PULL] -next branch for 1.11)

2011-03-01 Thread Adam Jackson
On Mon, 2011-02-28 at 21:14 -0800, Keith Packard wrote: Do we need more formal rules for merging code? The RandR 1.4 server code was merged before the protocol and library APIs had seen sufficient review, but we don't have a formal process for either of those modules. Anyone know how to help

Re: RandR 1.4 restart

2011-03-01 Thread Adam Jackson
On Tue, 2011-03-01 at 15:48 +0200, Ville Syrjälä wrote: So what about also allowing windows to use the scanout pixmaps as their backing pixmap? I'm mainly interested in something that would allow unredirected 32bpp windows on a 16bpp screen. I think the terminology is a little confusing here.

[PATCH] glx: Remove yet another open coded strdup()

2011-03-01 Thread Adam Jackson
This joke is no longer funny. Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 22 ++ 1 files changed, 2 insertions(+), 20 deletions(-) diff --git a/glx/glapi.c b/glx/glapi.c index d6a568e..fd4eb92 100644 --- a/glx/glapi.c +++ b/glx/glapi.c @@ -226,24 +226,6

[PATCH] Unifdef XGLServer

2011-03-01 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/glx/glapi.c b/glx/glapi.c index fd4eb92..d16cd85 100644 --- a/glx/glapi.c +++ b/glx/glapi.c @@ -372,7 +372,7 @@ _glapi_get_dispatch(void) # endif #endif

Re: [PATCH] glx: Remove yet another open coded strdup()

2011-03-02 Thread Adam Jackson
On 3/2/11 6:53 AM, Daniel Stone wrote: On Tue, Mar 01, 2011 at 04:17:55PM -0500, Adam Jackson wrote: This joke is no longer funny. I like how they even ensured that str_dup(NULL) also didn't do what you want. God. Signed-off-by: Adam Jacksona...@redhat.com Reviewed-by: Daniel Stonedan

[PATCH 00/11] GLX dispatch cleanup

2011-03-03 Thread Adam Jackson
In trying to figure out why the clutter FBO tests simply fell over in indirect contexts, I got to discover exactly how disgusting this code is. The glapi code appears to have been cargo-culted in from Mesa, but is over-general for our purposes. In particular, glapi goes through some contortions

[PATCH 01/11] glx: Remove unused _glapi_get_proc_offset and friends

2011-03-03 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 107 --- glx/glapi.h | 19 -- 2 files changed, 0 insertions(+), 126 deletions(-) diff --git a/glx/glapi.c b/glx/glapi.c index d6a568e..42bf6c1 100644 --- a/glx/glapi.c

[PATCH 02/11] glx: unifdef SOLARIS_THREADS

2011-03-03 Thread Adam Jackson
Solaris 7 and older are not supported; Solaris 8 and later have (and use) pthreads. Signed-off-by: Adam Jackson a...@redhat.com --- glx/glthread.c | 70 glx/glthread.h | 25 +--- 2 files changed, 1 insertions(+), 94

[PATCH 03/11] glx: unifdef USE_XTHREADS

2011-03-03 Thread Adam Jackson
xthreads is an ancient wrapper around a half dozen or so common thread APIs, including pthreads. Just use pthreads directly if you have it; if you don't, get with the times. Signed-off-by: Adam Jackson a...@redhat.com --- glx/glthread.c | 51

[PATCH 04/11] glx: unifdef BEOS_THREADS

2011-03-03 Thread Adam Jackson
We don't support BeOS, so, no. Signed-off-by: Adam Jackson a...@redhat.com --- glx/glthread.c | 41 - glx/glthread.h |2 +- 2 files changed, 1 insertions(+), 42 deletions(-) diff --git a/glx/glthread.c b/glx/glthread.c index a2d95b5..5da7e43 100644

[PATCH 05/11] glx: Simplify _glapi_check_multithread

2011-03-03 Thread Adam Jackson
We can guarantee that the X server does not call DRI driver services from multiple threads, so _glapi_check_multithread need never do anything special. As a result, ThreadSafe is always false, so remove it and simplify expressions where it appeared to match. Signed-off-by: Adam Jackson

[PATCH 06/11] glx: Remove unused _glapi_get_proc_name

2011-03-03 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 49 - glx/glapi.h |3 --- 2 files changed, 0 insertions(+), 52 deletions(-) diff --git a/glx/glapi.c b/glx/glapi.c index fde5d76..209ae50 100644 --- a/glx/glapi.c +++ b/glx/glapi.c

[PATCH 08/11] glx: Remove unused _glapi_set_warning_func and friends

2011-03-03 Thread Adam Jackson
These could only have been hit from the (now-removed) noop dispatch table. Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 23 --- glx/glapi.h |6 -- hw/xquartz/GL/indirect.c |9 - 3 files changed, 0 insertions

[PATCH 09/11] glx: Lobotomize _glapi_get_proc_address

2011-03-03 Thread Adam Jackson
This isn't a meaningful thing in the indirect glx loader, so just warn if it ever happens and move on. Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 39 ++- 1 files changed, 6 insertions(+), 33 deletions(-) diff --git a/glx/glapi.c b/glx

[PATCH 10/11] glx: Update some glapi comments

2011-03-03 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 38 ++ 1 files changed, 6 insertions(+), 32 deletions(-) diff --git a/glx/glapi.c b/glx/glapi.c index de5e7ea..f421c24 100644 --- a/glx/glapi.c +++ b/glx/glapi.c @@ -22,47 +22,21 @@ * CONNECTION

[PATCH 11/11] glx: Flatten -DXFree86Server

2011-03-03 Thread Adam Jackson
Always defined by the makefile, so, just get rid of it. Signed-off-by: Adam Jackson a...@redhat.com --- glx/Makefile.am |1 - glx/glapi.c | 43 --- 2 files changed, 0 insertions(+), 44 deletions(-) diff --git a/glx/Makefile.am b/glx/Makefile.am

Re: [PATCH xserver 0/3] Memory leak fixes.

2011-03-04 Thread Adam Jackson
+++--- config/udev.c|6 +++--- dix/devices.c|2 ++ xkb/xkbActions.c | 11 ++- 4 files changed, 10 insertions(+), 15 deletions(-) For the series, Reviewed-by: Adam Jackson a...@redhat.com - ajax ___ xorg-devel@lists.x.org

[PATCH 0/4]: Drawable API cleanup

2011-03-04 Thread Adam Jackson
Nothing too controversial, just incidental cleanups on the way to finally getting shatter implemented (someday). Should make every pixmap four bytes smaller on ILP32, which is pleasant; LP64 doesn't see any change though due to the struct padding rules. - ajax

[PATCH 1/4] dix: Remove usage_class from pixmaps, store it in -drawable.class

2011-03-04 Thread Adam Jackson
The class field was unused for pixmaps, and we don't have enough classes to justify a whole uint32 anyway. Signed-off-by: Adam Jackson a...@redhat.com --- exa/exa.h |2 +- exa/exa_classic.c |4 ++-- exa/exa_driver.c

[PATCH 2/4] dix: Remove deprecated.c

2011-03-04 Thread Adam Jackson
No more internal users, this can be dropped now. Signed-off-by: Adam Jackson a...@redhat.com --- dix/Makefile.am|1 - dix/deprecated.c | 165 include/dix.h | 31 -- include/resource.h | 29 - 4 files changed

[PATCH 3/4] dix: Simplify arguments to dixLookupDrawable

2011-03-04 Thread Adam Jackson
The mask argument was almost always 0 or (equivalently) M_ANY. Drop the mask, and fix up the scant few callers who needed anything stronger. Signed-off-by: Adam Jackson a...@redhat.com --- Xext/panoramiXprocs.c | 13 ++--- Xext/saver.c | 12

[PATCH 4/4] dix: Make InputOnly window checking more consistent

2011-03-04 Thread Adam Jackson
Remove the UNDRAWABLE_WINDOW macro (which was just needlessly cute) and always check -class to decide if a window is InputOnly or InputOutput. -type is now always either window or pixmap. Signed-off-by: Adam Jackson a...@redhat.com --- dix/dispatch.c |3 ++- dix/window.c |2

[PATCH] vgaarb: Don't wrap Block/WakeupHandler

2011-03-04 Thread Adam Jackson
These aren't hardware access, unless they are, in which case the rest of the wrapping will catch us. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/common/xf86VGAarbiter.c | 25 - hw/xfree86/common/xf86VGAarbiterPriv.h |4 2 files changed, 0

Re: [PATCH] vgaarb: Don't wrap Block/WakeupHandler

2011-03-04 Thread Adam Jackson
On 3/4/11 6:38 PM, Mark Kettenis wrote: From: Adam Jacksona...@redhat.com Date: Fri, 4 Mar 2011 16:15:28 -0500 These aren't hardware access, unless they are, in which case the rest of the wrapping will catch us. Sorry, but I don't think that is true. The xf86-video-glint driver has a

Re: [PATCH 09/11] glx: Lobotomize _glapi_get_proc_address

2011-03-07 Thread Adam Jackson
On 3/3/11 4:06 PM, Julien Cristau wrote: On Thu, Mar 3, 2011 at 14:07:23 -0500, Adam Jackson wrote: -/** - * Return pointer to the named function. If the function name isn't found - * in the name of static functions, try generating a new API entrypoint on - * the fly with assembly language

Re: [PATCH 1/3] glx: Factor out glxProbeDriver function.

2011-03-07 Thread Adam Jackson
I'd kind of like to see is the word AIGLX changed to GLX in the output strings, since if it's swrast there's nothing Accelerated about it. Nothing worth holding up merging for though. Reviewed-by: Adam Jackson a...@redhat.com - ajax ___ xorg-devel

Re: [PATCH 2/3] glx: Use PATH_MAX as size for filename buffer

2011-03-07 Thread Adam Jackson
On 3/6/11 10:11 PM, Christopher James Halse Rogers wrote: Signed-off-by: Christopher James Halse Rogerschristopher.halse.rog...@canonical.com Any chance you can clean this up to be something we get from misc.h or similar? There's about five #ifdef MAXPATHLENs already in various files. -

[PATCH 1/8] dix: Remove PIXEL typedef

2011-03-07 Thread Adam Jackson
Doesn't appear to be used anywhere. Signed-off-by: Adam Jackson a...@redhat.com --- include/misc.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/include/misc.h b/include/misc.h index 62d813e..0717db6 100644 --- a/include/misc.h +++ b/include/misc.h @@ -91,10 +91,8

[PATCH 0/8] LP64 ABI cleanup

2011-03-07 Thread Adam Jackson
Pretty much every use of 'long' is a bug. Atoms are only 32 bits on the wire, and though RESTYPE is not a wire type we're only using the low 32 bits of it. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives:

[PATCH 2/8] dix: Fix ATOM typedef

2011-03-07 Thread Adam Jackson
unsigned long is needlessly large on LP64. Use unsigned int instead. Signed-off-by: Adam Jackson a...@redhat.com --- include/misc.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/misc.h b/include/misc.h index 0717db6..7c97fae 100644 --- a/include/misc.h +++ b

[PATCH 3/8] dix: Shrink PropertyRec on LP64

2011-03-07 Thread Adam Jackson
size needn't be a long. No change on ILP32 but, combined with the previous change, 56 - 40 bytes on LP64. Signed-off-by: Adam Jackson a...@redhat.com --- include/propertyst.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/propertyst.h b/include/propertyst.h

[PATCH 4/8] xv: Use RESTYPE where appropriate

2011-03-07 Thread Adam Jackson
No functional change. Signed-off-by: Adam Jackson a...@redhat.com --- Xext/xvdix.h | 12 ++-- Xext/xvmain.c | 14 ++ 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/Xext/xvdix.h b/Xext/xvdix.h index a210615..e9c22bf 100644 --- a/Xext/xvdix.h +++ b/Xext

[PATCH 5/8] xinerama: Use RESTYPE consistently

2011-03-07 Thread Adam Jackson
No functional change Signed-off-by: Adam Jackson a...@redhat.com --- Xext/panoramiX.c| 10 +- Xext/panoramiXsrv.h | 12 ++-- render/render.c |2 +- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/Xext/panoramiX.c b/Xext/panoramiX.c index e6334bd

[PATCH 6/8] xvmc: Use RESTYPE consistently

2011-03-07 Thread Adam Jackson
Also mark these static since they're not used externally. Signed-off-by: Adam Jackson a...@redhat.com --- Xext/xvmc.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Xext/xvmc.c b/Xext/xvmc.c index 8fbdfae..4d29941 100644 --- a/Xext/xvmc.c +++ b/Xext/xvmc.c @@ -42,9

[PATCH 7/8] xi: Use RESTYPE consistently

2011-03-07 Thread Adam Jackson
No functional change Signed-off-by: Adam Jackson a...@redhat.com --- Xi/exglobals.h |2 +- Xi/extinit.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Xi/exglobals.h b/Xi/exglobals.h index f755707..8c5a42e 100644 --- a/Xi/exglobals.h +++ b/Xi/exglobals.h @@ -76,7

[PATCH 8/8] dix: Define RESTYPE as unsigned int

2011-03-07 Thread Adam Jackson
long is needlessly long on LP64. Before: textdata bss dec hex filename 1833242 69920 49696 1952858 1dcc5a hw/vfb/Xvfb After: textdata bss dec hex filename 1832426 69920 49504 1951850 1dc86a hw/vfb/Xvfb Signed-off-by: Adam Jackson a...@redhat.com

[PATCH] libXfixes v5: Pointer barriers

2011-03-07 Thread Adam Jackson
v2: Use int * for device list, consistent with libXi. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac|2 +- include/X11/extensions/Xfixes.h | 15 ++ src/Cursor.c| 60 +++ 3 files changed, 76

Re: [PATCH 2/8] dix: Fix ATOM typedef

2011-03-07 Thread Adam Jackson
On 3/7/11 11:51 AM, Daniel Stone wrote: On Mon, Mar 07, 2011 at 11:28:12AM -0500, Adam Jackson wrote: unsigned long is needlessly large on LP64. Use unsigned int instead. Could we just use uint32_t? stdint.h isn't included from misc.h. It could be, I guess, but if you have a platform

Re: [PATCH] libXfixes v5: Pointer barriers

2011-03-08 Thread Adam Jackson
On Tue, 2011-03-08 at 11:13 +1000, Peter Hutterer wrote: diff --git a/include/X11/extensions/Xfixes.h b/include/X11/extensions/Xfixes.h index 0c00310..b39716a 100644 --- a/include/X11/extensions/Xfixes.h +++ b/include/X11/extensions/Xfixes.h @@ -1,5 +1,6 @@ /* * Copyright (c)

[PATCH 01/14] glx: Do something unpleasant to current drawable tracking

2011-03-08 Thread Adam Jackson
This is wrong, very wrong. Almost as wrong as what it replaces. Do not merge me, ever. --- glx/glxcmds.c |6 -- glx/glxext.c | 12 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 9b4bc9e..59df1c8 100644 ---

[PATCH 02/14] glx: Remove unused _glapi_get_proc_offset and friends

2011-03-08 Thread Adam Jackson
Reviewed-by: Julien Cristau jcris...@debian.org Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 107 --- glx/glapi.h | 19 -- 2 files changed, 0 insertions(+), 126 deletions(-) diff --git a/glx/glapi.c b/glx/glapi.c

[PATCH 00/14] GLX cleanup, round two

2011-03-08 Thread Adam Jackson
Largely a resend of the last series, but patches 1 and 14 are novel. The first is _wrong_, wrong wrong wrong, but it makes piglit actually runnable in indirect contexts so in the spirit of showing one's work it's included. I don't know how I'm going to fix that particular issue yet, but I

[PATCH 03/14] glx: unifdef SOLARIS_THREADS

2011-03-08 Thread Adam Jackson
Solaris 7 and older are not supported; Solaris 8 and later have (and use) pthreads. Acked-by: Alan Coopersmith alan.coopersm...@oracle.com Signed-off-by: Adam Jackson a...@redhat.com --- glx/glthread.c | 70 glx/glthread.h | 25

[PATCH 04/14] glx: unifdef USE_XTHREADS

2011-03-08 Thread Adam Jackson
xthreads is an ancient wrapper around a half dozen or so common thread APIs, including pthreads. Just use pthreads directly if you have it; if you don't, get with the times. Reviewed-by: Julien Cristau jcris...@debian.org Signed-off-by: Adam Jackson a...@redhat.com --- glx/glthread.c | 51

  1   2   3   4   5   6   7   8   9   10   >