Re: [PATCH libXaw] Add definition of getpagesize(), missing on Windows.

2019-03-04 Thread James Larrowe
Ping. Anything wrong with this? It's only defined in the plugin header files for gcc. On Thu, Feb 28, 2019 at 12:56 PM James R Larrowe wrote: > Fix build with --enable-selective-werror. > > Signed-off-by: James R Larrowe > --- > src/OS.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff

Port of X11 to Windows 32-bit

2019-02-27 Thread James Larrowe
I'm working on nonintrusively patching Xlib and the X server to work natively on Windows 32-bit, and I'm interested in upstreaming the patches. I have two questions: 1. Would they be welcome? 2. What is the coding style/indentation style that X uses? Please CC me, as I'm not subscribed to the

Re: xorg-devel Digest, Vol 122, Issue 13

2019-03-09 Thread James Larrowe
e > > sucked for years at handling patches by email for the unmaintained > > modules like > > libXaw - we're trying to get better with gitlab merge requests now, but > > we're > > still not great - unmaintained modules are still not well maintained.) > > > >

Re: xorg-devel Digest, Vol 122, Issue 12

2019-03-09 Thread James Larrowe
Sorry if I'm intruding here, but please don't insult each other on a public resource like this. You were both under stress from something, and a simple mistake was made. The mistake has been corrected now. Please don't make this into an all out war on each other. Just forgive and forget. On Fri,

Re: [PATCH libXaw] Add definition of getpagesize(), missing on Windows.

2019-03-09 Thread James Larrowe
Please disregard this patch. I sent a better one. On Sat, Mar 9, 2019 at 9:33 AM James Larrowe wrote: > Sorry about that, accidentally responded to the digest: > > So add another check for cygwin or disable getpagesize use on windows? > > On Fri, Mar 8, 2019 at 8:19 PM Jon

Re: [PATCH libXaw] Use PAGE_SIZE on Windows

2019-03-09 Thread James Larrowe
This has some issues. Please give me a minute. On Sat, Mar 9, 2019 at 9:16 AM James R Larrowe wrote: > Undefine HAVE_GETPAGESIZE, > and use normal behavior on Cygwin. > > Signed-off-by: James R Larrowe > --- > src/OS.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/OS.c

Re: [PATCH libXaw] Use PAGE_SIZE on Windows

2019-03-09 Thread James Larrowe
Please disregard this patch. I sent a better one. On Sat, Mar 9, 2019 at 9:40 AM James Larrowe wrote: > This has some issues. Please give me a minute. > > On Sat, Mar 9, 2019 at 9:16 AM James R Larrowe > wrote: > >> Undefine HAVE_GETPAGESIZE, >> and use normal behav

Re: rfc: WIN32 vs _WIN32 and more

2019-05-17 Thread James Larrowe
If that's what you want to do, then I suggest to just use _WIN32 for everything. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel