ds
Michael
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Komplementärin: ORACLE Deutschl
gnome-shell)
wl_registry_bind() occurs when actually binding to an interface, which
in the case of wl_output occurs when adding a new output, not removing it.
Cheers,
Olivier
On 26 October 2017 at 15:40, Michael Thayer <mailto:michael.tha...@oracle.com>> wrote:
Hello,
Repor
Hello Pekka,
On 27.10.2017 08:01, Pekka Paalanen wrote:
On Thu, 26 Oct 2017 15:40:13 +0200 Michael Thayer
wrote:
[ Discussion of a global Wayland object disappearing triggering a fatal
error in xwl_log_handler in Xwayland.]
there is a known race around Wayland globals. If the Wayland server
.
Regards
Michael
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Komplementärin: ORACLE Deu
write to the list before that in case anyone else has thoughts,
ideas or fixes (potenially including how I could better handle the
driver update).
Regards,
Michael
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
ORACLE Deutschland
On 19.02.2016 16:16, Michael Thayer wrote:
I have been experimenting a bit with plugging and unplugging of graphics
devices (using a dummy KMS driver which is udl stripped of the actual
hardware poking) and how the X server copes with that. It seems to cope
well with a secondary device being
On 22.02.2016 21:29, Dave Airlie wrote:
On 22 February 2016 at 22:20, Michael Thayer wrote:
On 19.02.2016 16:16, Michael Thayer wrote:
I have been experimenting a bit with plugging and unplugging of graphics
devices (using a dummy KMS driver which is udl stripped of the actual
hardware
th in case some one else immediately has an
idea.
Note that I did my testing against Ubuntu's 1.17.2 server.
Regards,
Michael
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung:
Currently if modesetting ever fails to set a hardware cursor it will switch
to using a software cursor and never go back. Change this to try a hardware
cursor first every time a new one is set.
Signed-off-by: Michael Thayer
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 47
On 02.03.2016 18:43, Michael Thayer wrote:
At present if modesetting ever fails to set a hardware cursor it
switches back to a software one and stays that way until it is unloaded.
The following patch should fix that. I say "should" because I had
difficulties testing it - the cur
Hello Emil,
On 04.03.2016 19:52, Emil Velikov wrote:
Hi Michael,
On 4 March 2016 at 14:26, Michael Thayer wrote:
On 02.03.2016 18:43, Michael Thayer wrote:
At present if modesetting ever fails to set a hardware cursor it
switches back to a software one and stays that way until it is
Hello Emil,
On 05.03.2016 00:19, Emil Velikov wrote:
On 4 March 2016 at 19:02, Michael Thayer wrote:
[...]
On 04.03.2016 19:52, Emil Velikov wrote:
[...]
On 4 March 2016 at 14:26, Michael Thayer
wrote:
On 02.03.2016 18:43, Michael Thayer wrote:
At present if modesetting ever fails to
On 05.03.2016 09:42, Michael Thayer wrote:
[...]
On 05.03.2016 00:19, Emil Velikov wrote:
-EINVAL is interpreted by most/all of us as not supported (too old of
a kernel). Although another thing was at the back of my mind - why are
you removing the use_set_cursor2 static boolean. In all fairness
virtual
hardware may be able to handle hardware cursors at some times and not others.
Signed-off-by: Michael Thayer
---
Made the commit message more verbose on Emil's request.
hw/xfree86/drivers/modesetting/drmmode_display.c | 47 ++--
1 file changed, 20 insertions(+
virtual
hardware may be able to handle hardware cursors at some times and not
others.
Signed-off-by: Michael Thayer
---
Re-sending as this did not seem to get noticed much the first time.
hw/xfree86/drivers/modesetting/drmmode_display.c | 47
++--
1 file changed, 20
rbird -as seen in the message
source- (or any other MUA for that matter) that can break the patch
formatting and confuse git.
Indeed, I sent the original with g-s-e and the re-send with Thunderbird.
Thanks again.
Regards,
Michael
HTH, Cheers, Olivier
--
Michael Thayer | VirtualBox engineer
OR
n
someone might have twenty minutes to review it?
Regards,
Michael
On 06.03.2016 12:56, Michael Thayer wrote:
Currently if modesetting ever fails to set a hardware cursor it will switch
to using a software cursor and never go back. Change this to try a hardware
cursor first every time a new
frame.
We sort-of tried this in Weston for something else (we rendered
certain windows in overlays) and had to turn it off and go to always
SW because of the obnoxious flickering, at least until atomic landed.
On Sat, Mar 12, 2016 at 3:54 AM, Michael Thayer
wrote:
Hello,
I would just like to pol
* remain invisible until the next call to this function, which
+* may not happen before a while */
+if (!(infoPtr->MaxWidth == 0 || infoPtr->MaxHeight == 0))
+return;
}
}
--
Michael Thayer | VirtualBox engineer
OR
Hello Alex,
On 18.03.2016 10:42, Alexandre Courbot wrote:
Hello Michael,
On 03/18/2016 06:09 PM, Michael Thayer wrote:
In that context, see this patch to Modesetting which I send a couple of
weeks ago, which should incidentally also fix your issue:
https://patchwork.freedesktop.org/patch
xfree86/ramdac/xf86HWCurs.c
+++ b/hw/xfree86/ramdac/xf86HWCurs.c
@@ -161,8 +161,7 @@ xf86SetCursor(ScreenPtr pScreen, CursorPtr pCurs, int x,
int y)
(*infoPtr->SetCursorPosition) (infoPtr->pScrn, x, y);
-(*infoPtr->ShowCursor) (infoPtr->pScrn);
-return TRUE;
+return (*infoPtr-
ke sure the HW cursor is hidden if it's supposed to be, in case
+ * it was hidden while the CRTC was disabled
+ */
+if (!xf86_config->cursor_on)
+xf86_hide_cursors(scrn);
}
else {
crtc->x = saved_x;
--
Michael Thayer | Vi
-spot information in modesetting.
Does anyone have a good idea about how to deal with this? My best so
far is for my driver to intercept DRM_IOCTL_MODE_CURSOR2 and just
-EINVAL it to force fall-back.
Regards,
Michael
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co
On 01.04.2016 22:12, Michael Thayer wrote:
I have just been adjusting the cursor handling code in the VirtualBox
kernel driver and realised that the modesetting user space driver is
still adjusting the reported cursor position to take the hot-spot into
account, even though it also reports the
On 01.04.2016 22:22, Michael Thayer wrote:
On 01.04.2016 22:12, Michael Thayer wrote:
I have just been adjusting the cursor handling code in the VirtualBox
kernel driver and realised that the modesetting user space driver is
still adjusting the reported cursor position to take the hot-spot into
nt x,
int y)
(*infoPtr->SetCursorPosition) (infoPtr->pScrn, x, y);
-(*infoPtr->ShowCursor) (infoPtr->pScrn);
-return TRUE;
+return xf86ShowCursor(infoPtr);
+
}
void
@@ -184,7 +194,7 @@ xf86SetTransparentCursor(ScreenPtr pScreen)
xf86DriverLoadCursorIm
On 04.04.2016 22:09, Michael Thayer wrote:
Hello,
Please excuse the top posting. Tested this in a dual-head non-mirrored
virtual machine and hit the following problem: xf86CursorSetCursor() in
hw/xfree86/ramdac/xf86Cursor.c calls xf86SetCursor() which fails because
the cursor is not visible on
handle some cursors in hardware and
others not, or virtual hardware may be able to handle hardware cursors
at some times and not others.
Thanks and regards,
Michael
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
ORACLE Deutsch
been seen
to trigger in practice when the X server submits more rectangles at once to
the VirtualBox kernel driver than the kernel will accept. I would expect
this too affect most or all other drivers for virtual graphics devices and
some others.
Signed-off-by: Michael Thayer
---
hw/xfree86/drivers
On 05.07.2016 20:40, Adam Jackson wrote:
On Mon, 2016-07-04 at 21:43 +0200, Michael Thayer wrote:
When submitting dirty rectangles to the kernel driver, modesetting checks
the return value, and if it gets ENOSYS (driver does not support reporting)
or EINVAL (invalid data submitted to the kernel
On 05.07.2016 22:15, Michael Thayer wrote:
On 05.07.2016 20:40, Adam Jackson wrote:
On Mon, 2016-07-04 at 21:43 +0200, Michael Thayer wrote:
When submitting dirty rectangles to the kernel driver, modesetting
checks
the return value, and if it gets ENOSYS (driver does not support
reporting)
or
Hello Adam,
On 05.07.2016 20:40, Adam Jackson wrote:
On Mon, 2016-07-04 at 21:43 +0200, Michael Thayer wrote:
When submitting dirty rectangles to the kernel driver, modesetting checks
the return value, and if it gets ENOSYS (driver does not support reporting)
or EINVAL (invalid data submitted
On 10.07.2016 12:23, Michael Thayer wrote:
Hello Adam,
On 05.07.2016 20:40, Adam Jackson wrote:
On Mon, 2016-07-04 at 21:43 +0200, Michael Thayer wrote:
When submitting dirty rectangles to the kernel driver,
modesetting checks the return value, and if it gets ENOSYS
(driver does not support
On 15.07.2016 17:33, Adam Jackson wrote:
On Tue, 2016-07-12 at 15:56 +0200, Michael Thayer wrote:
I know it has just been two days, but still, a polite ping. I would
also generally be interested in the question of what I can do to get
this sort of patch moving. Would reviewing other people&#
Reviewed-by: Michael Thayer
And successfully tested by one user who experienced buggy behaviour
without the patch.
On 15.07.2016 17:28, Adam Jackson wrote:
This error code can mean we're submitting more rects at once than the
driver can handle. If that happens, resubmit one at a
ts.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Ri
Harms)
Signed-off-by: Adam Jackson
Reviewed-by: Michael Thayer
Went ahead and merged this:
remote: I: patch #99393 updated using rev
4b311d23e84356bd0e9e736aeed7448dd6382118.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
8d3a368..4b311d2 m
virtual
hardware may be able to handle hardware cursors at some times and not others.
Signed-off-by: Michael Thayer
---
Checked the current git source and this change is still needed. This is an
updated patch which takes into account changes in the driver source since
the original patch was created
On 14.09.2016 12:07, Hans de Goede wrote:
Hi,
On 13-09-16 17:42, Michael Thayer wrote:
Currently if modesetting ever fails to set a hardware cursor it will
switch
to using a software cursor and never go back. Change this to try a
hardware
cursor first every time a new one is set. This is
On 14.09.2016 12:07, Hans de Goede wrote:
Hi,
On 13-09-16 17:42, Michael Thayer wrote:
Currently if modesetting ever fails to set a hardware cursor it will
switch
to using a software cursor and never go back. Change this to try a
hardware
cursor first every time a new one is set. This is
calls to show_cursor unless the load
fails (when a call to hide_cursor should follow)
Signed-off-by: Michael Thayer
---
I hope that you are happy with the change I made to remove the set_cursor1
fall-back (it does rather simplify the code!); if not I will send v4.
hw/xfree86/drivers
Hello Hans,
On 15.09.2016 16:12, Hans de Goede wrote:
Hi,
On 15-09-16 12:04, Michael Thayer wrote:
Currently if modesetting ever fails to set a hardware cursor it will
switch
to using a software cursor and never go back. Change this to try a
hardware
cursor first every time a new one is set
Hello,
On 15.09.2016 19:18, Hans de Goede wrote:
Hi,
On 15-09-16 16:40, Michael Thayer wrote:
Hello Hans,
On 15.09.2016 16:12, Hans de Goede wrote:
Hi,
On 15-09-16 12:04, Michael Thayer wrote:
Currently if modesetting ever fails to set a hardware cursor it will
switch
to using a software
Split this up into the three following patches as suggested by Hans.
Many thanks for your patience!
Regards,
Michael
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstra
drmModeSetCursor2() will always return -EINVAL. Specifically, a return
value of -ENXIO usually means that neither are supported.
Signed-off-by: Michael Thayer
---
1) Tested that hardware cursors still work with the patch applied.
2) Tested in gdb that the expected path is taken when drmModeSetCursor2
When the X server asks us to load a hardware cursor, that request is always
followed up by a request to show it if we report success, or to hide it if
we report failure. Therefore it makes no sense to suppress the request if
the cursor is not currently visible.
Signed-off-by: Michael Thayer
load_cursor_argb_check
* keep the permanent software cursor fall-back if -ENXIO is returned
* move parts of v3 into separate patches
Signed-off-by: Michael Thayer
---
Tested switching from a hardware to a software cursor and back.
hw/xfree86/drivers/modesetting/drmmode_display.c | 30
On 16.09.2016 17:52, Michael Thayer wrote:
Currently if modesetting ever fails to set a hardware cursor it will switch
to using a software cursor and never go back. Change this to only
permanently switch to a software cursor if -ENXIO is returned (which means
hardware cursors not supported
On 16.09.2016 17:49, Michael Thayer wrote:
Split this up into the three following patches as suggested by Hans.
Many thanks for your patience!
Polite ping.
Regards,
Michael
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
OR
s did not
make it to my mailbox. Looks good to me, but if you like I can apply it
when I have time and check in gdb that it does what it says on the box.
Otherwise,
Reviewed-by: Michael Thayer
Regards,
Michael
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 7 ++-
hw/xfree86/d
Hello,
On 27.09.2016 12:06, Hans de Goede wrote:
Hi,
On 23-09-16 10:20, Hans de Goede wrote:
Hi All,
On 09/16/2016 06:52 PM, Michael Thayer wrote:
When the X server asks us to load a hardware cursor, that request is
always
followed up by a request to show it if we report success, or to hide
Hello,
On 28.09.2016 09:58, Hans de Goede wrote:
Hi,
On 28-09-16 05:05, Michel Dänzer wrote:
[...]
On 09/16/2016 06:52 PM, Michael Thayer wrote:
When the X server asks us to load a hardware cursor, that
request is always followed up by a request to show it if we
report success, or to hide
Hello Hans,
On 28.09.2016 15:37, Hans de Goede wrote:
Hi Michael,
On 28-09-16 14:47, Michael Thayer wrote:
[...]
On 09/16/2016 06:52 PM, Michael Thayer wrote:
When the X server asks us to load a hardware cursor, that
request is always followed up by a request to show it if we
report success
Hello Hans,
On 29.09.2016 09:56, Hans de Goede wrote:
Hi,
On 28-09-16 16:54, Michael Thayer wrote:
Hello Hans,
On 28.09.2016 15:37, Hans de Goede wrote:
Hi Michael,
On 28-09-16 14:47, Michael Thayer wrote:
[...]
On 09/16/2016 06:52 PM, Michael Thayer wrote:
When the X server asks us to
modesetting driver) and adjusted the code slightly
to match surrounding code. I also removed the new exported function
ShowCursorCheck(), as instead just changing ShowCursor() to return Bool
should not affect its current callers.
Signed-off-by: Michael Thayer
---
hw/xfree86/modes/xf86Crtc.h| 4
to match surrounding code.
- Effectively reverted af916477 which is made unnecessary by this patch.
Signed-off-by: Michael Thayer
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 15 +--
hw/xfree86/drivers/modesetting/drmmode_display.h | 1 -
2 files changed, 5 insertions
load_cursor_argb_check
* keep the permanent software cursor fall-back if -ENXIO is returned
* move parts of v3 into separate patches
Signed-off-by: Michael Thayer
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 30 ++--
hw/xfree86/drivers/modesetting/drmmode_display.h | 1 -
2 files
Hello Adam,
On 05.10.2016 21:33, Adam Jackson wrote:
On Fri, 2016-09-30 at 17:55 +0200, Michael Thayer wrote:
v5: Updated the patch to apply to current git HEAD, split up into two
patches (server and modesetting driver) and adjusted the code slightly
to match surrounding code. I also
Hello Hans,
Polite ping on this one.
Regards and thanks
Michael
01.10.2016 12:01, Hans de Goede wrote:
Hi,
On 30-09-16 17:55, Michael Thayer wrote:
Based on v4 by Alexandre Courbot
There is currently no reliable way to report failure to set a HW
cursor. Still such failures can happen if
The following changes since commit 7617a0a180a2cd3427a8ffa9534152df6a8fecbf:
dri2: refine dri2_probe_driver_name (v2) (2017-01-25 15:13:33 -0500)
are available in the git repository at:
https://github.com/michael-thayer/xserver.git
for you to fetch changes up to
Hello Adam and Keith,
For some reason you got left off CC on that message. No idea why, you
are still there in the copy in my "sent" folder...
Regards
Michael
27.01.2017 17:51, Michael Thayer wrote:
Hello Adam and Keith,
These patches have been hanging around for a while (since
Respectful but rather frustrated ping. Is it still worth my trying to
get these changes in or should I just give up?
Regards
Michael
27.01.2017 17:51, Michael Thayer wrote:
Hello Adam and Keith,
These patches have been hanging around for a while (since October in
fact), and never made it
Thanks Adam!
Regards
Michael
08.02.2017 18:05, Adam Jackson wrote:
On Thu, 2017-02-02 at 11:43 +0100, Michael Thayer wrote:
Respectful but rather frustrated ping. Is it still worth my trying to
get these changes in or should I just give up?
Sorry for the delay. The cursor code is that
focus or when the user restores the keyboard shortcuts using any
+ mechanism offered by the compositor.
+
+
+
+
+
+
+
+
+
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists
sor, "modesetting" could
pass this on to the X server. Neither of these feel quite satisfactory
of course; any better suggestions are welcome.
Thanks in advance.
Regards,
Michael
--
ORACLE Deutschland B.V. & Co. KG Michael Thayer
Werkstrasse 24
better one?
Thanks.
Regards,
Michael
--
ORACLE Deutschland B.V. & Co. KG Michael Thayer
Werkstrasse 24 VirtualBox engineering
71384 Weinstadt, Germany mailto:michael.tha...@oracle.com
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht Münc
On 05/03/14 19:50, Adam Jackson wrote:
On Thu, 2014-02-27 at 16:01 +0100, Michael Thayer wrote:
Another problem that I am running into is that the X11 client part of
our Guest Additions needs to know whether or not the X server VT is
currently the active one, for example so that it can disable
Signed-off-by: Michael Thayer
---
hw/xfree86/common/xf86Events.c | 36
1 file changed, 36 insertions(+)
diff --git a/hw/xfree86/common/xf86Events.c b/hw/xfree86/common/xf86Events.c
index 06af739..a1b43bb 100644
--- a/hw/xfree86/common/xf86Events.c
+++ b/hw
On 05/03/14 19:45, Adam Jackson wrote:
On Thu, 2014-02-27 at 15:46 +0100, Michael Thayer wrote:
Another would be
to add a return value to the DDX CRTC functions "load_cursor_argb", so
that if the KMS driver failed to set the cursor, "modesetting" could
pass this on to the
and OS-
specific detection, but that only the first case was implemented at the time.
Now that only the second is needed dropping the result to keep the protocol
as PROT_AUTO is presumably no longer useful and seems to actively breaking
things.
Signed-off-by: Michael Thayer
---
src/mouse.c |7
An X11 client may need to know whether the X server virtual terminal is
currently the active one. This change adds a root window property which
provides that information. Intended interface user: the VirtualBox Guest
Additions.
Signed-off-by: Michael Thayer
---
This is an updated version of my
On 18/03/14 11:17, Michael Thayer wrote:
On 05/03/14 19:45, Adam Jackson wrote:
On Thu, 2014-02-27 at 15:46 +0100, Michael Thayer wrote:
Another would be
to add a return value to the DDX CRTC functions "load_cursor_argb", so
that if the KMS driver failed to set the cursor, "mod
Hello,
I currently have three patches "in the air" waiting for review and
hopefully integration. It would be great if someone found time to go
over them.
Regards and thanks,
Michael
--
ORACLE Deutschland B.V. & Co. KG Michael Thayer
Werkstrasse 24
An X11 client may need to know whether the X server virtual terminal is
currently the active one. This change adds a root window property which
provides that information. Intended interface user: the VirtualBox Guest
Additions.
Signed-off-by: Michael Thayer
---
This is an updated version of a
and OS-
specific detection, but that only the first case was implemented at the time.
Now that only the second is needed dropping the result to keep the protocol
as PROT_AUTO is presumably no longer useful and seems to actively breaking
things.
Signed-off-by: Michael Thayer
---
src/mouse.c |7
the host at a
particular time but may wish to accept the same cursor at another time.
This patch adds a return value to the API and makes the server do the
software fall-back on failure.
Signed-off-by: Michael Thayer
---
I would also be interested in having set_cursor_position() able to fail and
Hello,
On 31/03/14 11:16, Michael Thayer wrote:
I currently have three patches "in the air" waiting for review and
hopefully integration. It would be great if someone found time to go
over them.
Trying again here. I was hoping to get these into 1.16, but I am
getting more and mor
) Virtual hardware
may not wish to pass through a cursor to the host at a particular
time but may wish to accept the same cursor at another time. This
patch adds a return value to the API and makes the server do the
software fall-back on failure.
Signed-off-by: Michael Thayer
I think this is a welcome
On 04/04/14 20:46, Jasper St. Pierre wrote:
For qemu, this is handled at the kernel modesetting level with QXL.
See drmModeSetCursor2.
On Fri, Apr 4, 2014 at 3:30 AM, Michael Thayer
mailto:michael.tha...@oracle.com>>
wrote:
And my question about whether a similar patch for
set_cursor_po
load_cursor_argb() makes the UseHWCursor*() call-backs irrelevant and
that I should perhaps submit a patch to remove them. And on similar
lines, is xf86ForceHWCursor() still useful? The only user seems to be
the R128 DRI1 code.
Regards,
Michael
--
ORACLE Deutschland B.V. & Co. KG Michael Th
set_cursor_position() may need to be able to fail and have the server fall
back to a software cursor in at least the situation in which we are running
on virtual hardware and using the host cursor as a hardware cursor for the
guest but cannot change its position.
Signed-off-by: Michael Thayer
No response on this yet. Who would be the right person for looking at
patches to xf86-input-mouse? I do realise that it is no longer as
widely used as it once was...
Regards,
Michael
On 31/03/14 11:21, Michael Thayer wrote:
In MousePickProtocol() with protocol PROT_AUTO we probe for the
Currently on Solaris absolute input reporting only takes resolution changes
into account when the video driver is using the pre-RandR 1.2 APIs, and
there it uses the physical resolution, not the virtual. This patch fixes
those two things.
Signed-off-by: Michael Thayer
---
src/sun_mouse.c
change.
Sorry, my fault: it didn't occur to me that this would fail to break
driver builds. Shall I submit another patch to change names? I presume
that would still be allowed after the end of the release window.
Regards,
Michael
--
ORACLE Deutschland B.V. & Co. KG Michael Thayer
Werks
Commit 901fbfb changed the return value of load_cursor_argb() and other
APIs which caused silent breakage of drivers. Rename the changed APIs to
make the breakage visible. The ABI version was already bumped with the
original commit.
Signed-off-by: Michael Thayer
---
Sorry for the unimaginitive
On 22/04/14 07:00, Keith Packard wrote:
Michael Thayer writes:
set_cursor_position() may need to be able to fail and have the server fall
back to a software cursor in at least the situation in which we are running
on virtual hardware and using the host cursor as a hardware cursor for the
ng trouble getting the latest versions of everything building in my
Solaris VM, though I thought I had submitted my forward-port to master.
I will check that tomorrow and re-submit.
Regards,
Michael
On 04/10/14 11:21 AM, Michael Thayer wrote:
Currently on Solaris absolute input reporting
org-edgers/+archive/ppa/+index?batch=75&memo=75&start=75
Regards,
Michael
--
ORACLE Deutschland B.V. & Co. KG Michael Thayer
Werkstrasse 24 VirtualBox engineering
71384 Weinstadt, Germany mailto:michael.tha...@oracle.com
Hauptverwaltung: Riesst
Currently on Solaris absolute input reporting only takes resolution changes
into account when the video driver is using the pre-RandR 1.2 APIs, and
there it uses the physical resolution, not the virtual. This patch fixes
those two things.
Signed-off-by: Michael Thayer
---
This builds against
driver
build breaks as the return type change will only trigger warnings otherwise.
Signed-off-by: Michael Thayer
---
hw/xfree86/common/xf86Module.h | 2 +-
hw/xfree86/modes/xf86Crtc.h| 4 ++--
hw/xfree86/modes/xf86Cursors.c | 18 --
hw/xfree86/ramdac/IBM.c
both are
available.
I've tested this with the upstream intel driver sources (without the
return value change) and it works correctly
Looks good to me too. Thanks a lot! I will do something similar for
the set_cursor_position() patch...
Regards,
Michael
Reviewed-by: Michael Thayer
ABI version 18 introduces load_cursor_image_check, load_cursor_argb_check,
LoadCursorImageCheck and LoadCursorARGBCheck.
Signed-off-by: Michael Thayer
---
hw/xfree86/common/xf86Module.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xfree86/common/xf86Module.h b/hw
Co. KG Michael Thayer
Werkstrasse 24 VirtualBox engineering
71384 Weinstadt, Germany mailto:michael.tha...@oracle.com
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Geschäftsführer: Jürgen Kunz
Komplementärin: ORACLE Deut
On 30/04/14 19:23, Keith Packard wrote:
Michael Thayer writes:
On 22/04/14 07:00, Keith Packard wrote:
Michael Thayer writes:
set_cursor_position() may need to be able to fail and have the server fall
back to a software cursor in at least the situation in which we are running
on virtual
On 21/05/14 15:23, Adam Jackson wrote:
This has to run at initial CreateWindow time, at CreateScreenResources
the root window doesn't actually exist yet.
Tested-by: Michael Thayer
Signed-off-by: Adam Jackson
I'm not an expert in that area of the code, but I did also go over t
Signed-off-by: Michael Thayer
---
I think the subject line says it all. I was wanting to see what RandR events
clients were getting and saw that this was on the X.Org todo list.
configure.ac |2 +-
xev.c| 214 ++
2 files
Signed-off-by: Michael Thayer
---
[Resending this as there were no responses the first time, but I don't
know whether it was due to lack of interest or whether it just went down
in the flood.]
I think the subject line says it all. I was wanting to see what RandR events
clients were gettin
On Thu, 2011-03-03 at 11:37 -0800, Aaron Plattner wrote:
> On Wed, Feb 16, 2011 at 04:00:25AM -0800, Michael Thayer wrote:
> > +if (rr_major >= 1 && rr_minor >= 2)
>
> This check seems wrong, since it will include these event masks for RandR
> version 2
I don't have an fd.o account, so it would be
great if you could submit it.
Regards,
Michael
--
ORACLE Deutschland B.V. & Co. KG Michael Thayer
Werkstrasse 24 VirtualBox engineer
71384 Weinstadt, Germany mailto:michael.tha...@oracle.com
Hauptverwaltung
if at all
possible.
Regards,
Michael
Begin forwarded message:
> From: Michael Thayer
> Date: January 29, 2010 9:32:31 PM GMT+01:00
> To: jcris...@debian.org
> Subject: libudev input hotplug in Debian and VirtualBox guest driver
>
> Hello,
>
> I wanted to pop you a
1 - 100 of 109 matches
Mail list logo
