Re: [PATCH] Handle animated cursor on shared sprite

2017-12-11 Thread Alan Hourihane
Keith/Adam, Another patch for cursor issues that can cause the Xserver to crash that's over 12 months old and hasn't been committed or commented on. Can you take a look at this too ? Thanks, Alan. On 12/10/16 10:05, Pierre Ossman wrote: > Sprites (and hence cursors) can be shared between mult

Re: [PATCH] Handle animated cursor on shared sprite

2016-10-13 Thread Pierre Ossman
+if (!activeDevice) +activeDevice = TRUE; why the check here ? just set. Historical reasons I guess. This is not code I changed, just re-indented. Regards -- Pierre Ossman Software Development Cendio AB https://cendio.com Teknikringen 8

Re: [PATCH] Handle animated cursor on shared sprite

2016-10-13 Thread Pierre Ossman
On 12/10/16 18:05, Emil Velikov wrote: Note that this changes the ABI so it might not be good for the point releases. Unless one wants to make things extra 'fun' for binary only drivers ;-) Might be a safe ABI change though as it only manipulates elements at the end of the structures, and onl

Re: [PATCH] Handle animated cursor on shared sprite

2016-10-12 Thread Emil Velikov
Hi Pierre, On 12 October 2016 at 10:05, Pierre Ossman wrote: > Sprites (and hence cursors) can be shared between multiple devices. > However the animation code was not prepared for this and could wind > up in a case where it would continue to animate a free:d cursor. > --- > include/inputstr.h |

Re: [PATCH] Handle animated cursor on shared sprite

2016-10-12 Thread walter harms
Am 12.10.2016 11:05, schrieb Pierre Ossman: > Sprites (and hence cursors) can be shared between multiple devices. > However the animation code was not prepared for this and could wind > up in a case where it would continue to animate a free:d cursor. > --- > include/inputstr.h | 14 - >

Re: [PATCH] Handle animated cursor on shared sprite

2016-10-12 Thread Pierre Ossman
This was causing crashes in TigerVNC with Chrome/Chromium. Regards -- Pierre Ossman Software Development Cendio AB https://cendio.com Teknikringen 8 https://twitter.com/ThinLinc 583 30 Linköpinghttps://facebook.com/ThinLinc Phone: +46-13-214600https://

[PATCH] Handle animated cursor on shared sprite

2016-10-12 Thread Pierre Ossman
Sprites (and hence cursors) can be shared between multiple devices. However the animation code was not prepared for this and could wind up in a case where it would continue to animate a free:d cursor. --- include/inputstr.h | 14 - render/animcur.c | 85 +-