Re: [PATCH] xv: Build left-shift constants from ints not longs

2016-03-09 Thread Adam Jackson 
On Wed, 2016-03-09 at 10:59 -0500, Olivier Fourdan wrote:

> Reviewed-by: Olivier Fourdan 

remote: I: patch #76365 updated using rev 
723881f31d65353e80660e6d8cd9785e6ec1b430.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/proto/videoproto
   3841508..723881f  master -> master

- ajax
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] xv: Build left-shift constants from ints not longs

2016-03-09 Thread Olivier Fourdan 
- Original Message -
> Looks good to me.
> 
> Funny that we have:
> #define XvNumReasons (XvLastReason + 1)
> and a few lines below it:
> #define XvAnyReasonMask   ((1L< Anyway,
> 
> Reviewed-by: Olivier Fourdan 
> 
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] xv: Build left-shift constants from ints not longs

2016-03-09 Thread Olivier Fourdan 
- Original Message -
> We typically store these in ints in server, leading to warnings like:
> 
> xwayland-glamor-xv.c: In function ‘xwl_glamor_xv_add_adaptors’:
> xwayland-glamor-xv.c:339:16: warning: large integer implicitly truncated
> to unsigned type [-Woverflow]
>  pa->type = XvWindowMask | XvInputMask | XvImageMask;;
> ^
> 
> Signed-off-by: Adam Jackson 
> ---
>  Xv.h | 16 
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/Xv.h b/Xv.h
> index ef3f786..f662df6 100644
> --- a/Xv.h
> +++ b/Xv.h
> @@ -59,8 +59,8 @@ typedef XID XvEncodingID;
>  #define XvInput  0
>  #define XvOutput 1
>  
> -#define XvInputMask  (1L< -#define XvOutputMask (1L< +#define XvInputMask  (1< +#define XvOutputMask (1<  #define XvVideoMask   0x0004
>  #define XvStillMask   0x0008
>  #define XvImageMask   0x0010
> @@ -100,13 +100,13 @@ typedef XID XvEncodingID;
>  
>  #define XvNumReasons (XvLastReason + 1)
>  
> -#define XvStartedMask (1L< -#define XvStoppedMask (1L< -#define XvBusyMask(1L< -#define XvPreemptedMask   (1L< -#define XvHardErrorMask   (1L< +#define XvStartedMask (1< +#define XvStoppedMask (1< +#define XvBusyMask(1< +#define XvPreemptedMask   (1< +#define XvHardErrorMask   (1<  
> -#define XvAnyReasonMask   ((1L< +#define XvAnyReasonMask   ((1<  #define XvNoReasonMask0
>  
>  /* Errors */

Looks good to me.

Funny that we have:
#define XvNumReasons (XvLastReason + 1)
and a few lines below it:
#define XvAnyReasonMask   ((1L<
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] xv: Build left-shift constants from ints not longs

2016-03-09 Thread Adam Jackson 
We typically store these in ints in server, leading to warnings like:

xwayland-glamor-xv.c: In function ‘xwl_glamor_xv_add_adaptors’:
xwayland-glamor-xv.c:339:16: warning: large integer implicitly truncated
to unsigned type [-Woverflow]
 pa->type = XvWindowMask | XvInputMask | XvImageMask;;
^

Signed-off-by: Adam Jackson 
---
 Xv.h | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/Xv.h b/Xv.h
index ef3f786..f662df6 100644
--- a/Xv.h
+++ b/Xv.h
@@ -59,8 +59,8 @@ typedef XID XvEncodingID;
 #define XvInput  0
 #define XvOutput 1
 
-#define XvInputMask  (1L<