Re: [PATCH] xwayland: Avoid repeatedly looping through window ancestor chain

2017-09-13 Thread Adam Jackson
On Tue, 2017-08-22 at 15:38 +0200, Roman Gilg wrote: > Calling xwl_window_from_window means looping through the window ancestor > chain whenever it is called on a child window or on an automatically > redirected window. > > Since these properties and the potential ancestor's xwl_window are

Re: [PATCH] xwayland: Avoid repeatedly looping through window ancestor chain

2017-08-23 Thread Pekka Paalanen
On Tue, 22 Aug 2017 15:38:26 +0200 Roman Gilg wrote: > Calling xwl_window_from_window means looping through the window ancestor > chain whenever it is called on a child window or on an automatically > redirected window. > > Since these properties and the potential ancestor's

Re: [PATCH] xwayland: Avoid repeatedly looping through window ancestor chain

2017-08-22 Thread Roman Gilg
I've just sent another version with different naming and the additional function for comparing the private field's xwl_window with its creator as reply to your mail. Take a look how you like it. One other difference: I realized that the xwl_window_find(..) function is unneeded, since when putting

[PATCH] xwayland: Avoid repeatedly looping through window ancestor chain

2017-08-22 Thread Roman Gilg
Calling xwl_window_from_window means looping through the window ancestor chain whenever it is called on a child window or on an automatically redirected window. Since these properties and the potential ancestor's xwl_window are constant between window realization and unrealization, we can omit

Re: [PATCH] xwayland: Avoid repeatedly looping through window ancestor chain

2017-08-14 Thread Pekka Paalanen
On Sat, 12 Aug 2017 03:45:39 +0200 Roman Gilg wrote: > On Thu, Aug 10, 2017 at 2:49 PM, Pekka Paalanen wrote: > > Assuming the theory is sound, how about you kept the old names and > > semantics of xwl_window_get() and xwl_window_from_window() but just >

Re: [PATCH] xwayland: Avoid repeatedly looping through window ancestor chain

2017-08-11 Thread Roman Gilg
On Thu, Aug 10, 2017 at 2:49 PM, Pekka Paalanen wrote: > > how does this work when windows are reparented? Does reparenting force > them to go through the unrealize/realize steps again? > I assumed this because it is described this way for the XLib function XReparentWindow:

Re: [PATCH] xwayland: Avoid repeatedly looping through window ancestor chain

2017-08-10 Thread Pekka Paalanen
On Sun, 6 Aug 2017 20:03:47 +0200 Roman Gilg wrote: > Calling xwl_window_from_window means looping through the window ancestor > chain whenever it is called on a child window or on an automatically > redirected window. > > Since these properties and the potential ancestor's

[PATCH] xwayland: Avoid repeatedly looping through window ancestor chain

2017-08-06 Thread Roman Gilg
Calling xwl_window_from_window means looping through the window ancestor chain whenever it is called on a child window or on an automatically redirected window. Since these properties and the potential ancestor's xwl_window are constant between window realization and unrealization, we can omit