[PATCH 2/8] dix: Fix ATOM typedef

2011-03-07 Thread Adam Jackson
unsigned long is needlessly large on LP64. Use unsigned int instead. Signed-off-by: Adam Jackson a...@redhat.com --- include/misc.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/misc.h b/include/misc.h index 0717db6..7c97fae 100644 --- a/include/misc.h +++

Re: [PATCH 2/8] dix: Fix ATOM typedef

2011-03-07 Thread Daniel Stone
On Mon, Mar 07, 2011 at 11:28:12AM -0500, Adam Jackson wrote: unsigned long is needlessly large on LP64. Use unsigned int instead. Could we just use uint32_t? Cheers, Daniel signature.asc Description: Digital signature ___ xorg-devel@lists.x.org:

Re: [PATCH 2/8] dix: Fix ATOM typedef

2011-03-07 Thread Adam Jackson
On 3/7/11 11:51 AM, Daniel Stone wrote: On Mon, Mar 07, 2011 at 11:28:12AM -0500, Adam Jackson wrote: unsigned long is needlessly large on LP64. Use unsigned int instead. Could we just use uint32_t? stdint.h isn't included from misc.h. It could be, I guess, but if you have a platform

Re: [PATCH 2/8] dix: Fix ATOM typedef

2011-03-07 Thread Keith Packard
On Mon, 7 Mar 2011 16:51:29 +, Daniel Stone dan...@fooishbar.org wrote: On Mon, Mar 07, 2011 at 11:28:12AM -0500, Adam Jackson wrote: unsigned long is needlessly large on LP64. Use unsigned int instead. Could we just use uint32_t? Yeah, stdint types seem like a better idea everywhere.