Re: [PATCH xserver 1/3] xwayland: Decouple GBM from glamor

2018-04-24 Thread Lyude Paul
On Tue, 2018-04-24 at 10:35 +0100, Daniel Stone wrote: > Hi, > > On 20 April 2018 at 19:38, Adam Jackson wrote: > > This takes all of the gbm related code in wayland-glamor.c and moves it > > into it's own EGL backend for Xwayland, xwayland-glamor-gbm.c. > > Additionally, we add

Re: [PATCH xserver 1/3] xwayland: Decouple GBM from glamor

2018-04-24 Thread Daniel Stone
Hi, On 20 April 2018 at 19:38, Adam Jackson wrote: > This takes all of the gbm related code in wayland-glamor.c and moves it > into it's own EGL backend for Xwayland, xwayland-glamor-gbm.c. > Additionally, we add the egl_backend struct into xwl_screen in order to > provide hooks

Re: [PATCH xserver 1/3] xwayland: Decouple GBM from glamor

2018-04-23 Thread Adam Jackson
On Fri, 2018-04-20 at 17:23 -0400, Lyude Paul wrote: > lgtm! for the whole series: > > Reviewed-by: Lyude Paul Thanks. I've found at least one interaction between this and the present window flip code (which assumes gbm, but merely checks whether ->glamor is set...). I'll

Re: [PATCH xserver 1/3] xwayland: Decouple GBM from glamor

2018-04-20 Thread Lyude Paul
lgtm! for the whole series: Reviewed-by: Lyude Paul On Fri, 2018-04-20 at 14:38 -0400, Adam Jackson wrote: > From: Lyude Paul > > This takes all of the gbm related code in wayland-glamor.c and moves it > into it's own EGL backend for Xwayland,

[PATCH xserver 1/3] xwayland: Decouple GBM from glamor

2018-04-20 Thread Adam Jackson
From: Lyude Paul This takes all of the gbm related code in wayland-glamor.c and moves it into it's own EGL backend for Xwayland, xwayland-glamor-gbm.c. Additionally, we add the egl_backend struct into xwl_screen in order to provide hooks for alternative EGL backends such as

[PATCH xserver 1/3] xwayland: Decouple GBM from glamor

2018-03-07 Thread Adam Jackson
From: Lyude Paul This takes all of the gbm related code in wayland-glamor.c and moves it into it's own EGL backend for Xwayland, xwayland-glamor-gbm.c. Additionally, we add the egl_backend struct into xwl_screen in order to provide hooks for alternative EGL backends such as